Commit graph

8966 commits

Author SHA1 Message Date
58d3a0fe84 Styling tabs on virtual shelves page. Did I forget this, or did it get removed at some point?
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:04 -05:00
Chris Nighswonger
af970db232 kohabug 2139 Fixes C4::Aquisition::NewOrder so that it saves the branchcode
&NewOrder did not save the branchcode posted with a new order. This patch adds that param.

Added code to select the branch the order is for in the branch dropdown list on
acqui/orderreceive.pl

Updating POD and tests

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:01 -05:00
Chris Nighswonger
880c1335f6 kohabug 2224 Corrects display descrepancies when applying filters
This patch corrects display descrepancies when filters are applied to the
acquisitions report. It also corrects a number of other issues with this
report.

Some documentation changes may be in order based on report filters that
were only partially implimented, but are now available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:37 -05:00
Galen Charlton
c7af4a8112 (minor) remove unconditional non-error warn
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:29 -05:00
b71cab54cf Minor tweak to tags display.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:22 -05:00
e348a70e45 Adding js table sorter for holdings.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:19 -05:00
Chris Nighswonger
542c54e067 kohabug 2392 Changing array dereferencing syntax
It appears that Perl 5.10 does not like ${@$foo}[0] but rather wants $foo->[0]
The latter is also much more readable. This patch makes the change.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:16 -05:00
Ryan Higgins
cf3ba2a822 BUGFIX 2387 : Pass vendor id to subsequent pages in neworder search from existing biblio.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:13 -05:00
Ryan Higgins
dd8bc50768 Hide the payment/writeoff dropdown on lines that are credits (or forgiven).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:11 -05:00
Ryan Higgins
eeef609466 Remove 'Cash Refund' from manual invoice, as it calls a deprecated function. Change the code for 'forgiven' from 'F' to 'FOR', since 'F' is used for 'Fine' elsewhere in the code. Mark other subroutines as deprecated that utilize the accountoffsets table, since that functionality was lost somewhere in the 2.2 series, and half-using it breaks things.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:07 -05:00
Ryan Higgins
1dcf4c5e9e Combine 'publication details' and volume columns in display to work with mixed serial data (i.e. some issues linked to serials module, some not). Cleans up display after patch to update sorting with enumchron based on biblio.serial.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:04 -05:00
Ryan Higgins
0411957f73 Update holdings sort to sort by items.enumchron if there's no serial record and the biblio.serial flag is set.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:02 -05:00
Andrew Moore
e78c7a5584 bug 1953 [2/2]: whitespace and documentation changes
perltidy and documentation enhancements.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:00 -05:00
Andrew Moore
551b95284e bug 1953 [1/2]: fixing SQL injection problem in C4::Context->preference
C4::Context->preference was not using placeholders and was potentially vulnerable to
a SQL injectin attack. This patch refactors the method to use placeholders.

Added some tests for C4::Context.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:25:58 -05:00
Andrew Moore
cd6d0c5d60 bug 2386: adding newline between items in overdue notices
The lines for each item in the overdue notices were not separated by newlines. This cause them to
all be smashed together. I'm putting a newline between them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:22:03 -05:00
Joshua Ferraro
9575a5f4fe UTF-8 to ASCII MAPPINGS -- WARNING: REINDEX REQUIRED
You've been warned :-). This patch contains a more
complete mapping of UTF-8 to ASCII. The mappings are
based on those compiled by Richard Mahoney on the
Zebra list: http://lists.indexdata.dk/pipermail/zebralist/2007-August/001707.html

Note to documentation team: we need an area in the
documentation that discusses how Koha handles searches
and indexing for words that contain diacritics, such
as E-ACUTE (vs E without an acute). If you can paste
this list of mappings from this patch directly into
the docs and it preserves the encoding that would be
great.

NOTE: I don't think this patch addresses issues of
combining vs non-combining forms, and may require
a refactor to address that.

Josh
2008-07-23 09:49:57 -05:00
Chris Nighswonger
4d8963d9c9 Correcting C4::VirtualShelves::ShelfPossibleAction to handle the case where the staff user is the superlibrarian ($user == 0)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-23 06:49:53 -05:00
Chris Nighswonger
ed762eb989 Correcting bad session var that caused Lists link not to be displayed in anonymous sessions
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-23 06:49:51 -05:00
Ryan Higgins
0ed39b89cd DB UPDATE : Patron category code was defined incorrectly in overduerules (notice/status triggers) and deletedborrowers.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 21:07:49 -05:00
Chris Nighswonger
8f55696a4d kohabug 2374 Corrects autoBarcode behavior in additem.pl
There should be a documenation change at least for 3.0 to the effect that on systems
not running JavaScript, 'incremental' is the only option available for autoBarcode
although other options appear. A fix for this will hopefully appear in 3.2.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:50:30 -05:00
Chris Nighswonger
40f09c8166 kohabug 2150 Correcting (somewhat) the inconsistent use of autoBarcode syspref
This patch corrects somewhat the inconsistent use of the autoBarcode syspref in serials-edit.pl
It does not impliment all the possibilities currently available in the autoBarcode syspref as
there is currently no support for the js plug-in/drop-in feature in serials-edit.pl. So in this
sense, the autoBarcode syspref is still used inconsistantly here. The fix for this is recommended
for rel_3_2

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:50:23 -05:00
Chris Nighswonger
bc31005f0d Adding lastmodified.virtualshelves; Bumping version to 100
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:50:05 -05:00
Chris Nighswonger
9971756a24 kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves
Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:48:13 -05:00
Chris Nighswonger
39d2d593c6 Allow anyone with superlibrarian permission to edit/delete public patron lists
Edit functions here are limited to renaming and changing the type. No one can view
a list except the list owner unless it is public.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:47:58 -05:00
Joe Atzberger
7c174930ac Bug 2279: TagsModeration effectiveness restored.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:45:04 -05:00
Joe Atzberger
64ba3ffe83 Refine "Patrons statistics" report, fix highlight, remove CGI::scrolling_lists.
At client request, I added code for a rowtitle_display and coltitle_display.  This
allows the script to substitute human-readable lables into the table instead of just
the literal hashkeys.  For this client with dozens of numerical patron categorycodes
having a row titled "29" was not very useful.

I cleaned up the templates and a lot of the report code.  It is of the same style as
the other copy/paste reports and still need further cleanup.  Added sql and debug
feedback (default styled to hidden), as I have for other reports.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:44:58 -05:00
fd2ee6411e Fix for Bug 2373 ("Tags missing from the left menu"). Also doing some cleanup and reformatting on review.tmpl. Fixing some capitalization--I hope that's not a translation problem.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:53 -05:00
16c8171564 Adding new patron form for non-javascript users (Fixes Bug 2344, No "New Member" button w/o js).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:51 -05:00
f2779f6dd7 Removing duplicate column (Bug 2364, "Library column repeated")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:37 -05:00
Chris Nighswonger
1bbfc4fd1c Correcting markup in intranet-main.tmpl to display "Lists" properly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:23 -05:00
Joshua Ferraro
9c68c22a0b Adds Arabic Staff Client translation 2008-07-22 15:38:03 -05:00
Joshua Ferraro
a711cbc224 Updates to the subtype limits for Audience to match the MARC21
standard:

a - Preschool
b - Primary
c - Pre-adolescent
d - Adolescent
e - Adult
f - Specialized
g - General
j - Juvenile

For documentation team: please update the screenshot for
this drop-down as the options have changed.

No re-indexing should be necessary.
2008-07-22 13:44:45 -05:00
Joshua Ferraro
82076c3d39 Fix a bug where the 008 field got replaced if you
inadvertantly clicked in the field and it wasn't empty.
This patch prevents the field from being replaced unless
it's empty.
2008-07-21 19:38:52 -05:00
Joshua Ferraro
4c4f815a34 Adds a stylesheet for Zebra to do an on-the-fly conversion of the
Koha 952 item fields to the MARC21 standard 852 location fields:

Please add the following to the documentation in a section explaining
the setup of a SRU/Z39.50 server. You can also pull info from:

http://wiki.koha.org/doku.php?id=en:development:z3950sru

Modifying Output of Your Records On-the-fly

Koha supports modifying the output of your MARC records for public-facing
Z39.50 and SRU servers. You can set up custom mappings to convert fields such
as 952 (Koha items) to 852 (MARC21 location fields). For example here would
be a popular mapping:
Name:		Koha Field		Mapping in MARC21
---------------------------
Location: 	952 $b => 		852 $b
Barcode: 	952 $p => 		852 $p
Price: 		952 $v => 		852 $r
Item type: 	952 $y => 		852 $w
Notes:		952 $z => 		852 $z

This would make the output from the SRU server suitable for a
resource sharing network that used the above convention for location
information. To add this configuration to your Zebra, add the following
block of code in the koha-conf.xml in the <retrievalinfo> area:

<retrieval syntax="xml" name="marc21location">
         <backend syntax="usmarc" name="F">
           <marc inputformat="marc" outputformat="marcxml"
                 inputcharset="utf-8"/>
           <xslt stylesheet="/path/to/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim9522852.xsl"/>
         </backend>
 </retrieval>

The retrieval set name (in this case, marc21location) is arbitrary and
should be set as required by your resource sharing network, so long as it won't
conflict with internal usage within Koha itself. It's the retrieval set name
that is used to trigger the server to respond and parse the record through the
stylesheet and apply the mappings.

In SRU, this is set as follows:

http://example.com:210/biblios?version=1.1&operation=searchRetrieve&query=it&startRecord=1&maximumRecords=20&recordSchema=marc21location

In Z39.50 it's the elementset name construct.
2008-07-21 18:09:27 -05:00
Joshua Ferraro
72143ef63e Final fix for 2335: Printers has never worked, so it's removed for 3.0
Someone who has the time to generalize it can add it back
2008-07-20 10:51:03 -05:00
Joshua Ferraro
71e436504b Removes the Libraries facet if singleBranchMode is ON 2008-07-18 17:54:11 -05:00
Joshua Ferraro
dd70b27305 Hide location selection when singleBranchMode is ON 2008-07-18 17:46:58 -05:00
Joshua Ferraro
bc408475f8 This patch resolves a few MARC21 Framework issues for
a default installation:

1. Re-names several of the item fields to make more sense to catalogers and patrons
2. Remove links Non-public note from items.paidfor
3. Changes Non-public note to be hidden in the OPAC view

Fixes issues with the 'hidden' field in the framework, specifically:

1. the editor obeys the rules of possible values for hidden (>4, or <-4)
2. the OPAC MARC display obeys the rules of positive values meaning 'hidden in OPAC'
3. the staff MARC display now obeys the rules specified in the hidden values description
2008-07-18 17:39:08 -05:00
Joshua Ferraro
d753635a95 Fix for 2372: Breadcrumbs on Tags Wrong 2008-07-18 13:47:04 -05:00
Joe Atzberger
322fd538d0 Refine lateorders - error feedback, filter independence
Added error catching for bad user input on number of days.  I.E., if you
try to filter by "bAd", you now get an error message prompting for valid
digits.  Also I updated highlighting to use loop_context_vars.

Fixed filtering to work on either days, vendor or both.  Previously, if
you selected a number of days, you had to select a vendor or else got
empty results.  DOCUMENTATION NOTE: this supplies the expected behavior,
so specifying vendor is no longer required.

Changed filters form to GET method.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:23:51 -05:00
Ryan Higgins
3c304cdb3a Add no-replace option to stage_biblios_file.pl, allowing incoming bibs to not overwrite existing bibs.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:31 -05:00
Ryan Higgins
d2ca343c71 Fix typo, which disabled receipt of non-periodic or unknown periodicity serials due to miscalculation of subscription end.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:30 -05:00
Ryan Higgins
5431e7eb3c Bug 2213 : First issue of serial was set to subscription start date instead of first issue date.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:29 -05:00
Ryan Higgins
5353d35b7a Correct misspelling of 'recieve'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:26 -05:00
Ryan Higgins
b16463a81e Change language on serials toolbar from 'edit record' to 'edit subscription'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:23 -05:00
Jesse Weaver
b9f814e57f fix for bug 2371: Change fine block message behavior...
This adds a variable to the checkout form, debt_confirmed, that is 1 when the de
bt block message has been canceled for this session.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:15:13 -05:00
Jesse Weaver
fba4191412 fix for bug 1892: When checking in item on hold...
Makes the print slip and confirm button show up on an in-library hold as well as a transfer. It also adds an ignore button that hides the hold dialog.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:15:10 -05:00
Jesse Weaver
98406923bb fix for bug 2282: Biblio framework subfields...
This fixes the tabs plugin's view of the % subfield by adding another template var called urisubfieldcode that is "pct" when the subfieldcode is "%".

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:25 -05:00
Jesse Weaver
0bb715b7ed fix for disappearing dropbox mode checkbox on returns screen
This makes the 'dropbox mode' checkbox appear unconditionally.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:24 -05:00
Jesse Weaver
8510d2664d fix for bug 2359: Returning an item from moremember.pl...
Adds a 'forgive fines' checkbox to moremember.pl that defaults to off, and removes the hardcoded $exemptfine = 1 argument to AddReturn in reserves/renewscript.pl. Also, cleans up a little inline CSS.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:20 -05:00