Koha-community/Koha - Koha - Koha: The world's first free and open source library system

23511 Commits

33 Branches

505 Tags

4.5 GiB

Tree: 11049f9d02

Commit Graph

Author	SHA1	Message	Date
Galen Charlton	f13c72ebee	Bug 9593: (follow-up) don't make currency.isocode required This patch changes the price parsing so that it can fall back on the currency name if an ISO code is not supplied; this allows for handling the very common situation where the currency name as entered was already the same as the ISO code. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	8 years ago
Lyon3 Team	94d3aed746	Bug 9593: improve parsing of prices from staged files Initial bug : When there's a round price with no decimals after it, or when the symbol is after the digits, the price is not captured by regular expression in MungeMarcPrice routine and the variable is not initialized. Enhancement : The MungeMarcPrice routine had been widely modified. It's still possible to priority pick the active currency but unlike the previous mechanism that worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string including it like '$US'. Moreover, an 'isocode' column had been added in currency table (editable in the staffo interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests, especially t/db_dependent/MungeMarcPrice.t Checked currencies can be added, edited and deleted. Notes: new ISO code field is mandatory. Sample sql files need to be updated (bug 12146) Signed-off-by: Galen Charlton <gmc@esilibrary.com>	8 years ago

Author

SHA1

Message

Date

Galen Charlton

f13c72ebee

Bug 9593: (follow-up) don't make currency.isocode required

This patch changes the price parsing so that it can fall
back on the currency name if an ISO code is not supplied; this allows
for handling the very common situation where the currency name
as entered was already the same as the ISO code.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

8 years ago

Lyon3 Team

94d3aed746

Bug 9593: improve parsing of prices from staged files

Initial bug :
When there's a round price with no decimals after it,
or when the symbol is after the digits, the price is not captured
by regular expression in MungeMarcPrice routine and the variable
is not initialized.

Enhancement :
The MungeMarcPrice routine had been widely modified.
It's still possible to priority pick the active currency but
unlike the previous mechanism that worked only for prices preceded
by the currency sign, it's now valid wherever the symbol is situated.
As symbol you may enter a pure currency sign as well as a string
including it like '$US'. Moreover, an 'isocode' column had been
added in currency table (editable in the staffo interface from
Administration/Currencies and exchange rates). So the active
currency can be picked either through its symbol or through its iso
code.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests, especially t/db_dependent/MungeMarcPrice.t
Checked currencies can be added, edited and deleted.
Notes: new ISO code field is mandatory.
       Sample sql files need to be updated (bug 12146)

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

8 years ago

2 Commits (11049f9d0267f7b1dcf66f148c82b36a25284954)