Commit graph

187 commits

Author SHA1 Message Date
2fbb36048b Fix for Bug 3271, Missing message when adding to a list with no items selected
The shelf js was trying to access a variable set by the Cart-related js. With
the cart disabled, the variable was missing. The patch sets this variable
for cases when the Cart is turned off.
2009-12-22 00:01:04 +01:00
Nicole Engard
43752b690a Bugs: 1172 3579 3596 fixes to patron detail in opac
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.

It also removed the messaging options from the patron
details and leaves them on the messaging tab.

Finally it adds in address fields that were missing
previously on the update patron form.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:30:28 +02:00
Paul Poulain
28718d254d bugfix for ???
Tag cloud fixes :
* ordering cloud by tag name, not by weight
* improve behaviour : either display everyone cloud or my cloud only. When clicquing on "Tag cloud" on the top, will display by default everyone cloud. when clicquing on "My tag" (left tab when logged in), the page will display only my tags and my tags only
2009-09-30 11:30:14 +02:00
Nicole Engard
4732c01085 Bug 1172: Added OPACPatronDetails system preference
This patch allows library staff to disable the patron details
tab on the OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:30:13 +02:00
Henri-Damien LAURENT
feeafa8168 Adding Opac-SearchHistory feature
Enables ppl to store their search history and delete the whole history

Adding Storable required by Opac-Search-History

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:22:21 +02:00
Nicole Engard
448ad31007 Bugs: 1172 3579 3596 fixes to patron detail in opac
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.

It also removed the messaging options from the patron
details and leaves them on the messaging tab.

Finally it adds in address fields that were missing
previously on the update patron form.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 08:56:58 -04:00
Nicole Engard
6dd6af59c2 Bug 2576: Added OPACFinesTab Syspref
This preference allows library staff to decide whether to show
the fines tab in the OPAC for logged in patrons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:35 -04:00
Nicole Engard
e71c8a4343 Bug 1172: Added OPACPatronDetails system preference
This patch allows library staff to disable the patron details
tab on the OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:34 -04:00
Michael Hafen
74a4f29236 Allow the reserve date to be set on holds
This adds to the interface and code the ability to set the reserve date when
requesting a hold.

Resubmit.  Sorry, I formatted it from the wrong branch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 18:02:26 -04:00
Joe Atzberger
b8a0cd9802 Search breadcrumb spacing
Also integrated both halves of the "searchdesc" conditional so they use the
same "No Result found!" message and <p> tags.
[LL 570]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 08:14:07 -04:00
5a93f0b806 More changes to implement jQuery upgrade.
- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:18 -04:00
Garry Collum
45069c1ca4 Bug 3229: Fixes sort-by feature for jquery tablesorter in lists.
This patch adds some variables for the sortfield that are passed through the URL so that the sort-by feature works when the jquery tablesorter is used for a list of titles in opac-shelves.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:09:28 -05:00
adde6f914d Correcting validation errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 09:34:46 -05:00
Galen Charlton
a8bfa5ffc0 retweak font-size of OPAC search box
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 18:26:10 -05:00
savitra.sirohi
6ae7b60962 Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages.
This is available only on the masthead search box in the OPAC.

User has to enter a word in english and press space or return to transliterate the word. The destination language can be selected from a drop down list. User can temporarily turn on/off the feature by using "ctrl +g".

A system preference - GoogleIndicTransliteration can be used to turn on this feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 18:05:47 -05:00
Matthias Meusburger
f2dfe5b46e bug 3271 : Added tooltip when adding to a list with no item selected (same as for cart)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 08:47:17 -05:00
Michael Hafen
53922726fc bugfix: unbalanced TMPL_IF in opac-tmpl/.../masthead.inc
There used to be two TMPL_IF's here, now there's just one.  Missed removing
the second /TMPL_IF though.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 14:04:52 -05:00
Ryan Higgins
ca5e412c1b bug 3244: Support for multiple PAC interfaces.
Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:52:23 -05:00
d9c63270d0 Quick fix to catch some instances of XSS vulnerability, there will be more probably, thanks for the heads up Mark
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 08:04:18 -05:00
Galen Charlton
391a6d3261 bug 2001, 2432: improve unAPI implementation
Improves Koha's unAPI support as follows:

* The implementation no longer depends on there being
  an accessible Zebra or SRW server.  Instead, responses
  are created by running the bib MARCXML through local
  stylesheets.
* unAPI now works for all bibs, not just ones that have
  an ISBN.  The ID format is changed from koha:isbn:ISBN
  to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
  http://validator.unapi.info/ .
* MODS3 support now works correctly.  As a consequence, this
  patch fixes bug 2432 (Zotero support when using the XSLT
  OPAC stylesheets).

TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 07:31:43 -05:00
1f0c678d5c Fix for Bug 2767, cart and lists buttons missing on opac-search.pl
This fix adds alternate markup to be included on the advanced search page in order to mimic the placement of the cart and lists buttons on other opac pages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:26 -05:00
root
dd8ee0bbc6 Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:33 -05:00
Galen Charlton
786a1aa36a bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:42 -05:00
502a8cb7e2 Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:36:26 -05:00
6542fc4216 Add Babeltheque OPAC enhanced content
www.babeltheque.com is a LibraryThings for Libraries equivalent.
This patch enables this service on OPAC.

  * Replace previous patch in order to apply onto last master HEAD
    and solve conflicts induced by last pushed pateches:
    1bb9f76e66
  * Modify kohaversion.pl
  * It uses v3.01.00.016 slot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:42 -05:00
Joshua Ferraro
3d65e44d5c Syndetics and Amazon bugfix enhancements
This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
2eb8d90fc4 Second patch to address LL Bug 367 Titles without ISBNs display "no cover image available" while titles with ISBNS that don't match a Syndetics cover display nothing
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Nahuel ANGELINETTI
b48df4e32f (bug #2962) escape searchbox, and change the search from tag clouds
This patch escape the searchbox to permit to have quotes in searchs.
And make exacts search on autorities from subject tag cloud.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:40:50 -06:00
Nahuel ANGELINETTI
0209a96db7 Unescape some double quotes, that make a validation error.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:29:34 -06:00
Nahuel ANGELINETTI
92afb0dd56 (bug #2887) Change the "Cart" box from js to tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:33:59 -06:00
Nahuel Angelinetti
ff27962633 A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:27 -06:00
Allen Reinmeyer
af9945088c UPDATE:Bug #2756 opacbookbag preference turns off add items to list
There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list.  Javascript wasn't including basket.js on virtualshelves option.  Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.

UPDATED:  Removed EXPR in TMPL_IF conditions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:12:29 -06:00
7045b67a50 Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:47:42 -06:00
Joe Atzberger
143b757cfe Unravelling links in masthead. Regularize logic and improve readability.
Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 15:41:18 -05:00
Galen Charlton
b47bdb43ae bug 2692: remove escape="url" from opac-facets.inc
Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:25:13 -05:00
0dcd876e6a Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:23:54 -05:00
Joe Atzberger
37a33c5041 Remove unnecessary EXPR.
There are two problems with this EXPR:
 (1) It's unnecessary, and
 (2) It's an EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:42 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
Joe Atzberger
18ced6629d masthead - realign terminology for Tag Cloud
Tag Cloud should link to user-generated tags, in a cloud display.
What used to be called "Tag Cloud" (ISBD subject links for UNIMARC libraries)
should be called a "Subject ...".  AFAICT it doesn't currently use a "cloudy"
display, so some other term might be more appropriate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-13 16:09:37 -05:00
Chris Nighswonger
9971756a24 kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves
Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:48:13 -05:00
Joshua Ferraro
71e436504b Removes the Libraries facet if singleBranchMode is ON 2008-07-18 17:54:11 -05:00
60d585aed6 Hide User Tags link when TagsEnabled preference is turned off. Change to Auth.pm allows TagsEnabled preference to work on login screens.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-12 08:59:39 -05:00
Joshua Ferraro
22684e9ec7 Fix for 2160: My Lists Tab on OPAC Profile 2008-07-08 00:18:40 -05:00
Chris Nighswonger
e6fb2bc77b Tidying up the Lists button menu
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 18:00:23 -05:00
Joe Atzberger (siptest
f79e1d2b9a Remove EXPRs from includes file.
This prevents the following log entries:
    error EXPR:at pos 42: non-initialized variable OPACViewOthersSuggestions
EXPR must NOT be used unless the author can guarantee ALL names referenced
will be defined at the BEGINNING of TMPL execution.  That suggests that in
.inc files, only variables populated by get_template... are valid, since
the author cannot guarantee what other templates might include the file.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 16:23:19 -05:00
Andrew Moore
401c84cc09 Bug 2176 (2/5): adding patron interface to update messaging preferences
This patch allows patrons to update their messaging preferences. This
includes methods in C4::Members to manage patron messaging preferences.

added cgi script to allow patron to edit their messaging preferences

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 13:04:50 -05:00
Chris Nighswonger
3cb7a9ac28 kohabug 2238 This patch allows patrons to add books to public open/free lists whether they are logged in or not.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 12:48:11 -05:00
22654a5977 Redesigning and bugfixing language-picker. Switching from fixed footer positioning to one with flows with page length. Fixing major unreported bug which prevented any but the first sublanguage menu from displaying.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-19 13:09:42 -05:00
Andrew Moore
6e52709824 Bug: 2259: eliminate lines too long for git to use.
This patch modifies 13 HTML templates and includes that have lines in them longer than 998 characters. Lines this long are known to break git.

I believe that none of these change behaviour at all, but I'm concerned about one of them. It adds whitespace (carraige returns) inside a <title> tag. I'm not certain that all browsers will deal with this OK.

No documentation changes necessary here.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 19:25:52 -05:00
89d34a7c48 A better fix for Bug 2229, I think. Text inside basket.js can be translated fine, this instance simply lacked the call to the dummy function for gettext. It's important /not/ to have the "Cart" text in masthead.inc because there should be no Cart link for users with javascript turned off.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 11:41:47 -05:00