Commit graph

3517 commits

Author SHA1 Message Date
Garry Collum
11f05061cc Bug 3452: Displays borrower category and adds links to Suggestions Management
A couple of enhancments to Suggestions Management.

Adds a display of the borrower category of the suggesting patron for each item.

Adds links to the title and author displays so that the catalog can be quickly search for an existing bib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:39:44 -04:00
7ad2cfac6d Change to layout of tag review interface (enhancement bug 3447)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:39:41 -04:00
J. David Bavousett
a5bd87735e (Bug 3402) Serials issue name not escaped when passed forward to routing slip
The issue descriptor was not being escaped before being passed on to the
routing slip, causing truncation.  It's truly impossible to know for sure
what will be there, so uri_escape-ing seemed the best way to ensure that
it gets handed forward and makes it all the way to the printable slip.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:45:11 -04:00
Garry Collum
a9609f6e96 Bug 2889: Added highlighting to Serials Subscriptions table in serials-home.tmpl.
Added highlighting to serials subscriptions table.  Cleaned up unused toggle variable code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:44:46 -04:00
Colin Campbell
acdb93ea6f Show claimed issues as 'Claimed' not just blank space
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 11:27:41 -04:00
605be873e0 Correcting some selectors to conform with upgraded jQuery syntax (see Bug 3297).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:56 -04:00
Garry Collum
be1ef2b2fa Bug 2553: Alphabetization of branches in the catalogue stats report.
Improvement on previous patch by using GetBranchesLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:53 -04:00
Garry Collum
8c1b8b47c5 Bug 2553: Alphabetization of branches in Checkout Statistics form.
Improvement of previous patch through the use of GetBranchLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:51 -04:00
Nahuel ANGELINETTI
2091a99e73 (bug #3421) fix the xhtml in serial biblio search
This fix differents errors, and escape in bib search.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 22:08:17 -04:00
Garry Collum
d7cecac86c Bug 3418: Fixes the alpha order of the system preference tags.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 21:07:16 -04:00
Matthias Meusburger
2e1a9d657a Bug 2593 : way to duplicate items
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:35:52 -04:00
Joe Atzberger
850a8c2a4b Cannot use the same TMPL_VAR to select ALL options.
Only one select can be selected in this case.  If preselection of search type is
desired, I recommend a clean implementation w/ jquery instead of adding a conditional
for each select.  Please note, that is the only good way to get multiple preselections,
since the same .inc file will be used in each case.  So a single variable like
    <TMPL_IF NAME="index_bc_selected">
cannot be used, since it would set for ALL (3) advanced search dropdowns.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:28:06 -04:00
Nahuel ANGELINETTI
3e7e8bf35e (bug #3398) fix unimarc 210c plugin
this add some args to SearchAuthority();
Fix the pagination, and fix javascript script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-15 09:09:27 -04:00
Joe Atzberger
46b9ee7a93 Branch auto-selection in additem
Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:39:00 -04:00
Nahuel ANGELINETTI
79fc6d81f7 (bug #3267) show items.uri in opac and intranet
This add a column in normal view, with a link to items.uri URL if it exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 08:26:33 -04:00
John Beppu
2fa6b26825 Minor Fixes for jQuery 1.3.2 Upgrade
I looked through all the relevant Javascript on this site
to find spots that would break in the upgrade from jQuery 1.2
to jQuery 1.3, and I fixed them.

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:20 -04:00
5a93f0b806 More changes to implement jQuery upgrade.
- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:18 -04:00
John Beppu
dbbe53ac63 Upgraded from jQuery 1.2.3 to 1.3.2
http://docs.jquery.com/Release:jQuery_1.3
http://www.learningjquery.com/2009/03/3-quick-steps-for-a-painless-upgrade-to-jquery-13

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:06 -04:00
Garry Collum
e2417fb5c5 Bug 3384: Fixes invalid xhtml in advsearch.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 06:54:27 -04:00
Garry Collum
a9ecff3d98 Bug 2889: Cleaning up toggle variables in readingrec.pl and tmpl.
Removed toggle variable from readingrec.pl and readingrec.tmpl.  Used __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:00:02 -04:00
Garry Collum
b9a0c1644f Bug 3392: Fixes highlighting in Patrons with no Checkouts report.
Fixed class definition and moved the definition from the <td> tags to the <tr> tags.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:00:00 -04:00
Darrell Ulm
62cf086ef1 Bug#: 3358 File 3 of 3 patch for reserve notes (show)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:33:46 -04:00
Darrell Ulm
c943c9f39c Bug#: 3358 File 2 of 3 patch for reserve notes (show)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:33:44 -04:00
Galen Charlton
3b4ee9c5f1 bug 3355 followup - fix XHTML errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:08:21 -04:00
Nahuel ANGELINETTI
34426697c5 (bug #3355) add pagination in bib search for subscriptions
This add the support of pagination, delete a javascript call, and use now a get method(why post was used?).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 22:45:14 -04:00
Nahuel ANGELINETTI
1be2c411f0 (bug #3284) fix borrower deletion in independantbranches mode
This patch fix the checks deleting a borrower in independantbranches mode.
Now, we check the user and the librarian are from the same branch, else we deny the deletion(and disable the link to delete).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:27:15 -05:00
471fe3927a Removing hard-coded $ symbols from the template, addressing Bug 2547
Pending a system for displaying the correct currency symbol based on the system's default currency all dollar-specific symbols should be removed in favor of no symbol.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:25 -05:00
0d0666ebab Tweaking CSS on z39.50 popup to improve readability (Bug 3269)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:23 -05:00
980029b93c Modifying the text of the error message for clarity and accuracy.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:21 -05:00
Garry Collum
25ec85cb00 Bug 3360: Fix for unclosed <ol> element in export.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 09:20:53 -05:00
Garry Collum
b082449da8 Bug 3362: Fixes invalid xhtml in stage-marc-import.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:57:16 -05:00
18abc28d62 Misplaced </tbody> breaks table sorting. Fixes Bug 3365.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:49:24 -05:00
aac1c7f8a9 Reformatting interface for Notice Triggers (Bug 3366)
Breaking up the table of options into three separate ones for first, second, and third notices, each in its own tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:36:26 -05:00
62107b5fea Putting text form field first ensures field will correctly be given focus.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:32:47 -05:00
Nahuel ANGELINETTI
ded3ff78cf (bug #3364) add itemnotes in itemslost report
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:18:45 -05:00
38a0e22d2e Spelling correction per convention: cataloguing -> cataloging (Bug 3277)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:11:24 -05:00
Garry Collum
653d9b7284 Bug 2889: Removed toggle variable from z3950_search.pl.
Removed unused toggle variable from z3959_search.pl.  Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:06:53 -05:00
0d0fef6dc5 Another fix for Bug 3119 (Add date due to circ history)
Moving links (non-table data) out of table to correct persistent table border display issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:03:43 -05:00
Liz Rea
eac25405c4 bug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake of consistency.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 07:56:06 -05:00
Joe Atzberger
e8908c2f97 Returns reworking to handle empty GetItemIssue
Code cannot rely on issueinformation being populated.

Note there is room for better efficiency to have AddReturn also provide the
itemnumber (where existing) so that GetItemnumberFromBarcode is not called
at both levels.  Unfortunately there is discrepancy between this idea (for
efficiency) and the stated purpose of the $iteminformation object returned,
since $iteminformation is specifically the info from the issues table and
MUST be empty when the item was not in fact issued.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:44:39 -05:00
Galen Charlton
9a02e5aa42 fixed table row highlighting CSS class
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:10:32 -05:00
Colin Campbell
d633bd1ba1 Enable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings Remove toggle variable
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:02:59 -05:00
Jane Wagner
a13c0db0c9 Bug # 2368 Change holds to pull default date range
Delivered range was 10 years ago to yesterday; changed default
to be two days ago to today.  Also removed notes field from report
output; 5xx fields can be quite large and including them in the
display resulted in a very lengthy printout for staff.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 08:55:11 -05:00
Liz Rea
66fa41460d Adding links to guided reports wizard, dictionary, create from sql to reports home page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 08:39:21 -05:00
Nahuel ANGELINETTI
1268f25b19 (bug #3339) fix rollover showed value
This patch just print the value of "whenmorethan1", that was missed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-19 06:01:32 -05:00
Garry Collum
1f0e6ec1fe Bug 3338: Fix for missing closing brackets in authorities/detail.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-19 06:01:30 -05:00
Garry Collum
16a94b5210 Bug 2889: Removed toggle variable from member.pl and .tmpl
Removed toggle variable from member.pl and member.tmpl.  Replaced with template variable __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-15 12:43:42 -05:00
bfbd5dc61d Fix an unstranslatable string in JavaScript
For an explanation, see:

http://wiki.koha.org/doku.php?id=en:development:codingguidelines#translatable_text

This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-15 12:43:25 -05:00
Joe Atzberger
c41a9cc218 Update references to batchRebuildBiblioTables
Also fixed escaping of literal "$" characters in usage.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-15 12:43:22 -05:00
b216babdf8 Fix bug 3330 - Report notes modification
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-15 12:43:18 -05:00