Commit graph

517 commits

Author SHA1 Message Date
Galen Charlton
1428ebed51 bug 3205: fix another error in the OAI-PMH Identify response
The optional description element of an Identify response
can't just be a string.  Identify.description is a container
for one or more elements; see http://www.openarchives.org/OAI/2.0/guidelines.htm

For now, simply commenting it out.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 11:59:03 -05:00
dfaa238186 Bugfix 3205 - Fix OAI server resonse to Identify request
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 11:23:34 -05:00
David Birmingham
d5d21fe101 Bug fix to OPAC shelf browsing query statement
If the items.location field was NULL, then the current
SQL query would produce no results.  I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.

In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open.  This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:18:27 -05:00
Chris Cormack
d32d5bfb9b Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:06:53 -05:00
Jane Wagner
f5be7dc8e4 Enhancements/fixes for OPAC advanced search screen
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.

Added Publication Date Range search to advanced search screen

Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).

Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:11:17 -05:00
Galen Charlton
53ace84401 Syndetics: add support for AVSUMMARY and AVPROFILE
Added support for the Syndetics AV summary and AV profile
data elements.  The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:19:19 -05:00
Michael Hafen
451ab9e77e OPAC Advanced Search - have user's branch selected by default
If SearchMyLibraryFirst is on, and the user is logged in, then have
their branch selected in the Location And Availability drop-down.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 08:08:12 -05:00
Chris Cormack
0501737f1c Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:02 -05:00
Chris Cormack
2677e75bb7 bug 2505 fixing warnings, I think we have them all for opac-search.pl now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:37 -05:00
199ec1473a Bugfix #2920 Avoid doing unecessary calls to Amazon Web Services
This patch modifies how AWS is called. AWS is now called
depending on syspref. It works completly for OPAC; it
has to be refined for intranet.

For OPAC:

  * If OPACAmazonReviews is set, AWS EditorialReview and
    Reviews (users) are grabed.
  * If OPACAmazonSimilarItems is set, AWS Similarities info
    are grabed.
  * If nothing is asked, AWS is not called anymore,
    sparing server bandwidth.

For intranet:

  It works as it used to work. AWS is called if AmazonEnabled
  is set whatever how other syspref are set.

  TODO:

    * Add a AmazonReviews syspref
    * Request Amazon content depending on AmazonSimilarities
      and AmazonReviews syspref

DOCUMENTATION:

  It should be explained that Amazon services related syspref
  have two levels:

  * AmazonEnable / OPACAmazonEnable
  * Other: OPACAmazonReviews (new), OPACAmazonSimilarProduct,
    OPACAmazonCover

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 10:36:14 -05:00
Galen Charlton
c101ea2379 bug 2505: fix more warnings in opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 10:24:38 -05:00
fccf91832e Bug 2505 Adding use warnings, and fixing the warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 09:51:03 -05:00
Galen Charlton
1e6b61cdb1 changed OAI-PMH implementation
Replaced older OAI-PMH server implementation
with new one by Frédéric Demians.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 14:01:21 -05:00
Galen Charlton
0a306bc28c bug 2505 followup: restored correct item type image display
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 10:04:32 -05:00
Andrew Moore
f447f8a91f Bug 2505: adding warnings to opac-detail.pl
Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 09:50:57 -05:00
29ab92d261 Bugfix #3155 Disabling Amazon Reviews
Disable Amazon reviews without disabling Amazon book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 05:56:54 -05:00
Christopher Hyde
b15a74c8d7 Changes Made to further optimize and condense code, include code documentation, and fix hardcoded instead of syspref'd library thing id
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:36:49 -05:00
Christopher Hyde
1d4892cf1c Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified:   admin/systempreferences.pl
	modified:   installer/data/mysql/en/mandatory/sysprefs.sql
	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
	modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:34:56 -05:00
Jane Wagner
a966c51f1a Creates a syspref & modifies template to show checked out username in OPAC
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC.  Most libraries will want
to leave this turned off!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 14:39:25 -05:00
Galen Charlton
696fc0ff22 bug 3141: use quoted printable encoding in cart/list emails
Ensure that emails sent from lists and the cart in the
OPAC have the correct quoted-printable encoding.  Otherwise,
if there is an equals sign followed by one or two characters
that look like hexadecimal digits in body of the email, the
results can look mangled in some email clients.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:36:14 -05:00
Nahuel ANGELINETTI
96543dcf5f (bug #3004) fix the opac authority search
This patch modify the way to transfer the different args, don't use the form arrays.
And use a GET form instead of POST(we are getting datas, sending nothing).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 12:01:58 -05:00
Galen Charlton
6a2a4e146e fix various warnings
* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
  (displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
  (attemping to calculate average Amazon rating if no Amazon info
   is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
  (attempting to calculate length of $isbn if it happens to be undef)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 15:54:19 -05:00
60761e44ae Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"
GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:01:21 -05:00
a2c071aace Fix for Bug 3095, Add to lists page doesn't redirect with no javascript
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:22 -05:00
Nahuel ANGELINETTI
89c062c44b (bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD view
this patch extract the generator of ISBD view in a C4 function, because it's used in intranet AND in OPAC but with 2 separate codes.
Now it's more reusable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 11:16:34 -05:00
Nahuel Angelinetti
13763623e7 add the possibility to replace, in sysprefs, the code by it's valuecode with {{code}} ex : {{995c}}
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 11:15:38 -05:00
02b5091c1a Internationalize Amazon support
With this patch:

  * On Amazon book cover, 'search inside' text is not displayed
    anymore because it's not translatable.
  * Link the image to local Amazon web site 'search inside' service.
    Based on AmazonLocale syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:38:37 -05:00
2b14727449 Corrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes bug 3083.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:31:16 -05:00
Galen Charlton
33996aab95 bug 3088: fix crash in opac-ISBDdetail.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:18:05 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Stephen Edwards
6d54aa97f0 bug 3034: Tag multiple items at once.
Added a "Tag" button in the toolbar area of the results
page.  This activates an inline form that allows the user
to enter a tag that can then be applied to all currently
selected items.

In addition, a "Tag" link has been added to both the List and
Cart pages that provides the same functionality in those contexts.
In these two cases, the a per-item states appears below the
bibliographic information for each item.

Status that applies to the overall operation, such as failing to
provide a tag, will be shown in an alert dialog box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 12:30:01 -05:00
f257730050 Add another OAI server
This OAI server has those characteristics:

   * It doesn't use C4::OAI anymore.
   * It uses HTTP::OAI library which is easily expandable.
   * XML result is not build anymore directly but using
     XML::SAX::Writer. It should solve encoding and XML related issues.
   * It returns two formats: oai_dc and marcxml.
   * DC is generated from biblioitems.marcxml by applying XSLT
     (MARC21slim2OAIDC.xsl or UNIMARCslim2OAIDC.xsl).
   * It uses the same tokens as previous OAI server (thanks Philippe
     Jaillon).
   * There is no more sets (it wasn't operational in previous version).

Add two new dependencies:

   * HTTP::OAI
   * XML::SAX::Writer
     available as a Debian package: libxml-sax-writer-perl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 11:30:08 -05:00
Galen Charlton
b28752346f add } that slipped out because of bad merge
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 11:03:21 -05:00
6542fc4216 Add Babeltheque OPAC enhanced content
www.babeltheque.com is a LibraryThings for Libraries equivalent.
This patch enables this service on OPAC.

  * Replace previous patch in order to apply onto last master HEAD
    and solve conflicts induced by last pushed pateches:
    1bb9f76e66
  * Modify kohaversion.pl
  * It uses v3.01.00.016 slot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:42 -05:00
Nahuel ANGELINETTI
030ed76dc7 (bug #2913) show "--" on repeated fields
This patch just transform the script to set the field title as "--" if it was already shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:31 -05:00
Joe Atzberger
92051e44dd Convert opac-reserve to use GetBranchesLoop.
Removed irrelevant and unused variables dealing with branches.
Also pulled default branch from userenv when not specified as a param.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:54 -05:00
Joe Atzberger
c16d624f8f whitespace cleanup and remove editor comments
No functionality affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:43 -05:00
Joe Atzberger
ec8ca853a6 Invalid field 'expiry' referenced.
This caused a warning from C4::Dates on every execution, since the value
passed to format_date was undefined.  Now we reference the correct field
and check for a populated value before trying to reformat it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:33:33 -05:00
Daniel Sweeney
afde76f1c1 Added upc to content_identifier_exists criteria.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
bd5272f074 Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images
Adds new template variable to test for enhanced content identifiers

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
3d65e44d5c Syndetics and Amazon bugfix enhancements
This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
9abcd844f5 Add Syndetics AuthorNotes, Awards, Series
This patch also includes a new function to retrieve the index
page from Syndetics and parse it for available content prior to
retrieving content; this is done to speed up syndetics content
by not retrieving content that doesn't exist for an item. However,
Syndetics continues to be a very slow service compared to Amazon.com
and other enhanced content services

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
11bd4a7660 Adds Syndetics Reviews
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
9806abf865 Adds support for Syndetics Excerpts and Editions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
de6227bd0a Add Syndetics Summaries and TOC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
69c74c06ae Move Amazon.pm to External/ directory
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00
4a962af1f4 UI tweaks to OPAC holds screen following addition of multiple holds functionality. Addition of subtitle and copy number to output.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:11 -05:00
Joe Atzberger
ccee815f4a Bug 2617: Add strict (and warnings), partial fix.
These are some of the simpler scripts to add strict to.
Corrected perldoc for Bookfund.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:36:55 -05:00
Joe Atzberger
cae7a7cccf Libraries (branches) should be sorted by branchname.
The display sorted by code, resulting in nonsensical order
for the users, who don't know or see the codes.  Note,
this data should come from GetBranchesLoop, when that
function is availabled (from a separate patch).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 13:04:36 -06:00
Nahuel ANGELINETTI
90fe0170f2 (bug #2811)[3.2] fix opac-renew.pl part
This patch only fix a "security" failure that permit a user to renew his loan using directly the opac-renew.pl url.
Now, we check that opacrenewalallowed is set to on to permit the renewal in opac.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 12:49:57 -06:00