Commit graph

4131 commits

Author SHA1 Message Date
Joe Atzberger
173556364d Bug 3128: IE7 tweak
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:28 -05:00
Stephen Edwards
47690dbcc4 bug 3093: Enhance placing of holds in the staff interface.
This patch allows staff users to request reserves on multiple
items at one time.

Added checkboxes, select-all, clear-all, and place-hold button to
staff search results page.  Place-hold button will only appear if
the user has permission to place holds for others.  Item-level
Place-Hold button will not appear for multiple holds, nor will
the vertical detail menu.

Patron input page now shows multiple items, if applicable.

Hold confirmation page shows results for multiple items, if
applicable.  Those which cannot be reserved are highlighted and
are excluded from the reservation.  The reservation is placed at
the biblio number (i.e. next available) level.

Fixed display of item type.

Removed side menu for multiple items; removed item-oriented button for multiple items.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 06:12:06 -05:00
29ab92d261 Bugfix #3155 Disabling Amazon Reviews
Disable Amazon reviews without disabling Amazon book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 05:56:54 -05:00
Galen Charlton
f5e93e0099 fix XHTML validation errors in LTFL output
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 16:13:29 -05:00
Christopher Hyde
a5d6494c62 Fixed minor error in comment code
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:37:15 -05:00
Christopher Hyde
4b56532d0a Changes made: Fixed typo/bug which had wrong order for if statement checking to see whether
Committer: Christopher Hyde <chyde@ebpl.org>

	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:35:02 -05:00
Christopher Hyde
1d4892cf1c Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified:   admin/systempreferences.pl
	modified:   installer/data/mysql/en/mandatory/sysprefs.sql
	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
	modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:34:56 -05:00
Jane Wagner
a966c51f1a Creates a syspref & modifies template to show checked out username in OPAC
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC.  Most libraries will want
to leave this turned off!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 14:39:25 -05:00
Joe Atzberger
b8d6ccf845 Bug 3118: Remove comment that perturbs IE
Formatting bugs not fixed.  Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected.  Go figure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 12:05:08 -05:00
Joe Atzberger
1afa403417 IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:28:28 -05:00
8f95ec3dbe Fix for Bug 3119: Add due date to the patron circulation history window
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:45:11 -05:00
e6076612ba Fix for Bug 1877, Link to patron record from manage suggestions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:44:02 -05:00
8c6d7c9996 Adding link back to OPAC for emailed cart and lists.
Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 14:29:11 -05:00
Brendan A. Gallagher
a09ad1edde Bug #3101 - Changed the Print and Confirm button
Changed button to read "Print slip, Transfer and Confirm"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:22:09 -05:00
Joe Atzberger
0ad2b08c28 Visual alert (red) on overdue return.
This was requested by a Koha user at KohaCon09.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:05:01 -05:00
Cory Jaeger
bb91778b8d Bug 2847 - Added url escaping for categorie.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:00:01 -05:00
Cory Jaeger
9a1a332dbc Bug 2847 - Fix html escaping in categorie.tmpl (more needed)
Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 09:58:15 -05:00
Nicole Engard
520d40614e Fix Bug #2925
This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.

In addition I have made it so that the Date Received
only shows if the item is 'Available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 13:08:38 -05:00
8246da13b2 Fixing xhtml errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 09:14:53 -05:00
Nicole Engard
40bd4a508a Partial fix for Bug #3139
Standardized all references to Address and Zip/Postal Code.

Also fixed bug #3138 by making the Alt address ready City, State.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 08:55:22 -05:00
204f8dc187 Fix for Bug 3136, Show hold/send/tag links for lists even for non-logged-in users
The patch adds link to "send list" and the text "Log in to place holds or add tags" (with link, similar to the log in message users see in the global lists menu).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 08:34:33 -05:00
Brendan A. Gallagher
066715ff35 Modification on Bug # 3102 - "Location" instead of "Localization"
This a change to previous patch for Bug #3102 (That has been pushed to head).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 08:34:15 -05:00
60fc079cfb Update for bug 1545 allowing for the title to be edited
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:36:16 -05:00
475fcc1f51 Setting focus on form fields
This patch includes an addition to the OPAC's default js (identical to one in the staff client) which lets you add a "focus" class to an element on the page and have javascript move the focus to that element (input or link).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:36:11 -05:00
Brendan A. Gallagher
a7ccef4f90 Change typo Localisation to Localization for Bug # 3102
[RM note: I think there are a few people who wouldn't
 call "localisation" a typo - such as our UK, NZ,
 Australian, etc. contributors ;-) ].  That said,
 I'm pushing this patch to consistent with the
 general trend of the English varient used on the
 /prog/ templates.  There's no implication that en_US
 is the "correct" version of the language.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 16:16:44 -05:00
Paul Poulain
6dbe43b54a fix for #946
A member returns a book : it would be better to see the category of this member
in "information member" near his name.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 16:04:50 -05:00
Jane Wagner
d4241eeeda Bug 3013 Fix for 007 value builder to include all material types
Delivered version only had Text material type; this patch includes
all 14 material types with appropriate values for each.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 15:25:58 -05:00
834001ffbb Allowing users to edit saved sql in guided reports. Bug 1545
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 14:59:02 -05:00
Paul Poulain
ff931f977c fix for #908
In an list of autorised values (Parameters >autotised values), if you delete an
autorised value after confirm, you go back to the first page of the list, and
you must return manually to the page you left before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 14:58:59 -05:00
ac8ff44432 Bug 3132: Reformatting guarantor entry based on C vs. P patron types
Professional patrons might have Organizations as guarantors, so display the guarantor entry form with a single line labelled appropriately. For Child patrons display the form fields as before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 14:58:52 -05:00
Galen Charlton
a0fd9d2cb0 followup to 3004 - fix typo
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 12:14:48 -05:00
Nahuel ANGELINETTI
96543dcf5f (bug #3004) fix the opac authority search
This patch modify the way to transfer the different args, don't use the form arrays.
And use a GET form instead of POST(we are getting datas, sending nothing).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 12:01:58 -05:00
c2fdde125b Removing duplicate email form field. Fixes Bug 3010.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 11:40:29 -05:00
Galen Charlton
764136b463 bug 3100: increase width of alternate postal code
The alternative postal code input on the patron
editing form was only permitted 5 characters of
input.  Increase this to 10 to match the
primary zipcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 09:34:08 -05:00
520c160542 Corrected: fix for Bug 3112, Emailed list contains too much whitespace
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 08:19:42 -05:00
Nahuel ANGELINETTI
5cf66ad6dd (bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:36 -05:00
Galen Charlton
684cea4309 bug 3049: display correct due date of renewed loans
The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.

The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date.  This patch
fixes the bug in two ways:

[1] AddRenewal() now updates items.onloan with the
    correct due date.
[2] Two templates were updated to display the
    due date from (indirectly) issues.date_due
    instead of items.onloan, thus making it less
    likely that the wrong value will be displayed.

This patch does *not* update items.onloan to reflect
the correct due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:32 -05:00
Joe Atzberger
ce760ba9e8 Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:00:13 -05:00
74e2741063 Minor markup corrections for validity.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:50:14 -05:00
Michael Hafen
4fb0141e61 bug: add items to batch - search results have multiple items on one table row
The table row openning and closing tags were outside the template loop.
This moves them inside the loop.  Without this search results with more
than one copy will append those copies to the one row.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:01:28 -05:00
60761e44ae Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"
GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:01:21 -05:00
Joe Atzberger
d5dbaf2a6d orderreceive cleanup
Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:36 -05:00
Joe Atzberger
4a1333c544 Factor common element out of both sides of conditional.
Add placeholder complaint about misuse of TMPL EXPR statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:33 -05:00
Joe Atzberger
dc8745c469 Remove unused TMPL variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:25 -05:00
fe75457c5d Adding new "tag" icon to tag link in lists interface. Also removing an unwanted ID from opac-shelves.tmpl markup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:20 -05:00
e183ac099a More fixes for Bug 3044
Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:17 -05:00
Galen Charlton
2e08f626f5 remove incomplete bib bulk editing code
Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:53:50 -05:00
502a8cb7e2 Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:36:26 -05:00
c705832fa9 New styles for bulk hold and bulk tag inputs on search results page.
This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 12:00:39 -05:00
e3d787fc22 Another try at fixing Bug 2949.
This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 11:48:28 -05:00