Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Kyle Hall	b00ec06968	Bug 10080 - Change system pref IndependantBranches to IndependentBranches Test Plan: 1) Enable IndependantBranches 2) Apply this patch 3) Run updatedatabase.pl 4) Verify that the system preference still functions correctly Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jared Camins-Esakov	7535f2bfa3	Revert "Bug 7167: New version for updatedatabase" This reverts commit `c9cb55ef47`.	12 years ago
Jonathan Druart	c9cb55ef47	Bug 7167: New version for updatedatabase This patch use DataTable, see BUG\|BZ 6836 - css/datatables.css - lib/jquery/plugins/jquery.dataTables.min.js - js/datatables.js http://bugs.koha-community.org/show_bug.cgi?id=7167 Bug 7167 follow-up Major changes: * creating database tables for update on the fly, the 1st time the update script is called * version is checked on mainpage.pl (and here only). If syspref Version differ from kohaversion.pl, the old updatedatabase is launched. If there are updates missing from new mechanism, the updatedatabase page is reached * kohaversion check on each page is now useless in Auth.pm, removed dead code * Updated installer: at the end of the process, retrieve all updates and automatically mark them "OK", as they're included in installer Minor changes: * adding copyright * adding poddoc * updating a warning, for better clarity * switching from $$var to $var-> * small TT glitch fixed in updatedatabase.tt * about.pl now returns the Version systempreference PLUS all the patches that have been applied Bug 7167 follow-up perlcritic & numbers display & partial apply depending on DEBUG * add use strict to updatedatabase, that is now perlcritic compliant * partial apply of DB revs is now managed by DEBUG env variable = if DEBUG=0, the user can just apply every DBrev. If DEBUG=1, we're in a dev env, the user know has the option to apply DBrevs one by one Display: * in updatedatabase, small spelling changes * in about.pl, remove 0 just after . (3.06.01 is displayed as 3.6.1) * improve the display of applied numbers on about.pl - before this patch, if you have N, N+1, N+2, N+3 and N+10 DB rev applied, about was displaying : , N+1 / N+2 / N+3 / N+10 - after this patch you have N......N+3 / N+10 * add ORDER BY into list_versions_already_knows to have number retrieved in the same order whatever the order they are applied http://bugs.koha-community.org/show_bug.cgi?id=6679 Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Improve the update.pl script * Added CLI options to update.pl * Call update.pl from the installer. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Now, we check versions on mainpage.pl and after login Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Reimplementing Marcel's suggestions & fixes * Fixing the bugguy old version check (that was made against 3.0900000 instead of 3.0900027 -the last current kohaversion number * in the CLI script, if there is nothing to report, just say it Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 7167: Remove check_coherency As suggested by Katrin, we've removed the call to check_coherency. It intended to provide readable comments when some SQL was wrong. Removing this sub result in the SQL error being displayed. That's OK because the sysadmin or the developer can google the error, understand it, then fix it. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Changing in .sql parsing We first split on delimiter and then extract comments. You can now put \n for delimiter comments. ex: DELIMITER ; -- this is a comment SELECT * FROM my_table; -- another comment Before this patch, we had to write: DELIMITER ; -- this is a comment; SELECT * FROM my_table; -- another comment; Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Add .pl and .sql examples Those files are in version directory, so will never be executed by the updater If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version) Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Improve display + factorize get_queries Despite it's size, this patch is dealing with display questions only: * The text "comments" and "queries" was hardcoded in ajax-updatedb-getinfo.pl script. It has been replaced by a JSON call, returning 2 separate values, "comments:" and "queries:" is now in the template, making it translatable * Some minor tweak in the display (like putting things in bold, displaying OK in green, warnings in yellow and KO in red) * Reordering the column headers for more readability: * Status column is merged with availability, column is after status * Status/availability terms more clear: "Not applied" instead of "unknown", "Applied and OK", "Applied and failed", "Applied and forced" are the 3 other statuses * Removed one click to display comments on DBREv not yet applied: before the patch, one had to click "Show details", then "Get comments", now, "Get comments" is enough Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: FIX typos & moving a script to a proper place * renamed availables to available * renamed already_knows to already_applied * fixed FSF & copyright headers * removing a "use strict" because we already had use Modern::Perl * fixed a tiny typo in about.tt * moving update.pl to misc/bin because it's a CLI script Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Add dependency File::Find::Rule Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: We want to execute non-numeric version with the -all option Dealing with Marcel comment 100: > Note that the current code around line 52/53 does not > handle that correctly: > Argument "\x{74}\x{65}..." isn't numeric in numeric ge (>=) at > installer/data/mysql/update.pl line 52. Now, a non-numeric DBRev will be applied if you provide the --all parameter, without throwing the error Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167 reindentation & removing dead code * The if (! defined $ENV{PERL5LIB}... block was wrongly intented * The 3 lines running update.pl are useless: the update (new mechanism) is run from admin/updatedatabase.pl script. This part of install.pl is run only when you have "old style" DB revisions. Summary: * old mechanism = it's run as previously, by reaching the installer/install.pl?step=3 page, that applies all revisions * new mechanism = when you log-in or reach mainpage.pl, you reach admin/updatedatabase.pl, where you can see what will be run, and run it Tiny side effect = the check for old mechanism is now done after authentification (thus it's not done on each page call). It means that the user will have to enter login/password twice : * first to log-in to Koha * second to run installer/updatedatabase.pl?step=3 As the old mechanism is deprecated, we can expect this will happend only a few time in the history of a setup, it's not a big deal. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Don't raise an error in routine TableExists Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: FIX merge Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Add .pl and .sql examples Those files are in version directory, so will never be executed by the updater If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version) Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167 follow-up fix POD syntax to please koha-qa.pl Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	92782d3832	Bug 7067 - OPAC Borrower Self Registration This development will add the ability for a new patron to register himself or herself. The self-registration will attempt to match this newly inputted data to any existing patrons and if any possible matches are found, ask if the patron is sure he or she doesn't already have an account at the library. A system preference may be set to prevent patron self-registration if the system detects the possibility that the person may already have an account. Once the patron has registered, passing a captcha (or similar bot-stopper), the patron will then be optionally verified a second time via email. At this point, the patron will be able to print a temporary library card (optional by system preference), and will be provided any details necessary to access electronic resources (this body of text would be a template in the slips and notices system). At the library's choice, this new patron would either be set to a temporary patron status (patron type set via system preference), or a fully-fledged patron (allow patron type to be determined by age and/or other attributes). Assuming the library uses temporary patron types for OPAC registrations, this patron will next enter a queue and would need to physically enter the library to verify himself and become a fully-fledged patron (most likely by bringing in physical proof of address, etc.). The librarian would look up the patron record and modify the patron type. If a temporary patron has not been verified within a certain time frame (defined by a system preference), the patron record will be deleted from the system via a cron job. For registered patrons, the system will allow each person to also update his or her personal data via the OPAC. When a patron updates his or her information, the changes will be entered into a queue to be verified by a librarian (preventing a patron from inputting obviously bogus data). The staff client home page will display the number of patron records with changes awaiting approval. A librarian would then be able to click through a list of modification requests, and approve or deny each (with approval and denial alerts being sent to the patron via the standard messaging system). NEW SYSTEM PREFERENCES * PatronSelfRegistration * PatronSelfRegistrationDetectDuplicates * PatronSelfRegistrationVerifyByEmail * PatronSelfRegistrationPrintTemporaryCard * PatronSelfRegistrationUseTemporaryStatus * PatronSelfRegistrationExpireTemporaryAccountsDelay NEW NOTICE * Verify by email notice NEW SLIP * Temporary card slip NEW CRON JOB * delete_expired_opac_registrations.pl - Deletes patrons that have not been upgraded from the temporary status within the specified delay * delete_unverified_opac_registrations.pl - Deletes the unverified patrons based on the length of time specified in the PatronSelfRegistrationExpireTemporaryAccountsDelay The patron will register from self_registration.pl, linked off opac-main.pl if enabled. The registration page will be translatable to other languages in the same way that existing templates are. Test Plan: 1) Enable PatronSelfRegistration 2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number of days 3) Create a self-registered borrower category 4) Set PatronSelfRegistrationUseTemporaryStatus 5) Set PatronSelfRegistrationVerifyByEmail to "Don't require" 6) Go to OPAC, log out if logged in. 7) You should see the "Register here" link below the login box 8) Attempt to register yourself 9) Verify you can log in with your temporary password. 10) Set PatronSelfRegistrationVerifyByEmail to "Require" 11) Attempt another self-registration 12) Check the messages table, you should see a new message with a verification link. 13) Copy and paste the link into a web browser to verify the registration 14) Log in with the given credentials to verify the account was created. Test Plan - Part 2 - Borrower Modifications 1) Log in to OPAC, go to "my personal details" tab. 2) Make some modifications to your details. 3) Repeat steps 1 and 2 for two more borrowers. 4) Log in to Koha intranet with a user that can modify borrowers. 5) At the bottom of mainpage.pl, you should see: Patrons requesting modifications: 3 6) Click the link 7) Approve one change, deny a different one, and ignore the third, then submit. 8) Check the records, you should see the changes take affect on the approved one, and no changes to the other two. You should also see "Patrons requesting modifications: 1" at the bottom of mainpage.pl now. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page * Add documentation and switches to cron scripts * Add required fields check for editing exiting patrons * Don't force require email address for existing patrons when PatronSelfRegistrationVerifyByEmail is enabled. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Paul Poulain	5293bb5540	Bug 9008: warn if user is logged-in with admin account Test plan: * log-in staff interface with admin (mysql) account => there's a large warning on the homepage * log-in with another account => nothing displayed Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Paul Poulain	056b5faa40	Bug 6875 cleaning mainpage.pl AutoritiesMarc is loaded for nothing : we don't display authorities anywhere, so removing the dependancy as well as the useless code Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	13 years ago
Owen Leonard	d3c02c6bb6	Bug 7259 - Show a count of items pending approval on staff client home and tools pages This patch adds count indicators on the staff client home page and the tools page for the number of items pending approval. On the home page this includes suggestions, comments, and tags. On the tools page a count of pending comments and tags is shown. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Counts appear for all types of actionable items listed, all are clickable through to the proper place. Nice work!	13 years ago
Chris Cormack	93d4c90a68	Bug 4330: Wrong address for Free Software Foundation Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>	13 years ago
Chris Cormack	80deb4081f	Bug 4330 : Updating copyright statements mainpage.pl git who mainpage.pl 7 tipaul 2 Chris Cormack 2 Galen Charlton 2 acli 1 Joshua Ferraro 1 hdl 1 kados 1 rangi 1 rych 1 tgarip1957 1 tonnesen	13 years ago
Galen Charlton	c0fedbab3c	remove last vestiges of NOTMARC mode MARC, the metadata exchange format for the 20th century! Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Chris Cormack	231ea7c341	Bug 2505 enabling warnings	15 years ago
Galen Charlton	4bf76c2d77	bug 2615: remove unneeded 'require Exporter' Most Perl scripts (as opposed to modules) do not need to require Exporter. No user-visible or documentation changes. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	16 years ago
Joshua Ferraro	3bf4859a8b	fixing permissions requirements on mainpage.pl Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
Chris Cormack	2d46b42cd6	Perltidy mainpage.pl	17 years ago
hdl	1ca8a9ceb8	I forgot this script.	17 years ago
kados	3969bbe369	fixing permissions on mainpage	17 years ago
rych	13f6840c71	add mainpage	17 years ago
tipaul	86e9db4e67	rel_3_0 moved to HEAD (removing useless file)	17 years ago
tgarip1957	04b2e6112f	Finalized XML version for intranet	18 years ago
tipaul	3389e743a1	commit for holidays and news management. (some forgotten files)	18 years ago
tipaul	f55e808ec0	synch'ing 2.2 and head	19 years ago
tipaul	22e25d5094	fix for #646 (logging with low rights librarian code)	21 years ago
rangi	7683a424ce	Fix for 418	21 years ago
acli	52a5fd4bbd	Moved C4/Charset.pm to C4/Interface/CGI/Output.pm Create output_html_with_http_headers function to contain the "print $query ->header(-type => guesstype...),..." call. This is in preparation for non-HTML output (e.g., text/xml) and charset conversion before output in the future. Created C4/Interface/CGI/Template.pm to hold convenience functions specific to the CGI interface using HTML::Template Modified moremembers.pl to make the "sex" field localizable for languages where M and F doesn't make sense	22 years ago
acli	ea50c2acb6	Preliminary fix of the CGI.pm problem of always assuming that everything is in ISO-8859-1. A new C4::Charset module (tentative name) has been created to guess the charset of a piece of HTML markup. The CGI programs will be modified to use this module as they are encountered during translation.	22 years ago
tipaul	5f3749d437	adding authentification with Auth.pm (note : i want to stay the 1st commiter in december as in november :-) )	22 years ago
tipaul	afe757aeca	* bugfixes * improvements done during dombes intallation/tests * adding authentication (new Auth.pm)	22 years ago
tonnesen	c16a952963	Merging from rel-1-2 to trunk	22 years ago
tipaul	4630b49761	merging 1.2 and bugfixes for auth and login : admin, members and reports home pages	22 years ago

29 Commits (1e0b890b0c2b15217e0961341cef1d3e3922c2c4)