Commit graph

166 commits

Author SHA1 Message Date
Colin Campbell
6f58777313 Bug 766 Remove scrolling list from serials claims
Let templating system do what its designed for
pass an array ref with the suppliers
2010-01-05 17:11:31 +01:00
Chris Cormack
b33641ed1c Bug 3903 - Members names not showing on serial routing list 2009-12-20 14:31:38 +01:00
1b1972044c Fix for Bug 3905 (Serial routing list add patron popup pagination broken)
This patch also includes formatting fixes and style updates. The patron search filter form is incorporated now within serials/member-search.tmpl in order to have a markup structure more suited to the pop-up.
2009-12-20 14:31:33 +01:00
Henri-Damien LAURENT
6b29bb866b followup da49fc77df enh 3736 2009-11-23 21:35:07 +01:00
Henri-Damien LAURENT
27460a7ab4 Follow up : MT1902
aaa8d0c80c
This fixes the loop with dates with was using implicit variable
2009-11-11 16:53:28 +01:00
Henri-Damien LAURENT
72d91ac361 Adding a warning On subscription deletion for item
If we really wanted to delete all items linked to a subscription when we delete a subscription
we should change the database structure as such :
ALTER TABLE serialitems ADD FOREIGN KEY ( itemnumber ) REFERENCES items (itemnumber) ON DELETE CASCADE ;
ALTER TABLE serial CHANGE subscriptionid subscriptionid INT( 11 ) NOT NULL
ALTER TABLE serial ADD INDEX subscription ( subscriptionid )
ALTER TABLE serial ADD FOREIGN KEY ( subscriptionid ) REFERENCES subscription (subscriptionid) ON DELETE CASCADE ;
2009-11-11 15:19:24 +01:00
Henri-Damien LAURENT
fc1a5ed318 MT1883 : Serials enddate was not cleanly used
GetExpirationDate should now be used only to get the NEXT expirationdate based on startdate
Perltidying C4/Serials.pm
2009-11-11 14:00:11 +01:00
Paul Poulain
21c3169795 removing warnings 2009-11-11 11:17:48 +01:00
Paul Poulain
bd989696e3 transforming dates to iso to avoid a mySQL error 2009-11-11 11:17:48 +01:00
Paul Poulain
1ca96457b3 Displaying serial call-number on receive.
when the subscription has item creation, the callnumber is inside the item creation.
But when it doesn't have, the callnumber is not displayed, but is useful to be put on physical item.
This patch display the callnumber after the title
2009-11-10 22:23:49 +01:00
Henri-Damien LAURENT
da49fc77df 3736 enh : Adding syspref RoutingListAddReserves
Adding syspref RoutingListAddReserves
Using it in routing-preview
2009-10-29 15:29:04 +01:00
Henri-Damien LAURENT
a9aca08a51 MT 1902 : routing lists presence should be shown
in serials-home, when showing the list of serials,
display is changed in order to display the presence of a routing list
for a subscription
2009-10-29 15:12:53 +01:00
Henri-Damien LAURENT
a2d34166d6 Improving patron search in serials routing
Adding category and library search
Unifying with central member search
2009-10-29 11:56:08 +01:00
Henri-Damien LAURENT
5555b9b780 Adding toggle of subscriptionhistory information 2009-10-26 15:34:33 +01:00
Matthias Meusburger
aaa8d0c80c MT 1902, Follow-up 2009-09-30 11:30:41 +02:00
Matthias Meusburger
cc2ca67ca0 Follow-up to 103e97c400a64a33fb12bea3b34d525251564b57 2009-09-30 11:30:40 +02:00
Matthias Meusburger
5ec00f6a55 Fix unmerged routing-preview.pl 2009-09-30 11:30:40 +02:00
Matthias Meusburger
d208a5593a MT 1903 : Remove "Automatically set to late" note in serials-collection.pl 2009-09-30 11:30:40 +02:00
Matthias Meusburger
2054864883 MT 1882 : ccode search in serials/subscription-bib-search.pl 2009-09-30 11:30:39 +02:00
Matthias Meusburger
0ecb9839b6 MT 1885 : Fixed patron notification when adding subscription 2009-09-30 11:30:36 +02:00
Paul Poulain
b147973091 fixing acqui-search.pl
removing useless & bugguy code (reference to bookfund)
2009-09-30 11:30:26 +02:00
Paul Poulain
74302d7570 Serials, use Budget instead of Bookfund 2009-09-30 11:30:22 +02:00
Jean-André Santoni
4335ab1438 (bug #3563) This replaces the library name by the branchname attached to the subscription, and hide streetaddesses in serials routing
In routing-preview, the title should be the branchname attached to the
subscription instead of the libraryname.
And showing the streetaddress of the members is useless, and harm privacy.
2009-09-30 11:30:11 +02:00
Henri-Damien LAURENT
fbe215e6c6 Claims management enhancement
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:24 +02:00
Henri-Damien LAURENT
837ce4a0d7 Adding enddate to Subscriptions
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:24 +02:00
Henri-Damien LAURENT
4271bbb738 Modifying Members : Add Mod and GetMember
This update the way Member is added and editing so that import and Edition
 could be best automatized
GetMember evolves and allow ppl to serach on a hash of data

Adding SQLHelper A new package to deal with INSERT UPDATE and SELECT

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:23 +02:00
Colin Campbell
bfad238475 Ensure op is defined in serials scripts
Set $op to an empty string if no value passed
otherwise the error-log fills with warnings on comparison
2009-09-16 07:20:08 -04:00
Colin Campbell
c9f3ede161 Enable warnings in serial scripts
Remove some superfluous variables
Simplify some loops over lists
Fix generated warnings
Strip whitespace from line endings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 21:26:11 -04:00
Henri-Damien LAURENT
2c1cdc5dc3 Bug Fixing 3568 : Untranslated strings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 14:20:19 -04:00
Michael Hafen
74a4f29236 Allow the reserve date to be set on holds
This adds to the interface and code the ability to set the reserve date when
requesting a hold.

Resubmit.  Sorry, I formatted it from the wrong branch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 18:02:26 -04:00
Garry Collum
94abcf6d98 Bug 2889: Removed toggle variable from Serials vendor search.
Removed toggle variable from acqui-search-result.pl.  Added highlighting using __odd__ to acqui-search-result.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:42:42 -04:00
Colin Campbell
d11c3e608a (bug 3434) Fix generation of Serials Claims
op was not being returned to claims.pl. It seems better logic
to use whether the there are ids the user has flagged for claims
to decide whether to generate the claims

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 21:22:16 -04:00
J. David Bavousett
a5bd87735e (Bug 3402) Serials issue name not escaped when passed forward to routing slip
The issue descriptor was not being escaped before being passed on to the
routing slip, causing truncation.  It's truly impossible to know for sure
what will be there, so uri_escape-ing seemed the best way to ensure that
it gets handed forward and makes it all the way to the printable slip.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:45:11 -04:00
Garry Collum
9046a26d68 Bug 2935: Patch to fix location in routing slip.
routing-preview.pl and routing.pl were pointing to a non-existent column in the borrowers table.  This patch replaces streetaddress with branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:44:56 -04:00
Nahuel ANGELINETTI
34426697c5 (bug #3355) add pagination in bib search for subscriptions
This add the support of pagination, delete a javascript call, and use now a get method(why post was used?).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 22:45:14 -04:00
d914fb60df Bug 3351 - Limit Serials Search for Biblio to an item type
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 08:43:42 -05:00
Galen Charlton
8aedc8f53f removing disused script
serials/subscription-copy.pl had been removed
in commit 8c78ff5aa5 but
for some reason had been accidentally restored in
a subsequent commit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-09 09:31:12 -05:00
Galen Charlton
ecdf595208 bug 3314: remove disused scripts and API functions
The distributedto column of the subscription table is
no longer used, having been replaced by the serials
routing list table.  This patch removes two C4::Serials
functions and a script and template, none of which were
reachable by current code:

C4::Serials::GetDistributedTo()
C4::Serials::SetDistributedTo()
koha-tmpl/intranet-tmpl/prog/en/modules/serials/distributedto.tmpl
serials/distributedto.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 17:03:05 -05:00
Paul Poulain
6924e7d6b4 fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected
Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:06:46 -05:00
Galen Charlton
ee4de2f652 various improvements to subscription editing
* fix XHTML errors in template
* the patron notification type is now correctly
  displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
  in initial patch for bug 3020

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:57 -05:00
Henri-Damien LAURENT
af32ae0962 Adding and managing location in subscription
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:55 -05:00
Nahuel ANGELINETTI
3b1d91d04f (bug #3020) add a grace period to subscriptions
This patch modify the database to have a grace period which can be set. And is used to create automatically new waited issues with a
cronjob(which is in this patch), and set old issues to "late" status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:46:36 -05:00
Nahuel ANGELINETTI
8cd87e5426 (bug #3198) fix serial receive with autobarcode
this add an arg to GetMarcFromKohaField, else it will always return (0,0).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:06 -05:00
Galen Charlton
70b7017eca fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:32:02 -05:00
Nahuel ANGELINETTI
70e46edf73 (bug #2961) change the workflow of the new issue
This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as "late"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 18:03:30 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Nahuel ANGELINETTI
5397ab31dc (bug #2961) add a button to add manually the next issue
This patch add a button in "Serial Collection" to add manually the next issue. And improve the function GetNextExpected
to retrieve at least something.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:40:55 -06:00
Galen Charlton
8f07521a2d bug 2955: fix remaining calls to GetMarcFromKohaField
This includes part of a patch from Henri-Damien Laurent
that could not be applied because Chris and Joe patches
happened to win the race.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 16:29:19 -06:00
Nahuel Angelinetti
e23ae31699 bug 2689: Fix the checked box "manual history" and fix the "null" value of serial next issue publication date
first part of this patch is the manual history must be checked if in database its checked.
Then, when you do not enter a value "Next issue publication date", a null value was set in the database, now, if empty, the  "first issue date" is set as "next issue".
And finally, We check that "manual history" is checked to show the "Subscription history" part. Actually its never shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:08:29 -06:00
Galen Charlton
4bf76c2d77 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:05:08 -05:00