Commit graph

33 commits

Author SHA1 Message Date
Alex Arnaud
b592c3a0f5 (MT #3651) Fix problems on search filters.
removing of useless value "no tabs" in organize by combo.
removing of useless value "Sort 1" in organize by combo.
Adding combodate for suggesteddate, manageddate, accepteddate.
Adding research on dates in query.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-25 05:22:05 -04:00
Alex Arnaud
70607332a1 (MT #3651) Fills "book fund" combobox with bugdets and fix some bugs of research by filter.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-25 05:22:03 -04:00
c9ba8c899d Merge branch 'bug2505_patches' of git://git.catalyst.net.nz/koha into to-push
* 'bug2505_patches' of git://git.catalyst.net.nz/koha: (24 commits)
  Bug 2505 - use strict and warnings in sax_parser_test
  Bug 2505 - enable warnings for link_bibs_to_authorities
  Bug 2505 - add strict and warnings to perlmodule_ls
  Bug 2505 - add strict and warnings to check_sysprefs
  Bug 2505 - Add commented use warnings where missing in *.t
  Bug 2505 - Add commented use warnings where missing in *.pm
  Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory
  Bug 2505 - Add commented use warnings where missing in the misc/ directory
  Bug 2505 - Add commented use warnings where missing in the tools/ directory
  Bug 2505 - Add commented use warnings where missing in the installer/ directory
  Bug 2505 - Add commented use warnings where missing in the rotating_collections/ directory
  Bug 2505 - Add commented use warnings where missing in the C4/ directory
  Bug 2505 - Add commented use warnings where missing in the serials/ directory
  Bug 2505 - Add commented use warnings where missing in the catalogue/ directory
  Bug 2505 - Add commented use warnings where missing in the sms/ directory
  Bug 2505 - Add commented use warnings where missing in the opac/ directory
  Bug 2505 - Add commented use warnings where missing in the virtualshelves/ directory
  Bug 2505 - Add commented use warnings where missing in the suggestion/ directory
  Bug 2505 - Add commented use warnings where missing in the admin/ directory
  Bug 2505 - Add commented use warnings where missing in the circ/ directory
  ...

Conflicts:
	C4/Auth_with_cas.pm
	acqui/supplier.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-23 07:13:37 -04:00
Paul Poulain
ae281f3712 follow-up : remove perl error if the librarian choose no budget
the librarian can enter the suggestion without selecting any budget.
Searching the budget name in this case resulted in a Perl error

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-23 07:00:59 -04:00
Henri-Damien LAURENT
c841eb0e0c MT3168 : Suggestion budget management
budget were not saved and not correctly displayed

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-23 07:00:56 -04:00
Donovan Jones
2587115062 Bug 2505 - Add commented use warnings where missing in the suggestion/ directory 2010-04-21 20:20:18 +12:00
d45ee12e5c Revised for biblibre/3.2_community: Reformat of suggestions management interface (Bug 3844)
Changes and fixes include:

- Moving filters forms into left-hand sidebar
- Making filter forms collapsed by default (click to show)
- Converting "check all" to text link to match similar controls on other pages
- Correcting case of tab labels
- Fixing display of custom reason field
- Converting radio buttons to drop-down for more compact display
- Table-sorter column exclusions
- Markup corrections
2010-01-20 22:32:11 +01:00
b6ced3b773 Fix for Bug 3926 (suggestion edit form combines data)
Breaking patron information variable into separate surname, firstname, branch, category, and borrowernumber variables and using those variables to tweak the display.
2009-12-20 14:31:39 +01:00
Chris Cormack
a05c092e99 Fixing suggestions management page, Authorised values werent being passed through 2009-12-20 14:31:33 +01:00
Henri-Damien LAURENT
58e76f605c followup 73de4a2e3f
Some merge problems occured
2009-11-19 17:08:47 +01:00
Henri-Damien LAURENT
73de4a2e3f Date management update Suggestions 2009-11-17 16:27:14 +01:00
Paul Poulain
f1b6fba45b fixing who and when the suggestion is done 2009-11-17 16:27:13 +01:00
Paul Poulain
8bea1fa2c4 reindenting 2009-11-17 16:27:13 +01:00
Paul Poulain
dc85da1830 suggestions improvements and fixes
- reindenting Suggestions.pm
- removing useless code in acqui-home.pl & fixing # of pending suggestion display
- add suggestion to order : displaying for selection suggestions accepted by the librarian (and reindenting)
- XHTMLing acqui-home (& removed useless parts)


NOTE ABOUT XHTML (could be useful) : <tfoot> must be BEFORE <tbody> in a <table>, even if, of course, it is displayed after.
2009-10-29 17:56:44 +01:00
Paul Poulain
44f3f7bb94 removing useless files & fixing broken link 2009-10-28 19:21:14 +01:00
Henri-Damien LAURENT
3ab463fc34 suggestion.pl has to be updated on C4/Budgets 2009-09-30 11:30:29 +02:00
Henri-Damien LAURENT
38b61303bd Bug Fixing : 1st Step Bookfund has become Budgets
More bug fixing on Suggestions and Budgets
2009-09-30 11:30:29 +02:00
Paul Poulain
03d9a79878 suggestions changes (probably useless)
and incompatible with hdl stuff
2009-09-30 11:30:22 +02:00
Henri-Damien LAURENT
8802bbf5fe Editing C4::Suggestions.pm
Enhancing C4::SearchSuggestion
And changing its API
Changing C4::Suggestions API taking a hashref for NewSuggestion and ModSuggestion

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:23 +02:00
Paul Poulain
6924e7d6b4 fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected
Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:06:46 -05:00
Joe Atzberger
be06bf0554 acceptorreject.pl cleanup
Perltidy the ugly block (still ugly).
Use elsif where appropriate.
Added FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:35 -05:00
Galen Charlton
ce8e70c6c6 bug 2505: turned on warnings for suggestion/acceptorreject.pl
Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:27:55 -06:00
Galen Charlton
4bf76c2d77 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:05:08 -05:00
157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:32 -05:00
Henri-Damien LAURENT
5e9465a14a Accept or reject : Bug Fix and improvements.
Improving workflow : A suggestion can be edited and status can be changed if mistaken as soon as it is not deleted or acquired.
Adding dates display.
Adding deletion of suggestions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-17 05:52:47 -05:00
Paul POULAIN
8b7085a8ab removing useless code
the 3 parameters :
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),

are filled by Auth.pm automatically, removing them in templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:03:38 -05:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
fc1342f73d rel_3_0 moved to HEAD 2007-03-09 15:12:54 +00:00
toins
bb9518b9f1 POD added. 2006-07-12 17:03:49 +00:00
toins
1696f62652 Sub renamed & GPL Licence added. 2006-07-07 09:00:12 +00:00
toins
cc9524a875 Head & rel_2_2 merged 2006-07-04 14:36:51 +00:00
tipaul
f29ce59691 Acquisition & Suggestion :
* acquisition rewritte : create a aqbasket table to deal with "bookseller order header".
* add "close basket" feature : a closed basket can't be modified
* suggestion feature : manage suggestions in acquisition (after suggestion filled in OPAC)
2004-07-15 09:41:03 +00:00