Commit graph

4413 commits

Author SHA1 Message Date
2402601988 Fix for Bug 3256, "Long email address cut off in patron windows"
This fix tweaks the overflow settings for the email address and adds an image of an elipsis as the background, giving the appearance that the text is being truncated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:13:59 -04:00
d5da1cace0 future hold request followup 4 - date controls
Fixed the calendar control for selecting the request
date in staff and OPAC so that user can explicitly
select current date and all days in the future.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:40 -04:00
Michael Hafen
74a4f29236 Allow the reserve date to be set on holds
This adds to the interface and code the ability to set the reserve date when
requesting a hold.

Resubmit.  Sorry, I formatted it from the wrong branch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 18:02:26 -04:00
Colin Campbell
c1d4bb641b Bug 3522 Refactor Create Update Delete letter for consistency and readability
Fixed inconsistent usuage of primary key in delete
Refactored:
Moved operations to separate subroutines to clarify data flow
Removed unnecessary redirects to self
Renamed confusingly named else variable passed to template
Other changes for code clarity
NB Outstanding:
database reading/writing should live in appropriate module
not duplicate it here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 17:51:43 -04:00
ae5b76c89b bug 2157: add ability to 'clean' staged record batches
batches, it is now possible to 'clean' a batch by
removing all bib and item records staged in the batch.  This
has the effect of helping to reduce database space used
by old import batches as well as removing staged records
from the cataloging reservoir search.  Note that 'cleaning'
a batch affects only the copies of the records that were staged;
if the batch was committed, cleaning the batch does not
affect any bibs and items that were committed into the catalog.

Also note that once you clean a committed batch of records, it is
impossible to undo the previous commit operation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-10 20:34:55 -04:00
9f6098e8b9 Showing "more searches" menu options when JavaScript is disabled (Bug 3517)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-10 20:34:42 -04:00
Kyle M Hall
f41971eadf Reverse Payment - Allows any payment to be 'undone' while retaining a record of said payment. Useful for accidental double-payments.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:23:33 -04:00
Garry Collum
3c27773a41 Bug 3292: Fix to display Branch names instead of branch codes in opac serial's displays.
Fixes display of branch name in opac-full-serial-issues.tmpl and opac-serial-issues.tmpl.  Also enables zebra striping in opac-serial-issues.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:18:29 -04:00
Nahuel ANGELINETTI
5e4d69484c (bug #3513) fix xhtml in marc detail
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 15:21:35 -04:00
Nahuel ANGELINETTI
47ecf39e75 (bug #3497) show publication year, or copyrightdate
This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-05 20:11:00 -04:00
Nahuel ANGELINETTI
45761d67cb (bug #3505) fix 210c and 225a unimarc's plugins
This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-05 20:10:42 -04:00
5cd357e76c bug 3465: enhance DB update reporting by web installer
This enhances the web installer so that messages from updatedatabase.pl will
be displayed to the user running a database update.  Messages printed to STDOUT
will be displayed as the update report, while messages printed to STDERR will
be displayed as update errors.

This patch introduces  a new module dependency, IPC::Cmd.
IPC::Cmd lets one run an external program such as updatedatabase.pl and easily
capture STDERR and STDOUT for further munging.  IPC::Cmd is core in Perl 5.10
and stable in Perl 5.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-04 06:15:40 -04:00
Kyle M Hall
9f3ecc8a29 Quick Spine Label Printer - Minors fixes
This new version of the patch does away with the need for 2 spinelabel css files.

This patch address two points brought up:
[1] (minor) if an item is not found, it should say so and return to
spinelabel-home.pl, not show an empty label
[2] (minor) can the print button be excluded from the printout?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-03 21:18:40 -04:00
Garry Collum
4cb2c16587 Bug 3466: Fixes xhtml errors in opac-shelves.tmpl.
Addendum to bug 3466.  opac-shelves.tmpl contained the same xhtml error as shelves.tmpl, if the user is viewing the public list a orphaned table row (<tr>) is present.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:11:10 -04:00
Kyle M Hall
6860310e96 Quick Spine Label Printer
This is a small tool for quickly printing spine labels using dedicated label printers.
It is located in the Tools page as Quick Spine Label Creator.
The system preference SpineLabelFormat defines which fields will be displayed.
The pref SpineLabelAutoPrint will make the print dialog pop up automatically.
The CSS file spinelabel.css controls all presentation for the labels.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 10:47:13 -04:00
Sébastien Hinderer
1ac250ea27 bug 3440: Modifies branches script and template so that the newly added rows are taken into account.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:44:22 -04:00
Garry Collum
94abcf6d98 Bug 2889: Removed toggle variable from Serials vendor search.
Removed toggle variable from acqui-search-result.pl.  Added highlighting using __odd__ to acqui-search-result.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:42:42 -04:00
Garry Collum
e997a4a11c Bug 2553: Additional patch for the branch drop-down in Existing Holds.
Improves previous patch through the use of GetBranchesLoop. Also adds highlighting to the Existing holds table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:42:36 -04:00
45f799a7de Minor change to fix Bug 3086, Can't close circulation date-picker popup in Internet Explorer
I don't know why this edit fixes the problem, but it does. Tested in IE6, IE7, and IE8 on Windows XP.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:27:23 -04:00
a08e269db0 Removing unused recentacquiloop markup (Bug 3439)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:09:55 -04:00
e5d9b34dce More XHTML corrections (Bug 3211)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:18:22 -04:00
f63456b025 XHTML corrections (Bug 3211)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:18:19 -04:00
Garry Collum
b904347142 Bug 3452: Additional patch that expands the branch name and category code in Suggestions Management.
Displays the Branch name and Category description along with their codes in Suggestion Management.

Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:05:22 -04:00
Colin Campbell
d11c3e608a (bug 3434) Fix generation of Serials Claims
op was not being returned to claims.pl. It seems better logic
to use whether the there are ids the user has flagged for claims
to decide whether to generate the claims

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 21:22:16 -04:00
Colin Campbell
05be94ba9a User will find it useful to see the date claimed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 21:22:13 -04:00
Kyle M Hall
207fb1c02a Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF (Part 2)
Added code to opac-ISBDdetail.pl to match the changes made to the template file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:37:04 -04:00
66d9fe254f Adding missing image: Bug 3457, broken image in opac.css - new.gif
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:37:03 -04:00
Garry Collum
3a058fcc9d Bug 1607: Fixes the delete checkboxes in purchase suggestions.
If a user views suggestions of another user, syspref (OPACViewOthersSuggestions), a selection check box for deletion appeared next to all of the suggested titles whether the logged-in user owned them or not. - fixed

Also fixes the "Clear all" and "Select all" links which appeared for anonymouse users, if AnonSuggestions is turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 22:34:26 -04:00
Joe Atzberger
b36269ea85 Bug 3056 - replace span hacking for terms in C4::Search
Reimplemented using jquery, added OSS plugin to both interfaces.  This is
another case where having a /common directory used by both OPAC and STAFF
would increase runtime efficiency and cut development time.

Removed unused variables.

I changed the OPAC .term color to match the staff interface, rather than being a
second shade of blue.  The highlight/unhighlight link is currently a bit bolder
than its neighbors, but my styling choices are provisional.  I expect the final
tweaking of CSS to come from another more capable designer, like Owen.

Note this patch may rely on previously submitted "Search.pm minor cleanup" patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 22:06:55 -04:00
Garry Collum
11f05061cc Bug 3452: Displays borrower category and adds links to Suggestions Management
A couple of enhancments to Suggestions Management.

Adds a display of the borrower category of the suggesting patron for each item.

Adds links to the title and author displays so that the catalog can be quickly search for an existing bib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:39:44 -04:00
7ad2cfac6d Change to layout of tag review interface (enhancement bug 3447)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:39:41 -04:00
Kyle M Hall
38b356da8b Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:15:13 -04:00
Nicole Engard
04db609d9e BUG 1255 Barred users will not see renew or renew all anymore
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 21:11:31 -04:00
J. David Bavousett
a5bd87735e (Bug 3402) Serials issue name not escaped when passed forward to routing slip
The issue descriptor was not being escaped before being passed on to the
routing slip, causing truncation.  It's truly impossible to know for sure
what will be there, so uri_escape-ing seemed the best way to ensure that
it gets handed forward and makes it all the way to the printable slip.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:45:11 -04:00
Garry Collum
a9609f6e96 Bug 2889: Added highlighting to Serials Subscriptions table in serials-home.tmpl.
Added highlighting to serials subscriptions table.  Cleaned up unused toggle variable code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:44:46 -04:00
Colin Campbell
acdb93ea6f Show claimed issues as 'Claimed' not just blank space
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 11:27:41 -04:00
605be873e0 Correcting some selectors to conform with upgraded jQuery syntax (see Bug 3297).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:56 -04:00
Garry Collum
be1ef2b2fa Bug 2553: Alphabetization of branches in the catalogue stats report.
Improvement on previous patch by using GetBranchesLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:53 -04:00
Garry Collum
8c1b8b47c5 Bug 2553: Alphabetization of branches in Checkout Statistics form.
Improvement of previous patch through the use of GetBranchLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:51 -04:00
Nahuel ANGELINETTI
2091a99e73 (bug #3421) fix the xhtml in serial biblio search
This fix differents errors, and escape in bib search.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 22:08:17 -04:00
Garry Collum
d7cecac86c Bug 3418: Fixes the alpha order of the system preference tags.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 21:07:16 -04:00
Garry Collum
8582033e7c Bug 3408: Tag cloud says login when logged in - fix.
Changed the logic in the html form to have the login prompt only appear if a user is not logged in.  Separated the hidemylist functionality from the "show tags from other users" option.  Created a link for "hide my tags" or "show my tags" depending on context.

The user can now choose how many tags of other users to show, and can also choose whether to show their own tags or not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:56:55 -04:00
Matthias Meusburger
2e1a9d657a Bug 2593 : way to duplicate items
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:35:52 -04:00
Joe Atzberger
850a8c2a4b Cannot use the same TMPL_VAR to select ALL options.
Only one select can be selected in this case.  If preselection of search type is
desired, I recommend a clean implementation w/ jquery instead of adding a conditional
for each select.  Please note, that is the only good way to get multiple preselections,
since the same .inc file will be used in each case.  So a single variable like
    <TMPL_IF NAME="index_bc_selected">
cannot be used, since it would set for ALL (3) advanced search dropdowns.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:28:06 -04:00
Joe Atzberger
df7ef101e1 Remove bogus "selected" logic from OPAC adv. search.
The only reason the TMPL_VAR works where it does is because it is part
of the TMPL_LOOP.  It doesn't mean anything outside the loops, since
*everything* would be selected with the same variable, indiscriminantly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:17:49 -04:00
Nahuel ANGELINETTI
3e7e8bf35e (bug #3398) fix unimarc 210c plugin
this add some args to SearchAuthority();
Fix the pagination, and fix javascript script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-15 09:09:27 -04:00
Nicole Engard
9915d66589 Fix BUG #3406 - move tag cloud above 'my tags' for ease of reading
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 23:00:29 -04:00
Garry Collum
a1f827a611 Bug 3317: Adds author and added-author to email sent from basket (Cart).
Adds the author and added author fields to the email that is sent from the shopping cart.  This makes the data sent via email consistent with the data that is viewed in the basket.

There is still a problem with author authority records other than 100 tags appearing correctly in the shopping cart.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 22:54:04 -04:00
68b34874b0 Changes to lists to improve behavior for users with no javascript
This patch moves the creation of some js-based function links to the script so that non-functioning links will not display when javascript is turned off. Other links which require TMPL processing are hidden with CSS and shown with JS.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 22:25:01 -04:00
Joe Atzberger
46b9ee7a93 Branch auto-selection in additem
Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:39:00 -04:00