Commit graph

125 commits

Author SHA1 Message Date
Henri-Damien LAURENT
4271bbb738 Modifying Members : Add Mod and GetMember
This update the way Member is added and editing so that import and Edition
 could be best automatized
GetMember evolves and allow ppl to serach on a hash of data

Adding SQLHelper A new package to deal with INSERT UPDATE and SELECT

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:23 +02:00
Katrin Fischer
c36098e316 Bug 3464: Added altcontactcountry and B_address2 to borrowers and deletedborrowers
- added altcontactcountry and B_address2 to tables borrowers and deletedborrowers so that all addresses offer the same fields
- changed B_country and country to work with syspref BorrowerMandatoryField
- changed display of Alternate Address on borrower detail page, added labels, lines and edit button to match the other sections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 10:01:51 -04:00
82f4badf51 bug 3464 followup - fix glitches
* Fixed 'counry' typo
* added country and B_country to deleteborrowers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:38:56 -04:00
Sébastien Hinderer
f1f833c965 bug 3464: Takes columns country and B_country of table borrowers into account in related operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:19:20 -04:00
Paul Poulain
6924e7d6b4 fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected
Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:06:46 -05:00
Galen Charlton
b6e62489d8 bug 3222: moved messaging preference editing
The display and editing of messaging preferences
for a patron have been moved as follows:

* the prefs for a patron are now displayed on the
  patron details tab, not the messaging tab.
* the prefs are now modified by editing the patron
  record, not on the messaging tab.

The messaging tab now contains only the list of
messages that have been or will be sent to the patron.

When creating a new patron record, changing the patron
category via the category dropdown now also changes
the default messaging preferences for that patron.  If
you start editing a new patron, change one of the messaging
preferences, then change the patron category, the form will
ask you if you want to keep the preferences or get
the defaults belonging to the new patron category.

Note that when you edit an existing patron record, changing
the patron category will *not* cause the messaging preferences
to be automatically changed.

Programmer's note: this commit introduces a new web service,
members/default_messagingprefs.pl, that uses Jesse Weaver's
C4::Service module.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:56 -05:00
Joe Atzberger
ccb64c18ee Bug 3177 - haspermission offers bogus option
$intflags was never used or returned if hashref instead of userid was passed.
Also cleaned up needless passing of $dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:20 -05:00
Galen Charlton
e203808549 bug 3159: allow editing child patron that has no valid guarantor
If a patron with a child patron category is not linked
to a guarantor (or a valid one), it was not possible to edit
the child patron's record.  When attempt, no changes were saved
and the following error is recorded in the Apache error log:

memberentry.pl: DBD::mysql::st execute failed: Cannot add or
update a child row: a foreign key constraint
fails (`gmc_koha/borrowers`, CONSTRAINT `borrowers_ibfk_2`
FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) ...

This patch fixes this bug, allowing a child patron record to be
edited even if it has no guarantor.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 19:49:05 -05:00
John Beppu
5279faf72e bug 356: removed redundant interface
The messaging tab already provided a way to configure these
notifications, so this isn't needed.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 13:48:47 -06:00
John Beppu
12045fd099 Removed RSS Option from UI
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:57:41 -06:00
John Beppu
a8accfb4c5 Messaging Preferences for Intranet
- Added ability to modify per-user messaging preferences.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:55:09 -06:00
Mason James
eaa62ab2cd bug 2870, fixes non-populating of guarantor fields
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-28 17:42:00 -06:00
Galen Charlton
a84935b83e bug 2505: further warnings fixes to memberentry.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:43:15 -06:00
stan
8042c6ec19 Added 'warnings' support, fixed bug 2870.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:20:51 -06:00
Galen Charlton
7b690aee84 bug 2856 followup - display form correctly when modifying patron
Upon further testing, original patch for 2856 had effect
of displaying form with blank values when modifying
an existing patron record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:20:16 -06:00
Nahuel ANGELINETTI
61ebf9160f (bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set
This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:46:11 -06:00
Nahuel Angelinetti
873d1c6336 bug #2757: change the opac login generation
This patch change the method used to generate a new login for a user when his informations are modified(memberentry.pl).

Before the login are generated with the first letter of lastname and the 9 first letter of the surname, and do not verify the
login already exist).
Now the login will be lastname.surnameX, where X is an incremented digit if the login already exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-02 08:35:01 -06:00
Joe Atzberger
f406ce43a9 Pure whitespace edits. Trying to make members more readable.
Use git diff -w to show only one line (a blank one) was edited (removed).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:51:38 -06:00
Joe Atzberger
9f97e871f1 Bug 2818 - Allow patron editing to coexist with minPasswordLength and '****'.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:49:26 -06:00
Nahuel Angelinetti
be5cddb39d Do not allow an user to have an empty date
If the user set an empty date as the expiration date during a patron modification, we recalculate the expiration date with sysprefs and the registration date.
Before, when you set an empty date, 0000-00-00 is put in the database (too bad).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 16:17:11 -06:00
2cf0eeedb6 More corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous patch included typo copied from member-password.pl. Both are corrected now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 09:23:33 -05:00
378e06dacb Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:29 -05:00
Marc Chantreux
e369181bee use alphabetical order to popup the cities
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 07:08:39 -05:00
Jesse Weaver
78d960152f fix for bug 2221: Problems with Guarantor Fields...
This patch corrects this problem, by, when a patron record is linked as a guarantor, showing that and not allowing the name to be edited. It still allows manual entry of a guarantor. It also untabifies a few places in the affected files and fixes some inconsistent names.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:27 -05:00
Jesse Weaver
0532b7deab fix for bug 2348: Cannot change patron category
This makes the code that generates the category code list loop through all six category types.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:13 -05:00
Galen Charlton
c5ac051f70 bug 2264: do not clear patron zipcode and city
When edting only a part of the patron record (e.g.,
the library use section or the alternate address), the
zipcode and city were cleared due to an error in
form processing.  Now the city and zipcode are set
only of those fields are actually in the submitted form.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-19 20:45:54 -05:00
Ryan Higgins
fc98d228c2 Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:33 -05:00
Mason James
b461a041d0 bug-2149, added new block to C4::Letters::SendAlerts() to email 'account creation' notice, and new block in memberentry.pl to call SendAlerts().
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:11:22 -05:00
Henri-Damien LAURENT
9fb4a72122 Bug Fixing 1782 patch
Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:42:25 -05:00
Galen Charlton
944063b247 patron attributes - staff search and display
If ExtendedPatronAttributes is ON, patron attributes
can be displayed and edited by staff members.

The patron attributes are displayed and edited
in a new section (step 4) of the patron details page.  Each
attribute is identified by its type (including type code
and type description) and value (included value description
if the attribute is controlled by an authorised value category).

Note: if, for a repeatable attribute type, the staff member
enters multiple copies of that type with the same value, duplicates
are removed when the patron record is saved.  Also, if the type
is repeatable, a JavaScript link allows the staff member to
create new attributes of that type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:09 -05:00
Henri-Damien LAURENT
d08d9e3fb7 Addressing bug 1782
Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.

Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 05:49:27 -05:00
Galen Charlton
a9f7993b3e fix errors with using today's date and format_date
This patch should reduce the occurrence of the following
message in the error log:

Illegal Date '2008-3-14' does not match 'iso' format: yyyy-mm-dd

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:21 -05:00
Ryan Higgins
bd8f90387b Add Local-use statistical patron category_type
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-10 05:27:37 -05:00
QA Manager
496012c7b5 fix for bug 1836, Adding patrons fails when using cites/zipcode feature]
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-19 20:43:25 -06:00
Ryan Higgins
d40c752671 category entry javascript fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:40:46 -06:00
Chris Cormack
7c9f045815 Fix for 1599 getting expiry date prepopulating on member entry
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 15:36:40 -06:00
37090d171a Changing circ redirect to use borrowernumber instead of cardnumber: If you edited a patron's record to change their cardnumber the redirect would fail because it used the old number.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-09 14:50:01 -06:00
Ryan Higgins
8a4ad06a55 cleanup in memberentry,categories.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:22:33 -06:00
Chris Cormack
a924f7d6a5 Taking out warn
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:21:47 -06:00
Chris Cormack
28fe361296 Fix for bug 1666
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:21:35 -06:00
Chris Cormack
c8e13ff834 Fix for bug 1164, child branch not defaulting to guarantor's on add child
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 22:15:08 -06:00
Chris Cormack
68bf17afc4 Fix for 1654
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 20:48:06 -06:00
Chris Cormack
867131812a Fix for 1699, cant change category type
Now you can change a borrower to any category

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 16:51:05 -06:00
Joe Atzberger
c102b3c6f5 Members overhaul for Dates.pm - Stop double converts and disappearing expiration mods.
Allow errors displayed by memberentrygen.  Please confirm with add'l tests, feedback.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:19:00 -06:00
Joe Atzberger
14eb56e8dd memberentry.pl - fixes inappropriate use of map in void context, tweaks debug for CGI
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-19 18:54:42 -06:00
39d01437cc A couple of changes to address issues raised by Bug 1631: City, State label. Also streamlining changecity js (no need to have inline javascript generated by the Perl script).
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-18 16:39:36 -06:00
Joe Atzberger
b9c74fb24c memberentry.pl - dates validation, error passing to template
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-18 16:37:25 -06:00
Joe Atzberger
116e5aed66 memberentry.pl - $debug-ify warn messages
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-18 16:37:24 -06:00
Ryan Higgins
f4811762d0 cleanup in memberentry,categories.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 08:19:07 -06:00
Joe Atzberger
fa6fffeb6d memberentry.pl and calendar-setup.js - remove CVS '$Id$'
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 11:00:09 -06:00