Commit graph

4097 commits

Author SHA1 Message Date
520c160542 Corrected: fix for Bug 3112, Emailed list contains too much whitespace
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 08:19:42 -05:00
Nahuel ANGELINETTI
5cf66ad6dd (bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:36 -05:00
Galen Charlton
684cea4309 bug 3049: display correct due date of renewed loans
The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.

The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date.  This patch
fixes the bug in two ways:

[1] AddRenewal() now updates items.onloan with the
    correct due date.
[2] Two templates were updated to display the
    due date from (indirectly) issues.date_due
    instead of items.onloan, thus making it less
    likely that the wrong value will be displayed.

This patch does *not* update items.onloan to reflect
the correct due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:32 -05:00
Joe Atzberger
ce760ba9e8 Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:00:13 -05:00
74e2741063 Minor markup corrections for validity.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:50:14 -05:00
Michael Hafen
4fb0141e61 bug: add items to batch - search results have multiple items on one table row
The table row openning and closing tags were outside the template loop.
This moves them inside the loop.  Without this search results with more
than one copy will append those copies to the one row.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:01:28 -05:00
60761e44ae Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"
GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:01:21 -05:00
Joe Atzberger
d5dbaf2a6d orderreceive cleanup
Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:36 -05:00
Joe Atzberger
4a1333c544 Factor common element out of both sides of conditional.
Add placeholder complaint about misuse of TMPL EXPR statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:33 -05:00
Joe Atzberger
dc8745c469 Remove unused TMPL variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:25 -05:00
fe75457c5d Adding new "tag" icon to tag link in lists interface. Also removing an unwanted ID from opac-shelves.tmpl markup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:20 -05:00
e183ac099a More fixes for Bug 3044
Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:17 -05:00
Galen Charlton
2e08f626f5 remove incomplete bib bulk editing code
Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:53:50 -05:00
502a8cb7e2 Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:36:26 -05:00
c705832fa9 New styles for bulk hold and bulk tag inputs on search results page.
This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 12:00:39 -05:00
e3d787fc22 Another try at fixing Bug 2949.
This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 11:48:28 -05:00
Joe Atzberger
14be4400d8 Bug 3066 - Overhaul guided reports
execute_query now refactored, returns reliable results, does
zero presentation-layer crap.  Arguments reduced, client scripts
adapted to new API and performance improved.  Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.

Replaced tools/runreport.pl with misc/cronjobs/runreport.pl:
    ~ security fixed
    ~ documentation improved
    ~ TODO: finish sendmail option.

Bug 3077 also fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 20:17:55 -05:00
02b5091c1a Internationalize Amazon support
With this patch:

  * On Amazon book cover, 'search inside' text is not displayed
    anymore because it's not translatable.
  * Link the image to local Amazon web site 'search inside' service.
    Based on AmazonLocale syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:38:37 -05:00
J. David Bavousett
5e99f59fa6 Added ISBN to RSS results.
Added ISBN tag to RSS results, right after the title.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:04:38 -05:00
Michael Hafen
a0a24ae25f tweek css for staff search results item type images
This add a clear:left; to the #searchresults ul li selector.  Otherwise
it's possible an item type image will be offset by an image above it and
not float all the way to the left.  This makes sure the image is clear
of the above image.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:52:50 -05:00
2b14727449 Corrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes bug 3083.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:31:16 -05:00
Nahuel ANGELINETTI
83dc3588de (bug #3084) in baskets, change the isbn of column
this patch add a new column and put the isbn in it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:31:05 -05:00
462dead372 Adding details to OPAC search results RSS, described in Bug 2973.
This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:22:04 -05:00
Joshua Ferraro
76f03c53b0 Adds a 'New Subscription' option for selection from the detail page of a record.
NOTE TO DOCUMENTATION WRITERS: Due to the limitations in the serials module search
interface, some users may find it easier to use the standard catalog search to locate
an item on which to create a subscription record, and then use this new button to
create a subscription from the detail page.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:48 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Galen Charlton
130ca7fb63 fix syntax error in tags JavaScript
FF will tolerate a trailing comma in an
array literal, but Internet Explorer does not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:08:43 -05:00
Stephen Edwards
6d54aa97f0 bug 3034: Tag multiple items at once.
Added a "Tag" button in the toolbar area of the results
page.  This activates an inline form that allows the user
to enter a tag that can then be applied to all currently
selected items.

In addition, a "Tag" link has been added to both the List and
Cart pages that provides the same functionality in those contexts.
In these two cases, the a per-item states appears below the
bibliographic information for each item.

Status that applies to the overall operation, such as failing to
provide a tag, will be shown in an alert dialog box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 12:30:01 -05:00
28d653dd38 Add a UNIMARC to Dublin Core XSL
This XSL transforms XML UNIMARC biblio record into
its DC representation. It is the equivalent of
MARC21slimOAIDC.xsl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 11:30:13 -05:00
46c0706ee1 Bug #3071 - Z39.50 search result highlights are mixed
This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:53 -05:00
6542fc4216 Add Babeltheque OPAC enhanced content
www.babeltheque.com is a LibraryThings for Libraries equivalent.
This patch enables this service on OPAC.

  * Replace previous patch in order to apply onto last master HEAD
    and solve conflicts induced by last pushed pateches:
    1bb9f76e66
  * Modify kohaversion.pl
  * It uses v3.01.00.016 slot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:42 -05:00
67bba6319d Reformatting receipt template and CSS to be more readable.
A narrow printable area is unsuitable for a three-column table of information. Changing to paragraph sections for each item. Also correcting terminology: issue -> checkout

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:37 -05:00
b70cd9f3eb Adding patron address to select patron form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:27 -05:00
Joe Atzberger
92051e44dd Convert opac-reserve to use GetBranchesLoop.
Removed irrelevant and unused variables dealing with branches.
Also pulled default branch from userenv when not specified as a param.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:54 -05:00
7f3cac43d3 Changing "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be pulled" falsely implies that items are available'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:37:00 -05:00
3d2e952983 Hiding labels for add to list options when user isn't logged in or options don't exist. Fixes Bug 3043.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:36:55 -05:00
Mason James
dacb4e0e60 quietens a noisy debug pop-up, when debugging
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:36:49 -05:00
3c3e20526e Fix for Bug 3062, "place hold on lists different font"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:33:26 -05:00
Galen Charlton
30dae108e6 convert '&' to '&amp;' in Syndetics URLs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:17:46 -05:00
Daniel Sweeney
0e76b374eb Changed syndetics base URI from syndetics.com to www.syndetics.com
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:52 -05:00
Daniel Sweeney
1dd8e5996c Added content_identifier_exists test to opac-detail.tmpl to prevent broken images in Syndetics content for some titles.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
bd5272f074 Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images
Adds new template variable to test for enhanced content identifiers

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
3d65e44d5c Syndetics and Amazon bugfix enhancements
This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
2eb8d90fc4 Second patch to address LL Bug 367 Titles without ISBNs display "no cover image available" while titles with ISBNS that don't match a Syndetics cover display nothing
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
9abcd844f5 Add Syndetics AuthorNotes, Awards, Series
This patch also includes a new function to retrieve the index
page from Syndetics and parse it for available content prior to
retrieving content; this is done to speed up syndetics content
by not retrieving content that doesn't exist for an item. However,
Syndetics continues to be a very slow service compared to Amazon.com
and other enhanced content services

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
91a998a2ec Fix for LL bug 367 Titles without ISBNs display "no cover image available"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
11bd4a7660 Adds Syndetics Reviews
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
9806abf865 Adds support for Syndetics Excerpts and Editions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
de6227bd0a Add Syndetics Summaries and TOC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
2cc793f7aa Adding Syndetics Cover Images to OPAC Detail Page, including shelf browser
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
e99fd37c69 Adds Syndetics Cover Images to Results Page on OPAC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00