Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Jonathan Druart	49778103ce	Bug 9857: Fix failing tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	b1ba7fac2c	Bug 18292: Remove return 1 statements in tests The test files do not need to return 1 Patch generated with: perl -p -i -e "s/^1;\n//xsm" t/*/.t Test plan: git grep '^1;$' t/*/.t should not return any results NOTE: does not fix C4/SIP/t, nor xt tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	1917e0c89f	Bug 18851: Fix few other tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Olli-Antti Kivilahti	1985e6e4b3	Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1 t/00-load.t already checks if all of the perl modules can be compiled. The tests deleted in this commit do a duplicate test with t/00-load.t Hence they have become unnecessary. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Tomás Cohen Arazi	95ce6945d8	Bug 13277: (QA followup) use t::lib::Mocks Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	98fcda28ff	Bug 13277: t/SuggestionEngine_AuthorityFile.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/SuggestionEngine_AuthorityFile.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/SuggestionEngine_AuthorityFile.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Turned off MySQL and ran the tests before and after the patch. Works as advertized. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jared Camins-Esakov	25f6ba2447	Bug 8209 follow-up: another correction for BuildSummary API Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Jared Camins-Esakov	52f54eec1d	Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Sorry about the problematic last attempt at uploading. I missed a patch when squashing. It is now included.	12 years ago
Jared Camins-Esakov	8471158160	Bug 8209: "Did you mean?" from authorities One of the ideas behind authority records is that users who search for one term should have related terms (according to the authority file) suggested to them. At the moment, Koha doesn't do that. Adding an authority searching step to regular searches and displaying any suggestions in a "Did you mean" bar at the top of the results would be very useful. This commit adds a Koha::SuggestionEngine class which is in charge of getting suggestions from individual suggestion engine plugins, which much be in the Koha::SuggestionEngine::Plugin::* namespace, and extend Koha::SuggestionEngine::Base. Suggestions are loaded asynchronously using AJAX, and a link to a page with suggestions is provided for users with Javascript turned off. The AuthorityFile suggestion engine plugin looks up the specified search terms in the authority file and then suggests searches for records using matching authorities. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased 2 August 2012 and incorporated QA feedback Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan: - Verified database update added system preference correctly, pref defaults to OFF - Verified search results and detail pages in OPAC and staff still worked the same as before * for no results * with results - Activated system preference and tested various searches * Searches from simple search * Searches from advanced search * Search links in records - Deactivated Javascript - verified fallback works correctly Notes: - Suggested terms can include autorities with no linked records. - When combining more than one search option using advanced search this results in "no suggestions" more often. Feature works best from simple search. Overall great feature making use of authorities in a user friendly way! Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on latest master 2012-09-10 Signed-off-by: wajasu <matted-34813@mypacks.net>	12 years ago