Commit graph

53 commits

Author SHA1 Message Date
Henri-Damien LAURENT
02c3fe4c45 ordering branches by branchcodes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 06:10:03 -06:00
Henri-Damien LAURENT
fc0ac9ea1b Adding manual datedue for renewals on moremember pages.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:18 -06:00
Chris Cormack
ef6b767117 Changing CanBookBeRenewed to pass back the reason a renewal cannot proceed
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 16:13:20 -06:00
Henri-Damien LAURENT
e7b1232250 Adding feature : multiple returns via moremember page.
Adding Connection for renewScript
Adding javascript functions to moremeber.tmpl
Adding error management for returns.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 14:07:03 -06:00
Galen Charlton
8c60e82605 fixed variable masking warnings found by perl -w
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:23:59 -06:00
Galen Charlton
8e41022b0d item rework: moved various accessor functions
Moved following functions from C4::Biblio to
C4::Items:

    GetItemStatus
    GetItemLocation
    GetLostItems
    GetItemsForInventory
    GetItemsCount
    GetItemInfosOf
    GetItemsByBiblioitemnumber
    GetItemsInfo
    get_itemnumbers_of

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:25:05 -06:00
Galen Charlton
9e7c94bf96 item rework: moved GetItem
Moved from C4::Biblio to C4::Items.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:24:04 -06:00
9aadee2f92 Some refinements to statuses and messages. Beginning to standardize call number displays.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 01:20:33 -06:00
Chris Cormack
db37744333 Bugfix for 1725 request.pl erroring with a biblio that has no items
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 17:43:40 -06:00
Joshua Ferraro
3b7029f4ed modrequest.pl did not previously have auth checking, security bug!
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 13:58:01 -06:00
Joshua Ferraro
200e44c1ce WARNING: BIGFIXING 670
670 is primarily about the status of a biblio or item that's got a
hold on it ... specifically the 'in transit' and 'waiting' status.
It applies to the following pages.

* request.pl - tested
* detail.pl - tested
* circulation.pl - tested
* moremember.pl - tested
* opac-user.pl - doesn't show transit status, but only shows waiting
when item has arrived at the pickup library
* opac-detail.pl - doesn't show hold statuses

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 11:07:38 -06:00
Joshua Ferraro
a8ba013e1e Synching opac with fixes to reserves adding back dev_week opac reserve cancel feature that was removed Could use some style improvements
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 02:01:04 -06:00
Joshua Ferraro
43334b8cec bugfixing request.pl
Major Fix:
Fixing bug where 'expected' label existed for items that
were 'waiting'

Minor Cleanup:
Show correct statuses
Show itemtypes at correct levels depending on
global system preference
Display branch names, not branch codes
Adding in visibility option for 'canreservefromotherbranches' syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 00:43:26 -06:00
Joshua Ferraro
61d8942a20 show itemtypes at level specified in syspref for holds
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 00:43:14 -06:00
Chris Cormack
5e1921e6af Missed one priority == 0
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:27:15 -06:00
Chris Cormack
883edf9391 Priority = 0 does not equal reserve found, only found='W' equals reserve found
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:27:14 -06:00
Joshua Ferraro
1ff189e59b cleanup of admin/ after Dates integration 2007-12-04 19:10:59 -06:00
Joe Atzberger
21a875ce36 reserve and virtualshelves (leftovers) - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:14 -06:00
Chris Cormack
e30fb761ec Adding a system pref so you can stop users from reserving items that dont belong at their branch
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 21:24:23 -06:00
Chris Cormack
653885bdf0 Fix for rank being set to zero if a specific item is selected
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:51 -06:00
Chris Cormack
9123b86bb8 Fix for bug 1402, now if a renewal fails, the librarian is aware of it
Another patch to come

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:05:13 -06:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
0c454c95b7 Tweaking holds screen, trying to get additional patron information to show up in holds sidebar; Tweaks to serials interface, including overhaul of subscription-add screen
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:56:51 -05:00
Paul POULAIN
57f8e48039 #1455 (placing reserve from OPAC)
SANOP hadn't ported reserve to OPAC yet. that's why opac reserves were no more working.

I've fixed that, but it need more testing...

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-03 14:58:55 -05:00
Paul POULAIN
f4339f536f #1445 checking that there is an expiry date
if there is none, automatically warn the librarian

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-03 14:58:03 -05:00
78df55c5a5 More work to toolbars and menus. Adding experimental YUI-based toolbar to detail.tmpl. Adding dashboard-style layout to tools-home.tmpl. Correcting markup in request.tmpl. Adding patron information variables to request.pl for display in holds-menu.inc.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-02 15:40:03 -05:00
401dce8971 Various random noodlings: - Visual changes to circ, detail, request, and member pages. Fixed checkouts/reserves tabs on circulation.tmpl. Moved new form-layout CSS into staff-global.css and generalized it for wider use. Refined patron details sidebar for use on circulation.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-27 16:32:52 -05:00
Chris Cormack
1a4fc157bf Applying the fix for bug 1416 from paul
Had to edit the patch as it was corrupt
2007-09-20 17:39:43 -05:00
Paul POULAIN
3206db0692 no need to define a const var just to pass it to a sub
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-20 15:31:23 -05:00
btoumi
9395334e69 add control of 'return date' if it 's a special or repeatable holidays , and return a right return date
(renewal)
2007-07-25 14:09:39 +00:00
tipaul
23427c51b9 some fixes (and only fixes) 2007-06-15 13:44:44 +00:00
tipaul
577a7bf094 some (minor, functionnaly speaking) bugfixes 2007-06-05 08:54:17 +00:00
tipaul
1e2d7c8b5a cleaning duplicate entries in top menus & fixing a bug in "branch" index (zebra) & updated french translation 2007-05-30 09:33:18 +00:00
tipaul
fb143b71ba BIG COMMIT : cleaning of Reserves.pm. See detail on koha-devel 2007-04-24 16:10:36 +00:00
hdl
b642e687d2 Still Code Cleaning.
Abiding by Name Convention.
Using Members wherever it should be used.
Borrower is only used for borrower Categories.
+ GetBorrowersWhoHaveNeverBorrowed
and lists like that.
2007-04-24 15:41:27 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
9f42b8ad49 renaming currenttransfers to transferstoreceive 2007-04-23 15:21:17 +00:00
tipaul
3ddec89262 moving Reserves2.pm to Reserves.pm 2007-04-23 14:08:47 +00:00
hdl
0b66bd800d Code Cleaning Members.
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
2007-04-23 13:10:07 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation.
some stuff to do, i'll write a mail on koha-devel NOW !
2007-04-04 16:46:22 +00:00
tipaul
f8e9fb6445 rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00
tipaul
fc1342f73d rel_3_0 moved to HEAD 2007-03-09 15:12:54 +00:00
tgarip1957
5b41a8e262 New XML API 2006-09-11 17:41:54 +00:00
toins
62689dba49 subs renamed 2006-07-21 09:41:55 +00:00
alaurin
193e22714f Add a new system preference 'AutomaticItemReturn' :
if this prefence is switched on: the document returned in another library than homebranch, the system automaticly transfer the document to his homebranch (with notification for librarian in returns.tmpl) .

switch off : the document stay in the holdingbranch ...

correcting bugs :
- comment C4::acquisition (not using in request.pl).
- correcting date in request.pl
-add the new call of function getbranches in request.pl
2006-06-08 15:36:31 +00:00
alaurin
c5f7394fcb change the name of function : "get_return_date_of" to "get_current_date_of" 2006-06-07 13:47:55 +00:00
alaurin
0f00577a9e bug fix : for item reservation, now the system don't keep the reserve if the document is returned, works fine !!!! 2006-06-06 12:26:57 +00:00
alaurin
c0a44fe115 improvement of reserves.pl with item - reservation 2006-05-19 17:05:11 +00:00
plg
68924c5e6b New feature from SAN Ouest Provence: ability to reserve a specific item in
the intranet. The development was made on branch 2.2 by Arnaud Laurin from
Ouest Provence and integrated on HEAD by Pierrick Le Gall from INEO media
system.

New page reserve/request.pl taking a biblionumber as entry point.

New functions:

- C4::Biblio::get_iteminfos_of retrieves item informations for a list of
  itemnumbers

- C4::Biblio::get_biblioiteminfos_of retrieves biblioitem informations for a
  list of biblioitemnumbers

- C4::Biblio::get_itemnumbers_of retrieve the list of itemnumbers related to
  each biblionumber given in argument.

- C4::Circulation::Circ2::get_return_date_of retrieves return date for a
  list of itemnumbers.

- C4::Koha::get_itemtypeinfos_of retrieves the informations related to a
  list of itemtypes.

- C4::Koha::get_branchinfos_of retrieves the informations related to a list
  of branchcodes.

- C4::Koha::get_notforloan_label_of retrives the list of status/label for
  the authorised_values related to notforloan.

- C4::Koha::get_infos_of is the generic function used by all get_*infos_of.

- C4::Reserves2::GetNumberReservesFromBorrower

- C4::Reserves2::GetFirstReserveDateFromItem

Modified functions:

- C4::Reserves2::FindReserves was simplified to be more readable.

The reservation page is reserve/request.pl and is linked from nowhere as
long as zebra is not stable yet on HEAD.
2006-05-17 16:06:23 +00:00