Adds branchnames along with branchcodes for display
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Change of permissions names
Change of branch title in guided reports
Add a "Select All / Clean All" on items selection
Add a link to item when a given item cannot be deleted
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Also fix the barcode not found problem (due to empty lines)
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch add information to hold transfer slip:
* itemcallnumber
* location
* waiting date
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch adds div tags to every section of the page, to allow jquery to find them.
Divs added: basiclimits, language, pubrange, subtype, availability, itemtypelist, currently-avail, select-libs, and sortby
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
when closing a basket without creating a basketgroup, the group is still created => corrected
+ replace "create a basketgroup?" by "create a purchase order now?" in confirmation step.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Basket.pl: withdrawal of the "can not close the basket"button. only Uncerain
prices button is displayed. And removing the "??" in the price columns,
replaced by "uncertain" in rrp column
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Changing the display of the basket column: changing "basketNumber" to "my
basket (basketNumber)".
Adding the Basket group column with fallowing display: "my group (group
Number)"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Since this fix enables the previously-missing variable
'AmazonEnabled' in Auth.pm, this will also enable other
Amazon content in the staff client like Product
Descriptions and Amazon Similar Items (See Bug 3863)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds inline pop-up menu for each row of Z39.50 search results, similar to the
one recently added to the additem screen. This allows the user to click
anywhere in the row to display the menu and access the preview/import links.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
budget were not saved and not correctly displayed
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Description by Colin Campbell:
A number of commits, subsequent to enabling warnings in C4::Serials and
eradicating errors and removing dead code.
These are extracted from an install branch running at UN FAO in Rome.
Commits have been rebased on current 3.2 HEAD.
These are not major new functionality, but a series of fixes to
eradicate some randomness caused by undefined values. Includes a commit
to fix Licenses in the serials directory.
* 'serials_mods' of git://github.com/colinsc/koha:
Check value is defined before splitting it
Fix FSF Address in directory serials/
Bug 4380 Use syspref to resolve which bib display is used
Remove bottleneck making claims page unuseable
Clean up Pod Documentation
add warnings to Serials.pm
Add Text to claim date column's header
Basic refactoring of serials-edit.pm
Remove unused or unnecessary variables in claims processing
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fix includes a change to the format of the page to consolidate
matching rule settings with matching rule controls. This
reduces potential confusion from the placement of the message
box. Assuming that matching rule settings and controls were
displayed separately for clarity and control, I've added
JavaScript which allows the user to change their mind after
changing a selection (but before submitting). It's a new
interaction which I hope is useful.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
While the idea of showing the number of late serials against the
vendor name was nice it does not scale and on large sites selecting claims
was just timing out. Improved the speed of the initial query but have removed
the big query for each user just to get a count.
Check for 0000-00-00 dates so that C4::Dates does not log error
Removed a variable that was never set and the bit of template used
if the impossible happened
Also cleaned the interface to the claims related functions
in C4::Serials so they do not return an extra count variable
moved generation of dropdown to template instead of inline code
Remove unnecessary db calls and processing from acqui-home.pl
Do not duplicate processing of fields
Declare variables closer to use
Remove unnecessary holding vars
Replace some anonymous var names by something more meaningful
Do not generate a toggle variable use Template's LOOP vars
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
For an explanation, see:
http://wiki.koha.org/doku.php?id=en:development:codingguidelines#translatable_text
This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.
Problem with new strings and new html tags inside the strings
this patch removes them
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Following idea in patch submitted by Kyle Hall on 1 April 2010,
use issues.branchcode instead of issues.issuingbranch to set
displayed issuing library. Also tweaked wording.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch fix some perl ugly code to be more readable and lesser complex.
And it allow in intranet to order by issues.timestamp.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Use GetRecordValue() to show subtitle
- Show author
- Separate branch and call number display for better sorting
- Correct teriminology (reserve -> hold)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Reformating display for readability
- Converting select/clear all buttons to links to match existing patterns
- Fixing "Results x of x" display which was broken for single-page sets
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
* 'Bug3482' of git://github.com/ptfs/Koha-PTFS:
Bug 3482: Updated DB version
Bug 3482 changed name of notices file
Bug 3482 Allow hold notices to be sent in print form
Add expiration date, today to hold notices
Modified to use dirspec only
Bug 3482 Print Notices via HTML
Fixes following error when displaying records with 880 fields:
runtime error: file .../MARC21slim2intranetDetail.xsl line 63 element call-template The called template 'm880Select' was not found.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This is done by saving the notices in the message_queue table with
type 'print'. The notices are generated from a notice named
HOLD_PRINT. At the end of the day, they are dumped to an HTML file and
marked as sent by a new cronjob.
This setup is intended to be temporary; modules/batch/ shouldn't be around
forever.
Mandatory SQL:
INSERT INTO message_transport_types (message_transport_type) values ('print');
This fixes the opac results - non xsl transformed - and the intranet result lists.
Also fixes opac-detail which was showing all items 'on hold' if there was a bib level request, whether items were on the hold shelf or not.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This preference didn't make sense in Interface - it's a holds
policy related preference and so I've moved it to that area.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adding two new granular permissions under 'reserveforothers,' place_holds
and modify_holds_priority. If a user does not have modify_holds_priority
permission, the option to change the priority of a hold is hidden.
Revised patch includes changes to mandatory data files including
properly translated fr-FR version.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This is a much improved re-implementation of the reserves updates from dev_week.
Less new code has been added, and more existing functions are used instead of adding new ones.
The 'Lock Hold' function has been removed due to it not working as intended.
[RM note for documentation: this adds the following features:
* ability to specify an expiration date for a hold request
when placing it via the staff interface or OPAC
* daily batch job to cancel expired holds
* nice interface to change the priority of hold
requests for a bib in the staff interface]
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
[cherry-pick from 3.0.x]
This patch :
* fix indentation
* Separate waiting holds from holds over with tabs
* Select only holds for librarian library
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Recent change to C4/VirtualShelves/Page.pm caused display of subtitles
to break in the staff client display of lists
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Add preference OAI-PMH:ConfFile. I just add it in web-services.pref
and not in DB. It's enough. It's not an end-user preference. Without
this pref, OAI server operates as previously. And preferences editor
allow to add a new value to the DB if necessary.
- Fix response to ListMetadataFormats which was empty in extended mode.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Tweaked wording of the soundon syspref, added it to the non-English
SQL scripts, and created a DBrev. Thanks to Nahuel and Eric
for the French translation.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This doesn't actually do much, since the <audio> tag is still
not defined in XHTML1, but it makes it consistent with the rest of the
markup.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Works for HTML5 because it loads smoothly and no plugins required but *at
this time* this update will only work with staff clients which are Firefox
version >=3.5 (std for Koha) but other browsers will soon be adding support.
Additional sounds are included for people to modify and play with, but this
is such a simple upgrade I doubt at this time Koha needs another complex
selector so users can add their own sounds. It could be a nice enhancement
later, of course.
Suggest we stick with HTML5 <audio tag because it is a standard and no
plug-ins.
This simple update has been running live for SMFPL.org for almost 2 weeks
-Darrell Ulm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- moving some links to the left part of koha (currencies and suggestions)
- removed currency table
- changing supplier display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Also fixed a variety of XHTML validation errors.
Programming note: it is invalid XHTML and can break Javascript
to use element IDs and class names that start with digits.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This fix the form to have always the submit button, and fix security issue in aqplan.pl(authnotrequired set to 1)
Conflicts solved:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds an ID field to the save reports table in guided reports to make running runreport.pl easier for users.
Also adds zebra striping to the data table.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
If one attempts to add a new library with a code already in use,
an error message is shown. The main library data input by the user
is preserved, allowing the user to try a new code.
This also corrects a glitch in the previous patch concerning
adding a branch category whose code is already in use.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The MARC21 framework uses $0 for the item withdrawn status. Because
of how the tool had marked the barcode and stocknumber as being
uneditable, this resulted in an off-by-one error, causing the wrong
item fields to be updated.
Fixed by simply not including the uneditable fields in list
of item fields that can be edited - if you can't change the barcode,
there's no point in displaying it in the list of fields.
Also fixed how the bib title/author/ISBN got displayed so that the
withdrawn column gets displayed after an item update.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Since TMPL_IFs evaluate false if the template variable is 0,
smart-rules.tmpl was not displaying zero values in fields where
the db field value was indeed zero which leads to some small confusion.
This patch removes the TMPL_IFs since those fields will always be
populated with some value even if it is zero.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
When no lateorders were found, there was no way to change the limit in order to check for older orders
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixed bug in date validation that prevented adding new contracts
if the dateformat syspref was set to something other than 'metric'.
In process, also removed three hand-written date validation routines
in favor of using JavaScript Date objects and the Date_from_syspref
function provided in calendar.inc.
This fixes bug 3912, and partially addresses bug 4144.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Note that this patch causes the authority subfield visibility
to match 3.0.x, but at a cost - only two options are available now,
hide all and show all, and much flexibility is lost. This will
need to be improved.
(cherry picked from commit 56831089ed)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds a link to the Authority tag to expand the fields if advancedMARCeditor is in "Don't display" mode.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- "Do not delete" form was missing hidden framework code input.
- Also added details to breadcrumb navigation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Some koha acq terminology is confusing to new users so lets at least
be consistent in our usages we are adding to the basket here not an order
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Add two syspref:
- OPACXSLTResultsDisplay
- OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Changes the output of compact.xsl to XHTML for catalogue/showmarc.pl?viewas=card.
Adds <title> element in <head>.
Removes link to nonexistent css file (bug 2651).
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Renewal failure message should appear in renewal checkbox column just
like it does in moremember.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
