Commit graph

3072 commits

Author SHA1 Message Date
30efc33dba Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:47 -05:00
77b3a204f5 Tweak to results display to correct punctuation and add ISBN.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:16 -05:00
Darrell Ulm
f0da737c25 Removing Billing.pl link, will not even slightly work with InnoDB tables as there is no fast count, will work on later
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:55:40 -05:00
Chris Nighswonger
1baf6348cc kohabug 2404 This patch removes Image::Magick and adds GD
This patch removes Image::Magick as a dependency and replaces it with
the (much) lighter GD. Functionality of patronimage code has not changed with
this conversion.

Adding errorhandling for corrupted image file and link to return to moremember.pl when called from there

Added notes about supported image mime types.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:38:18 -05:00
85832f8524 A couple more corrections that should have been in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:40 -05:00
d73b577fa6 Fix for Bug 2408 ("Note: separated from content in cgi-bin/koha/serials/subscription-add.pl") and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:38 -05:00
Nicole Engard
480f329c96 Update to help file
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:54:35 -05:00
root
a75ffcede8 Small patch again to fix repeated col in reserveratios.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:50:40 -05:00
Chris Nighswonger
f6a3f83ca2 kohabug 2224 Third installment: Further corrections for NULL fields
This patch adds code to clean out any NULL fields in rows returned
since NULL fields do not truly meet the filter criteria

It also corrects a bad db field reference.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:10:21 -05:00
Ryan Higgins
fa28afba18 BUG 2351 : Add duplicate barcode check prior to receiving multiple items. This patch adds a javascript form check for duplicates in-form, and returns an error if there are duplicates in the catalog.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:05:18 -05:00
82d0920ec0 Spelling corrections (Fixes Bug 2381).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 05:57:25 -05:00
Chris Nighswonger
af288205f5 kohabug 2154 Modifying form input controls to accomodate translations
Due to the logic of the underlying picture-upload.pl depending upon the "value" of the
form input controls and this value being translated, the script then failed to function.
This patch changes the input controls so that this should not be an issue.

This issue should be kept in mind, though, so that it can be avoided in the future.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-25 08:56:10 -05:00
Chris Nighswonger
d8ea5fc339 kohabug 2224 Second installment: Correcting NULL field display
Query references to the unused aqorderdelivery table caused a NULL field to be
displayed in the report results. This patch removes those references.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:11 -05:00
58d3a0fe84 Styling tabs on virtual shelves page. Did I forget this, or did it get removed at some point?
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:04 -05:00
Chris Nighswonger
880c1335f6 kohabug 2224 Corrects display descrepancies when applying filters
This patch corrects display descrepancies when filters are applied to the
acquisitions report. It also corrects a number of other issues with this
report.

Some documentation changes may be in order based on report filters that
were only partially implimented, but are now available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:37 -05:00
Ryan Higgins
eeef609466 Remove 'Cash Refund' from manual invoice, as it calls a deprecated function. Change the code for 'forgiven' from 'F' to 'FOR', since 'F' is used for 'Fine' elsewhere in the code. Mark other subroutines as deprecated that utilize the accountoffsets table, since that functionality was lost somewhere in the 2.2 series, and half-using it breaks things.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:07 -05:00
Ryan Higgins
1dcf4c5e9e Combine 'publication details' and volume columns in display to work with mixed serial data (i.e. some issues linked to serials module, some not). Cleans up display after patch to update sorting with enumchron based on biblio.serial.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:04 -05:00
Chris Nighswonger
9971756a24 kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves
Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:48:13 -05:00
Chris Nighswonger
39d2d593c6 Allow anyone with superlibrarian permission to edit/delete public patron lists
Edit functions here are limited to renaming and changing the type. No one can view
a list except the list owner unless it is public.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:47:58 -05:00
Joe Atzberger
64ba3ffe83 Refine "Patrons statistics" report, fix highlight, remove CGI::scrolling_lists.
At client request, I added code for a rowtitle_display and coltitle_display.  This
allows the script to substitute human-readable lables into the table instead of just
the literal hashkeys.  For this client with dozens of numerical patron categorycodes
having a row titled "29" was not very useful.

I cleaned up the templates and a lot of the report code.  It is of the same style as
the other copy/paste reports and still need further cleanup.  Added sql and debug
feedback (default styled to hidden), as I have for other reports.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:44:58 -05:00
fd2ee6411e Fix for Bug 2373 ("Tags missing from the left menu"). Also doing some cleanup and reformatting on review.tmpl. Fixing some capitalization--I hope that's not a translation problem.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:53 -05:00
16c8171564 Adding new patron form for non-javascript users (Fixes Bug 2344, No "New Member" button w/o js).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:51 -05:00
Chris Nighswonger
1bbfc4fd1c Correcting markup in intranet-main.tmpl to display "Lists" properly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:23 -05:00
Joshua Ferraro
a711cbc224 Updates to the subtype limits for Audience to match the MARC21
standard:

a - Preschool
b - Primary
c - Pre-adolescent
d - Adolescent
e - Adult
f - Specialized
g - General
j - Juvenile

For documentation team: please update the screenshot for
this drop-down as the options have changed.

No re-indexing should be necessary.
2008-07-22 13:44:45 -05:00
Joshua Ferraro
4c4f815a34 Adds a stylesheet for Zebra to do an on-the-fly conversion of the
Koha 952 item fields to the MARC21 standard 852 location fields:

Please add the following to the documentation in a section explaining
the setup of a SRU/Z39.50 server. You can also pull info from:

http://wiki.koha.org/doku.php?id=en:development:z3950sru

Modifying Output of Your Records On-the-fly

Koha supports modifying the output of your MARC records for public-facing
Z39.50 and SRU servers. You can set up custom mappings to convert fields such
as 952 (Koha items) to 852 (MARC21 location fields). For example here would
be a popular mapping:
Name:		Koha Field		Mapping in MARC21
---------------------------
Location: 	952 $b => 		852 $b
Barcode: 	952 $p => 		852 $p
Price: 		952 $v => 		852 $r
Item type: 	952 $y => 		852 $w
Notes:		952 $z => 		852 $z

This would make the output from the SRU server suitable for a
resource sharing network that used the above convention for location
information. To add this configuration to your Zebra, add the following
block of code in the koha-conf.xml in the <retrievalinfo> area:

<retrieval syntax="xml" name="marc21location">
         <backend syntax="usmarc" name="F">
           <marc inputformat="marc" outputformat="marcxml"
                 inputcharset="utf-8"/>
           <xslt stylesheet="/path/to/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim9522852.xsl"/>
         </backend>
 </retrieval>

The retrieval set name (in this case, marc21location) is arbitrary and
should be set as required by your resource sharing network, so long as it won't
conflict with internal usage within Koha itself. It's the retrieval set name
that is used to trigger the server to respond and parse the record through the
stylesheet and apply the mappings.

In SRU, this is set as follows:

http://example.com:210/biblios?version=1.1&operation=searchRetrieve&query=it&startRecord=1&maximumRecords=20&recordSchema=marc21location

In Z39.50 it's the elementset name construct.
2008-07-21 18:09:27 -05:00
Joshua Ferraro
72143ef63e Final fix for 2335: Printers has never worked, so it's removed for 3.0
Someone who has the time to generalize it can add it back
2008-07-20 10:51:03 -05:00
Joshua Ferraro
bc408475f8 This patch resolves a few MARC21 Framework issues for
a default installation:

1. Re-names several of the item fields to make more sense to catalogers and patrons
2. Remove links Non-public note from items.paidfor
3. Changes Non-public note to be hidden in the OPAC view

Fixes issues with the 'hidden' field in the framework, specifically:

1. the editor obeys the rules of possible values for hidden (>4, or <-4)
2. the OPAC MARC display obeys the rules of positive values meaning 'hidden in OPAC'
3. the staff MARC display now obeys the rules specified in the hidden values description
2008-07-18 17:39:08 -05:00
Joshua Ferraro
d753635a95 Fix for 2372: Breadcrumbs on Tags Wrong 2008-07-18 13:47:04 -05:00
Joe Atzberger
322fd538d0 Refine lateorders - error feedback, filter independence
Added error catching for bad user input on number of days.  I.E., if you
try to filter by "bAd", you now get an error message prompting for valid
digits.  Also I updated highlighting to use loop_context_vars.

Fixed filtering to work on either days, vendor or both.  Previously, if
you selected a number of days, you had to select a vendor or else got
empty results.  DOCUMENTATION NOTE: this supplies the expected behavior,
so specifying vendor is no longer required.

Changed filters form to GET method.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:23:51 -05:00
Ryan Higgins
5353d35b7a Correct misspelling of 'recieve'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:26 -05:00
Ryan Higgins
b16463a81e Change language on serials toolbar from 'edit record' to 'edit subscription'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:23 -05:00
Jesse Weaver
b9f814e57f fix for bug 2371: Change fine block message behavior...
This adds a variable to the checkout form, debt_confirmed, that is 1 when the de
bt block message has been canceled for this session.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:15:13 -05:00
Jesse Weaver
fba4191412 fix for bug 1892: When checking in item on hold...
Makes the print slip and confirm button show up on an in-library hold as well as a transfer. It also adds an ignore button that hides the hold dialog.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:15:10 -05:00
Jesse Weaver
98406923bb fix for bug 2282: Biblio framework subfields...
This fixes the tabs plugin's view of the % subfield by adding another template var called urisubfieldcode that is "pct" when the subfieldcode is "%".

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:25 -05:00
Jesse Weaver
0bb715b7ed fix for disappearing dropbox mode checkbox on returns screen
This makes the 'dropbox mode' checkbox appear unconditionally.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:24 -05:00
Jesse Weaver
8510d2664d fix for bug 2359: Returning an item from moremember.pl...
Adds a 'forgive fines' checkbox to moremember.pl that defaults to off, and removes the hardcoded $exemptfine = 1 argument to AddReturn in reserves/renewscript.pl. Also, cleans up a little inline CSS.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:20 -05:00
NCE
940bf128d0 Massive updates to help file. Translators will have a chance to translate this stuff in coming versions.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:49:37 -05:00
NCE
d983e09226 Additional help files updated
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:49:29 -05:00
NCE
7a83b1f4c1 iMore updates to translations
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:49:20 -05:00
Jesse Weaver
78d960152f fix for bug 2221: Problems with Guarantor Fields...
This patch corrects this problem, by, when a patron record is linked as a guarantor, showing that and not allowing the name to be edited. It still allows manual entry of a guarantor. It also untabifies a few places in the affected files and fixes some inconsistent names.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:27 -05:00
Paul POULAIN
12f590fba2 BUGFIX : wrong link
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:26 -05:00
Joe Atzberger
c86f708197 Bug 2453 - Obsoleted report removed (use issues_stats instead)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:18 -05:00
Jesse Weaver
3b6e8cbc53 fix for 2177: Barcode on checkout slip
This patch adds barcodes to the Checkouts and Overdues section of the receipt. It also removes the Overdues section if it is empty.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 20:10:03 -05:00
350b9dd3af Allowing people to search on all itemtypes when adding a serial subscription, workaround for the fact you cant limit by itemtype
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 20:02:13 -05:00
Joshua Ferraro
6f0526abaf Fix for bug: 2323: Conference name search fails in staff interface.
wrdl missing from definition on adv search page in staff client
2008-07-14 13:05:04 -05:00
Joshua Ferraro
9f3e6b4a40 Fix for 1863: Result list for 'scan' index searches incorrect after first page 2008-07-14 11:33:13 -05:00
NCE
645ca22647 Updates to online help
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 07:52:35 -05:00
Joshua Ferraro
8943dc7fea Final fix for 2008: Daily reconciliation report broken
Stuff that hasn't ever worked in Koha gets commented out in 3.0 ;-)
2008-07-12 10:04:27 -05:00
Joshua Ferraro
085f329d7a Fix for bug 2342: Searching on more than 1 itemtype breaks
The problem was that the 'mc-' was removed from the checkboxes a while back and
that's what triggers the automatic application of OR boolean searching. I've
added it back to the templates and modified the ccl.properties file to include
mapping for itype,itemtype and ccode
2008-07-12 09:09:14 -05:00
Joe Atzberger
e5df39dee8 Report cleanup - fix highlight, add debugging feedback
The debugging feedback (default style: hidden) is necessary to
investigate client reports where even after "backfill_statistics"
this report still fails to return results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-12 08:59:38 -05:00