Commit graph

38 commits

Author SHA1 Message Date
Galen Charlton
684cea4309 bug 3049: display correct due date of renewed loans
The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.

The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date.  This patch
fixes the bug in two ways:

[1] AddRenewal() now updates items.onloan with the
    correct due date.
[2] Two templates were updated to display the
    due date from (indirectly) issues.date_due
    instead of items.onloan, thus making it less
    likely that the wrong value will be displayed.

This patch does *not* update items.onloan to reflect
the correct due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:32 -05:00
Joe Atzberger
126920f470 moredetail.pl is not an Exporter.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:21:55 -05:00
Michael Hafen
0543a9633c If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:38:16 -05:00
Galen Charlton
0fb1c26d1c Revert "If itemnumber is sent to catalogue/moredetail.pl use it"
Applied wrong version of patch.  Oops.

This reverts commit 9eb1465b28.
2008-09-02 15:36:02 -05:00
Michael Hafen
9eb1465b28 If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl put it to use.
This happens in members/boraccount.pl if a fine is attached to a barcode.

This patch makes moredetail.pl show only the item specified by itemnumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-28 09:45:42 -05:00
Chris Nighswonger
6e714ce442 kohabug 2427 Correcting C4::Items:: _koha_new_item to populate items.copynumber
The INSERT was missing the copynumber parameter. moredetail.pl was also not setting
the copyvol template variable. This patch corrects these issues so that the copynumber
is both inserted when a new item is created (including during a bulkmarcimport.pl run)
and displayed properly on moredetail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:26 -05:00
Joe Atzberger
757f42d94b Replace EXPR.
Prevents log error:
	EXPR:at pos 14: non-initialized variable notforloantext

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 15:31:14 -05:00
Paul POULAIN
bc11a3bce2 BUGFIX (bloquing) moredetail & item edition
this patch introduce the same behaviour as for additem.pl, ie : edit only own homebranch items, except for superlibrarians

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:24:48 -05:00
934332b8b1 Fix for Bug 2016, navigation bar in moredetail.pl not the same as in detail.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:40:04 -05:00
Galen Charlton
8e41022b0d item rework: moved various accessor functions
Moved following functions from C4::Biblio to
C4::Items:

    GetItemStatus
    GetItemLocation
    GetLostItems
    GetItemsForInventory
    GetItemsCount
    GetItemInfosOf
    GetItemsByBiblioitemnumber
    GetItemsInfo
    get_itemnumbers_of

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:25:05 -06:00
Galen Charlton
d01707e5c2 removed erroneous comment
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:24:08 -06:00
Joshua Ferraro
2143002750 IMPORTANT: BUGFIXING STATUSES
Major bugfixes:
* Circulation status in moredetail.pl now correctly displays On loan
status and Date due
* Bugfixes on Status column in detail.pl
   * Removed hard-coded English strings from status column in detail.pl
      * Added missing auth values for lost and damaged statuses, sane
defaults if those auth
     values don't exist
        * Added missing 'On hold' status and 'Hold waiting' status
display

Medium bugfixes:
* Now correctly shows itemtype at level specified in systempreference
* Uses itemtypeimage for display, image title is full itemtype
description

* Fixed Location column concatenation between branchname location and
itemcallnumber
  * broke out Location (branch), Collection (items.location)
      Call Number (itemcallnumber) into their own columns
        * Added auth value display for items.location

	Minor fixes:
	* detail.pl didn't show dates correctly
	* nomenclature s/Checked out/On loan/ in opac-detail.tmpl
	* s/Book/Item/ in my $desc="Item Returned
".$iteminfo->{'barcode'}; in Circulation.pm
* request.tmpl: s/date_due/onloan/ to display date due
* Fixed SimilarItems, XISBNSimilarItems

NOTE: Needs to be ported to OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 13:34:44 -06:00
Joshua Ferraro
e4799032d2 Warning: big commit Fixing moredetail.pl
Previously, about 50% of the data on this page was either incorrect or missing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:32:34 -06:00
Paul POULAIN
15acb6eb89 fixing moredetails to point to biblionumber instead of biblioitemnumber
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:10:23 -06:00
Ryan Higgins
0734f8fca0 Clean up moredetail.pl and updateitem.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-12 08:03:10 -06:00
Joshua Ferraro
78dfccbf0c cleanup for catalogue/ dir Dates integration 2007-12-04 19:07:09 -06:00
Joe Atzberger
fe00a94164 cataloge subdir (and cataloguing) - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:11 -06:00
c16539a291 Bugfixing interface issues. Also enabling contextual menu highlighting for catalogue detail pages.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-21 18:07:01 -06:00
Galen Charlton
9dd5c0ab7d bugfix: bib delete button now working in catalogue bib display
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 19:45:41 -05:00
Joshua Ferraro
a6f1915422 fixes to moredetail.pl to allow status editing using updateitem.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:13:43 -05:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
Henri-Damien LAURENT
6dad593dee Adding Biblionumber to template param list
This enables navigating on MARC/ISBD/Normal View

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:07:39 -05:00
Joshua Ferraro
326af18039 more work on 1481: adding back drop-downs for
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:35:01 -05:00
Joshua Ferraro
e494fadf0a partial 1481: adding to templates, fixing non-display of data
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:34:56 -05:00
Chris Cormack
b989b83264 Fix for bug 1437, items not showing on moredetail.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 17:58:02 -05:00
tipaul
23427c51b9 some fixes (and only fixes) 2007-06-15 13:44:44 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation.
some stuff to do, i'll write a mail on koha-devel NOW !
2007-04-04 16:46:22 +00:00
tipaul
2ffd5b7228 rel_3_0 moved to HEAD 2007-03-09 14:28:54 +00:00
tgarip1957
4843e0ee78 Resynching Savannah 2006-11-15 01:41:51 +00:00
tgarip1957
5b41a8e262 New XML API 2006-09-11 17:41:54 +00:00
tgarip1957
7e52a5665c Clean up before final commits 2006-09-06 16:21:03 +00:00
tgarip1957
3129c52ff7 A basic search script catalogue-search.pl demonstrates the use of koha_attr table to create PQF free searches 2006-09-01 22:25:05 +00:00
toins
c08ab01523 Add a call to GetOrderNumber. 2006-08-01 08:50:11 +00:00
toins
a0a50aff8a modify input parameters for GetOrder. 2006-07-28 13:20:27 +00:00
toins
3c6410111b subs renamed according to coding guidelines. 2006-07-21 10:10:29 +00:00
tipaul
6285c93429 moving moredetail to catalogue directory 2006-01-17 16:49:23 +00:00
Renamed from moredetail.pl (Browse further)