Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	9c2a74a638	Bug 23384: Fix use statement order for ArticleRequest::Status Koha::ArticleRequest is used by Koha::ArticleRequests so Koha::ArticleRequest::Status should not be needed in Koha::ArticleRequest. Also Koha::ArticleRequest::Status must be loaded before Koha::ArticleRequest Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Marcel de Rooy	b4d56d3fd8	Bug 22273: Modify Koha::ArticleRequest->store to fill created_on For a new record, store should fill created_on. The database will always update the timestamp updated_on. Since open also calls SUPER::store, we do not need to call it twice. Test plan: [1] Run t/db_dependent/ArticleRequests.t [2] In the interface, add two article requests. Change the status of one to PROCESSING. Check created_on and updated_on in the article_requests table. The changed request should have updated_on > created_on. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> [1] Tests pass ok 12 - New article request has created_on date set ok 13 - New article request has updated_on date set [2] Work as described. No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Marcel de Rooy	8dc15ceffd	Bug 22273: Replace typo opan by opac in POD Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Jonathan Druart	7d8b96803f	Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Kyle Hall	85b0424eb7	Bug 18477: Populate article_requests table values for AR_PENDING notices The default AR_PENDING letter does not print populate <<article_requests.*>> fields. Test Plan: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Place request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. 7) Apply this patch 8) Repeat steps 2-6, not the fields now display! Signed-off-by: Eric Phetteplace <phette23@gmail.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	f7b11f38e8	Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	95e6f6a612	Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Jonathan Druart	0faf643661	Bug 17634: Fix circ dependency with require instead of use This is definitely wrong but we won't have time to fix it correctly before the release. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	64900dc7c6	Revert "Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing" This reverts commit `75f7510158`. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Kyle Hall	75f7510158	Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing Test Plan: 1) prove t/db_dependent/ArticleRequests.t 2) Apply this patch 3) prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Kyle Hall	bf1563e60b	Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago

11 Commits (34b9c061f347da750f4565a57012c9caab93f925)