Commit graph

459 commits

Author SHA1 Message Date
Nahuel Angelinetti
d7fc49f0a7 make some line REAL comments, else the installer is buggous
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:17:01 -06:00
Galen Charlton
f91e8fb509 followup 2 to to renewal limit override
Remove duplicate entry for SMSSendDriver syspref
added by original patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:34:59 -05:00
Michael Hafen
03d8521cbf Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:34:50 -05:00
Galen Charlton
6f383040d5 bug 2582 [2/2]: fix NULL issues.issuedate
Corrects loans whose issuedate was set to NULL
during a renewal as follows:

* First, tries to extract the loan date from
  the statistics table.
* For any remaining rows,  sets the issue date
  to the date of the last renewal.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:11:29 -05:00
Galen Charlton
6337b20087 bug 2568: set default value of intranetuserjs to blank
The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.

Documentation changes: none per se.  However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:06:48 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
Galen Charlton
4c037341e4 bug 2522 [1/3]: DB rev 3.1/001 - hold request targetting
For bug 2522, add a new table called hold_fill_targets to
implement hold request targeting.  This table
has the following columns:

  borrowernumber     - identify request
  biblionumber       - ditto
  itemnumber         - item targeted to fill request
  source_branchcode  - current location of item
  item_level_request - if 1, request is item-level

For bug 2331, adds a column called item_level_request
to tmp_holdsqueue.

Note: both of the item_level_request columns can
go away once reserves is modified so that
it is clear whether a request is item-level or
bib-level.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:16:08 -05:00
Galen Charlton
1387904cdb bug 2504: switch version number in HEAD to 3.1
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-11 20:54:55 -05:00
Ryan Higgins
49ffa55a2e Update longoverdue.pl cron job to manage setting lost values.
This patch deprecates the NoReturnSetLost system preference, which, as it
turns out, was not implemented anyway.  New longoverdue script allows one to
specify on the commandline system-wide delays for changing items to different
lost statuses, and optionally charge for the item.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-10 15:54:29 -05:00
Joshua Ferraro
9698452a8c Remove biblio.* from sample notice templates and
replace with <<items.content>>
2008-08-10 14:49:56 -05:00
Joshua Ferraro
afe8231229 Updates to the subtag registry for new translations
Updates to the RElease Manager's notes
Fix Danish langauge from dk to da
2008-08-10 09:45:05 -05:00
Joshua Ferraro
0e050c3eca 2425: Spelling Error - Permissions 2008-08-09 07:45:35 -05:00
Joe Atzberger
f7b304ac65 Remove <br /> from syspref descriptions.
The template HTML-escapes the descriptions now (as it should).
So we can't make them prettier w/ HTML inserted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:21:58 -05:00
Andrew Moore
63b6523ccc Bug 2084 [2/2]: Database version 3.00.00.107: adding warnings to three system preferences
This patch adds warnings to the OPACShelfBrowser, CataloguingLog, and NoZebra system preferences. Using
them on busy koha installations has proven to be rather resource intensive.

This is considered a stopgap solution. Making these features less resource using to run
would be preferred.

Note to documentation writers: screenshots of these system preferences could be updated, but
no functionality has changed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:58:56 -05:00
Joshua Ferraro
0a70c31f60 Putting the db revision from 105 into 106 as it wasn't
applied in 105
2008-08-04 08:32:55 -05:00
Paul POULAIN
b29b77f706 bump to 106, bug 2452, subscriptionhistory.enddate can be 0000-00-00
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:12:56 -05:00
Paul POULAIN
434f06149f BUGFIX fix on 2380 fix, dump to 102
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-01 14:59:06 -05:00
Andrew Moore
b9c43464e8 bug 2335: adding SMSSendDriver system preference - DB update to version 3.00.00.105
Previously, the SMSSendDriver system preference was set as a local use system
preference. This patch makes it an official system preference under the "Patron" tab.
This system preference determines which SMS::Send driver is used to send SMS messages.

I have attempted to take care to not overwrite this system preference if it has already
been set.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:15:49 -05:00
Galen Charlton
9adfdcbb77 bug 2413: remove noOPACHolds syspref (DB rev 104)
Preference was removed in patch for bug 2234; completing
removal in existing 3.0 installations via DB rev 104.

No documentation changes (deprecation of noOPACHolds
done in an earlier patch)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:45:17 -05:00
Chris Nighswonger
4f3df5d1d2 kohabug 2219 Corrects inconsistent use of subscription.serialsadditems column
From the bug report:

The serialsadditems syspref was ostensibly removed in DB rev 071
(http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=5c41ae54e68866f9661e853376537059f4d83f70)
in favor of a new serialsadditems column in the subscription table.

However, this removal was incomplete.  It is still created for new installations by:

installer/data/mysql/en/mandatory/sysprefs.sql
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql

and is used in

serials/serials-recieve.pl
serials/serials-edit.pl
admin/systempreferences.pl

Since the system preference was not removed from the sample data scripts, it
is necessary to add another DB rev to remove it - a user may have made a
fresh install of Koha after DB rev 071.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:07:45 -05:00
Chris Nighswonger
cdf93bffee kohabug 2380 Correcting serialitems table structure and fixing duplicate barcode check
The current serialitems table structure does not provide for a *:1 relationship with
the serial table. This causes a problem when attempting to add multiple items to a given
serial. The db throws an error when attempting to INSERT in  serialitems due to serialid.serialitems
being a unique key. A further side effect is that the marc record is updated with the
item inspite of the error. The mods to the serialitems table structure in this patch
drop serialid.serialitems as a key and make itemnumber.serialitems the primary key
creating a *:1 relationship with the serial table. This patch also makes serialid.serialitems
a foreign key referencing serialid.serial to maintain referential integrity.

Fix for duplicate barcode check

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:07:40 -05:00
Ryan Higgins
0ed39b89cd DB UPDATE : Patron category code was defined incorrectly in overduerules (notice/status triggers) and deletedborrowers.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 21:07:49 -05:00
Chris Nighswonger
bc31005f0d Adding lastmodified.virtualshelves; Bumping version to 100
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:50:05 -05:00
Joshua Ferraro
bc408475f8 This patch resolves a few MARC21 Framework issues for
a default installation:

1. Re-names several of the item fields to make more sense to catalogers and patrons
2. Remove links Non-public note from items.paidfor
3. Changes Non-public note to be hidden in the OPAC view

Fixes issues with the 'hidden' field in the framework, specifically:

1. the editor obeys the rules of possible values for hidden (>4, or <-4)
2. the OPAC MARC display obeys the rules of positive values meaning 'hidden in OPAC'
3. the staff MARC display now obeys the rules specified in the hidden values description
2008-07-18 17:39:08 -05:00
Joshua Ferraro
3b6507dd39 Updating the name of the script for build_browser_and_cloud.pl 2008-07-17 08:29:33 -05:00
Joshua Ferraro
dd47f7bf7c Fix for bug 2191: Subfield $n (Suppress in OPAC) has no effect on OPAC
Adding missing OpacSuppression syspref
2008-07-14 14:51:07 -05:00
Andrew Moore
5834de1419 bug 2347 [2/2]: database chagnes (adds to version 098)
I'm removing RSS from the message_transports table now. I forgot that before.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 14:10:36 -05:00
Andrew Moore
f646ee277c bug 2347 [1/2]: removing RSS from optional and mandatory sql scripts
The RSS message_transport_type was recently removed (until we get it implemented). It
is now being removed from the other tables that reference it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 14:10:34 -05:00
Joshua Ferraro
765cbf93ba Fix to 2277: patron cardnumber is not a required field
Note to sysadmins: you'll need to add 'cardnumber' to the
syspref manually.
2008-07-14 12:57:20 -05:00
Joshua Ferraro
6ff2026281 Fix for bug 2116: Disable_Dictionary Syspref depreciated
It has been replaced by the syspref OpacAuthorities
2008-07-14 11:05:43 -05:00
Joshua Ferraro
d16a7fda37 Partial fix for 2084: opac-topissues.pl is both EXPERIMENTAL and
very proc hungry and we needed to warn systems admins and turn it
OFF by default.
2008-07-12 09:52:17 -05:00
Joshua Ferraro
6c8b87ded1 Fix for bug2234: noOPACHolds syspref unused, superceded by RequestOnOpac
Note to systems maintainers: please delete from your systems manually.
2008-07-12 09:12:41 -05:00
Andrew Moore
d7dd3f416e bug 2329: removing unused RSS transport type - DB version 098.
I didn't implement a way for patrons to get their advance notices and other
messages through RSS, so I'm removing it from the list of available transport types.
This will cause the "RSS" column in the patron messasging pages to be
unavailable. When we implement RSS, we can add it back in and the checkboxes will return.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 11:36:39 -05:00
Andrew Moore
d7872f94ef bug 2329 [1/1]: remove RSS from list of transport options for patron messaging
I didn't implement a way for patrons to get their advance notices and other messages
through RSS, so I'm removing it from the list of available transport types.
This will cause the "RSS" column in the patron messasging pages to be unavailable.
When we implement RSS, we can add it back in and the checkboxes will return.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 09:11:48 -05:00
Andrew Moore
74118daa82 bug 2274 [1/5] database changes (DB rev 097) to add email address to message_queue table
I added three fields to the message_queue table:
 - to_address
 - from_address
 - content_type: necessary to hold email header for attachments
I changed one field in message_queue:
 - borrowernumber can now be NULL for messages sent to the admin

These can be used to override the default addresses used. By default, emails are sent to
the borrowers.email address and sent from the KohaAdminEmailAddress syspref address. These
values are still used if the to_address or from_address values are NULL. These changes
are necessary to let overdue_notices.pl be backwards compatible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 09:10:42 -05:00
Joshua Ferraro
886749cf31 Improving the list of itemtypes to match the bridge iconset 2008-07-07 23:32:51 -05:00
Joshua Ferraro
08c3c60f57 Bug 1881: Managing Suggestions - default SUGGEST authorised values 2008-07-07 23:31:51 -05:00
Paul POULAIN
6ed47e433f OPACUserCSS has wrong default value (fix for 2211, for french)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-02 12:25:27 -05:00
Joe Atzberger
1de9cb26a2 Script to correct faulty statistics table entries.
This is the first iteration of this script, likely to be expanded
if other mappings are determined.  Currently it populates the
itemtype for all statistics that have itemnumbers and then pulls
borrownumbers from old_issues (or issues).  This has the benign
side effect of ignoring whether or not itemtype was a different
value at the time of the transaction.

It then tries to populate null borrowernumbers using a fairly
conservative approach, only where exactly one match exists, else warns.

The process of updating statistics is needlessly complex based on the
lack of a reliable primary key.  ALL such tables should have a numerical
primary key.  The impression that the timestamp and any other fields
are enough to combine for a "unique enough" key is wrong.  For example,
running SIP tests will add multiple transactions that might share
borrowernumber, itemnumber and timestamp.  Key uniqueness should be
logically inherent, not de facto.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-26 05:51:26 -05:00
Galen Charlton
d8e0f61f0e bug 2176: fix typo in column name (DB rev 096)
In borrower_message_preferences, wants_digets => wants_digest

Note that the typo is present only in databases that had
borrower_message_preferences created via updatedatabase.pl.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-25 15:33:46 -05:00
Galen Charlton
10127d15a6 bug 2254 [2/3]: fix authority types in MARC21 frameworks (DB rev 095)
Corrected two errors found in the authority types used
in the MARC21 frameworks:

* one subfield that used "Meeting Name" instead of "MEETI_NAME"
* various subfields that used "CORP0_NAME" instead of "CORPO_NAME"

The biggest visible consequence of this change is that corporate
name headings (110, 610, 710, 810, etc.) will now link correctly
to their authority records.

In addition, brought the fr-FR MARC21 framework scripts up-to-date
with respect to the changes made to the English versions.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-25 11:39:28 -05:00
Ryan Higgins
67e20d82ff DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-23 08:00:03 -05:00
Joshua Ferraro
66b2a15f13 fix for 1913: Remove opaclargeimage system preference 2008-06-20 18:38:10 -05:00
Ryan Higgins
c522e99e20 DATABASE UPDATE: change copynumber column to allow free text - [ bug 2223 ] - WARNING, will take some time for large db.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 17:55:54 -05:00
Andrew Moore
6bd827e546 bug: 2176 improvements to database upgrade path
This patch calls the new optional database SQL scripts to that sensible data is isntalled.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 17:47:36 -05:00
Joshua Ferraro
86f50f5fef fix for 2117: opacbookbag should have the term 'cart' in the description 2008-06-20 17:45:07 -05:00
Joshua Ferraro
85c0d73e89 fix for 2118: virtualshelves should say 'list' in the description 2008-06-20 17:44:02 -05:00
Joshua Ferraro
7600792b7e fix to 2142: maxItemsInSearchResults No longer used 2008-06-20 17:42:42 -05:00
Joshua Ferraro
254c505322 fix to bug 1914: OpacNav system preference description contains typo 2008-06-20 17:29:18 -05:00
Joshua Ferraro
a9cca373f0 fix for 1948: LibraryName has wrong description 2008-06-20 17:28:10 -05:00