Commit graph

102 commits

Author SHA1 Message Date
Henri-Damien LAURENT
f55d783c25 bug fix 2590 :
seems that when itemtypeimagelocation returns undef, the hash is messed up.
put it at the end of the hash and everything is fine.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-08 18:50:29 -05:00
Jesse Weaver
7da895cda7 fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:29 -05:00
Joshua Ferraro
ad368764e9 2487: Collection code select boxes in Adv search show both code and description 2008-08-09 12:06:04 -05:00
Chris Nighswonger
9971756a24 kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves
Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:48:13 -05:00
Joshua Ferraro
1e45b14714 Prior to this patch, XSL and scan indexes conflicted.
This patch resolves the issue by passing $scan to the
searchResults function to toggle XSL for scan results
2008-07-08 15:59:09 -05:00
Chris Nighswonger
3cb7a9ac28 kohabug 2238 This patch allows patrons to add books to public open/free lists whether they are logged in or not.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 12:48:11 -05:00
Joshua Ferraro
fee2ddc086 Fix for bug 2212: Searching with Itemtype limit doesn't work
The issue was that the index for itemtype is different depending
on whether you're using item-level or bib-level itemtypes. This
patch detects the system choice and sets the index properly
2008-06-18 13:57:22 -05:00
Joshua Ferraro
6c9b83fbdc Resolves bug 2250: RFC: New System Preference to Determine which 'Types' and associated icons to display in advanced Search
For documentation, please indicate that as part of profiling,
staff can refer to the AdvancedSearchTypes system preference to
choose where to draw the advanced search 'Types' from. Currently
this is implemented as a choice, between itemtypes and ccodes,
but it's been designed to work with any authorised value so long
as an index exists for searching by that authorised value.

By default, and if this syspref doesn't exist, it will pull from
itemtypes as before.
2008-06-18 13:01:20 -05:00
Joe Atzberger
37c25f55b2 Restrict OPAC tags display to approved=>1.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:47 -05:00
Galen Charlton
fe202cdc94 kohabug 2078 - settle on application/xml Content-type for feeds
Required by IE6 to at least get a feed to display as XML
in the browser instead of being downloaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:55 -05:00
Galen Charlton
8fc6b927df kohabug 2078 - send correct Content-type for search feeds
OPAC search RSS and ATOM feeds now have the correct
Content-type sent - "application/rss+xml" and "application/atom+xml",
respectively.

As part of this patch, added an optional fourth parameter
to C4::Output::output_html_with_http_headers to specify
the content type.  If that parameter is now supplied, or if
the value of the parameter does not contain at least a "/",
the default type of "text/html" is returned.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:54 -05:00
Galen Charlton
d177975239 kohabug 2078 - fix feed validation errors
Fix several validation errors in RSS and Atom feeds
generated from the OPAC:

- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements

Issues identified but not solved in this patch:

- setting Atom updated element for each bib (presumably
  from biblio.timestamp)
- possible problems performing paging of Atom feed

Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:10 -05:00
Paul POULAIN
67ffed7fec Respect BiblioDefaultView when search returns only 1 result & jump directly to the detail
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:57:34 -05:00
Joshua Ferraro
f093a84974 Fixing bug 1629: RSS Feeds of Search Results in OPAC 2008-05-01 18:55:13 -05:00
Joe Atzberger
fa7ffc8b33 opac-search - CORRECTION: remove diagnostic Dumper lines
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:51 -05:00
Joe Atzberger
31da55ea2d Baker and Taylor OPAC integration, plus some logic for Tags
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:36 -05:00
Joe Atzberger
015e5da39f Tagging - add basic template slot in search for tags and script responsiveness to tagging sysprefs
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:27 -05:00
Joshua Ferraro
850b9ac67c fix for 1610: Redirect to result when opac search returns only one item
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 20:41:01 -05:00
Joshua Ferraro
fabe13324e fixing itemtype icon display for item-level_itype = OFF
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 06:22:32 -05:00
Galen Charlton
94f32e2873 FRBR: fixed paging through grouped results
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 16:35:17 -06:00
Galen Charlton
84233f4b6d FRBR: added OPAC search result grouping option
Because this feature is experimental, the syspref will
not be added to the list just yet.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 16:35:17 -06:00
Galen Charlton
35249f48e4 more experimental work on grouping with pazpar2
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 16:35:14 -06:00
Joshua Ferraro
69ea5a25ad synching opac search with staff search
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 06:20:33 -06:00
Joshua Ferraro
8c9ded3e54 fixing a bug where the query cgi was loaded twice for re-sort forms
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 06:20:22 -06:00
38490915a0 Previous change hid global search on results page too, fixing.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:03 -06:00
a67714128a Button styling in masthead.inc is still conflicting with the js load() functions and the menu popup, so buttons are unstyled at the moment. Still need to integrate cart (basket/bookbag) functions.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:13 -06:00
c9baf7441f Styling facets; correcting markup error in search results; removing language picker from opac-main (is now in the footer); continuing unfinished work on cart/lists buttons
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:10 -06:00
Joshua Ferraro
8892919aaa cleanup of opac-search.pl, synch with search.pl, etc.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-24 08:05:48 -06:00
Joshua Ferraro
2baca29e58 WARNING: BIG I18N PATCH, you must import the subtag_registry.sql after this upgrade to benefit from the new features ... if you don't everything will work as before.
bugfixing I18N language selection from staff and OPAC, adding BiDi
support

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:51 -06:00
Paul POULAIN
40107f895f Adding OPACItemsResultsDisplay syspref (missing file from previous commit)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 00:51:43 -06:00
Paul POULAIN
01b332d466 removing some code that is for staff, not for opac
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 14:33:03 -06:00
Joshua Ferraro
3edaba0cc0 fixes to search results list, ccl.properties tweak
patch updateitem.pl (was failing ... missing 'my')
update OPAC results
fix limit by availability

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 17:35:46 -06:00
Joshua Ferraro
4075926730 adding query_desc and limit_desc to staff catalog search
when no hits found

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 12:52:31 -06:00
Joshua Ferraro
fcc3986cfd Updates to date indexing and search processing
Summary of Koha 3.0 date indexing for MARC21:

Index                   Expected format         Notes
-----------------------------------------------------
date-entered-on-file    [yymmdd]                (008/0-5, indexed in word and sort indexes)
copydate                [yyyy]                  (260$c, indexed in word and sort indexes)
acqdate                 [yyyy-mm-dd]            (952$d, indexed in date,word,sort indexes)
pubdate                 [yyyy]                  (008/7-10, indexed in year,word,sort indexes)

Template Search Parameters Tested:
        limit-yr (either yyyy or yyyy-yyyy) (added processing for ge le, structure attribute st-numeric, etc.)
        yr pubdate (yyyy)
        acqdate,st-date-normalized (yyyy-mm-dd)

Template Sort Parameters Tested:
        pubdate_dsc
        pubdate_asc
        acqdate_dsc
        acqdate_asc

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 12:00:30 -06:00
Chris Nighswonger
6bf61aa64f Fix for BUG 1653
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-13 17:27:13 -06:00
Joe Atzberger
093e3f5215 opac subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:03 -06:00
Paul POULAIN
c28aaec2d5 it appears that hidelostitems can be true here and not set to 1 in syspref
in syspref it appears as "OFF", but in opac-search it's considered as true.
Changing the test to be sure syspref & opac-search consider the same thing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:56:31 -06:00
Joshua Ferraro
824d50c50d forward-porting default sort by options
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 18:47:12 -06:00
Joshua Ferraro
eab6705ce6 adding numSearchResults and OPACnumSearchResults
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 18:04:56 -06:00
Joshua Ferraro
7471f4c017 add OPAC hidelostitems and suppression from dev_week
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:27:44 -06:00
Joshua Ferraro
160440cc3a fixing masthead query detection, fixing author and subject links
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:27:26 -06:00
Joshua Ferraro
7b4c5fd8e0 searchdesc improvements, more opac fixes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:26:35 -06:00
Joshua Ferraro
bb86c39e35 adding limit_cgi_not_availablity which is identical to
limit_cgi but without the available limit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:26:25 -06:00
Joshua Ferraro
cf46662107 starting work on porting search to OPAC
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:25:48 -06:00
Paul POULAIN
ef2855e2cd porting sort_by stuff from staff to opac
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-17 11:16:15 -06:00
e496677ac9 Beginning redesign of the OPAC. At this stage it's a move to make it more like the dev_week design, but this is only a starting point. This commit makes most OPAC page layouts very broken.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 21:35:45 -06:00
Paul POULAIN
321f3694c4 bugfix to limit search to branch in OPAC
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-12 17:10:18 -06:00
Paul POULAIN
4c7ca14fb8 fixing buildQuery call to new API
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 19:42:26 -05:00
Paul POULAIN
9a954f7263 revert kw,wrdl search (part 2)
kados should commit something better, this is a quick hack.
if I send it mistakenly chris/kados, pls don't validate

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:44:22 -05:00
Paul POULAIN
b1f2856974 Show images only if there is one
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:43:21 -05:00