Commit graph

22 commits

Author SHA1 Message Date
Paul POULAIN
ded734b1e8 bugfixing pending reserves
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:30 -05:00
157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:32 -05:00
Galen Charlton
20241fd686 more XHTML corrections for new circ reports
Note: I question the use of GROUP_CONCAT(... SEPARATOR '<br/>'),
because that puts knowledge of the output mechanism (currently HTML)
into the SQL query.  However, I am not fixing this right now.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:21 -05:00
Galen Charlton
f3258cc311 SQL cleanup in new circ scripts: use placeholders
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:20 -05:00
Galen Charlton
ef8a880b25 use C4::Debug instead of checking DEBUG env var directly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:19 -05:00
Galen Charlton
a2c59f25e2 various date-related cleanups in circ
* use Date::Calc to perform date arithmetic
* use Date::Calc::Today to consistently format the current date
* format date per syspref in overdue report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:14 -05:00
Darrell Ulm
8cafcef8bf All patches to Koha 3 beta to date. All work with branches.
Billing.pl     -- new, gives bills that occur in a range, works
 pendingreserves.pl  -- fixed, works now, with branches also
 reserveratios.pl  -- indicates distressed reserves
 itemslost.pl  -- Fix to this to make it more useful and fix bugs
 Itmes.pm -- small change to work for itemslost, should not affect
             anything else
 and all tmpl files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:07 -05:00
Ryan Higgins
86ee8ee384 Add print slip to hold confirmation dialog.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:20:25 -05:00
Galen Charlton
ec0c0ba3e0 bug 1742: don't include items on loan in pending holds report
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:16 -05:00
Galen Charlton
9222f7a6ca created old_issues and old_reserves tables
The new tables have the same structure and constraints
as the tables they archive with the following exceptions:

* borrowernumber and biblionumber in old_reserves can be
  NULL
* the FK constraints (e.g., for itemnumber) on old_reserves
  set the child column to NULL if the parent row is deleted
  instead of deleting the child row.
* there is no FK constraint on old_issues.branchcode, allowing
  a branch to be deleted without changing archived requests.

Some miscellaneous cleanup was done as part of this patch:

* GetMemberIssuesAndFines (C4::Members) now uses bind variables
* fixed POD for GetMemberIssuesAndFines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:31 -05:00
Galen Charlton
86e4cdf54b use 'F' or 'W', not 'f' or 'w' when using reserves.found
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:24 -05:00
Chris Cormack
b9b77bcb60 Still a work in progress, pendingreserves.pl is quite broken
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:49:24 -06:00
Joe Atzberger
ee1a241479 pendingreserves.pl - debugify warn
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:19:09 -06:00
Ryan Higgins
88e913046a fixing pending reserves to use dates specified
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-16 07:12:08 -06:00
Joshua Ferraro
687c83370e fixes to date handling 2007-11-13 20:41:46 -06:00
Chris Cormack
d8d27ab898 Missing AND in the SQL in pendingreserves.pl only if independentbranches was turned on
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 18:05:07 -06:00
Chris Cormack
c3c520b385 Working on a fix for bug 1456
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 21:55:57 -05:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
paul
a5bd240321 FIX for Date calculation
Rule :
- always format_date() before sending date to template
- always format_date_in_iso immediatly after reading a date coming from a parameter
- deal internally only with dates in iso

Note that :
- I could not test things related to issues stats due to the my DB -issues.issuedate not filled, see commit about 3.00.00.006
- acquisitions_stats does not work when you filter on date

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 11:51:12 -05:00
Chris Cormack
1a4fc157bf Applying the fix for bug 1416 from paul
Had to edit the patch as it was corrupt
2007-09-20 17:39:43 -05:00
tipaul
5ff7fcffa4 Bugfixes & improvements (various and minor) :
- updating templates to have tmpl_process3.pl running without any errors
- adding a drupal-like css for prog templates (with 3 small images)
- fixing some bugs in circulation & other scripts
- updating french translation
- fixing some typos in templates
2007-05-22 09:13:54 +00:00
tipaul
0c020dd8bf renaming reserves & branchreserves to pendingreserves and waitingreserves 2007-04-23 16:42:59 +00:00