Commit graph

172 commits

Author SHA1 Message Date
Chris Nighswonger
a339f5f94a [19/40] Various tweaks to the interface cosmetics, form validation scripts, css, etc. 2009-09-01 15:51:03 -04:00
Henri-Damien LAURENT
97a68f046e Translating unimarc_leader plugin in english
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:07 -04:00
Nahuel ANGELINETTI
45761d67cb (bug #3505) fix 210c and 225a unimarc's plugins
This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-05 20:10:42 -04:00
e5d9b34dce More XHTML corrections (Bug 3211)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:18:22 -04:00
f63456b025 XHTML corrections (Bug 3211)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:18:19 -04:00
Matthias Meusburger
2e1a9d657a Bug 2593 : way to duplicate items
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:35:52 -04:00
Nahuel ANGELINETTI
3e7e8bf35e (bug #3398) fix unimarc 210c plugin
this add some args to SearchAuthority();
Fix the pagination, and fix javascript script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-15 09:09:27 -04:00
Joe Atzberger
46b9ee7a93 Branch auto-selection in additem
Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:39:00 -04:00
John Beppu
2fa6b26825 Minor Fixes for jQuery 1.3.2 Upgrade
I looked through all the relevant Javascript on this site
to find spots that would break in the upgrade from jQuery 1.2
to jQuery 1.3, and I fixed them.

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:20 -04:00
5a93f0b806 More changes to implement jQuery upgrade.
- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:18 -04:00
0d0666ebab Tweaking CSS on z39.50 popup to improve readability (Bug 3269)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:23 -05:00
Garry Collum
653d9b7284 Bug 2889: Removed toggle variable from z3950_search.pl.
Removed unused toggle variable from z3959_search.pl.  Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:06:53 -05:00
Galen Charlton
9a02e5aa42 fixed table row highlighting CSS class
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:10:32 -05:00
Colin Campbell
d633bd1ba1 Enable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings Remove toggle variable
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:02:59 -05:00
Galen Charlton
8b3655025d bug 2737: fixed typo in MARC21 008 plugin
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:16:59 -05:00
Galen Charlton
84c4c269b6 bug 3170 followup
* tags >= 010, not just > 010, can have subfields
* fixed so that mandatory fields are checked
  regardless of whether a new one is created
  or an existing one modified

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 08:09:11 -05:00
Nahuel ANGELINETTI
c885a150c5 (bug #3170) do not check fields < 010
This patch add a if, to disallow the check of fields < 010, because they could have no subfields, and are mandatory.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 15:08:30 -05:00
Nahuel ANGELINETTI
927d3e6982 (bug #3170) check if mandatory fields are not empty
This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 15:06:25 -05:00
Galen Charlton
39a9910f2f fix markup error in unimarc_field_128a.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:52:17 -05:00
Garry Collum
6f66396ff9 Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed.  The user clicks on the marc tag's title to expand the marc fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 07:03:41 -05:00
Galen Charlton
17ab0a7532 bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:20 -05:00
Nicole Engard
6bb030a0f7 BUG 2736 - added link for MARC country codes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-20 08:38:09 -05:00
Nicole Engard
eb2513887d BUG #2736 Fix. Updated link to go to list of language codes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-18 16:47:05 -05:00
Nicole Engard
794b39a84e Bug 2736 fix. Updated link to go to LOC instead of itsmarc.com
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-18 16:22:38 -05:00
Galen Charlton
d32c39a157 fix XHTML errors in z3950_search.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 10:17:02 -05:00
Darrell Ulm
b7aff5cde0 BUG #1277 Enhance: Z39.50 More search criteria
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 09:48:21 -05:00
Galen Charlton
2f5a28ee6a bug 3212: MARC21 bib leader plugin sets Leader/09 to 'a'
Changed the plugin so that the form for editing the MARC21
leader now sets postion 9 (character coding) to 'a' (UCS/Unicode)
and no longer gives the cataloger the option to change it.  Koha
uses UTF-8 exclusively for MARC records, and a number of bugs
can be triggered by storing MARC21 bib and authority record
whose Leader/09 is anything other than 'a'.  Since internal
routines are increasingly ensuring that the MARC21 Leader/09 is
set to 'a', it doesn't make sense to give catalogers the idea
that it's possible (or a good idea) to set the Leader/09 to any
other value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:41 -05:00
Galen Charlton
7b3a06692c bug 3211: fix XHTML validation errors in MAR21 bib leader plugin
Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.

This patch also fixes the descriptions of the Leader/09
and Leader/17.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:40 -05:00
Galen Charlton
2de58fc287 bug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown
Also made the following updates to the MARC21 leader plugin

[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:28 -05:00
Galen Charlton
70b7017eca fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:32:02 -05:00
Joe Atzberger
aebdecfb35 Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:44 -05:00
Galen Charlton
feead03b08 fix XHTML error - duplicate tabindex
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:36:30 -05:00
Andrew Moore
b15be22620 refactor: removing a few unnecessary loops and moving HTML out of script into template
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:48:38 -05:00
Joe Atzberger
1afa403417 IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:28:28 -05:00
Jane Wagner
d4241eeeda Bug 3013 Fix for 007 value builder to include all material types
Delivered version only had Text material type; this patch includes
all 14 material types with appropriate values for each.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 15:25:58 -05:00
Nahuel ANGELINETTI
5cf66ad6dd (bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:36 -05:00
Joe Atzberger
ce760ba9e8 Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:00:13 -05:00
46c0706ee1 Bug #3071 - Z39.50 search result highlights are mixed
This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:53 -05:00
0a2be5e29b Changes to tabindex values to improve keyboard access.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:21 -05:00
Nahuel ANGELINETTI
04f8382d5b (bug #2978) fix differents bugs in marc editor
This patch fix two bugs:

 * tag duplication
If you try to duplicate an autority tag, the javascript call is kept, and the id is not modified, and fields are not emptied.

 * openAuth() call
The id called on duplicated fields is not the great id.
And the different values sent to auth_finder.pl to pre-fetch datas from firstname, etc... send values from all same tags, and not from the selected tag.
(cherry picked from commit 40115eb110)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:39:51 -06:00
Nahuel ANGELINETTI
72563b0449 (bug #2933) change popup names containing space chars
This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:37:30 -06:00
Henri-Damien LAURENT
1c14654c8e Using openAuth function for authorities Searching
Adding two js functions :
getSubfieldcode(tagsubfieldid)  returns the subfieldcode from tagsubfieldid
(tag_XXX_subfield_Y_WWWW_TTTT returns Y)
getTagInputnameFilter(tagsubfieldid)
(tag_XXX_subfield_Y_WWWW_TTTT returns tag_XXX_subfield_._WWWW)

I think those two functions are much useful when cataloguing.

openAuth now takes all the information for Heading search of authorities.

TODO A javascript DOM Navigation would be better.
This js works, but is surely slower than DOM would be.
Still, it seems that our DOM tree is quite hard to decode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:34:27 -06:00
Nahuel ANGELINETTI
bda53debab (bug #2996) update unimarc 105 plugin to the actual norm
This patch add some codes which have been added to the norm:
* Religious Text
* dissertation or thesis
* booklet
(cherry picked from commit 673bd0d832)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 09:23:08 -06:00
Nahuel ANGELINETTI
49a39b311a (bug #2996) fix and improve 100 and 105 unimarc plugins
This plugins need some stuffs for the users to help them to choose, like show the codes, add some codes, etc...
(cherry picked from commit 75e6ac4a03)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 09:22:51 -06:00
Henri-Damien LAURENT
c1682628e9 Translating UNIMARC plugins in English
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
(cherry picked from commit 839c87a48c)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 08:53:01 -06:00
Joe Atzberger
3d2ec1607d Trivial comment typos corrected.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:57:24 -06:00
Nahuel ANGELINETTI
6b4fed3b47 (bug #2956) fix another results calculation
this patch fix more about 4XX plugin, for results display and calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:47:41 -06:00
Nahuel Angelinetti
7588809b0d bug 2829: add a plugin for 010$a field and 210$c
This plugin use the 'ISBN' field(010$a) to search the "publishercode"(editor) and set it in as 210$c.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:52:46 -06:00
Nahuel Angelinetti
3ad66441c8 (bug #2853) fix an error in returned string
this patch delete the last char of the returned string, that is not conform to unimarc, only one blankchar must be at the end of
the leader string.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:39:50 -06:00
Nahuel Angelinetti
e0bbb9d7e7 Delete all calls to thesaurus_popup.pl, and no more used plugins.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:31:46 -06:00