Commit graph

312 commits

Author SHA1 Message Date
Chris Cormack
f0bf2fea25 Fix for bug 1400, some variables not being passed to the branch transfers
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-09 14:49:59 -06:00
Chris Cormack
b9b77bcb60 Still a work in progress, pendingreserves.pl is quite broken
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:49:24 -06:00
Joe Atzberger
ef902ea85f circ/stats.pl - debugify warnings
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:19:22 -06:00
Joe Atzberger
ee1a241479 pendingreserves.pl - debugify warn
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:19:09 -06:00
Galen Charlton
9d4d8897b2 item rework: various changes
* Move CheckItemPreSave to C4::Items (from C4::Biblio)
* Modified C4::Biblio::AddBiblioAndItems to use appropriate
   internal routines from C4::Items
* Moved GetItemnumberFromBarcode to C4::Items
* Removed duplicate C4::Biblio::_koha_new_items
* Removed disused C4::Biblio::MARCitemchange

Currently AddBiblioAndItems is a special routine that
uses private subs from both C4::Biblio and C4::Items.
This needs to be refactored.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:25:42 -06:00
Galen Charlton
c6c8e80a73 start of BIB change -- introduce C4::Items
Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:12 -06:00
Chris Cormack
052861306b Fix to redirect the user ot the select branch page if they try to use
circulation without a branch set

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 20:03:08 -06:00
Chris Cormack
48b4d54408 Fix for bug 1515
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 20:51:22 -06:00
Chris Cormack
ddd0140ef1 Fix for bug 1626, whitespace stripped from barcodes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:24:30 -06:00
Chris Cormack
bcc60a1117 Fix for bug 1552, fix ordering of issued items
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:24:27 -06:00
Chris Cormack
39fad89745 Fix for bug 1253 borrowers names sorted case sensitivly in circulation.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 12:07:59 -06:00
Chris Cormack
358ec9c6c3 Fix for 1582, if independent branches is on, you cant return to
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:24:37 -06:00
Ryan Higgins
a9d03af6dc adding 'exempt fine on return' option.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:22:45 -06:00
Chris Cormack
7d6282e513 Fix for 1704, now if autoitemreturns is off you get a dialogue warning a
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:22:00 -06:00
Chris Cormack
55a525cb3a Fix for bug 1703
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 17:53:43 -06:00
Galen Charlton
26fa7bf58d use syspref date format for manual due date
NOTE: will fail if user manages to enter date
in wrong format.  This is not a change from before
this patch, but is pointed out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:14:41 -06:00
Galen Charlton
af0b208bdf use standard template var for DHTML date format
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:13:59 -06:00
Chris Cormack
6cfe88b7b2 Fix for bug 1427
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-19 18:55:20 -06:00
0e675ef820 - Changes to the way patron renewals are handled. Circulation page now offers 'renew' link alongside warning about patron expiration (as in dev_week), using the new setstatus script.
- Member pages now use member toolbar include instead of circ one
- setstatus.pl now uses 3.0's patron renewal function
- Adding missing item-bullet.gif (Bug 1659)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 19:24:49 -06:00
Chris Cormack
ea7cbfff43 Fix for bug 1648, specifying a due date resulted in a blank due date
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 08:19:55 -06:00
Chris Cormack
0bc686acf9 Fix so ysearch.pl uses utf-8
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-05 15:34:34 -06:00
Joshua Ferraro
5227d242fd cleanup of circ/ dir changes to Dates ... missing format_date 2007-12-04 18:47:03 -06:00
Joshua Ferraro
e428929bff adding format_date to 'use C4::Date' 2007-12-04 18:29:18 -06:00
Joe Atzberger
82b8c496fd circ subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:12 -06:00
266b59cf65 Moving "Check Out" from the action toolbar to the view menu
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:56:22 -06:00
f46ebf69a0 Passing "adultborrower" variable to the template so that "Add Child" button can be displayed in the toolbar when appropriate. Fixes Bug 1510.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 15:06:29 -06:00
c5e80b7b86 Attempting to pretty up confirmations and messages in returns; Adding some variables to the template output; Fixing layout in circulation.tmpl for patrons without messages; Minor correction to OPAC css.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:58:06 -06:00
Galen Charlton
958b5a097c new C4::Auth::get_session for single place to get CGI::Session object
Refactoring to provide single place to get CGI::Session ojbject;
fixes bug for DB storage method other than 'mysql'.

This refactoring is also part of the patch series for
handling large input files for staging and processing
MARC records.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:43:26 -06:00
Ryan Higgins
cb1ec158c0 Adding calendar widget to circulation/stickyduedate
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:27:25 -06:00
Ryan Higgins
88e913046a fixing pending reserves to use dates specified
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-16 07:12:08 -06:00
Joshua Ferraro
687c83370e fixes to date handling 2007-11-13 20:41:46 -06:00
Chris Cormack
d8d27ab898 Missing AND in the SQL in pendingreserves.pl only if independentbranches was turned on
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 18:05:07 -06:00
Ryan Higgins
9c2d58a470 update item-at-wrong-branch error message to show homebranch.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:45 -06:00
Chris Cormack
5342904792 We were calling get biblioitemdata when we should have been calling get bibliodata
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 11:19:26 -06:00
Chris Cormack
5fa4703ee0 Fix for 404 error when clicking on a reserve in circulations
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-12 17:40:23 -06:00
Ryan Higgins
3967fa9c79 further mods to change from ccode to itype at item-level itypes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-11 18:40:20 -06:00
Chris Cormack
24af640015 Rest of the fix for 1402
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:05:20 -06:00
Joshua Ferraro
58d3b163d0 merge mason's fix to circulation 2007-11-06 06:19:17 -06:00
Mason James
275e3eb8b1 undeclared @issued_itemtypes_count_loop;
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-06 06:18:15 -06:00
Joshua Ferraro
9e8dc6b021 adding back my @issued_itemtypes_count_loop; 2007-11-05 08:41:11 -06:00
Ryan Higgins
371efb047b adding item-level itypes: based on systempref: item-level_itypes, we use items.ccode as the circ code rather than biblioitems.itemtype. This is initial commit -- still requiring interface changes basic loanlength, maxissues should be by ccode now.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:37:53 -06:00
Ryan Higgins
d6eea9c622 fixed redefined itemtype_count variable .
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:37:38 -06:00
b453d173ae Standardizing information shown in sidebar when patron-related pages are displayed (making sure address, phone, email variables are available to all templates). Adding tabs to account-related pages as means of section navigation.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:31:32 -06:00
4a9745dbb0 More interface changes for circulation: Further tweaking of circ warning dialog, formatting patron selection form, adding 'focus' class to patron selection select list.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:31:02 -06:00
Ryan Higgins
dac69bc799 Couple of minor changes to staff client view on patron.
item-level_itypes still need display changes in both opac and staff.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:27:59 -06:00
Chris Cormack
ff179bb1d4 Fix for bug 1518
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:21:46 -05:00
Paul POULAIN
8b7085a8ab removing useless code
the 3 parameters :
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),

are filled by Auth.pm automatically, removing them in templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:03:38 -05:00
b6e604c80e patch
See attached file. Thanks.

>From 1c3021f31675193ad2e9b91a95191f9ae0caeff2 Mon Sep 17 00:00:00 2001
From: Frederic Demians <f.demians@tamil.fr>
Date: Wed, 24 Oct 2007 11:50:08 +0200
Subject: [PATCH] Borrower name autocompletion improvement
 Autocompletion is selected by syspref directly in circ-search.inc.
 This way it could be activated elsewhere just by adding CircAutocompl
 param into page using circ-search.inc.
 Done for example in circ/branchtransfers.pl. Must be done in all other
 circ/*.pl pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:01:41 -05:00
Chris Cormack
53be8065d1 Fix for bug 1456
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:58:14 -05:00
Chris Cormack
c3c520b385 Working on a fix for bug 1456
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 21:55:57 -05:00
701d6ef020 Circulation borrower name autocompletion
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-20 16:17:08 -05:00
Joe Atzberger
6f15e48f65 circulation.pl cleaned up. I think you'll like the difference. Less
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 21:21:31 -05:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
b4d14e4558 Adding new circulation-home, what we ultimately hope to be a "dashboard" interface for circulation functions. circulation-home.pl was created by copy-and-paste, so it should be reviewed. Circulation sub-pages' breadcrumb links have been updated to point to circulation-home.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:26:04 -05:00
Henri-Damien LAURENT
d1c03deb7e Reintroducing overdue filters.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:56:02 -05:00
paul
a5bd240321 FIX for Date calculation
Rule :
- always format_date() before sending date to template
- always format_date_in_iso immediatly after reading a date coming from a parameter
- deal internally only with dates in iso

Note that :
- I could not test things related to issues stats due to the my DB -issues.issuedate not filled, see commit about 3.00.00.006
- acquisitions_stats does not work when you filter on date

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 11:51:12 -05:00
Paul POULAIN
47321d0068 Adding dates for display to circulation.pl Minor bug fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 18:44:46 -05:00
Chris Cormack
ee56e731ab Fix for bug 1436, changing to use issuedate, not timestamp for sorting issues
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 20:45:46 -05:00
34b67109d1 A couple more tweaks to member entry form. Still unfinished: inline CSS will have to be generalized and moved to external stylesheet. Trying some changes to circ page, including moving patron info into sidebar, consolidating messages and warnings. Also unfinished!
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-25 14:47:02 -05:00
a37daca905 More efforts with toolbars, nothing solved. Also corrections, and modifications to resident search to place focus on displayed form field.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-25 14:46:56 -05:00
Paul POULAIN
c4d4b6ecf2 Bug fixing : 1396
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-24 15:31:40 -05:00
Paul POULAIN
3568e20644 bug fixing on 1396 :
Conflicts:

	circ/circulation.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-24 15:29:42 -05:00
Chris Cormack
1a4fc157bf Applying the fix for bug 1416 from paul
Had to edit the patch as it was corrupt
2007-09-20 17:39:43 -05:00
Paul POULAIN
e809eff05f BUGFIX : branch CPL was hardcoded
What is the branch CPL ?

Anyway, this was buggy and reseted the branch to empty
which was a bug ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-18 15:06:47 -05:00
Chris Cormack
f12fc20e1d Fix to get selectbranchandprinter working fine with the Session
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-06 20:48:13 -05:00
Paul POULAIN
497bbd84b0 show the departure date if close or past
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-14 21:32:22 -05:00
Joshua Ferraro
cefeb583ad fixing permissions on scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-08-13 12:22:30 -05:00
Joshua Ferraro
e9ae8c0686 patches from paul 2007-08-08 07:41:19 -05:00
Chris Cormack
2e4a11773c Merge branch 'master' of /home/jmf/repos/koha-rm-root.git/ 2007-08-08 07:36:43 -05:00
Paul POULAIN
19aa1c7a5a formatting date
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-08 07:25:09 -05:00
kados
40af15d8e6 changing permissions on templates and scripts 2007-08-07 13:20:51 -05:00
jmf@arwen.metavore.com
c0d85e87b4 From 0751ba130288bc69e9e563473e7fc25551edc40e Mon Sep 17 00:00:00 2001
From: kados <jmf@arwen.metavore.com>
Date: Sat, 4 Aug 2007 20:10:51 -0500
Subject: [PATCH] fixing permissions on all scripts

Signed-off-by: Chris Cormack <crc@arwen.metavore.com>
2007-08-04 22:41:41 -05:00
toins
ee5c4c303c display enhancement. 2007-07-24 14:17:07 +00:00
toins
cae655f928 removing a compilation warn. 2007-06-05 09:48:31 +00:00
toins
738d04c2ca chmod +x
using output_html_with_http_headers instead of a print "..."
2007-06-05 09:48:06 +00:00
tipaul
577a7bf094 some (minor, functionnaly speaking) bugfixes 2007-06-05 08:54:17 +00:00
tipaul
a04f92a30a some minor bugfixes, templates improvements & zebra default config file changes 2007-05-29 16:36:11 +00:00
tipaul
5ff7fcffa4 Bugfixes & improvements (various and minor) :
- updating templates to have tmpl_process3.pl running without any errors
- adding a drupal-like css for prog templates (with 3 small images)
- fixing some bugs in circulation & other scripts
- updating french translation
- fixing some typos in templates
2007-05-22 09:13:54 +00:00
hdl
286930bdc7 Changing GetMarcStructure signature.
Deleting first parameter $dbh
2007-05-22 08:50:47 +00:00
alaurin
5c4a2c3e4b bugfixing for circulation. 2007-05-04 10:18:00 +00:00
hdl
097fef712a Removing $dbh from GetMarcFromKohaField (dbh is not used in this function.) 2007-04-27 14:00:48 +00:00
hdl
a171035f1d GetBorrowerIssues is deleted from C4::Circulation
Use GetPendingIssues from C4::Members instead.
2007-04-25 14:07:34 +00:00
tipaul
fb143b71ba BIG COMMIT : cleaning of Reserves.pm. See detail on koha-devel 2007-04-24 16:10:36 +00:00
tipaul
ee40bfb5c6 removing reserve.pl (moved to pendingreserves.pl) 2007-04-24 16:09:11 +00:00
hdl
b642e687d2 Still Code Cleaning.
Abiding by Name Convention.
Using Members wherever it should be used.
Borrower is only used for borrower Categories.
+ GetBorrowersWhoHaveNeverBorrowed
and lists like that.
2007-04-24 15:41:27 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
4dea4d29b3 moving dotransfer to Biblio.pm::ModItemTransfer + some CheckReserves fixes 2007-04-24 09:07:53 +00:00
tipaul
0c020dd8bf renaming reserves & branchreserves to pendingreserves and waitingreserves 2007-04-23 16:42:59 +00:00
tipaul
9f42b8ad49 renaming currenttransfers to transferstoreceive 2007-04-23 15:21:17 +00:00
tipaul
3ddec89262 moving Reserves2.pm to Reserves.pm 2007-04-23 14:08:47 +00:00
hdl
0b66bd800d Code Cleaning Members.
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
2007-04-23 13:10:07 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
5af8ae975b removing "department" and replacing by items.location 2007-04-18 14:20:54 +00:00
tipaul
43ad7fb4df circulation cleaning continued: working on branchtransfers.pl (unfinished, but at least it compiles... 2007-04-17 16:24:59 +00:00
tipaul
b71839d85c circulation cleaning continued: bufixing 2007-04-17 08:44:49 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation.
some stuff to do, i'll write a mail on koha-devel NOW !
2007-04-04 16:46:22 +00:00
alaurin
d23c6c9955 bugfixing of warnings in current transfers and waitingreservestranfers
same bugfixing as branchreserves
2007-04-03 15:41:36 +00:00
alaurin
6f84890152 bugfixing for displaying the maxpicking delays for reservations, now the method of date works is using
Add_Delta_Days and not delta year and month
now the system working
2007-04-03 15:04:30 +00:00
tipaul
987ceb8ce7 using C4::Date instead of C4::Circulation::Date 2007-03-30 11:58:48 +00:00
kados
b4d72b977f fix for bug 1276: Cannot search for patron wtih apostrophe in their name 2007-03-18 04:13:21 +00:00