Commit graph

161 commits

Author SHA1 Message Date
82c3c3df6c Fix for Bug 4534, Box for SQL not visible in "Create Report from SQL"
Changed style of SQL box and altered markup for a somewhat
cleaner layout

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 08:43:51 -04:00
841da504e8 Further corrections for Bug 4244, Use "checkouts" instead of "issues"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-07 13:26:29 -04:00
38b16e34fd fix various errors reported by xt/author/translatable-templates.t
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 08:36:21 -04:00
Garry Collum
84dada43d3 Bug 2889: Added zebra striping to the table in dictionary.tmpl.
Also fixed a couple of minor XHTML errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:24:03 -04:00
79616840b1 Fix for Bug 4244, Use "checkouts" instead of "issues"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-17 09:11:58 -04:00
Garry Collum
3cdbce6919 Bug 3090: Adds the report ID field to the saved reports page in the guided reports.
Adds an ID field to the save reports table in guided reports to make running runreport.pl easier for users.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:41 -05:00
Chris Cormack
8f902d3248 Bug 1542, followup patch to tidy up some messy dropdown behaviour
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 18:14:19 -05:00
2ce51846a0 More fixes for Bug 2600, HTML tags in titles not escaped in many places
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 16:52:31 -05:00
cd921163c0 Fixes for Bug 3089, Date entry fields should indicate required date format
- Added include, date-format.inc, which shows format, e.g. "(DD/MM/YYYY)"
- Hint shows expected date format based on system preference
- Removing calendar.inc include from templates which don't use it

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 15:12:18 -05:00
Paul Poulain
7d8b369ba4 Improved guided reports (#3929)
added runtime parameters for guided reports. Online help:

Can I have run-time defined parameters?

Yes, you can: there is a specific syntax that Koha will understand as 'ask for values when running the report'. The syntax is &lt;&lt;Question to ask|authorised_value&gt;&gt;.

The &lt;&lt; and &gt;&gt; are just delimiters. You must put &lt;&lt; at the beginning and &gt;&gt; at the end of your parameter
The Question to ask will be displayed on the left of the string to enter.
The authorised_value can be omitted if not applicable. If it contains an authorised value category, or <strong>branches</strong> or <strong>itemtype</strong> or <strong>categorycode</strong>, a list with the Koha authorised values will be displayed instead of a free field

Note that you can have more than one parameter in a given SQL
Note that entering nothing at run time won't probably work as you expect. It will be considered as "value empty" not as "ignore this parameter". For example entering nothing for : "title=&lt;&lt;Enter title&gt;&gt;" will display results with title='' (no title). If you want to have to have something not mandatory, use "title like &lt;&lt;Enter title&gt;&gt;" and enter a % at run time instead of nothing
Sample :
SELECT surname,firstname FROM borrowers WHERE branchcode=&lt;&lt;Enter patrons library|branches&gt;&gt; AND surname like &lt;&lt;Enter filter for patron surname (% if none)&gt;&gt;
2010-01-28 15:11:46 +01:00
4b60c8a9aa Fixes for Bug 3958, Standardize vendor/supplier/bookseller terminology
Changing instances of "supplier" or "bookseller" to "vendor."
2010-01-25 18:37:12 +01:00
Nicole Engard
52acec53c6 bug 4011 remove blank row on stats form 2009-12-31 10:58:03 +01:00
Nicole Engard
40d1a32c42 Bug 3952 changed checkout stats to read circulation stats 2009-12-20 14:31:45 +01:00
Matthias Meusburger
cff0c954da MT 2051, Follow-up : Fixing typo in granular permissions for guided reports 2009-11-19 23:22:55 +01:00
Matthias Meusburger
b529f00aa3 MT 2050 : Fast cataloging 2009-11-19 23:09:46 +01:00
Paul Poulain
3a76e49977 reindenting + typo fix (MAJOR : missing s in permission checking) 2009-11-03 17:17:27 +01:00
Matthias Meusburger
9a43a47755 MT 2051 : granular permissions for guided reports 2009-10-16 23:55:50 +02:00
Matthias Meusburger
b87b3273a9 MT 1443 : better reports on items 2009-09-30 11:30:32 +02:00
Paul Poulain
fb8131e531 replacing links to bookfunds into budgets 2009-09-30 11:30:21 +02:00
Nicole Engard
20949844c3 Cleaned up display on reports page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:40:25 -04:00
Garry Collum
315a541682 Bug 3420: Fixes 'Patrons with no checkouts' report.
Fixed typo in SQL statement.  Commented out some unused SQL statements.

Removed limit for itemtype (column not available in results) and added limit for branchcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:56:03 -04:00
Garry Collum
5d23aafbee Bug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.
Form - Fixes alphabetization of dropdowns.

Results - Fixes format of "Date last seen" to be the system date preference.  Adds highlighting to the table.

Enables warnings. Pages generated no warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:38:59 -04:00
Garry Collum
be1ef2b2fa Bug 2553: Alphabetization of branches in the catalogue stats report.
Improvement on previous patch by using GetBranchesLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:53 -04:00
Garry Collum
8c1b8b47c5 Bug 2553: Alphabetization of branches in Checkout Statistics form.
Improvement of previous patch through the use of GetBranchLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:51 -04:00
Garry Collum
b9a0c1644f Bug 3392: Fixes highlighting in Patrons with no Checkouts report.
Fixed class definition and moved the definition from the <td> tags to the <tr> tags.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:00:00 -04:00
471fe3927a Removing hard-coded $ symbols from the template, addressing Bug 2547
Pending a system for displaying the correct currency symbol based on the system's default currency all dollar-specific symbols should be removed in favor of no symbol.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:25 -05:00
Nahuel ANGELINETTI
ded3ff78cf (bug #3364) add itemnotes in itemslost report
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:18:45 -05:00
Liz Rea
66fa41460d Adding links to guided reports wizard, dictionary, create from sql to reports home page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 08:39:21 -05:00
b216babdf8 Fix bug 3330 - Report notes modification
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-15 12:43:18 -05:00
Garry Collum
b5f419ba93 Bug 3252: Fixes XHTML on catalog statistic form page.
Several form input fields were within a <table> element, but not in a <td>.  This patch pulls the input fields out of the table.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 07:53:55 -05:00
Garry Collum
22b55a4a1d Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Added code to detect if the syspref for item-level_itypes is being used.  The report now correctly returns data based on the syspref.  There are some pre-existing XML errors with the FORM view of catalogue_stats.pl.  I'll send a subsequent patch to deal with these.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:24 -05:00
Garry Collum
7eff11f229 Bug 3253: Fixes XHTML for the Patron Statistics form page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 08:51:31 -05:00
Garry Collum
6d8cb8fa2c Bug 3254: Fixes the Catalog by Item Type report XHTML.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 08:51:30 -05:00
a89c3085cf Bug 1542, fixing filter by area in reports dictionary
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-14 06:59:52 -05:00
Nahuel ANGELINETTI
b1180360a8 (bug #3196) fix itemlost.pl
This patch fix 3 things:
* fix order by
* take care of item_level-itype
* use join in sql query

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 08:34:07 -05:00
Nahuel ANGELINETTI
78756abc37 (bug #3174) show the member name in reports
this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:17:30 -05:00
Nahuel ANGELINETTI
4dbe34f231 (bug #3174) fill borrower number, and show author and creation date in saved reports
This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:25:36 -05:00
Joe Atzberger
a57b438df0 Bug 3126: remove comma for IE7
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:12 -05:00
Joe Atzberger
1afa403417 IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:28:28 -05:00
8246da13b2 Fixing xhtml errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 09:14:53 -05:00
60fc079cfb Update for bug 1545 allowing for the title to be edited
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:36:16 -05:00
834001ffbb Allowing users to edit saved sql in guided reports. Bug 1545
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 14:59:02 -05:00
Joe Atzberger
14be4400d8 Bug 3066 - Overhaul guided reports
execute_query now refactored, returns reliable results, does
zero presentation-layer crap.  Arguments reduced, client scripts
adapted to new API and performance improved.  Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.

Replaced tools/runreport.pl with misc/cronjobs/runreport.pl:
    ~ security fixed
    ~ documentation improved
    ~ TODO: finish sendmail option.

Bug 3077 also fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 20:17:55 -05:00
Joe Atzberger
04ad0fa0ec Add larger values to numerical limit.
Client requested additional values in dropdown for numerical limit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:36:50 -05:00
Nahuel Angelinetti
b61e083301 (bug #2854) add the possibility to make a fuzzy search on the barcode
This patch add a field that permit to make a "like" and "not like" filter on barcode in the catalog report.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 14:29:04 -06:00
Joe Atzberger
5a4032b2e3 catalogue_out report cleanup.
Warnings enabled, comparison adjusted to accomodate undef.
Hardcoded CGI::scrolling_list removed.
Sort order on item types corrected.  Unused dependencies commented out.
GetBranchesLoop used instead of copy/paste code.

NOTE: CSV output is not fixed by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 12:56:19 -06:00
1c9e6f16e7 Using "escape=html" on TMPL_VAR containing SQL to prevent HTML from breaking when SQL includes double-quotes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 13:50:02 -06:00
Nahuel ANGELINETTI
ba34bea474 (bug #2938)[follow previous] Add new report in menus
Just adding the new report in miscellaneous menus

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:42:00 -06:00
Nahuel ANGELINETTI
720cddeca6 (bug #2938) add a serials subscriptions report
this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:41:48 -06:00
Jesse Weaver
b8d8a0ec5a fix for bug 2543: report output by tabulation a bit too literal
This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 11:44:28 -05:00