Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Owen Leonard	e55d16f0da	Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates This patch modifies staff client templates to remove the "type" attribute from <style> tags. The attribute is no longer valid. To test, apply the patch and confirm the changes to the templates. The appearance of the staff client should be unchanged. Validating pages from the staff client should not return any errors related to the <style> "type" attribute. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	b704a1adfc	Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Andrew Isherwood	a1d24a2b61	Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	cd81bdc6a0	Bug 21526: Use the 'url' filter when needed Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	6 years ago
Jonathan Druart	dcd1f5d48c	Bug 13618: Add html filters to all the variables Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	9 years ago
Sophie Meynieux	06a8b6f314	Bug 9210: wrap long lines in printed hold notices This commit adds wrapping styles to print-notices.tt template Test plan: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's split on 2 lines with this patch (it is not before this patch) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Katrin Fischer	84839a93f5	Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error) Signed-off-by: Owen Leonard <oleonard@myacpl.org>	12 years ago
Srdjan Jankovic	a9ded4fa00	bug_7001: Issue and Reserve slips are notices. Branches can have their own version of notices - added branchcode to letter table. Support html notices - added is_html to letter table. Support for borrower attributes in templates. GetPreparedletter() is the interface for compiling letters (notices). Sysprefs for notice and slips stylesheets Added TRANSFERSLIP to the letters Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Chris Cormack	5884fb1000	Bug 5917 : Swapping templates over	13 years ago
Alex Arnaud	0b96414ce3	Bug 6095: Add UTF8 encoding in template Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Jesse Weaver	63e871dd40	Bug 3482 Allow hold notices to be sent in print form This is done by saving the notices in the message_queue table with type 'print'. The notices are generated from a notice named HOLD_PRINT. At the end of the day, they are dumped to an HTML file and marked as sent by a new cronjob. This setup is intended to be temporary; modules/batch/ shouldn't be around forever. Mandatory SQL: INSERT INTO message_transport_types (message_transport_type) values ('print');	15 years ago

11 Commits (3b273de5777ac7dd5bebac629dc8c88e6bdc962a)