Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	5d76558875	Bug 16112: Do not depend on SpecifyDueDate It's possible to specify a renewal due date in the checkouts table even if SpecifyDueDate is off. Also change the label from "Specify due date:" to "Renewal due date:" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	41fe5b41f9	Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	9189dd4f71	Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Ere Maijala	a1a05db1b6	Bug 11529: Add templates for biblio title display. Unify display. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Andrew Isherwood	3b50efb7d5	Bug 7088: (follow-up) Remove script "type" attribute As per item 1 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Andrew Isherwood	c48af49ded	Bug 7088: Allow renew on hold items with due date This patch adds the ability for items that are on hold to be renewed with a due date specfied by the user. It is enabled by the new "AllowRenewalOnHoldOverride" syspref. It is manifested in two locations: 1. In the "Checkouts" table on the Patron Details screen. It is now possible to select on loan items that would otherwise fulfil a hold request to be renewed. When such an item is selected, an additional date selection box is displayed to allow the user to specify the due date for all on hold items that are to be renewed. 2. In the Circulation > Renew alert screen. When a barcode of an on loan item that would ordinarily fulfil a hold request is entered, the usual alert is displayed indicating that the item is on hold, it is still possible to override this, and renew, however it is now also possible to specify a due date. Test plan: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing <Andrew.Farthing@sefton.gov.uk> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
helene hickey	4eab830835	Bug 22054: Updated the error message for attempting to renew an onsite checkout To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing 8) apply the patch and reload page with error message 9) verify display: Item cannot be renewed because it's an onsite checkout Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Owen Leonard	1cf849eee0	Bug 21442: Update two-column templates with Bootstrap grid: Circulation part 1 This patch modifies several circulation templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Circulation -> Pending on-site checkouts (enable OnSiteCheckouts preference). - Test with the CircSidebar system preference both on and off - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Renew - Test with the CircSidebar system preference both on and off - Circulation -> Bibliographic detail page -> Request article (enable ArticleRequests system preferences) - Circulation -> Hold ratios Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Nick Clemens	72750cf3b7	Bug 15494: Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	7 years ago
Jonathan Druart	5825026448	Bug 21526: uri escape TT variables when used in 'a href' This patch has been generated with the script provided on bug 21576. It only affects variable used in the href attribute of a link when href it the first attribute of the node (grep "a href") Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Christopher Brannon	92a2d74c1c	Bug 13272: Adds type="text" to inputs missing it Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	dcd1f5d48c	Bug 13618: Add html filters to all the variables Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	9 years ago
Julian Maurice	6325f9ed55	Bug 19444: (QA follow-up) Remove repeating condition Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	25e050e2ef	Bug 19444: Display error message for auto_account_expired Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Owen Leonard	44e7d5e84b	Bug 19700: Move template JavaScript to the footer: Some circulation pages This patch modifies some staff client circulation templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Article requests (enable ArticleRequests system preference, have at least one outstanding article request) - Request article (Bibliographic detail page -> Request article). - Item circulation statistics (Bibliographic detail page -> Items -> View item's checkout history). - On-site checkouts (enable OnSiteCheckouts system preference; Check out some items as on-site checkouts; Go to Circulation -> Pending on-site checkouts - Overdues report (Circulation -> Overdues). - Holds to pull (Circulation -> Holds to pull). - Renew - Holds ratios (Circulation -> Holds ratios). - Check in - Transfers to receive (Circulation -> Transfers to receive). - Holds queue (Circulation -> Holds queue). - Holds awaiting pickup (Circulation -> Holds awaiting pickup). Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	2c07f63ae8	Bug 18449: Rename misleading button when renewing If you hit the renewal limit on the renewal tab, the message gives you a message like: "Windows 8 / ( 50610018249545 ) has been renewed the maximum number of times by Johnny Test ( 12345678 )" And has a button that reads: "Ignore and continue" This button is misleading, as it may be interpreted as "ignore the limit and continue to renew the item". Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	d08a0bc685	Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached If a patron owes more than the OPACFineNoRenewals value, the issue won't be auto renewed anymore (driven by the new pref OPACFineNoRenewalsBlockAutoRenew). Test plan: Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Set the OPACFineNoRenewals to 5 (for instance) 2/ Set OPACFineNoRenewalsBlockAutoRenew to block 3/ Check an item out to a patron and mark is as an auto renewal 4/ Make sure the patron does not have any fees or charges. 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 6/ Create an invoice for this patron with a amount > OPACFineNoRenewals (6 for instance) 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed. 8/ Set OPACFineNoRenewalsBlockAutoRenew to allow 9/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed Sponsored-by: University of the Arts London Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Aleisha	1edb8cbeee	Bug 16530: Adding a circ sidebar navigation menu and circSidebar syspref to activate/deactivate Edit: Fast cataloging link should now show on all pages, removed offline circulation links Edit 2: Creates the syspref to activate or deactivate the sidebar Edit 3: Fixing merge conflicts, using Koha::BiblioFrameworks to find FA framework and adding sidebar to on-site checkouts This adds a sidebar to circ/branchoverdues.tt circ/circulation.tt (I also fixed up some of the indentation in this file to make it easier to see where the divs started and ended) circ/renew.tt circ/returns.tt circ/selectbranchprinter.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt circ/branchtransfers.tt circ/on-site_checkouts.tt To test: 1) Confirm syspref CircSidebar is activated 2) Go to all of the above pages and confirm the sidebar menu shows up 3) Confirm fast cataloguing link and transfer link are there 4) Trigger any error messages you can possibly think of (i.e. on renew.pl: barcode does not exist). Confirm that this does not mess up the layout of the page 5) Go to a user account page, Check out tab. (Since this is a circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm it looks as it usually does) 6) Deactivate circSidebar 7) Confirm pages all look normal Sponsored-by: Catalyst IT Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	15b1f6c7fe	Bug 15581: Display the latest auto renew date possible when renewing manually If an issue marked as auto_renew is renewed manually, we want to display the latest auto renew date possible. Test plan: 1/ Define circ rules as in the previous patch. 2/ Check a item out, mark it as an auto renewal 3/ Back date the issuedate and make sure it will be too late to renew it 4/ Use the Circulation > renew page (circ/renew.pl) to manually renew this issue. You should get a warning "You barcode has been scheduled for automatic renewal and cannot be renewed anymore since DATE." If the pref AllowRenewalLimitOverride is set, you will be allowed to renew it anyway. Sponsored-by: University of the Arts London Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	53dfa99727	Bug 15581: Add a circ rule to limit the auto renewals given a delay This patch adds a new circulation rule (no_auto_renewal_after) to block/allow auto renewals after a given delay. For instance, if the issue date is 10 days before today, and no_auto_renewal_after is set to 10, tomorrow the issue won't be auto renewed. Test plan: 0/ Execute the update DB entry Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Define a rule with no_auto_renewal_after (10 for instance) and norenewalbefore (5 for instance). (This new rule will behave the same as norenewalbefore: the unit depends on the lengthunit value). The automatic renewals will be done from 5 to 10 days ahead. 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed (too soon) 4/ Repeat step 2 with a due date set as 11 days before 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed (too late) 6/ Repeat step 2 with a due date set as 7 days before 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed (issues.renewals has been incremented and date_due has been updated according your circ rules). Sponsored-by: University of the Arts London Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Andreas Roussos	884e28fab5	Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>	8 years ago
Aleisha	10a9a1e147	Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT EDIT: Made changes from Comment 2 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Jonathan Druart	1302f91755	Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Link repaired. At first glance, I am wondering if biblioitemnumber is of actual use here; is it only passed back and forth between script and template? Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Kyle Hall	a8942c2884	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues Revert "DBRev to make notes of the XSS patches and the new important dependency." This reverts commit `e140603a59`. Revert "Bug 13618: Specific for branches.opac_info" This reverts commit `06e4a50f00`. Revert "Bug 13618: (follow-up) Specific for other prefs" This reverts commit `d6475a111f`. Revert "Bug 13618: Fix for debarredcomment and patron messages" This reverts commit `dd98c9df92`. Revert "Bug 13618: Do not display html tags in patron's notices" This reverts commit `a065b243fe`. Revert "Bug 13618: Do not display   and html tags in item fields content" This reverts commit `baeeaffbf8`. Revert "Bug 13618: Fix for system preference description" This reverts commit `a967a09261`. Revert "Bug 13618: Remove html filters for newly pushed code" This reverts commit `0e98662b10`. Revert "Bug 13618: (follow-up) add missing lines for opac-shelves" This reverts commit `fc2fb605e5`. Revert "Bug 13618: (follow-up) Specific for ColumnsSettings" This reverts commit `bc308fdd9c`. Revert "Bug 13618: Fix for edit biblios and items" This reverts commit `811c4e8402`. Revert "Bug 13618: followup to remove tabs" This reverts commit `ca8e8c397c`. Revert "Bug 13618: Fix last occurrences recently introduced to master" This reverts commit `bb417b256b`. Revert "Bug 13618: Fix for news" This reverts commit `ae5b98020a`. Revert "Bug 13618: Fix escape on sending baskets or shelves by email" This reverts commit `a7731ffe25`. Revert "Bug 13618: Specific for XSLTBloc" This reverts commit `11fa38dc29`. Revert "Bug 13618: Specific for Salutation on editing a patron" This reverts commit `36c07ad6d3`. Revert "Bug 13618: Specific for other prefs" This reverts commit `e6ea281a3b`. Revert "Bug 13618 - memberentrygen.tt errors Not a GLOB reference" This reverts commit `7824874557`. Revert "Bug 13618: Specific for ColumnsSettings" This reverts commit `1834da3da3`. Revert "Bug 13618: Specific for IntranetUser* and OPACUser* prefs" This reverts commit `21ae62b253`. Revert "Bug 13618: Fix error 'Not a GLOB reference'" This reverts commit `602bdbab4c`. Revert "Bug 13618: Specific for the ISBD view" This reverts commit `d254362435`. Revert "Bug 13618: Specific for pagination_bar" This reverts commit `8837a8ae68`. Revert "Bug 13618: Specific places where we don't need to escape variables - intra" This reverts commit `00eff140b3`. Revert "Bug 13618: Remove html filters at the intranet" This reverts commit `7db851ff03`. Revert "Bug 13618: Specific places where we don't need to escape variables" This reverts commit `49a3738b8d`. Revert "Bug 13618: Remove html filters at the OPAC" This reverts commit `cedaa0e23e`. Revert "Bug 13618: Use Template::Stash::AutoEscaping to use the html filter" This reverts commit `01b38d3b13`. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Jonathan Druart	7db851ff03	Bug 13618: Remove html filters at the intranet Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	9 years ago
Jonathan Druart	de823801e6	Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates Test plan: use circ/renew.pl to renew an issue. Without this patch, you will get an error. Note: The error exists for 1 year now and nobody complained?? Does someone still use this script? Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>	8 years ago
Frédéric Demians	b38370ff83	Bug 13941: [2/2] Fix <body> tags missing id/class Followed test plan from patch 1/2, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	52c5f030bf	Bug 11944: (follow-up) Remove all utf8 filter from templates This patch removes 2 new occurrences introduced by bug 11351 and bug 10493. Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Removes a nasty "Template process failed: plugin error - EncodeUTF8: plugin not found at /home/magnus/scripts/kohaclone/C4/Templates.pm line 124" from /cgi-bin/koha/admin/itemtypes.pl Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	99521c37fa	Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Holger Meißner	555d0d5898	Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Galen Charlton	26c7924186	Bug 7413: (follow-up) teach renew interface about too_soon This patch ensures that the new staff interface for renewals recognizes when premature renewals are requested. If the AllowRenewalLimitOverride system preference is enabled, staff members are able to override the block: To test: [1] Set up a loan policy with a "no renewal before" value and check out an item. [2] In the renewal page, verify that attempting to renew the loan results in an error forbidding the renew. [3] If AllowRenewalLimitOverride is enabled, the operator should also be given the option to override the block. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Kyle Hall	a5161d8fce	Bug 10493: (follow-up) fix various QA issues Adds a new Template Toolkit filter EncodeUTF8 to encode strings to utf8 for correct display of diactritics. Adds the new JavaScript function removeFocus() to staff-global.js Use this function to remove the focus from any element for repeated scanning actions on errors so the librarian doesn't continue scanning and miss the error. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> This works as described - you have to actually look at the error and pick what you want to do or confirm it. I think maybe tying the action to a shortcut (c = confirm or similar) would be nice, so you can get away with only using the keyboard. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	d6cbbcd07c	Bug 10493: (follow-up) fix minor template issues This template followup fixes some minor template errors and adds some style to dialog buttons matching those seen on the circulation page. To test, submit barcodes to trigger the various error conditions: Non-existant barcode, over the renew limit, restricted patron, item on hold. Override and Ignore buttons should be properly styled and functional. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	2e4411e77f	Bug 10493: Add renewal script This patch adds a renewal tool that functions similar to the returns where a librarian can continuously scan items for renewal. This script blocks renewals that are impossible, and allow the same renewal overrides as circulation.pl Test plan: 1) Apply the patches for bug 8798 2) Apply this patch 3) Browse to /cgi-bin/koha/circ/renew.pl 4) Enter an invalid barcode, you should get an error message 5) Enter a valid, but not checked out barcode, you should get an error message. 6) Enter a valid barcode that is checkout out and should be renewable, you should get a success message. 7) Enable AllowRenewalLimitOverride 8) Enter a barcode for an item that has been renewed too many times 9) You should get a warning which you can override. 10) Disable AllowRenewalLimitOverride 11) Repeat steap 8 12) You should get a blocking error message 11) Enter a barcode for an item with unfilled holds on it, you should get an overridable warning Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Passes all tests and QA script, some issues have been addressed in follow-ups. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago

34 Commits (3b273de5777ac7dd5bebac629dc8c88e6bdc962a)