Commit graph

118 commits

Author SHA1 Message Date
Colin Campbell
d8b362e0f9 Bug 5415 Let calls of SimpleSearch utilize considtent interface
Remove some unnecessary checks when check of error is
sufficient. Make the order in some cases more logical
Should remove some possibilities of runtime warning noise.
Although some calls belong to the 'Nothing could
ever go wrong' school have added some warnings

Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-08 13:52:57 +12:00
Chris Nighswonger
5a924cc530 Bug 5865 - Labels wrap incorrectly when paper width is greater than height
This is due to the incorrect use of string comparators to compare numeric values.
This patch corrects that.

Note: This should be backported to 3.2.x

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-03-15 21:52:32 +13:00
Chris Nighswonger
0448a6d014 Bug 5391 - can't add multiples to batch
This was due to the use of an OR which seems to have caused the
param method to be called in a scalar context thus returning only
the first of multiple repeated cgi params.

This patch retains the intent of the OR by replacing it with a
conditional.

Signed-off-by: Koustubha Kale <kmkale@anantcorp.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-13 09:13:16 +13:00
Andrew Elwell
9fa574f609 Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 10:06:55 +13:00
Chris Nighswonger
3169100d51 Bug 5227 [3.4] Enhance the label batch edit interface
This patch adds the ability to enter items into label batches via
barcode scanning

Work sponsored by Tamil - http://www.tamil.fr

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-26 09:03:54 -04:00
07ae6c6cd6 Merge remote branch 'koha-fbc/k_bug_5249' into to-push
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:10:36 -04:00
Chris Nighswonger
947b47954e Bug 5249 - Guide boxes do not print when selected for a layout 2010-09-24 14:42:42 -04:00
Chris Nighswonger
b8d5a69e4e Bug 5203 - Creating a label template causes fatal error if description field is empty
This is due to the underlying script not having any defaults hard coded which results
in skewed hash elements when the parameter array is coerced into a hash at a later point.

This also occurs in layouts and profiles. This patch adds defaults to all three.

No documentation changes are necessary.
2010-09-23 13:52:40 -04:00
573ac9488f remove a bunch of unconditional debug warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 10:57:08 -04:00
40cecd0c82 Bug 4382 Export batch label to CSV
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-16 00:58:32 -04:00
Lars Wirzenius
772ada9bf3 Fix FSF address in directory labels/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:50 -04:00
Koha User
e3421f0f9f Fixes bug 4232: Undefined hash references in Label Creator
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-10 15:59:35 -05:00
Chris Nighswonger
84d5b28f12 Bringing label, patroncard, and creator modules into conformity with the rest of C4 style.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 20:54:34 -05:00
Chris Nighswonger
ff13d25bb3 Bugfix: Various Label Creator bugs
This fixes:

* A bug which caused the label template editor to throw
an error when saving when no previous profile was applied.

* A typo which caused a 'fetch without execute' error in Labels.pm

It also comments out several useless warns
2010-01-19 22:27:09 -05:00
Chris Nighswonger
ed7009df42 [30/30] Removing depricated files 2010-01-11 18:21:43 -05:00
Chris Nighswonger
4a675bcaad [5/30] A rework of Label Creator code
This rework removes code held in common with the Patron Card Creator
and move is to the new C4::Creators module.
2010-01-11 18:16:52 -05:00
Henri-Damien LAURENT
1ec6e3df73 Change in API : ordnum becomes ordernumber 2009-10-30 00:30:47 +01:00
Chris Nighswonger
a46714b1d7 Bug 3706 Label templates/layouts do not save properly
Two issues here:

1. No radio box was selected by default in the format section of the layout editor. This actually needs some additional attention to allow the user
to establish a default method of entering the format string. As noted in comments in the code, this would probably be best implimented by adding yet
another syspref. However, I don't have time atm.

2. On saving a new template, if no profile was assigned to the new template, the script threw an error and died.

Both issues are addressed in this patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-10-14 18:19:08 +02:00
dd08a539dc remove unnecesary import of HTM:::Template::pro
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 21:43:12 -04:00
0bbcfeda0e replace syslog with warns
As discussed with Chris Nighswonger on #koha, this patch
removes the calls to syslog and replaces them with warns
so that error messages generated by the labels code
are sent to the Apache error log.  This avoids splitting
this sort of logging across multiple files and is consistent
with current practice in most of the rest of Koha.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 21:43:12 -04:00
Chris Cormack
0af3d16b27 Nicer error message if a branch is not set
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 19:56:22 -04:00
Chris Nighswonger
aa16f1229c Adding a missing module to labels search
This causes an error to be thrown if no items are retrieved and the
code goes to call &syslog

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 19:56:21 -04:00
Chris Nighswonger
3720e0261f Fixing warns (tnx to Chris Cormack for identifying these)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 19:56:20 -04:00
Chris Nighswonger
dcfaf1121f [40/40] Removing depricated files 2009-09-01 15:58:07 -04:00
Chris Nighswonger
ded8c88e95 [36/40] Bugfix for profile update on profile/template association change. 2009-09-01 15:54:18 -04:00
Chris Nighswonger
9b56b1ead9 [35/40] Work on C4::Labels tests and various bugfixs resulting
This patch also moves the Labels tests into their own sub directory.

Due to a squash mistake this patch also includes the following:

Fixing up POD for C4::Labels modules

Also a minor bugfix and code refactoring.
2009-09-01 15:54:01 -04:00
Chris Nighswonger
38817fb300 [31/40] Misc bugfixes and cosmetic cleanup. 2009-09-01 15:53:18 -04:00
Chris Nighswonger
39d227d712 [24/40] Adding single/multiple label printing to label export code and interface.
This adds single/multiple label printing by item number along with new CSV and XML export code.
2009-09-01 15:51:58 -04:00
Chris Nighswonger
51db13b8da [23/40] Initial work on label export interface. 2009-09-01 15:51:47 -04:00
Chris Nighswonger
c468a724b4 [22/40] General code cleanup of new labels module code. 2009-09-01 15:51:39 -04:00
Chris Nighswonger
4b4b161d50 [21/40] Adding de-duplicating method and associated label edit batch code. 2009-09-01 15:51:26 -04:00
Chris Nighswonger
13e894585f [20/40] Work on label printing code. 2009-09-01 15:51:16 -04:00
Chris Nighswonger
a339f5f94a [19/40] Various tweaks to the interface cosmetics, form validation scripts, css, etc. 2009-09-01 15:51:03 -04:00
Chris Nighswonger
c9e6962fd4 [18/40] Work on label item search. 2009-09-01 15:50:51 -04:00
Chris Nighswonger
86a5bc80e2 [17/40] Work on C4::Labels::Lib::html_table api to add link field option 2009-09-01 15:50:38 -04:00
Chris Nighswonger
ff606c3eb1 [16/40] Improvements to label management interface code. 2009-09-01 15:50:27 -04:00
Chris Nighswonger
a192e57f00 [15/40] Initial work on label batch edit interface. 2009-09-01 15:50:14 -04:00
Chris Nighswonger
204e051dff [14/40] Work on batch management interface. 2009-09-01 15:50:05 -04:00
Chris Nighswonger
0645c95a36 [13/40] Work on profile editor interface. 2009-09-01 15:49:53 -04:00
Chris Nighswonger
d47afd597b [12/40] Work on label managment interface. 2009-09-01 15:49:39 -04:00
Chris Nighswonger
4554222629 [11/40] Work on layout editor interface. 2009-09-01 15:49:29 -04:00
Chris Nighswonger
b44db285a6 [10/40] Work on Label Tool Homepage. 2009-09-01 15:48:57 -04:00
Chris Nighswonger
e12ae1892c [9/40] Work on template interface. 2009-09-01 15:48:50 -04:00
Chris Nighswonger
12663796ca [8/40] Adding new layout management page
This moves the layouts off of the labels tool start page to bring it into
conformity with the other parts of this tool.
2009-09-01 15:48:38 -04:00
Sébastien Hinderer
f1f833c965 bug 3464: Takes columns country and B_country of table borrowers into account in related operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:19:20 -04:00
56c72ab972 bug 3467 followup: fix test for item found
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-03 21:25:27 -04:00
Kyle M Hall
9f3ecc8a29 Quick Spine Label Printer - Minors fixes
This new version of the patch does away with the need for 2 spinelabel css files.

This patch address two points brought up:
[1] (minor) if an item is not found, it should say so and return to
spinelabel-home.pl, not show an empty label
[2] (minor) can the print button be excluded from the printout?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-03 21:18:40 -04:00
fabede22cc textual cleanup of new quick spine label code
* perltidy
* added license header to source files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
57be4114d8 quell warning on NULL item fields
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
5d0f29090b removed unneeded module imports
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00