Commit graph

117 commits

Author SHA1 Message Date
Paul POULAIN
7da4fd00b9 patenthesis at wrong place in javascript
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:36:05 -06:00
Henri-Damien LAURENT
2835ee1bf2 call to plugins didnot work.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:25:42 -06:00
Paul POULAIN
289e8f445e DO NOT return if SimpleSearch give no result, we need to check reservoir too
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:32:03 -05:00
Paul POULAIN
317736360b fix related #1340 (z3950 search for quick cataloguing)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-30 17:44:21 -05:00
Galen Charlton
d37919eab9 improved import batches part 2 -- replace use of marc_breeding
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:05:25 -05:00
Galen Charlton
b5ba60e726 fix another parentheses problem
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:58:10 -05:00
Galen Charlton
9ea0c6ba77 fix problem with prior patch that inadvertantly
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:57:44 -05:00
Galen Charlton
51e639ed7e added dropdown for classification source for addbiblio and additem
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:57:29 -05:00
Galen Charlton
7a24aac808 bib and item editing bugfixes
- bugfix: update items.cn_sort upon edit of item
- bugfix: make failure of a value_builder plugin non-fatal
- bugfix: remove references to non-existent plugins
          from optional MARC21 frameworks
             bookseller.pl
             marc21_callnumber.pl
             marc21_classcodes.pl
             marc21_locationqualifier.pl
- bugfix: corrected trying to enter 'u*' fields twice in the 'CF'
          format in the optional MARC21 frameworks; resulted in
          most of the framework not being loaded

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:57:10 -05:00
Galen Charlton
af9dfd9cda bib and item editing bugfixes
- bugfix: update items.cn_sort upon edit of item
- bugfix: make failure of a value_builder plugin non-fatal
- bugfix: remove references to non-existent plugins
          from optional MARC21 frameworks
             bookseller.pl
             marc21_callnumber.pl
             marc21_classcodes.pl
             marc21_locationqualifier.pl
- bugfix: corrected trying to enter 'u*' fields twice in the 'CF'
          format in the optional MARC21 frameworks; resulted in
          most of the framework not being loaded

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:56:53 -05:00
Henri-Damien LAURENT
458111f263 Managing IndependantBranches when creating a new Biblio
librarians can only add/edit/delete items on their own branches.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:44:29 -05:00
4cb09388fa Misplaced closing parethesis was causing javascript error with plugins
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 15:41:19 -05:00
Paul POULAIN
10eb85455b bugfix (security flaw) : the additem template was open AFTER doing actions
when Logguing was ON, this resulted in an internal server error, thus the discovery of this bug.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:24:49 -05:00
Paul POULAIN
124ed1188b #1432 : duplicated barcodes when item edited
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:18:13 -05:00
Henri-Damien LAURENT
38685bdf90 Bug Fixing : Adding item had a javascript Error.
So.
There are no more errors on saving an item.
There are still little problems when you duplicate a subfield :
Display table is not adapted
When you reedit, all the duplicate field values are concatenated.
But apart from that, it works.
Donot have time enough to work on it these days.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-20 14:12:01 -05:00
Chris Cormack
b9c20fa9cf Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:22:01 -05:00
Galen Charlton
af466ca41a start of reworking call number handling and other Biblio changes
Most of this commit by Joshua Ferraro.
updatedatabase changes by Galen Charlton.

Major changes:

This commit includes a lot of fairly major changes
to Koha's Biblio handling, largest is the addition
and deletion of several columns in the biblioitems,
items tables, as well as cleanup of deletedbiblioitems,
deleteditems tables. Some of the changes are simple
cleanup, but most have to do with improvements to
storage of call numbers in Koha.

Also, I had to clean up the _koha_* routines quite a
lot to make them work -- there was lots of data just
being lost because columns weren't being updated.

I'm still not completely convinced that the items
table is being treated as authoritative for items
data, investigating further.

DB Changes (updated in kohastructure.sql and in
updatedatabases):

ADDED:
biblioitems.cn_source   ( auth value, CN_SOURCE, stores the source of the
                          call number: DDC, LCC, NLM, etc.)
biblioitems.cn_class    ( plugin, marc21_callnumber.pl, helps fill in
                          the rest of the biblio-level fields)
biblioitems.cn_item
biblioitems.cn_suffix
biblioitems.cn_sort     ( for zebra sorting, stored as a decimal number)
biblioitems.totalissues ( for counting the total times issued )

items.cn_source         ( auth value, CN_SOURCE, stores DDC, LCC, NLM, etc.)
items.itemcallnumber    ( plugin, marc21_itemcallnumber.pl, helps fill in
                          the itemcallnumber based on the record data )
items.cn_sort           ( for zebra sorting, stored as a decimal number)
items.ccode             ( auth value, CCODE, stores the Collection Code
                          of the item, can be used as call number prefix
                          by some libraries )
items.uri
items.materials
items.damaged

DELETED:
items.itype
items.cutterextra
biblioitems.classification
biblioitems.subclass
biblioitems.dewey
biblioitems.lcsort
biblioitems.lccn
biblioitems.ccode

DB version now 3.00.00.009.

Minor changes:

* Drop revision history from C4/Biblio.pm
* GetMarcAuthors now returns additional authors (7XX), not
  main authors (1XX)
* Debug warnings in C4/Search.pm commented out

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:19:56 -05:00
Henri-Damien LAURENT
8bdc7f83ac bug Fixing bugs.koha.org 1479
Porting userinterface improvements from biblios to items.

I have to port that also into serialsadditems.
Maybe there could be a way to have only one place for MARCinput management.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:28:15 -05:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
Paul POULAIN
4682f9ae39 reintroducing size for fields in addbiblio
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:10:31 -05:00
Paul POULAIN
9f58a48ef2 bugfix: parenthesis at wrong place
authorities could not be open in MARC editor

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:20:21 -05:00
16d0f61af9 Corrections to addbiblio.pl and addbiblio.tmpl for XHTML compliance; Formatting addbilbio.tmpl tabs.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-10 17:08:39 -05:00
Henri-Damien LAURENT
7f15241095 BugFixing unimarc_field_210c.pl was badly broken. It allows searches.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 18:46:09 -05:00
Paul POULAIN
e36f63bfc4 #1473: MARCfindbreeding breaks MARC21 records in reservoir
doesn't change anything for UNIMARC (as expected), UNTESTED for MARC21, pls test it

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-08 15:51:35 -05:00
Paul POULAIN
2c596cec54 1340 (querying 2 z3950 servers merged results)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-08 15:49:30 -05:00
Joshua Ferraro
3840e76192 partial 1481: adding back missing updateitem.pl script
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:59:44 -05:00
Joshua Ferraro
e494fadf0a partial 1481: adding to templates, fixing non-display of data
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:34:56 -05:00
Joshua Ferraro
a6ad58f82a partial 1481: adding back missing updateitem.pl script
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:34:46 -05:00
Joshua Ferraro
ba36be1cbc refining barcode plugin, two new options
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 01:39:11 -05:00
Joshua Ferraro
2131e1e9aa adding dateaccessioned plugin
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 01:38:49 -05:00
Paul POULAIN
40b8937717 MARC21 plugins fixed
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:54:59 -05:00
Paul POULAIN
0396492c4e 1363 (mandatory field break MARC editor)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:53:08 -05:00
Paul POULAIN
fa5acd49ea fixing upbutton that has disappeared & fixedfield condition check
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:52:30 -05:00
Paul POULAIN
421e85ad16 #1452 (Labels for item editor are truncated)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:50:24 -05:00
Henri-Damien LAURENT
1b5ae3aea5 BUG FIXING : 210$c is now searching EDITORS
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:38:15 -05:00
Joshua Ferraro
dace73a81f fix for bug 1451
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-02 20:22:34 -05:00
Henri-Damien LAURENT
eb8e666234 Bug Fixing : page changes were broken for unimarcfield_4XX.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-02 15:45:11 -05:00
Paul POULAIN
4025e6fd38 BUGFIX: we show the 1st page, that is numbered 0
Without this, the search in catalogue showed the # of results, but not the results !

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 16:03:45 -05:00
Paul POULAIN
9a1b556879 BUGFIX : create a unique div for each subfield
otherwise, when you have a repeated field, when editing biblio,
the cloneSubfield (+) button will clone the subfield in the 1st field
wherever you click !

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-27 16:32:40 -05:00
Paul POULAIN
ff9aca298d BUGFIX (unimarc specific) escaping ' in template variables in 4XX plugin
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-26 05:28:52 -05:00
Paul POULAIN
5f15ea68e8 2 BUGFIX (1 being unimarc specific) : change in plugin handling
before this commit, the main (usually $a) entry could not be entered by the librarian.
With the new BiblioAddAuthority feature, it's a bad idea : the librarian will
be able to enter a value manually, and the authority will be automatically created on the fly
Thus the small change in addbiblio.pl

This commit also fixes a bug in plugin 4XX (which is unimarc specific) :
"Empty" option did not work properly + API convention fix (biblionumber instead of bibnum)

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-26 05:28:45 -05:00
Paul POULAIN
b67d77e211 BUGFIX : repeated fields where merged on biblio update
When updating a biblio, all repeated fields had the same input name.
Thus, when retrieving them through cgi->param resulted in a single line
Thus all subfields where merged in a single MARC field.
Adding a random() part to the name solves the problem

+ removing some warn lines

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-12 20:54:31 -05:00
0f3b435b15 Removing script-specified CSS and js pointers. More markup cleanup and restructuring.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-11 16:41:39 -05:00
55bc6939ad Corrections for XHTML compliance
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-11 16:41:36 -05:00
Paul POULAIN
a201aac3c8 BUGFIX (major) : when editing an existing biblio, biblionumber was lost
In Koha 2.2 the biblionumber was an hidden field in the form,
exactly as any other subfield.
As we also stored biblionumber as specific field, it was useless to have it
twice.

with this commit, we restore the biblionumber in the MARC:Record in TransformHtml2Marc

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-04 16:35:22 -05:00
Paul POULAIN
6af15e5e9d BUGFIX : deal with repeatable values when retrieving a z3950 biblio
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-04 05:43:55 -05:00
c44f56fcac Moving </head><body> into body of templates so that js and css can be embedded per-page.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-30 15:50:54 -05:00
dc68c00c8d Testing new changes to Auth.pm to allow passing of page-specific js and css to templates
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-30 15:50:01 -05:00
3262d91a16 Modifications to enable YUI-Grids layout structure. Unfinished.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-28 16:50:42 -05:00
Henri-Damien LAURENT
61efebb7e7 Adding new feature : creating authorities on-the-fly.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-23 15:14:22 -05:00