The display sorted by code, resulting in nonsensical order
for the users, who don't know or see the codes. Note,
this data should come from GetBranchesLoop, when that
function is availabled (from a separate patch).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allow arguments to be specified in the negative (i.e. 0).
Allow function to be called with no arguments.
This supercedes the patch titled:
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Warnings enabled, comparison adjusted to accomodate undef.
Hardcoded CGI::scrolling_list removed.
Sort order on item types corrected. Unused dependencies commented out.
GetBranchesLoop used instead of copy/paste code.
NOTE: CSV output is not fixed by this patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Advances search limit by shelving location doesn't work due to
missing ccl definition in default installation. Once updated,
the zebradb will need to be reindexed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch only fix a "security" failure that permit a user to renew his loan using directly the opac-renew.pl url.
Now, we check that opacrenewalallowed is set to on to permit the renewal in opac.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch was not fully tested because the actual behavior intended
by constraints 'o' and 'e' was apparently never implemented here.
But it had no chance of success as with:
my $sth = $dbh->prepare("");
This uses the inteneded query, removes unneeded $sth->finish calls and
fixes *some* redeclaration of my $variables in the same scope, as
would be needed to run under warnings pragma.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This based on a patch by Nahuel ANGELINETTI; done to
merge changes with Mason's patch for 2951. The original
patch description is:
in the previous patch the field used for link "name" was 856$z, but the unimarc doesn't specify this, it say to use the 856$2 fi
This patch make koha to use the 856$2."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Updated the results, cart, and shelf pages to include a button
or link to initiate a hold request based on checked items.
Updated the request CGI scripts to handle multiple biblio items.
Updated the reserve confirmation page to display multiple items,
with an optional list of copies for each one.
Turned on warnings in opac/opac-reserve.pl and fixed resulting
warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fix two bugs:
* tag duplication
If you try to duplicate an autority tag, the javascript call is kept, and the id is not modified, and fields are not emptied.
* openAuth() call
The id called on duplicated fields is not the great id.
And the different values sent to auth_finder.pl to pre-fetch datas from firstname, etc... send values from all same tags, and not from the selected tag.
(cherry picked from commit 40115eb110)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch change all call to open.window that have a window identifier which contains space chars.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Adding two js functions :
getSubfieldcode(tagsubfieldid) returns the subfieldcode from tagsubfieldid
(tag_XXX_subfield_Y_WWWW_TTTT returns Y)
getTagInputnameFilter(tagsubfieldid)
(tag_XXX_subfield_Y_WWWW_TTTT returns tag_XXX_subfield_._WWWW)
I think those two functions are much useful when cataloguing.
openAuth now takes all the information for Heading search of authorities.
TODO A javascript DOM Navigation would be better.
This js works, but is surely slower than DOM would be.
Still, it seems that our DOM tree is quite hard to decode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch just fix the script which export to csv the overdue, and field the missing fields
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The bug exists because for each table line, an hidden field was set, with subscriptionid, but it's not used by the script and
create a bug "Request-URI Too Large".
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This does not fix all problems recorded in 2883 (see all the FIXME's), but
it does improve the script's basic feedback to an intelligible level.
It also adjusts the documentation and examples to correct bogus usage
instructions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Also added more feedback and the ability to override KOHA_CONF
"useldapserver" value with ENV variable KOHA_USELDAPSERVER.
This patch should be considered for inclusion to 3.0 stable branch
because it prevents unnecessary failure of test battery.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch add some codes which have been added to the norm:
* Religious Text
* dissertation or thesis
* booklet
(cherry picked from commit 673bd0d832)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This plugins need some stuffs for the users to help them to choose, like show the codes, add some codes, etc...
(cherry picked from commit 75e6ac4a03)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch is writted by Paul Poulain.
It auto-select the marcflavour from syspref in the stage marc import.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Warning would look like:
updatedatabase.pl: Use of uninitialized value in string eq
at /home/user/koha/installer/data/mysql/updatedatabase.pl line 2141.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch add a field in the ->execute() statement which was missing.
The sql request have 8 args, and only 7 was passed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch add a button in "Serial Collection" to add manually the next issue. And improve the function GetNextExpected
to retrieve at least something.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch escape the searchbox to permit to have quotes in searchs.
And make exacts search on autorities from subject tag cloud.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The current regexp used to split fiction call numbers does not handle the '.' char well. This patch corrects the regexp so that it behaves as expected.
This patch should be ported to the 3.0.x branch.
[fbcbug 5]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Following a similar patch for UNIMARC, tweak the
authtype index for MARC21 authorities if the GRS-1
Zebra filter is in use.
Note that it is recommended that *DOM* mode indexing
be used for MARC21 authorities; if you're using DOM mode,
it is not necessary to rebuild the index. However, if
you're using the GRS-1 definitions (record.abs), it will
be necessary to reindex the authority records using
misc/migration_tools/rebuild_zebra.pl -a -r
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
On authorities-home.pl page, when you do search, you don't have any
result. Looking in log file, you see a Zebra error:
Unsupported Use attribute (114) authtype Bib-1
This patch modify record.abs UNIMARC definition.
The same may have to be done for MARC21 record.abs.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
