Commit graph

247 commits

Author SHA1 Message Date
d2b9602e53 Fix for Bug 5540, editing slip news changes to librarian interface
The script checks for a language-specific OPAC message and, if none
is found, preselects none of the "display location" options. This
results in the first item in the <select> behing highlighted by
default, "Librarian interface." If we want to select "slip," we
must add an explicit check for it.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-29 20:27:43 +13:00
cb969684da Fix for Bug 5285, Show/hide columns in the output of items in batch operations
Also adds title/author information to output of batch deletions

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-13 09:45:30 +13:00
Liz Rea
61957d07ce Bug 4935: fix for allowing authorized values to be "unset"
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-12 21:07:28 +13:00
e6ebf10bba Fix for Bug 4851 - Batch delete shouldn't show delete button if no items were found
- Adding template flag to indicate valid results (hidden or not)
 - Clarifying warning messages based on various outcomes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-03 12:47:12 +13:00
d056b2f62a bug 4451 followup - don't need /g for this replace
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 14:29:17 +13:00
3f5d9537db Fix for Bug 4451 Batch item tool can't process file with Windows line endings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-30 14:29:04 +13:00
994d6e2aac bug 4211: more fixes to suggestion letter template handling
* Now displays the correct list of fields to choose
  for suggestion letters.
* Clean up mixture of old and new column selection code
  introduced in commit 88bb1b63, thereby restoring
  the intent of the patch for bug 3522.
* Enable suggestion library to be used in suggestion
  letter templates

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-11-30 06:47:52 +13:00
Andrew Elwell
efa66f1f55 Bug 5385: POD Cleanups (part 2)
More podchecker cleanups to eliminate warnings / errors

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 10:06:56 +13:00
Andrew Elwell
9fa574f609 Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 10:06:55 +13:00
Colin Campbell
a9010530a3 Bug 5105 - Remove use of depreciated Switch module
Use of switch generates errors in perl 12 and above
Replaced uses of the Switch module by if- else constructs
Removed some mixed space+tab indentation around these where
it generated visual confusion

As of perl 10 you can use given/when constructs but this is not
supported in earlier perls.
2010-11-11 11:32:02 +13:00
1117f6920c Fix for Bug 4991, Overhaul of Calendar interface
- Put hints, key, and existing holidays into right column
- Style entry form for added clarity and consistency with other
  forms in Koha
- Change the way dynamically displayed hints are shown to better
  match existing static hints in Koha's interface
- Add branch name (instead of branch code) for clarity
- Add the ability to add and edit holiday titles (previously
  only description could be edited).
- Add links to the list of existing single-day holidays and
  exceptions which opens the calendar to that month/year

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-11-02 15:02:54 +13:00
ce5e2429db fixing various links to point to *.koha-community.org
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-21 22:08:24 -04:00
b49a0a30a1 bug 4176: remove references to unimplemented system preference MIME
The intended functionality of this system preference was never
implemented.  To avoid template changes prior to 3.2.0, put in
hard-coded string 'CSV' to (accurately) identify the type of
the output files in the affected reports.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-21 21:36:45 -04:00
8eb7e1cbf7 further correction to the invocation of unzip
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 19:55:01 -04:00
Ian Walls
1125f4f432 Tighten system call to unzip
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 19:22:41 -04:00
Colin Campbell
c02cd2cabf Bug 5205 Fix compile time warnings in tools/batchMod.pl
$dbh was declared twice
prototypes used in a subroutine that was not declared before use

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 05:59:10 -04:00
0d7a33f671 bug 3916: set another "no change" dropdwon in batch item modification
Item type drop-down in the batch item modification tool
now has its default value set to the 'no change' value.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 14:38:28 -04:00
72d7840f52 bug 3916: set final "no change" dropdwon in batch item modification
Classification source drop-down in the batch item modification tool
now has its default value set to the 'no change' value.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 13:17:32 -04:00
573ac9488f remove a bunch of unconditional debug warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 10:57:08 -04:00
Henri-Damien LAURENT
a4dab23a41 Bug3916 : Batch Modify tool overwrites branches fields
This was owed to the Item modification construction and the change in GetBranchesLoop behaviour which selects the user branch by default.
Adding a void branch selected
Changing default value to ""

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-23 22:37:44 -04:00
ef58c445d3 removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 23:30:48 -04:00
Lars Wirzenius
6a730ce7a3 Convert to UTF-8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 17:58:54 -04:00
Nahuel ANGELINETTI
5d268a83a0 (bug #4295) fix overduerules edition
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:57:18 -04:00
Paul Poulain
c2f0fb370f removing AutoCommit=0, the last item is not commited
For an unknown reason, the last item batch updated is NOT updated.
After investigating a LOT (more than 3 hours), it appears the problem comes from the AutoCommit=0
I tried to solve it, but failed. So I remove the AutoCommit=0 option.

this result in a loss of perfs, but it's not a big problem I think. OTH, now everything is updated !

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:59:15 -04:00
Paul Poulain
d0bca1bdd3 Bug Fixing batchmod.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:57:38 -04:00
Matthias Meusburger
c8bf22893e MT 2553 : Adds background job for items batch modification
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:57:04 -04:00
Matthias Meusburger
7f3df2735d MT 2269, Follow-up : Granular permissions for items batch modification and deletion
Change of permissions names
Change of branch title in guided reports
Add a "Select All / Clean All" on items selection
Add a link to item when a given item cannot be deleted

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:55:39 -04:00
Matthias Meusburger
4b027bc4c9 MT2527 : Adds default empty value for branches when batch modifying items
(so they are not modified by mistake)

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:52:17 -04:00
Matthias Meusburger
4dd2086deb MT 2269 : Do not display all the items if there is a large amount of items
Also fix the barcode not found problem (due to empty lines)

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:52:15 -04:00
Garry Collum
a8927736dc Bug 4307: Sorts library locations in inventory drop-down list.
Replacement patch for previous patch submitted.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:06:25 -04:00
Donovan Jones
44201a54e1 Bug 2505 - Add commented use warnings where missing in the tools/ directory 2010-04-21 20:26:38 +12:00
Lars Wirzenius
49e0a8fc78 Fix FSF address in directory tools/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:51 -04:00
Lars Wirzenius
9675fcb5f0 Fix wording of 'at your option' in GPL license statement
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:48 -04:00
Matthias Meusburger
0268a58e16 MT2116: Addons to the CSV export
Adds the ability to customize CSV exports through the use of a YAML file.

The following customizations are available :
  - Preprocessing
  - Postprocessing
  - Field-by-field processing

The YAML field should be stored in the tools/csv-profiles/ directory and
named after the id of the CSV profile you want to customize.
An example file is provided in that directory.
(cherry picked from commit 76655b5b94)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:51:33 -05:00
9b98fc778d bug 4169: fix item batch modification for MARC21
The MARC21 framework uses $0 for the item withdrawn status.  Because
of how the tool had marked the barcode and stocknumber as being
uneditable, this resulted in an off-by-one error, causing the wrong
item fields to be updated.

Fixed by simply not including the uneditable fields in list
of item fields that can be edited - if you can't change the barcode,
there's no point in displaying it in the list of fields.

Also fixed how the bib title/author/ISBN got displayed so that the
withdrawn column gets displayed after an item update.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
2010-02-12 15:03:00 -05:00
6672df6de8 bug 4152: fixed call to GetItemsForInventory()
Restores ability to run a report of items for inventory.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 12:45:08 -05:00
Chris Nighswonger
f86b788e3b Bugfix: Upping the byte size limit of patron images
This brings it more in line with the size limit placed on other images
uploaded for use on patron cards.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 15:11:23 -05:00
Matthias Meusburger
b40d4052b9 MT2116 : Addons to the CSV Export
Add encoding selection
Add authorised values handling
2010-01-28 15:11:55 +01:00
Matthias Meusburger
a404384b11 MT2116: Addons to the CSV export
Add user-defined headers
Add CSV, field and subfield separator selection
2010-01-28 15:11:54 +01:00
Nahuel ANGELINETTI
e75d26e794 (bug #3667) fix borrowers cleanup
This add a check of borrower expiry date, and don't delete the borrower if he's still active.
2010-01-28 15:11:49 +01:00
Chris Nighswonger
3b1d56ccb5 [4/30] Modifications to picture upload script to accommodate image sizes up to 200 X 300 pixel dimesions.
This also changes the storage image format to PNG which is lossless (an important factor when using these
images for patroncards).

NOTE: In the end, this script was *not* used for uploading images for patron cards. However, these changes
are left as an improvement upon this script which is used for patron image uploads.

This script could be greatly reduced in size by using Graphics::Magick and working along the same lines
as the upload code found in patroncards/image-manage.pl
2010-01-11 18:16:17 -05:00
Nahuel ANGELINETTI
e1c2f85c2c (bug #3791) overduerules and numeric categorycodes
this fix overduesrules.pl when library have numeric category codes.
2009-11-18 17:42:22 +01:00
Matthias Meusburger
06c5cb2cf6 MT 2269 : Granular permissions for items batch modification and deletion
Notes :
Permissions themselves were already added in commit 50ef9288606077dfc2b457db490f6fc2a5461c6c : (bug #3396)   This add batch deletion of items and fixes permissions for batch modification by Jean-André Santoni
Javascript for bolding currently selected page in tools-menu.inc enhanced to support url with parameters
2009-11-10 22:23:50 +01:00
Henri-Damien LAURENT
1f7f00b626 Adding stocknumber field to items table 2009-11-03 16:06:20 +01:00
Matthias Meusburger
b47c8d4ac9 MT 2067, Follow-up : Description for CSV export not mandatory anymore 2009-11-03 15:43:19 +01:00
Matthias Meusburger
ddf2210554 MT 2073 : Allow to have non-editable fields for item batch modification 2009-10-27 09:58:35 +01:00
Matthias Meusburger
9553788824 MT 2071, 2072 : Check that barcodes are found and that items are allowed to be deleted 2009-10-26 14:40:39 +01:00
Matthias Meusburger
b622a96305 Batch deletion of items enhancements
Separate templates
Status message after deletion
2009-10-23 17:13:43 +02:00
Matthias Meusburger
ee0b0fca49 MT 2068 : Fixed scheduling guided reports 2009-10-16 11:30:58 +02:00
Matthias Meusburger
5bd08a1d7f MT 0002070: Batch item deletion 2009-10-16 09:57:41 +02:00