Commit graph

258 commits

Author SHA1 Message Date
Ryan Higgins
dd8bc50768 Hide the payment/writeoff dropdown on lines that are credits (or forgiven).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:11 -05:00
Jesse Weaver
78d960152f fix for bug 2221: Problems with Guarantor Fields...
This patch corrects this problem, by, when a patron record is linked as a guarantor, showing that and not allowing the name to be edited. It still allows manual entry of a guarantor. It also untabifies a few places in the affected files and fixes some inconsistent names.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:27 -05:00
Jesse Weaver
0532b7deab fix for bug 2348: Cannot change patron category
This makes the code that generates the category code list loop through all six category types.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:13 -05:00
Jesse Weaver
3b6e8cbc53 fix for 2177: Barcode on checkout slip
This patch adds barcodes to the Checkouts and Overdues section of the receipt. It also removes the Overdues section if it is empty.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 20:10:03 -05:00
1e2ff18e95 More changes to update-child process. Many scripts missing necessary data for checking how to process an update-child request. Also cleaning up update-child.tmpl for formatting. Minor text change (translation problem?)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-08 18:09:38 -05:00
52c933c413 Scripts missing check for Child category type would not correctly show 'update child patron' link in toolbar.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-08 18:09:36 -05:00
Andrew Moore
3aafdf768d Bug 2176 (5/5): adding staff interface to patron messaging preferences
I added another tab to the "patron" area of the staff interface to let staff
edit patron messaging preferences.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 13:04:55 -05:00
Galen Charlton
c5ac051f70 bug 2264: do not clear patron zipcode and city
When edting only a part of the patron record (e.g.,
the library use section or the alternate address), the
zipcode and city were cleared due to an error in
form processing.  Now the city and zipcode are set
only of those fields are actually in the submitted form.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-19 20:45:54 -05:00
Galen Charlton
356e48b678 bug 2263 - transfer zipcode when selecting guarantor
The template for the guarantor search implies that
the zipcode is one of the values to be copied from
guarantor to guarantee.  Fixed so that the transfer
can actually take place.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-19 20:45:53 -05:00
Ryan Higgins
3675d88035 Fix upgrade-child: could not update child unless guarantor was defined. Also, limit upgrade path to C -> A .
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-12 16:36:50 -05:00
Ryan Higgins
fc98d228c2 Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:33 -05:00
Mason James
b461a041d0 bug-2149, added new block to C4::Letters::SendAlerts() to email 'account creation' notice, and new block in memberentry.pl to call SendAlerts().
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:11:22 -05:00
dcd12da0e0 Fix for bug 2130, "Patron Image Missing on Permissions Screen"; Correction to allow proper tab highlighting when viewing patron log.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:23 -05:00
Galen Charlton
a7ba1bb941 kohabug 2105: prevent crash on IE7
Three scripts were incorrect setting the HTTP type
header to 'utf-8' instead of something appropriate
like 'text/html' - Firefox evidentally can ignore that
mistake, but IE7 does not.

Fixed by replacing an invalid print of the HTTP header
and template output with a call to
C4::Output::output_html_with_http_headers.

Also corrected POD in C4::Auth and InstallAuth to
reflect correct use of output_html_with_http_headers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:36 -05:00
157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:32 -05:00
Henri-Damien LAURENT
9fb4a72122 Bug Fixing 1782 patch
Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:42:25 -05:00
Galen Charlton
944063b247 patron attributes - staff search and display
If ExtendedPatronAttributes is ON, patron attributes
can be displayed and edited by staff members.

The patron attributes are displayed and edited
in a new section (step 4) of the patron details page.  Each
attribute is identified by its type (including type code
and type description) and value (included value description
if the attribute is controlled by an authorised value category).

Note: if, for a repeatable attribute type, the staff member
enters multiple copies of that type with the same value, duplicates
are removed when the patron record is saved.  Also, if the type
is repeatable, a JavaScript link allows the staff member to
create new attributes of that type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:09 -05:00
Henri-Damien LAURENT
d08d9e3fb7 Addressing bug 1782
Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.

Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 05:49:27 -05:00
Ryan Higgins
f4f840da2c Small template cleanup: display library name and cat description instead of codes
in circ-menu include.  Also, change 'Default' on main login page to 'My Library'.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:54:19 -05:00
Galen Charlton
83f8e22aec renamed CheckSpecificUserPermissions to GranularPermissions
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:53:45 -05:00
Galen Charlton
0f7ed0ebb4 granular permissions - update CGI script for permissions editor
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:53:26 -05:00
be99aba949 Some formatting changes, bringing displays in circ and moremember more in line with each other
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-08 08:37:03 -05:00
afabf473f4 Removing old patronimages js check, adding missing patron image variable to script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:22:33 -05:00
5702b149c3 Fixing bug that caused all items in checked-out list to show up as overdue; Reformatting table and tweaking select all/none behavior.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:22:31 -05:00
Galen Charlton
a9f7993b3e fix errors with using today's date and format_date
This patch should reduce the occurrence of the following
message in the error log:

Illegal Date '2008-3-14' does not match 'iso' format: yyyy-mm-dd

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:21 -05:00
Galen Charlton
ba82ae3a95 fix crash when recording payment for lost item
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:15 -05:00
Galen Charlton
79c0fd029c fix crash when writing off fine that is not associated with an item
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:14 -05:00
Galen Charlton
e1c01255d5 after processing payment, redirect to patron account list
* redirecting to the account page shows operator that
  payment was recorded
* avoids a jarring transition

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:13 -05:00
Galen Charlton
4895e8f6f2 fixed another non-initialized variable in TMPL_IF EXPR
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:12 -05:00
Galen Charlton
60896f68c5 removed invalid TMPL_IF EXPR
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:42 -05:00
Ryan Higgins
bd8f90387b Add Local-use statistical patron category_type
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-10 05:27:37 -05:00
Chris Nighswonger
c767c99051 Correcting code to display patronimage correctly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-07 07:40:38 -06:00
Chris Nighswonger
6b89cda969 Completing adding patronimage upload form to patron details screen.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 06:25:13 -06:00
Chris Nighswonger
36baa63f97 First installment on adding patronimage upload form to member details view.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 06:25:11 -06:00
Chris Nighswonger
5bd4181aaa Switching CGI calls to a more Object Oriented sytax
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-28 07:58:47 -06:00
Chris Nighswonger
4f6cf28106 Adding code to default to patron-blank.png if no image exists in the
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-27 09:02:16 -06:00
Chris Nighswonger
fc3d45bb99 Adding members/patronimage.pl to retrieve patron image data from db and format for display in HTML
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:38 -06:00
QA Manager
496012c7b5 fix for bug 1836, Adding patrons fails when using cites/zipcode feature]
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-19 20:43:25 -06:00
Paul POULAIN
b0d18cfd4d Added issue date column to issues list
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-19 20:22:03 -06:00
Chris Nighswonger
c6d6f60013 More fixes for patron images
Added GetPatronImage function to Members.pm
Added code to circulation.pl, boraccount.pl, readingrec.pl, and moremember.pl to grab patron image and pass it off to the template
Corrected code in circ-menu.inc to properly display patron image.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:28 -06:00
Chris Nighswonger
3fdd6a17cf Second installment on Patron Images fixes
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:01 -06:00
Henri-Damien LAURENT
fc0ac9ea1b Adding manual datedue for renewals on moremember pages.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:18 -06:00
Chris Cormack
7d758613cf Fix for bug 1772, thanks for the bug report Arona
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:31:05 -06:00
Paul POULAIN
d02d53e85a adding dateexpiry to borrowers search result list
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-22 07:20:23 -06:00
Henri-Damien LAURENT
70a284bd1e adding syspref PatronsPerPage
PatronsPerPage stores the number of patrons to display per page.
Default is 20

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-15 15:32:29 -06:00
Ryan Higgins
d40c752671 category entry javascript fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:40:46 -06:00
Chris Cormack
7c9f045815 Fix for 1599 getting expiry date prepopulating on member entry
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 15:36:40 -06:00
Chris Cormack
552fd87fa4 Fix for bug 1686
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-09 14:50:17 -06:00
83d8e095ae Cleanup for member entry: XHTML-compliance (close inputs, ids must match labels) and translator-friendliness (can't embed TMPL_IF inside tags); Cleanup of circ and members menus; Menu context flag for readingrec.pl; Correction to Auth.pm (updatecharge -> updatecharges)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-09 14:50:02 -06:00
37090d171a Changing circ redirect to use borrowernumber instead of cardnumber: If you edited a patron's record to change their cardnumber the redirect would fail because it used the old number.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-09 14:50:01 -06:00