Commit graph

117 commits

Author SHA1 Message Date
Galen Charlton
4bf76c2d77 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:05:08 -05:00
Jesse Weaver
7da895cda7 fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:29 -05:00
Galen Charlton
b8fe6d7a1b bug 1433: use same bib when adding new subscription from details page
When viewing the subscription details page of a bib that already
has at least one subscription, clicking on the 'New Subscription'
button in the toolbar will fill in the biblionumber and title
in the new subscription form.

Clicking on the 'New Subscription' button in other context (e.g.,
when viewing the results of a search) will leave the biblionumber
and title fields unpopulated, as there is no specific bib to
use.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:15:16 -05:00
Henri-Damien LAURENT
d7a56c856e Bug fixing : 2470 Serials forgetting library
Using default values for PrepareItemrecordDisplay
It changes Biblio.pm
Adding a hash with default values to PrepareItemrecordDisplay
Usunf that API in Serials.pm and serials-edit.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 09:35:44 -05:00
Henri-Damien LAURENT
111298c5b9 Bug fix : 2361 Location was lost on subscription update
Location is now defaulted to the location of the librarian
When updating subscription, subscription branchcode is taken into account.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 08:12:12 -05:00
Paul POULAIN
80c8b5c149 bugfix for 2451 : serial recieve & barcode does exist complaint
If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.

This manage multiple errors on barcode and displays them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 08:15:29 -05:00
Joshua Ferraro
d7e117afe3 Revert "bugfix for 2451 : serial recieve & barcode does exist complaint"
This reverts commit 23b8da277b.
2008-08-05 08:12:49 -05:00
Ryan Higgins
0c66ac6702 Final patch for serials planning bugs
This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously  was reporting nothing since the js was broken).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 07:31:24 -05:00
Paul POULAIN
23b8da277b bugfix for 2451 : serial recieve & barcode does exist complaint
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:43:20 -05:00
Ryan Higgins
8393fb0a3a Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )
Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
the subscription definition, but did not affect prediction.  This patch adds two fuctions
to Serials.pm to get/set the current expected issue date (note that all date calculations
in prediction patterns are based on the current expected date, and there's only one serial
issue per subscription in the 'expected' status at any time).  Subscription editing
now allows you to edit the next expected date, but not the first acqui date (unless you
haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
This patch also updates fixes some discrepancies in irregularities / prediction display.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:04:49 -05:00
Ryan Higgins
44d1aa5eb0 Serials planning updates patch 1/3
This patch addresses usability and interface bugs in the javascript irregularity checks by
adding extra controls: 'test pattern' button (always visible) replaces the 'irregularity' link
that was previously only sometimes visible.  A 'show advanced pattern' button will display/hide the
base prediction table at any time.  A 'reset pattern' button is added.  The form may now also be submitted
even if it fails the irregularity test, as there are cases when this will result in the desired behavior.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 07:59:06 -05:00
88889f38f5 Need to pass dateformat pref to the template so tablesorter js knows how to handle sorting date column.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:50 -05:00
30efc33dba Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:47 -05:00
Chris Nighswonger
4f3df5d1d2 kohabug 2219 Corrects inconsistent use of subscription.serialsadditems column
From the bug report:

The serialsadditems syspref was ostensibly removed in DB rev 071
(http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=5c41ae54e68866f9661e853376537059f4d83f70)
in favor of a new serialsadditems column in the subscription table.

However, this removal was incomplete.  It is still created for new installations by:

installer/data/mysql/en/mandatory/sysprefs.sql
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql

and is used in

serials/serials-recieve.pl
serials/serials-edit.pl
admin/systempreferences.pl

Since the system preference was not removed from the sample data scripts, it
is necessary to add another DB rev to remove it - a user may have made a
fresh install of Koha after DB rev 071.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:07:45 -05:00
Chris Nighswonger
cdf93bffee kohabug 2380 Correcting serialitems table structure and fixing duplicate barcode check
The current serialitems table structure does not provide for a *:1 relationship with
the serial table. This causes a problem when attempting to add multiple items to a given
serial. The db throws an error when attempting to INSERT in  serialitems due to serialid.serialitems
being a unique key. A further side effect is that the marc record is updated with the
item inspite of the error. The mods to the serialitems table structure in this patch
drop serialid.serialitems as a key and make itemnumber.serialitems the primary key
creating a *:1 relationship with the serial table. This patch also makes serialid.serialitems
a foreign key referencing serialid.serial to maintain referential integrity.

Fix for duplicate barcode check

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:07:40 -05:00
Galen Charlton
c7af4a8112 (minor) remove unconditional non-error warn
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:29 -05:00
Chris Nighswonger
40f09c8166 kohabug 2150 Correcting (somewhat) the inconsistent use of autoBarcode syspref
This patch corrects somewhat the inconsistent use of the autoBarcode syspref in serials-edit.pl
It does not impliment all the possibilities currently available in the autoBarcode syspref as
there is currently no support for the js plug-in/drop-in feature in serials-edit.pl. So in this
sense, the autoBarcode syspref is still used inconsistantly here. The fix for this is recommended
for rel_3_2

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:50:23 -05:00
Andrew Moore
66c420c3d0 bug 1980: updateing calls to SimpleSearch to limit number of things returned
C4::Search::SimpleSearch was alredy patched to let you pass in the number of results you want back.
These instances were not using the new API. This patch makes all calls to SimpleSearch specify a limit.

I improved the documentation of SimpleSearch a bit to include the third returned value.

I believe there's a bug in C4::Output::pagination_bar, in that it doesn't deal well with URLs
with only one pair of parameter=value passed to it. I'm getting around this by passing in a second
pair that does nothing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 09:11:24 -05:00
Joe Atzberger
75c0bef66f Remove bad use of map in void context, exclusively for side effects!
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:20 -05:00
Ryan Higgins
fc98d228c2 Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:33 -05:00
paul
7be6d1f12b IMPROVEMENT : serialsadditems at subscription level (bump 071)
The patch update the DB by adding a row in the subscription table (serialsadditems), that is filled with the value of the syspref.
then, the syspref is deleted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:34:33 -05:00
Chris Nighswonger
9b47b82a77 Porting SimpleSearch return changes to all code calling it.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-17 05:52:45 -05:00
Paul POULAIN
e30d1d6844 bugfix : independantbranches behaviour
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:55:50 -05:00
Paul POULAIN
f5674f953a reintroducing the limit on itemtype when searching a biblio in subscription add
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:56 -05:00
Paul POULAIN
fa4cead909 reintroducing history manual modification feature
The history start date and enddate is also useful to modify manually for the same reason : your serial collection may be older than your Koha serial management.

This commit reintroduce the feature.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:52 -05:00
Galen Charlton
9222f7a6ca created old_issues and old_reserves tables
The new tables have the same structure and constraints
as the tables they archive with the following exceptions:

* borrowernumber and biblionumber in old_reserves can be
  NULL
* the FK constraints (e.g., for itemnumber) on old_reserves
  set the child column to NULL if the parent row is deleted
  instead of deleting the child row.
* there is no FK constraint on old_issues.branchcode, allowing
  a branch to be deleted without changing archived requests.

Some miscellaneous cleanup was done as part of this patch:

* GetMemberIssuesAndFines (C4::Members) now uses bind variables
* fixed POD for GetMemberIssuesAndFines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:31 -05:00
Ryan Higgins
dd3c971aaa Date format fix for serials irregularities.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-18 19:30:42 -06:00
Ryan Higgins
fd65fcc365 fix record->field call on autobarcode
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 15:36:18 -06:00
Ryan Higgins
f98e567b57 Populate serialitems table, bugfix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 13:45:19 -06:00
Ryan Higgins
d7821250aa Some templating for serials.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:46 -06:00
Ryan Higgins
3de59aba27 Serials updates to link item record to serial table.
This commit makes db changes to subscription, serials tables:
  allow subscriptions larger than 127 issues
  link serial to item uniquely.
MARC Framework:
  Adding MARC tag 942$s (990$s unimarc) to map biblio.serial
Udate biblio.serial on new-subscription.
Use biblio.serial to check if Items.pm should return
  pubdate and enumeration text string from serials table with items.
Update opac-detail so serial items are sorted most recent first.
Adding link from items table to serial table.

Allows sorting of serials in details pages, and removes
enum data from itemnotes field.
Also fixes  visibility in serials item editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:45 -06:00
Ryan Higgins
ccadef4372 set of serials fixes to subscriptions
fix zeroes in enddate field and backwards public v nonpublic notes
do not allow modification of free-text subscription history
changing terms from supplier to vendor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:42 -06:00
Mason James
ee5c60cc2d BUG 1580, subscription irregularities and volume type, not passed when editing subscription
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-04 08:06:08 -06:00
Galen Charlton
0c087b87ef replaced incorrect '=>' with '='
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:22:19 -06:00
Galen Charlton
8e41022b0d item rework: moved various accessor functions
Moved following functions from C4::Biblio to
C4::Items:

    GetItemStatus
    GetItemLocation
    GetLostItems
    GetItemsForInventory
    GetItemsCount
    GetItemInfosOf
    GetItemsByBiblioitemnumber
    GetItemsInfo
    get_itemnumbers_of

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:25:05 -06:00
Galen Charlton
c6c8e80a73 start of BIB change -- introduce C4::Items
Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:12 -06:00
Mason James
2b16d7a083 padding Add_Delta_Days date, again.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 00:32:51 -06:00
Mason James
0e0586c264 BUGFIX padding add_delta_days() date
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 00:32:50 -06:00
Paul POULAIN
6a924eb363 reintroducing lateissues-excel
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:09:37 -06:00
Joshua Ferraro
a602c6d6eb cleanup for serials and members for Dates 2007-12-04 19:03:35 -06:00
Joe Atzberger
a5746c616a serials subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:07 -06:00
Henri-Damien LAURENT
eec6b41c3f numberingpattern was disimissed when editing a subscription
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:09:50 -06:00
Mason James
a62811200a bug 1566, enddate not showing.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:48 -06:00
Mason James
b3d218b41c bug fixed 'weeklength', not showing in subscription edit screen
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:47 -06:00
Henri-Damien LAURENT
855d9697de Bug Fixing : itemization would create undesirable items
One item was created for "unexpected" issues if the first issue was received.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 17:10:49 -06:00
Henri-Damien LAURENT
6e6f93c933 Bug fixing : irregularities were not saved. Nor were innerloops.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:21:21 -06:00
Henri-Damien LAURENT
4399daf0bd Managing Independant branches.
librarian can edit only subscriptions on branches of his or subscription with no branch now.
cannotedit is a calculated value in Mysql and transfered for process.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:27:25 -06:00
Henri-Damien LAURENT
59d80a8ce0 Removing Date::Manip
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:26:48 -06:00
Mason James
58dfd9c18e fix for 1521, boolean test for 'autobarcode' syspref fixed, and test for non-existant $marc->field before barcode subfield add
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:58:14 -05:00
Mason James
fda72bf787 if() incorrectly eval-ing syspref value 'FALSE' as true, wrapping in boolean.
if (C4::Boolean::true_p(C4::Context->preference("autoBarcode")) != 0 )

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:06:09 -05:00