21 commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
1fe1b704f9 |
Bug 22824: Fix yes/no vs 1/0
Patch generated with: perl -p -i -e 's# no: # 0: #' **/*.pref perl -p -i -e 's# yes: # 1: #' **/*.pref no must be 0 and yes must be 1! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
|||
eccc6ee715 |
Bug 27263: Link to preferences mentioned in system preference descriptions
This patch attempts to locate all references to system preference names in various system preference descriptions and link those preference names to a search for that preference. This will allow the user to easily jump between preferences which are related or depend on each other. To test, apply the patch go to Administration -> System preferences. - Open each preference category and confirm that the page loads without error. - Test any system preference links you find to confirm that they work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
|||
David Nind
|
024bb186e6 |
Bug 25630: (follow-up) Fix capitalization and terminology for system preferences
Additional capitalization, punctuation, terminolgy and improvements to text for system preferences: - Punctuation (such as full stops at the end of sentences) - Capitalization - Terminology (staff interface, use of "Don't" instead of "Do not") - Rearranged/rephrased for better readability To test: - Verify that the changes listed are consistent and make sense. - Check that on the staff interface home page that the window title says "Koha staff interface". - Verify that in system preferences the name of the tab for Staff interface displays correctly, and that clicking on it brings up the staff interface preferences. - For Patrons > CollapseFieldsPatronAddForm check that the edit and add patron form works correctly (edit a patron, add a new patron, check that labels display correctly). Staff interface home page ------------------------- - Change the page title in browser from "Koha staff client" to "Koha staff interface". Administration -------------- Google OpenID Connect: . GoogleOpenIDConnectAutoRegister: change "Don't Allow" to "Don't allow" and change "users" to "patrons". . GoogleOpenIDConnectDefaultBranch: move the input field to the end of the sentence. . GoogleOpenIDConnectDefaultCategory: move the input field to the end of the sentence. . GoogleOpenIDConnectDomain: reword to "Restrict Google OpenID Connect to domain (or subdomain of this domain): ____. Leave blank for all Google domains.". Interface options: . SendAllEmailsTo: add a full stop. Share anonymous usage statistics: . UsageStatsLibrariesInfo: change "Do not share" to "Don't share"; add a full stop; for note "Don't share" should be "No". . most preferences: for note "Don't share" should be "No" (don't share) (for preferences UsageStatsCountry, UsageStatsGeolocation, UsageStatsLibrariesInfo, UsageStatsLibraryName, UsageStatsLibraryType, and UsageStatsLibraryUrl), various edits to make more readable and consistent. Authorities ----------- General . AuthorityControlledIndicators: change "biblio field" to "bibliographic field". . AutoCreateAuthorities: change "do not generate" to "don't generate". Linker: . CatalogModuleRelink: change "Do not" to "Don't". . LinkerKeepStale: change "Do not" to "Don't". . LinkerModule: change "Default" to "default". . LinkerOptions: add a full stop. . LinkerRelink: change "Do not" to "Don't". Cataloguing ----------- Display: . MergeReportFields: change "example:" to "Example:" Exporting: . BibtexExportAdditionalFields and RisExportAdditionalFields: change "Include following" to "Include the following"; add ":" at end of sentence, change "specificy" to "specify", and add full stops at end of complete sentences. Interface: . EnableAdvancedCatalogingEditor: format NOTE in bold. Record structure: . AlternateHoldingsField: change "(This" to "(this", change "; for instance" to ", for example", remove full stop. , MarcFieldForCreatorId: format NOTE in bold. . SubfieldsToAllowForRestrictedBatchmod: change "pref" to "system preference". Circulation ----------- Batch checkout: . BatchCheckoutsValidCategories: add a full stop. Checkin policy: . CalculateFinesOnReturn: only bold "NOTE", not the whole sentence (x2). . StoreLastBorrower: change "opacreadinghistory/AnonymousPatron" to "the opacreadinghistory and AnonymousPatron". . UpdateItemLocationOnCheckin: change note "for these locations only can location and permanent_location differ," to "for these locations the location and permanent_location can differ," . UpdateNotForLoanStatusOnCheckin: change "E.g.," to "For example," Checkout policy: . AgeRestrictionMarker: change "E.g.," to ". For example," . AllFinesNeedOverride: change "system preference noissuescharge" to "the noissuescharge system preference". . AllowFineOverride: add "the" before "noissuescharge". . AllowRenewalLimitOverride: change "with respect to" to "for". . AutoRemoveOverduesRestrictions: change "Do not" to "Don't". . DefaultLongOverdueChargeValue: change "user" to "patron". . ItemsDeniedRenewal: change . "e.g.," to "For example:", format the note the same as other notes with NOTE in bold. . OnSiteCheckoutsForce: change "on-site" to "on-site checkout", "(Even" to "(even", and "user" to "patron". . RentalFeesCheckoutConfirmation: change "do not ask" to "don't ask". . RestrictionBlockRenewing: change "If patron" to "If a patron", change "Allow" and "Block" to "allow" and "block". . UseTransportCostMatrix: "Transport" to "the transport". Interface: . AllowOfflineCirculation: change "Do not enable" to "Don't enable". . ExportRemoveFields: add a full stop. . ShowAllCheckins: change "Do not show" to "Don't show". . UpdateTotalIssuesOnCirc: change "Do not" to "Don't". Interlibrary loans: . CirculateILL: add a full stop. . ILLCheckAvailability: add a full stop. Self check-in module (sci-main.pl): . SelfCheckInModule: change "module. (available" to "module (available", add a full stop. Self check-out module (sco-main.pl): . AutoSelfCheckAllowed: change "automatically login" to "automatically log in". . WebBasedSelfCheck: change "system. (available" to "system (available", add a full stop. Enhanced content ---------------- Novelist Select: . NovelistSelectStaffView: change "staff" to "staff interface". Babelthèque: . Babeltheque_url_js: rewitten . from "______ Defined the URL for the Babeltheque javascript file (eg. http://www.babeltheque.com/bw_XX.js)" . to "Use this URL for the Babelthèque javascript file: ________ (e.g. http://www.babeltheque.com/bw_XX.js)." . Babeltheque_url_update: rewritten . from "______ Defined the URL for the Babeltheque update periodically (eq. http://www.babeltheque.com/.../file.csv.bz2)." . to "Use this URL for the Babelthèque periodic update: _______ (e.g. http://www.babeltheque.com/.../file.csv.bz2)." I18N/L10N --------- . dateformat and TimeFormat: Change "Note" to "NOTE" to be consistent with other notes, change <b> tag to <strong> as it is more semantically correct. Logs ---- Debugging: . DumpTemplateVarsIntranet: change "variable" to "variables" and "staff intranet" to "staff interface". . DumpTemplateVarsOpac: change "variable" to "variables". Logging: . AuthFailureLog: add full stop. . AuthSuccessLog: add full stop. OPAC ---- Appearance: . BiblioDefaultView: change "bib" to "bibliographic". . HighlightOwnItemsOnOPAC: change ". (Non-XSLT Only)" to " (non-XSLT only).". . OpacAdditionalStylesheet: change "specified" to "specific". . OPACDisplay856uAsImage: change all options in the drop down list so they start in lowercase. . OpacHighlightedWords: change ";" to a full stop, add a full stop at the end. . OPACHoldingsDefaultSortField: add a full stop. . OpacMaxItemsToDisplay: change "user" to "patron". . OPACMySummaryHTML: change "user" to "patron". . OpacSeparateHoldings: change "user's to "patron's". . OpacStarRatings: change "user" to "patron" for the drop down option. . OPACShowUnusedAuthorities: change "Do not show" to "Don't show". . OPACUserSummary: change "user's to "patron's", change "fines" to "charges". . OPACXSLT*: change "Leave" to "leave". . Remove empty row at bottom of appearance options. Features: . OpacBrowser: change "OPAC" to "the OPAC". . OpacBrowseSearch: reword as "[Enable/Disable] interface for browsing all holdings (Elasticsearch only)." . OpacCloud: change "OPAC" to "the OPAC". . OPACDetailQRCode: change "Don't enable" to "Disable". . OPACFinesTab: change "Fines" to "charges", change "the My Accouunt" to "their account". (Should now show as "..patrons to access the charges tab on their account page on the OPAC." . OpacHoldNotes: change "Do not allow" to "Don't allow", change "users" to "patrons". . OpacResetPassword: change "users" to "patrons", add full stop. . SocialNetworks: change "in opac" to "on the OPAC". Note: Also deleted lines with # in front of them for the OpacBrowser and OpacCloud system preferences in the Policy section - these look like duplicated entries to me (previously lines 600-611). Policy: . OPACFineNoRenewalsIncludeCredits: change "users" to "patrons". Self registration and modification: . PatronSelfRegistrationConfirmEmail: change "Do not require" to "Don't require", change "users" to "patrons". . PatronSelfRegistrationEmailMustBeUnique: change "Do not consider" to "Don't consider". . PatronSelfRegistrationPrefillForm: change "Do not display and prefill" to "Don't display and prefill". Patrons ------- General: . AllowPatronToControlAutorenewal: add full stop. Notices and notifications: . EnhancedMessagingPreferences: change "Staff" to "staff". - FallbackToSMSIfNoEmail: change "Send" to "sending". Patron forms: . BorrowerUnwantedField: add full stop. . CollapseFieldsPatronAddForm: . Dropdown list changes: .. "Organization/Patron identity" => "Patron identity". .. "OPAC/Staff login" to "OPAC/Staff interface login". . Requires changes to the memberentrygen.tt - check that the add and edit form for a patron dispaly correctly: .. change "Contact" to "Contact information". .. change "Library set-up" to "Library setup". .. change "OPAC/Staff login" to "OPAC/Staff interface login". Patron relationships: . PrefillGuaranteeField: change drop down list option "Main address - street number" to "Main address - Street number" to match with format of other entries. Security: . RequireStrongPassword: change "More" to "more". Searching --------- Search form: . AdvancedSearchTypes: change "staff-side" to "staff interface". . expandedSearchOption: change "staff" to "staff interface". Serials ------- . makePreviousSerialAvailable: change "Do not make" to Don't make"; "syspref" to "system preference". . PreserveSerialNotes: change "Do not" to "Don't". . RoutingListNote: change "Include following" to "Include the following" Staff interface --------------- Tab label and link: . This tab was previously labelled "Staff client". . Change tab label on the left hand side from "Staff client" to "Staff interface". . Change URL when selected from "preferences.pl?tab=staff_client" to "preferences.pl?tab=staff_interface". . Check that the link works as expected. Appearance: . IntranetFavicon: change "Staff" to "staff". Tools ----- Reports: . NumSavedReports: change "Saved reports page" to "saved reports page". Web services ------------ IdRef: . IdRef: change "allows to request" to "allows requests for". Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
Katrin Fischer
|
c3033ae17c |
Bug 25630: Fix capitalization and terminology for Authorities and Cataloging system preferences
- Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AuthDisplayHierarchy (biblio to bibliographic) - MARCAuthorityControlField008 (p) - UNIMARCAuthorityField100 (p) - LinkerModule (c) - LinkerOptions (p) - SpineLabelShowPrintOnBibDetails (bib to bibliographic) - DefaultLanguageField008 (p) - DefaultCountryField008 (p) - SubfieldsToAllowForRestricted* (p, rephrase) - URLLinkText (added 'and items' - new with 20.05) - IntranetBiblioDefaultView (c) - MergeReportFields (rephrase) - BibtexExportAdditionalFields (marc to MARC) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
Caroline Cyr La Rose
|
772205bab5 |
Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong
Test plan: 1- Apply patch 2- Go to Administration > Global system preferences > Authorities 3- The path to merge_authorities.pl in the AuthorityMergeLimit description should now read misc/cronjobs/merge_authorities.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
Katrin Fischer
|
a83bc8ca4c |
Bug 12258: (QA follow-up) Add some missing rrrrrrs
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21158 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> |
||
Caroline Cyr La Rose
|
380f1dcbf8 |
Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required
This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. Followed test plan and patch is as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=12258 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> |
||
Zoe Bennett
|
6b8218ee2f |
Bug 19833: Changing the "biblios" - most of admin
To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt Corrected a single capitalization error during signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> |
||
73c9053006 |
Bug 14769: Add preference AuthorityControlledIndicators
Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
|||
4e31223aa0 |
Bug 18554: Adjust a few typos including responsability
typo responsability typo defautl in authorities.pref typo reveived in t/db_dependent/Acquisition.t typo ;; in advance_notices.pl typo Stopping in restart_indexer (koha-indexer) typo instutitional in moremember.pl typo Corretly (Biblio.t) typo periodicy in help serials Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |
|||
7d762b1d8f |
Bug 9988: Database revision for AuthorityMergeLimit
Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Also tested sysprefs.sql on a new database. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |
|||
f9a4204ce3 |
Bug 17913: Add AuthorityMergeMode preference
Original patch from bug 5572, dating back to 2011! Amended by Marcel de Rooy January 2017. Renamed the pref. The fix on this report is based on this preference. Depending on the pref, subfields will be deleted or kept. Test plan: Run the dbrev. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |
|||
Mathieu Saby
|
68a7f7f445 |
Bug 11611: Rephrase description and examples of 5 MARC related sysprefs
This patch rephrases the description or examples of 5 sysprefs: 1/ MARCAuthorityControlField008: "MARC" -> "MARC21" 2/ itemcallnumber: "Examples" -> "Examples (for MARC21 records)" 3/ DefaultLanguageField008: "Range 35-37" -> "Range 35-37 of MARC21 records" 4/ MARCOrgCode: "new MARC records" -> "new MARC21 records" 5/ UNIMARCAuthorityField100 description: "Do NOT include the date (position 00-05)." -> "position 08-35. Do NOT include the date (position 00-07)." It also adds description in SQL systempreferences table for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode. Test plan: - Apply and run updatedatabase.pl - Check the changes are taken into account in syspref administration page - Check the changes are taken into account in systempreferences table (for UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> |
||
Vitor FERNANDES
|
2b5067b0f9 |
BUG 9145: Authorities: standard language for UNIMARC
New Authority system preference created UNIMARCAuthorityField100 with default value "afrey50 ba0". AuthoritiesMarc.pm uses the system preference instead of label "afrey50 ba0". Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, all tests and QA script pass. 1) Check system preference is created correctly. 2) Change pref. 3) Catalog a new authority. 4) Change framework to make 100 show in frameworks or check in the the database, that now 100 has the new defined value. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> |
||
Jared Camins-Esakov
|
83370c519c |
Bug 8523: Display auth hierarchies w/all marcflavours
This commit adds support for displaying authority hierarchies for all flavours of MARC, not just UNIMARC. Display now uses the jQuery jstree plugin, selected with the help of Owen Leonard, resulting in a much faster experience for users. Be aware that the jstree file uses tabs rather than 4-space indentation, which I left as-is so as to make it easier to integrate upstream releases in the future. To test: 1) Enable the AuthDisplayHierarchy syspref 2) Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w=g for broader terms and subfield $w=h for narrower terms) 3) View the authorities in the OPAC, noting the hierarchical view at the top of the page. This initial patch does not create bidirection linkages from unidirectional links in MARC21 authorities. This means that when moving up the authority hierarchy, lower levels will disappear. This is intentional, as the first patch is intended merely to ensure that AuthDisplayHierarchy functions the same for all marcflavours. A future patch will add a cron job to generate the bidirectional linkages, once we are sure that the hierarchy functionality for UNIMARC and MARC21/NORMARC coexists peaceably. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Resolved conflicts in updatedatabase.pl, sysprefs.sql and in one of the CSS files. Test plan: 1) Run t/AuthoritiesMarc.t New tests complete without any errors. 2) Make sure updatedatabase works correctly. Update works nicely, new system preference is also added to syspref.sql 3) Make sure new terms are translatable. Created new po files for de-DE and checked for new terms. All translations appear correctly. 4) Make sure everything works with AuthDisplayHieararchy OFF - Add authority - Edit authority - Delete authority 5) Test feature with AuthDisplayHieararchy ON - Add authority - Edit authority - Delete authority 6) Add a couple of hierarchically linked authorities Note: links have to be created in both directions Example: 151 $aGermany 551 $a Baden-Württemberg $w h 151 $aBaden-Württemberg 551 $a Konstanz $w h 551 $a Germany $w g 151 $aKonstanz 551 $a Baden-Württemberg $w g 551 $a Fürstenberg $w h 551 $a Paradies $w h 151 $a Fürstenberg 551 $a Konstanz $w g 151 $a Paradies 551 $a Konstanz $w g Tree shows up nicely above the authority record - in staff - in OPAC - on the normal view tab - on the MARC view tab 7) Checking the logs for warnings - no Javascript errors or warnings - no warnings or errors in log files |
||
Jared Camins-Esakov
|
5207699f98 |
signed off Bug 7284: Authority matching improvements
Squashed patch incorporating all previous patches (there is no functional change compared to the previous version of this patch, this patch merely squashes the original patch and follow-up, and rebases on latest master). === TL;DR VERSION === *** Installation *** 1. Run installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt1 and installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt2 2. Make sure you copy the following files from kohaclone to koha-dev: etc/zeradb/authorities/etc/bib1.att, etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml, etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl, etc/zebradb/marc_defs/marc21/authorities/koha-indexdefs-to-zebra.xsl, and etc/zebradb/marc_defs/unimarc/authorities/record.abs 3. Run misc/migration_tools/rebuild_zebra.pl -a -r *** New sysprefs *** * AutoCreateAuthorities * CatalogModuleRelink * LinkerModule * LinkerOptions * LinkerRelink * LinkerKeepStale *** Important notes *** You must have rebuild_zebra processing the zebraqueue for bibs when testing this patch. === DESCRIPTION === *** Cataloging module *** * Added an additional box to the authority finder plugin for "Heading match," which consults not just the main entry but also See-from and See-also-from headings. * With this patch, the automatic authority linking will actually work properly in the cataloging module. As Owen pointed out while testing the patch, though, longtime users of Koha will not be expecting that. In keeping with the principles of least surprise and maximum configurability, a new syspref, CatalogModuleRelink makes it possible to disable authority relinking in the cataloging module only (i.e. leaving it enabled for future runs of link_bibs_to_authorities.pl). Note that though the default behavior matches the current behavior of Koha, it does not match the intended behavior. Libraries that want the intended behavior rather than the current behavior will need to adjust the CatalogModuleRelink syspref. *** misc/link_bibs_to_authorities.pl *** Added the following options to the misc/link_bibs_to_authorities.pl script: --auth-limit Only process those headings that match the authorities matching the user-specified WHERE clause. --bib-limit Only process those bib records that match the user-specified WHERE clause. --commit Commit the results to the database after every N records are processed. --link-report Display a report of all the headings that were processed. Converted misc/link_bibs_to_authorities.pl to use POD. Added a detailed report of headings that linked, did not link, and linked in a "fuzzy" fashion (the exact semantics of fuzzy are up to the individual linker modules) during the run. *** C4::Linker *** Implemented new C4::Linker functionality to make it possible to easily add custom authority linker algorithms. Currently available linker options are: * Default: retains the current behavior of only creating links when there is an exact match to one and only one authority record; if the 'broader_headings' option is enabled, it will try to link to headings to authority records for broader headings by removing subfields from the end of the heading (NOTE: test the results before enabling broader_headings in a production system because its usefulness is very much dependent on individual sites' authority files) * First Match: based on Default, creates a link to the *first* authority record that matches a given heading, even if there is more than one authority record that matches * Last Match: based on Default, creates a link to the *last* authority record that matches a given heading, even if there is more than one record that matches The API for linker modules is very simple. All modules should implement the following two functions: <get_link ($field)> - return the authid for the authority that should be linked to the provided MARC::Field object, and a boolean to indicate whether the match is "fuzzy" (the semantics of "fuzzy" are up to the individual plugin). In order to handle authority limits, get_link should always end with: return $self->SUPER::_handle_auth_limit($authid), $fuzzy; <flip_heading ($field)> - return a MARC::Field object with the heading flipped to the preferred form. At present this routine is not used, and can be a stub. Made the linking functionality use the SearchAuthorities in C4::AuthoritiesMarc rather than SimpleSearch in C4::Search. Once C4::Search has been refactored, SearchAuthorities should be rewritten to simply call into C4::Search. However, at this time C4::Search cannot handle authority searching. Also fixed numerous performance issues in SearchAuthorities and the Linker script: * Correctly destroy ZOOM recordsets in SearchAuthorities when finished. If left undestroyed, efficiency appears to approach O(log n^n) * Add an optional $skipmetadata flag to SearchAuthorities that can be used to avoid additional calls into Zebra when all that is wanted are authority records and not statistics about their use *** New sysprefs *** * AutoCreateAuthorities - When this and BiblioAddsAuthorities are both turned on, automatically create authority records for headings that don't have any authority link when cataloging. When BiblioAddsAuthorities is on and AutoCreateAuthorities is turned off, do not automatically generate authority records, but allow the user to enter headings that don't match an existing authority. When BiblioAddsAuthorities is off, this has no effect. * CatalogModuleRelink - when turned on, the automatic linker will relink headings when a record is saved in the cataloging module when LinkerRelink is turned on, even if the headings were manually linked to a different authority by the cataloger. When turned off (the default), the automatic linker will not relink any headings that have already been linked when a record is saved. * LinkerModule - Chooses which linker module to use for matching headings (current options are as described above in the section on linker options: "Default," "FirstMatch," and "LastMatch") * LinkerOptions - A pipe-separated list of options to set for the authority linker (at the moment, the only option available is "broader_headings," which is described below) * LinkerRelink - When turned on, the linker will confirm the links for headings that have previously been linked to an authority record when it runs. When turned off, any heading with an existing link will be ignored. * LinkerKeepStale - When turned on, the linker will never *delete* a link to an authority record, though, depending on the value of LinkerRelink, it may change the link. *** Other changes *** * Cleaned up authorities code by removing unused functions and adding unimplemented functions and added some unit tests. * This patch also modifies the authority indexing to remove trailing punctuation from Match indexes. * Replace the old BiblioAddAuthorities subroutines with calls into the new C4::Linker routines. * Add a simple implementation for C4::Heading::UNIMARC. (With thanks to F. Demians, 2011.01.09) Correct C4::Heading::UNIMARC class loading. Create biblio tag to authority types data structure at initialization rather than querying DB. * Ran perltidy on all changed code. *** Linker Options *** Enter "broader_headings" in LinkerOptions. With this option, the linker will try to match the following heading as follows: =600 10$aCamins-Esakov, Jared$xCoin collections$vCatalogs$vEarly works to 1800. First: Camins-Esakov, Jared--Coin collections--Catalogs--Early works to 1800 Next: Camins-Esakov, Jared--Coin collections--Catalogs Next: Camins-Esakov, Jared--Coin collections Next: Camins-Esakov, Jared (matches! if a previous attempt had matched, it would not have tried this) This is probably relevant only to MARC21 and LCSH, but could potentially be of great use to libraries that make heavy use of floating subdivisions. === TESTING PLAN === Note: all of these tests require that you have some authority records, preferably for headings that actually appear in your bibliographic data. At least one authority record must contain a "see from" reference (remember which one contains this, as you'll need it for some of the tests). The number shown in the "Used in" column in the authority module is populated using Zebra searches of the bibliographic database, so you *must* have rebuild_zebra.pl -b -z [-x] running in cron, or manually run it after running the linker. *** Testing the Heading match in the cataloging plugin *** 1. Create a new record, and open the cataloging plugin for an authority-controlled field. 2. Search for an authority by entering the "see from" term in the Heading Match box 3. Confirm that the appropriate heading shows up 4. Search for an authority by entering the preferred heading into the Main entry or Main entry ($a only) box (i.e., repeat the procedure you usually use for cataloging, whatever that may be) 5. Confirm that the appropriate heading shows up *** Testing the cataloging interface *** 6. Turn off BiblioAddsAuthorities 7. Confirm that you cannot enter text directly in an authority-controlled field 8. Confirm that if you search for a heading using the authority control plugin the heading is inserted (note, however, that this patch does not AND IS NOT INTENDED TO fix the bugs in the authority plugin with duplicate subfields; those are wholly out of scope- this check is for regressions) 9. Turn on BiblioAddsAuthorities and AutoCreateAuthorities 10. Confirm that you can enter text directly into an authority-controlled field, and if you enter a heading that doesn't currently have an authority record, an authority record stub is automatically created, and the heading you entered linked 11. Confirm that if you enter a heading with only a subfield $a that fully *matches* an existing heading (i.e. the existing heading has only subfield $a populated), the authid for that heading is inserted into subfield $9 12. Confirm that if you enter a heading with multiple subfields that *matches* an existing heading, the authid for that heading is inserted into subfield $9 13. Turn on BiblioAddsAuthorities and turn off AutoCreateAuthorities 14. Confirm that you can enter text directly into an authority-controlled field, and if you enter a heading that doesn't currently have an authority record, an authority record stub is *not* created 15. Confirm that if you enter a heading with only a subfield $a that *matches* an existing heading, the authid for that heading is inserted into subfield $9 16. Confirm that if you enter a heading with multiple subfields that *matches* an existing heading, the authid for that heading is inserted into subfield $9 17. Create a record and link an authority record to an authorized field using the authority plugin. 18. Save the record. Ensure that the heading is linked to the appropriate authority. 19. Open the record. Change the heading manually to something else, leaving the link. Save the record. 20. Ensure that the heading remains linked to that same authority. 21. Change CatalogModuleRelink to "on." 22. Open the record. Use the authority plugin to link that heading to the same authority record you did earlier. 23. Save the record. Ensure that the heading is linked to the appropriate authority. 24. Open the record. Change the heading manually to something else, leaving the link. Save the record. 25. Ensure that the heading is no longer linked to the old authority record. *** Testing link_bibs_to_authorities.pl *** 26. Set LinkerModule to "Default," turn on LinkerRelink and BiblioAddsAuthorities, and turn AutoCreateAuthorities and LinkerKeepStale off 27. Edit one bib record so that an authority controlled field that has already been linked (i.e. has data in $9) has a heading that does not match any authority record in your database 28. Run misc/link_bibs_to_authorities.pl --link-report --verbose --test (you may want to pipe the output into less or a file, as the result is quite a lot of information) 29. Look over the report to see if the headings that you have authority records for report being matched, that the heading you modified in step 2 is reported as "unlinked," and confirm that no changes were actually made to the database (to check this, look at the bib record you edited earlier, and check that the authid in the field you edited hasn't changed) 30. Run misc/link_bibs_to_authorities.pl --link-report --verbose (you may want to pipe the output into less or a file, as the result is quite a lot of information) 31. Check that the heading you modified has been unlinked 32. Change the modified heading back to whatever it was, but don't use the authority control plugin to populate $9 33. Run misc/link_bibs_to_authorities.pl --link-report --verbose --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber of the record you've been editing) 34. Confirm that the heading has been linked to the correct authority record 35. Turn LinkerKeepStale on 36. Change that heading to something else 37. Run misc/link_bibs_to_authorities.pl --link-report --verbose --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber of the record you've been editing) 38. Confirm that the $9 has not changed 39. Turn LinkerKeepStale off 40. Create two authorities with the same heading 41. Run misc/migration_tools/rebuild_zebra.pl -a -z 42. Enter that heading into the bibliographic record you are working with 43. Run misc/link_bibs_to_authorities.pl --link-report --verbose --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber of the record you've been editing) 44. Confirm that the heading has not been linked 45. Change LinkerModule to "FirstMatch" 46. Run misc/link_bibs_to_authorities.pl --link-report --verbose --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber of the record you've been editing) 47. Confirm that the heading has been linked to the first authority record it matches 48. Change LinkerModule to "LastMatch" 49. Run misc/link_bibs_to_authorities.pl --link-report --verbose --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber of the record you've been editing) 50. Confirm that the heading has been linked to the second authority record it matches 51. Run misc/link_bibs_to_authorities.pl --link-report --verbose --auth-limit="authid=${AUTH}" (replacing ${AUTH} with an authid) 52. Confirm that only that heading is displayed in the report, and only those bibs with that heading have been changed If all those things worked, good news! You're ready to sign off on the patch for bug 7284. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on latest master and squashed follow-up, 16 February 2012 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on latest master, 21 February 2012 Signed-off-by: schuster <dschust1@gmail.com> |
||
6768c72440 |
Bug 7368: Correct spelling of merge authorities job in pref file.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> |
|||
Nicole C. Engard
|
a66ae182f8 |
bug 6702 update typo in BiblioAddsAuthorities preference
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: MJ Ray <mjr@phonecoop.coop> Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> |
||
6de831da03 |
Bug 4839: Adjust default values for MARC21 authority Fixed-Length Data Elements
Currently, the default for this MARC control field is hardcoded in the plugin code of marc21_field_008_authorities.pl (two occurrences). This patch moves it into a new syspref. If this pref should not exist, the old hardcoded value is used. Authorities preference file is updated too. A warning is generated if the length of the field is not correct. Furthermore, the default for position 14 (heading use: main or added entry) should be dependent on the authority type. For CHRON_TERM, GENRE/FORM and TOPIC_TERM, it should be b (not appropriate) instead of a (appropriate). Rebased on March 17. Follow-up patch added for installation pref. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com> |
|||
Jared Camins-Esakov
|
4bc293c3aa |
Bug 5810: Subject tracings search complete subfields
This patch adds the syspref TraceCompleteSubfields. When TraceCompleteSubfields is set to "force," clicking on links in non-authority controlled subject tracings will only find other records where the entire subfields match. Leaving it at "don't force" keeps the current behavior of doing a keyword search of the subject indexes. This patch implements complete-subfield subject tracings in MARC21 XSLTs (OPAC and Staff) and all Normal mode interfaces. UNIMARC XSLTs have not been updated. This patch also adds the syspref UseAuthoritiesForTracings. When set to "Do not" tracings in the XSLT detail displays will never generate links using authority numbers, but rather use the heading strings (NB: the tracings currently use only subfield 'a' for generating links). Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jane Wagner <jwagner@ptfs.com> Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> |
||
Jesse Weaver
|
147eee0e22 |
Data files for new system preferences editor
These are the necessary data files for the new system preferences editor. They are not yet complete, but suitable for testing. |