Commit graph

393 commits

Author SHA1 Message Date
arensb
15a05e968f Updated a FIXME comment. 2002-10-16 12:45:15 +00:00
arensb
aa3a88a76c Added and updated some FIXME comments. 2002-10-16 12:44:25 +00:00
arensb
15d6ecc822 Added some FIXME comments. 2002-10-16 12:42:29 +00:00
tipaul
6d578747a9 removing Acquisition.pm
deleting unused code in biblio.pm, rewriting POD and answering most FIXME comments
2002-10-15 13:39:17 +00:00
tipaul
c4892ded4d merging arens + my modifs/bugfixes 2002-10-14 07:40:04 +00:00
finlayt
6800d04813 added small fix to UpdateReserve that fixes a bug coming from the calles from moremember.pl 2002-10-14 04:22:25 +00:00
arensb
eff606ba56 Replaced expressions of the form "$x = $x <op> $y" with "$x <op>= $y".
Thus, $x = $x+2 becomes $x += 2, and so forth.
2002-10-13 11:32:14 +00:00
arensb
24b7b9a73d Removed trailing whitespace. 2002-10-13 09:31:35 +00:00
arensb
89ed0f29f6 Removed unused finalizer. 2002-10-13 08:34:49 +00:00
arensb
fddab26c2e Deleted unused variables.
Removed trailing whitespace.
2002-10-13 08:27:49 +00:00
arensb
7197a3735b Added magic RCS comment.
Removed trailing whitespace.
2002-10-13 07:31:21 +00:00
arensb
d5c8d40e23 Deleted unused variables.
Removed trailing whitespace.
2002-10-13 06:37:54 +00:00
arensb
73bcde4fa1 Added magic RCS comment.
Added some FIXME comments explaining why I didn't write a POD.
Removed unused finalizer.
2002-10-13 06:29:37 +00:00
arensb
a3118241ed Added magic RCS comment.
Added some FIXME comments.
Added some explanatory comments.
Removed trailing whitespace.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:28:49 +00:00
arensb
c572ee3b11 Added magic RCS comment.
Added some FIXME comments.
Added some explanatory comments.
Removed trailing whitespace.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:22:48 +00:00
arensb
f96a21551d Added magic RCS comment.
Added some FIXME comments.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:20:22 +00:00
arensb
048e1fdfe1 Added magic RCS comment.
Removed a lying comment.
Removed unused global variables.
Added POD.
Added some FIXME comments.
Added some explanatory comments.
Removed unused finalizer.
2002-10-13 06:18:42 +00:00
arensb
198d27dd88 Added magic RCS string.
Added some FIXME comments.
Removed unused finalizer.
2002-10-13 06:15:08 +00:00
arensb
4779119226 Added magic RCS string.
Added a FIXME comment.
Removed unused finalizer.
2002-10-13 06:14:10 +00:00
arensb
3660bc647a Removed bogus #! line (this isn't a script!)
Removed unused global variables.
Added POD.
Added some explanatory comments.
Added some FIXME comments.
2002-10-13 06:13:23 +00:00
arensb
6e4f0b9fb7 Added magic RCS comment.
Removed declarations for nonexistent variables.
Added some FIXME comments.
Removed unused finalizer.
2002-10-13 06:12:00 +00:00
arensb
bc9257875b Added partial POD (but I don't understand reserves well enough to
continue).
Added magic RCS comment.
Added some explanatory comments.
Removed trailing whitespace.
Added some FIXME comments.
Moved comments in first column to where they wouldn't obscure the
indentation.
Removed unused finalizer.
2002-10-13 06:09:26 +00:00
arensb
3a92eb7781 Added some FIXME comments. 2002-10-13 06:05:59 +00:00
arensb
6da9869463 Added a FIXME comment. 2002-10-13 06:03:38 +00:00
arensb
118907bcdd Added some FIXME comments.
Added RCS magic comment.
Removed unused finalizer.
2002-10-13 06:03:03 +00:00
arensb
c7f9fb2b99 Added some FIXME comments. 2002-10-13 05:56:10 +00:00
arensb
3e5e5e0303 Added a partial POD.
Wrote some FIXME comments explaining why I'm not going to write any
more PODs.
Added some other FIXME comments.
2002-10-13 05:52:46 +00:00
arensb
5c91d43a43 Added some FIXME comments. 2002-10-13 05:49:13 +00:00
arensb
125a9fafcf Added some FIXME comments. 2002-10-12 07:31:35 +00:00
arensb
5ff7515d5b Turn off authentication entirely if systempreference "insecure" is set
to "yes".
2002-10-12 06:12:39 +00:00
arensb
57bc667d07 Got rid of the dependency on Set::Scalar. Yay! One fewer package that
the user has to install!
Redid the way SQL queries are built up, to make it more readable and
maintainable.
Removed a couple of unused variables.
Got rid of some un-Perl-like bogosity.
2002-10-12 05:43:03 +00:00
arensb
13d93ef115 Added a FIXME comment. 2002-10-11 13:06:52 +00:00
arensb
f981e30f4a Gutted.
Every function in this module is now obsolete. Removed just about
everything.
The name "Database" might still be reused, though the next time
something gets added, it should probably be called v2.0.
2002-10-11 12:52:11 +00:00
arensb
70d8c21450 Removed bogus unused variables at the top.
Prettified @EXPORT list.
(bug fix): Added missing semicolon.
2002-10-11 12:42:08 +00:00
arensb
70c08fd084 Replaced &requireDBI with C4::Context->dbh, thus making the "use
Database" statement unnecessary.
Fixed POD up a bit.
2002-10-11 12:40:50 +00:00
arensb
52d2d7bf92 Removed trailing whitespace that was messing up the POD. 2002-10-11 12:39:34 +00:00
arensb
cd8203d8d8 Added FIXME comment. This file is obsolete, right? 2002-10-11 12:36:44 +00:00
arensb
e744903393 Updated FIXME comment. This file is obsolete, right? 2002-10-11 12:36:26 +00:00
arensb
81ec28f127 Replaced &requireDBI with C4::Context->dbh 2002-10-11 12:34:53 +00:00
arensb
99fdc7afa0 Cleaned things up a bit. 2002-10-11 03:24:29 +00:00
arensb
61d632bf8a Removed &systemprefs. It is no longer used. 2002-10-11 03:14:51 +00:00
arensb
ddcc85bfc2 Use C4::Context->preference instead of &systemprefs or explicit SQL
calls to get an entry from the systempreferences table.
2002-10-11 03:14:03 +00:00
arensb
527fdc97e0 Made code a bit more Perl-ish. 2002-10-10 14:51:14 +00:00
tipaul
b47c3c7627 bugfixes 2002-10-10 14:48:25 +00:00
tipaul
ae8bd1dbf8 cleaning code 2002-10-10 14:47:00 +00:00
tipaul
9d31145bf2 merging 1.2 and bugfixes for auth and login 2002-10-10 10:07:34 +00:00
arensb
afa8db75fc Added some FIXMEs.
Made code more Perlish.
(bug fix): Allow whitespace in $HTTP_ACCEPT_LANGUAGE (Konqueror uses
", " as language separator).
2002-10-10 05:32:20 +00:00
arensb
657643c67d Added whitespace to make the POD work.
Added author.
2002-10-10 04:47:54 +00:00
arensb
94d2f6ea1f Added whitespace to make the POD work. 2002-10-10 04:44:28 +00:00
arensb
4c345d156a Fixed a few problems with POD. 2002-10-10 04:43:44 +00:00
arensb
d00793f8a1 Simplified references. 2002-10-10 04:42:35 +00:00
arensb
ef8cf295eb Added whitespace to make the POD work.
Removed references, added author.
2002-10-10 04:41:05 +00:00
arensb
95e2b3d1e6 Removed reference to Perl in POD. It should be obvious. 2002-10-10 04:34:51 +00:00
arensb
fa62f577cf Added whitespace to make the POD work.
Simplified references.
Added author email address.
2002-10-10 04:34:20 +00:00
arensb
668b558887 Fixed FIXMEs.
Removed reference to Perl in POD. It should be obvious.
2002-10-10 04:33:25 +00:00
arensb
9f09e01c07 Simplified references. 2002-10-10 04:32:44 +00:00
arensb
e4a482ac3d Fixed FIXMEs.
Removed reference to Perl. It should be obvious.
2002-10-10 04:32:06 +00:00
arensb
fa873de1fd Added whitespace to make the POD work.
Simplified references.
2002-10-10 04:29:39 +00:00
arensb
2f9a3a5bec Removed trailing whitespace that was breaking the POD. 2002-10-09 15:25:03 +00:00
arensb
3344f22bb7 Added POD.
Added a bunch of FIXMEs.
Trimmed trailing whitespace.
2002-10-09 14:17:49 +00:00
arensb
594987f486 Fixed missing bracket in POD. 2002-10-09 14:14:08 +00:00
arensb
99298f3d92 Added some FIXMEs. 2002-10-09 14:13:31 +00:00
arensb
7dcba2d082 Fixed FIXMEs in the POD. 2002-10-09 14:13:01 +00:00
arensb
3e7a102268 Added a couple of comments. 2002-10-09 14:04:49 +00:00
tipaul
dd1fd87846 road to 1.3.1 : viewing MARC biblio 2002-10-07 14:04:26 +00:00
arensb
fe98e2768b Removed unnecessary "use" line. 2002-10-07 00:51:55 +00:00
arensb
09fbb5e9d7 Added POD and some comments. 2002-10-07 00:51:22 +00:00
arensb
888c451d3d Added a FIXME comment. 2002-10-07 00:50:33 +00:00
arensb
21f62b0c03 Added a POD of sorts. 2002-10-07 00:48:50 +00:00
arensb
d00f624169 Added some FIXME comments. 2002-10-07 00:45:25 +00:00
arensb
695eb3b4b6 Removed unnecessary "use" line. 2002-10-07 00:44:23 +00:00
arensb
e551a3b888 Added a FIXME comment. 2002-10-07 00:35:44 +00:00
arensb
acaffcf53e Added POD and some comments. 2002-10-07 00:34:24 +00:00
arensb
f32b071f5c Fixed typo in synopsis. 2002-10-07 00:33:50 +00:00
arensb
3d22e58550 Fixed some bogosity.
Added some FIXMEs.
2002-10-05 23:59:40 +00:00
arensb
c3a1bd7117 Replaced several prepare()/execute()/finish() sequences with do(). 2002-10-05 23:57:39 +00:00
arensb
45c739791e Added "preference" method, for fetching a single value from
systempreferences (which is all most scripts need).
2002-10-05 23:55:00 +00:00
arensb
6421ecc986 Added a couple of FIXME comments. 2002-10-05 17:17:20 +00:00
arensb
ba786212eb Switched new functions to using C4::Context. 2002-10-05 16:55:09 +00:00
arensb
f0d284e6bd Removed remnants of code that read /etc/koha.conf for itself. 2002-10-05 16:48:08 +00:00
arensb
dbca39823f Merged with arensb-context branch: use C4::Context->dbh instead of
&C4Connect, and generally prefer C4::Context over C4::Database.
2002-10-05 09:44:27 +00:00
arensb
dbb94761cf Changed a function call to a class method call, and a few more anal
changes.
2002-10-03 16:15:10 +00:00
tipaul
cbd283722e pod doc adding 2002-10-03 11:31:31 +00:00
tipaul
f75126490d Extending Context.pm to add stopword management and using it in MARC-API.
First benchmarks show a medium speed improvement, which  is nice as this part is heavily called.
2002-10-03 11:28:18 +00:00
finlayt
772d5bc36c Added a field to the barcodes sql search, now it returns the holding branch as well. 2002-10-03 03:56:10 +00:00
arensb
39d7df4191 Fixed some run-time bugs, so it'll actually load. 2002-10-02 23:38:47 +00:00
arensb
64c01c3574 Fixed typos in POD. 2002-10-02 17:21:09 +00:00
arensb
f46cb5b0a3 (added) Module for reading the config file and getting access to the
database.
2002-10-02 17:12:04 +00:00
tipaul
0d150edefe road to 1.3.1 2002-10-02 16:26:44 +00:00
tipaul
3c30f8b69e templating modifications to rspect finlay structure 2002-10-02 16:26:14 +00:00
arensb
fbd7f81044 Added an incomplete POD, as well as some FIXME comments (which, as it
turns out, might not be necessary after all).
2002-10-01 13:22:02 +00:00
arensb
048d545d11 Added some FIXME comments, mostly marking duplicate functions. 2002-10-01 11:48:51 +00:00
arensb
b5c2a888be Added some FIXME comments. 2002-09-28 04:58:18 +00:00
arensb
780b60f0d3 Added POD.
Removed extraneous trailing whitespace.
2002-09-28 04:56:26 +00:00
finlayt
13e7c898df Added the possiblity of deleting waiting reservesm or setting them back to not waiting.
uses UpdateReserve now, instead of updatereserves from Reserves2.pm
2002-09-27 05:21:44 +00:00
tipaul
3120194e94 long WAS the road to 1.3.0...
coming VERY SOON NOW...
modifying installer and buildrelease to update the DB
2002-09-24 13:49:26 +00:00
arensb
5087f3d208 Added POD. 2002-09-23 13:53:18 +00:00
arensb
ca2aba8788 Added POD.
Removed unnecessary trailing whitespace.
2002-09-23 13:52:38 +00:00
arensb
4478773b2d Fixed missing bit in POD. 2002-09-23 13:50:30 +00:00
arensb
a26ac73061 Fixed missing bits in POD. 2002-09-23 13:49:46 +00:00
arensb
4d8413ab87 Added POD.
Added some FIXME comments.
Removed useless trailing whitespace.
2002-09-22 17:29:17 +00:00
arensb
4bddc658c2 Added some FIXME comments. 2002-09-22 16:49:20 +00:00
arensb
c09e821d8c Added POD. 2002-09-22 05:38:32 +00:00
arensb
01e1912093 Added PODs.
Removed a bunch of trailing whitespace.
Fixed &mkheadr to match the documentation.
2002-09-22 04:04:22 +00:00
arensb
cf30cc742c Removed trailing spaces, especially those interfering with the POD. 2002-09-22 00:30:35 +00:00
tipaul
973334c26a long is the road to 1.4.0
* MARCadditem and MARCmoditem now wroks
* various bugfixes in MARC management
!!! 1.3.0 should be released very soon now. Be careful !!!
2002-09-20 12:57:46 +00:00
pate
500b95460e adding POD from Andres Arensburger 2002-09-20 12:49:47 +00:00
finlayt
70003da4ec Fixed the ordering of bibitems displayed in the request page. Most recent at top, ordered by dateaccessioned on the items table. 2002-09-19 00:24:27 +00:00
dnmeid
adf1769e43 Added getpathtotemplate-function 2002-09-17 12:42:52 +00:00
rangi
a68e85669b fixes for the ordering of the issues table in issues, and also on the
printed slip
2002-09-14 00:57:27 +00:00
tipaul
de7dfb22fc MARC API continued...
* some bugfixes
* multiple item management : MARCadditem and MARCmoditem have been added. They suppose that ALL the MARC field linked to koha-item are in the same MARC tag (on the same line of MARC file)

Note : it should not be hard for marcimport and marcexport to re-link fields from internal tag/subfield to "legal" tag/subfield.
2002-09-10 13:53:52 +00:00
finlayt
4867288671 changed the way Waiting items are transfered from returns.pl to Circ2.pm 2002-09-05 00:16:39 +00:00
finlayt
69c03f2194 Little bug fixes. 2002-09-04 22:51:39 +00:00
finlayt
f0244671c4 Bug fix in ReserveWaiting to make sure only the record found is marked waiting. 2002-09-04 22:31:06 +00:00
finlayt
4d9cb5162d rewrote CheckReserves so that it can be called with a barcode as well as on itemnumber. 2002-08-26 22:34:29 +00:00
finlayt
816520a4a1 Fixed up the display of bibitems, implemented some restrictions on which items can be reserved. 2002-08-22 02:31:58 +00:00
finlayt
eb78ea1a41 minor changes to comments etc.... 2002-08-21 02:45:30 +00:00
finlayt
98239184b7 Fixed a bug in the reordering priorities in FillReserve and andother different bug in CheckReserves. 2002-08-21 01:31:16 +00:00
finlayt
b195ac3625 removed the printreserve routine. It has been replaced by printslip. 2002-08-20 22:40:12 +00:00
finlayt
7eab6cbfda fixed up the CheckReserves.pm routine so that it does not put Referece items into "waiting" status if there is a reserve. Also fixed a bug in detail.pl. 2002-08-19 06:29:36 +00:00
finlayt
91fc634cdd Fixed a really terrible bug! Took out the fixpriorities call in FillReserve. This is not necesary because the priorities are fixed up when the item is set to waiting in ReserveWaiting. 2002-08-15 03:31:02 +00:00
finlayt
49e2aee04c Added some red color here into the message that appears when a waiting book is attempted to be issued. 2002-08-15 03:27:28 +00:00
rangi
6f9cbbda8a Fix for last borrower for the moredetail.pl page
sCVS:
2002-08-15 02:02:40 +00:00
tonnesen
1e67687742 Added copyright statement to all .pl and .pm files 2002-08-14 18:12:50 +00:00
finlayt
7cb45abb40 added a check in the returnbook subroutine that checks to see if a book has been cancelled: i.e. that the wthdrawn field has been set to 1. 2002-08-14 05:37:07 +00:00
finlayt
3045d3aa12 Changed the ItemInfo method. if an items "itemlost" field is 2, the 'duedate' is set to "Very Overdue". If itemlost = 1, duedate is set to "Lost". 2002-07-31 01:50:06 +00:00
finlayt
c03d4f6f94 Fixxing bugs 2002-07-26 01:08:48 +00:00
finlayt
6eae239bb2 Changed FindReserves so that it gets biblioitem data if the reserve has a reserve constraint. 2002-07-25 21:41:10 +00:00
tipaul
0ae56dd011 pod documenting the API. 2002-07-25 13:40:31 +00:00
tipaul
9fb81afb85 Now, the API...
Database.pm and Output.pm are almost not modified (var test...)

Biblio.pm is almost completly rewritten.

WHAT DOES IT ??? ==> END of Hitchcock suspens

1st, it does... nothing...
Every old API should be there. So if MARC-stuff is not done, the behaviour is EXACTLY the same (if there is no added bug, of course). So, if you use normal acquisition, you won't find anything new neither on screen or old-DB tables ...

All old-API functions have been cloned. for example, the "newbiblio" sub, now has become :
* a "newbiblio" sub, with the same parameters. It just call a sub named OLDnewbiblio
* a "OLDnewbiblio" sub, which is a copy/paste of the previous newbiblio sub. Then, when you want to add the MARC-DB stuff, you can modify the newbiblio sub without modifying the OLDnewbiblio one. If we correct a bug in 1.2 in newbiblio, we can do the same in main branch by correcting OLDnewbiblio.
* The MARC stuff is usually done through a sub named MARCxxx where xxx is the same as OLDxxx. For example, newbiblio calls MARCnewbiblio. the MARCxxx subs use a MARC::Record as parameter.
The last thing to solve was to manage biblios through real MARC import : they must populate the old-db, but must populate the MARC-DB too, without loosing information (if we go from MARC::Record to old-data then back to MARC::Record, we loose A LOT OF ROWS). To do this, there are subs beginning by "ALLxxx" : they manage datas with MARC::Record datas. they call OLDxxx sub too (to populate old-DB), but MARCxxx subs too, with a complete MARC::Record ;-)

In Biblio.pm, there are some subs that permits to build a old-style record from a MARC::Record, and the opposite. There is also a sub finding a MARC-bibid from a old-biblionumber and the opposite too.
Note we have decided with steve that a old-biblio <=> a MARC-Biblio.
2002-07-24 16:11:37 +00:00
finlayt
55798ef08a commented out a warn or two... 2002-07-24 04:00:33 +00:00
finlayt
51e0e140c2 Fixed up the Print module. Added a function printslip that takes a string as an argument. It is easier to prepare the slip and then call the print function.
in circulation.pl I have moved some javascript out to the circulation-top.inc
2002-07-24 03:16:21 +00:00
finlayt
34aee13b95 fixed bug that kept asigning reserved books to the same person! 2002-07-24 03:01:17 +00:00
finlayt
4ec4fd9552 reactivated the printreserve method that is used to print a slip when a reserved book is returned. this is used in /circ/returns.pl 2002-07-23 03:32:42 +00:00
tonnesen
dd541749fb Missing bracket 2002-07-22 20:45:47 +00:00
tonnesen
b6f8a4a580 Cleaned up contents of location information 2002-07-11 05:48:01 +00:00
tonnesen
17388eccad Updates to authentications cripts. userpage.pl is the page for authenticated
users in the OPAC to set preferences, get personal information, etc.
2002-07-11 05:46:58 +00:00
tipaul
3c4ca5a444 *** empty log message *** 2002-07-10 13:58:43 +00:00
tonnesen
657685e1ac Auth.pm now caches form submissions and resubmits them if a user logs back in
after being logged out for inactivity.  Also switched from crypt passwords to
md5 passwords stored in borrowers table.  Used Digest::MD5 module.  I ain't
gonna reinvent _that_ wheel.  :)
2002-07-09 05:37:53 +00:00
tonnesen
e30b2ea968 use warnings breaks perl 5.005 2002-07-08 16:45:34 +00:00
tonnesen
1a43c68fe3 Cookie bug. 2002-07-05 20:33:23 +00:00
tonnesen
259a4873fb Auth.pm now checks the password againts a new field in the borrowers table
(password).   There is also a new "userid" field in the borrowers table.  When
a user logs in, the userid will be checked against the userid first and the
cardnumber second, so either method will work.
2002-07-05 19:56:35 +00:00
tonnesen
a66bcaa168 Minor changes to authentication routines. 2002-07-05 05:03:36 +00:00
tonnesen
bdee484019 Checks for a basic authentication userid. If found, it skips the cookie stuff.
Also now supports scripts that do not _require_ authentication, but might
display differently if they get an authenticated userid (might be useful for
opac pages, where pages could be tailored to meet a patron's preferences).
2002-07-04 21:22:21 +00:00
tonnesen
185adfbfe7 Additions to authentication scheme. Logs to /tmp/sessionlog. Will move this
to a db table.
2002-07-04 21:09:43 +00:00
tonnesen
62e0baa92a Minor changes 2002-07-04 19:42:48 +00:00
tonnesen
60a72c67fe Beginning of authentication api. Applied to shelves.pl for now as a test case. 2002-07-04 19:21:29 +00:00
tipaul
528f1b2b80 Long is the road to MARC..
Not related to MARC :
* removed HLT- empty link when no basket for a supplier (should be useful to copy this into rel-1-2 i think)
* fixed some "use of uninitialized value"
related to MARC
* changed use Acquisition to use Catalogue, new package for MARC management

For instance, nothing is done to MARC DB, but structure is modified (see Biblio.pm for details), and everything seems to work : it's still possible to use acqui, and it fills old-DB pretty good.

WARNING : if you work on main trunk, please note Acquisition.pm is NO MORE USED in /acqui/ system. Every sub in Acquisition.pm has been moved to Biblio.pm or Catalogue.pm.
2002-07-04 15:53:02 +00:00
tipaul
ec25ca4dfd bugfix from merging 2002-07-04 12:28:54 +00:00
tipaul
057fd6af5c merging 1.2 and main branches 2002-07-03 12:41:01 +00:00