Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Julian Maurice	b168f4a2e9	Bug 21395: Make perlcritic happy This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	5 years ago
Frédéric Demians	c7ec79b839	Bug 15258: Prevent unused declared variables Add a perlcritic rule to 00-perlcritic.t to prevent unused declared variable. TO TEST: - Apply the 1st patch (unit test) - Run the UT: prove -v t/00-testcritic.t - Note that several Perl script fail - Apply the 2nd patch - Run the UT, and confirm it passes. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All tests pass successful. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>	8 years ago
Chris Cormack	c77b8756f7	Updating perlcriticrc to allow Modern::Perl to suffice instead of use warnings; and use strict; http://bugs.koha-community.org/show_bug.cgi?id=6836 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>	12 years ago
Chris Cormack	7dbb966b49	Bug 6679 : Allowing eval require Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Colin Campbell	5f7b1a58f0	Bug 5485: Add script to run Test::Perl::Critic Tests are run if TEST_QA environment variable is set and Test::Perl::Critic is installed e.g. TEST_QA=1 prove =l t/00-testcritic.t Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago