Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Blou	5bc36cd672	Bug 27082: uncertainprice.pl does not handle pagination To reproduce: 1- create a basket 2- add more of 20 orders with uncertain price 3- click on uncertain price button 4- on page 1 of list, uncheck uncertain box of an order 5- click on save button 6- orders who were on page 2 are not display anymore in page uncertainprice.pl 7- return to basket view acqui/basket.pl 8- orders who were on page 2 have "rvcd" label and quantity is null The data in page 2 and beyond is not transmitted, but the code doesn't handle that. This patch makes sure that all that (empty) data is not (wrongly) processed. Sponsored by: CCSR Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	a961487d65	Bug 18177: remove aqbooksellers.booksellerurl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Jonathan Druart	0d9ff747a2	Bug 18177: remove aqbooksellers.booksellerfax Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Julian Maurice	0e73e723ef	Bug 19809: Re-allow to call Koha::Objects::find in list context and remove 'scalar' keyword in calls where it's not needed. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	6 years ago
Charlotte Cordwell	cc37c04bf3	Bug 19993: use Modern::Perl in Acquisition perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; acqui-home.pl addorder.pl basketgroup.pl basketheader.pl booksellers.pl check_budget_total.pl check_duplicate_barcode_ajax.pl edi_ean.pl edifactmsgs.pl edimsg.pl finishreceive.pl histsearch.pl invoice.pl invoices.pl neworderbiblio.pl neworderempty.pl newordersuggestion.pl ordered.pl orderreceive.pl parcel.pl parcels.pl pdfformat/layout2pages.pm pdfformat/layout2pagesde.pm pdfformat/layout3pages.pm pdfformat/layout3pagesfr.pm spent.pl supplier.pl uncertainprice.pl updatesupplier.pl z3950_search.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Corrected a single semicolon in edimsg.pl during signoff. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Stefan Berndtsson	7aad1df80c	Bug 19695: Fix another instance of ->find in list context (uncertainprice.pl) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Jesse Weaver	b29493265b	Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	8 years ago
Fridolyn SOMERS	c59e395b74	Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : <a href="link to catalog using biblionumber">[title]</a> <em>by</em> [author] – [isbn] <em>Publisher:</em> [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	10 years ago
Jonathan Druart	5c0dfe8523	Bug 13726: Make Koha::Acq::Bookseller using Koha::Object This patch create a Koha::Acquisition::Booksellers module and Koha::Acquisition::Bookseller::Contract[s] modules. All code in the acquisition module is adapted to use the CRUD methods of Koha::Object[s]. The former C4 routines are removed. Test plan: Since a lot of files are impacted by this patch, try a complete acquisition workflow and try to catch errors. Be focused on bookseller and bookseller' contacts data. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
Jonathan Druart	58c652a0fc	Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor would not be able to add a basket / add an order. Revised test plan ================= 1/ In the acquisition module create 2 vendors: 1 active and 1 inactive. 2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar), you should be able to, for both the 'active' as well as the inactive vendor : (a) add new basket (b) add order items to the basket Remark: This is wrong. You should be able to do so only for active vendor. 3/ Apply the patch 4/ Go to the links in step #2 above and select the inactive vendor you should no longer be able to: (a) add new basket (b) add order items to the basket Remark: This is the correct behaviour 5/ No change should be noted for vendor marked "active", and should be able to undertake operations 4 (a), 4 (b) and 4 (c). Remark: This is the correct behaviour. 6/ run koha qa tests tool Bug 12054: (follow-up) Inactive vendors should be inactive Don't display "add order""block and buttons if the vendor is inactive. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Mark Tompsett	63427fce60	Bug 14428: Remove C4::Input Jonathan Druart agreed that C4::Input is vestigial code that should be removed. Here is how I checked. First I found where C4::Input was used. Then, I checked what functions are in the package: just checkdigit. Then, I confirmed that checkdigit is not used at all in any acquisition, administration, or member related perl scripts. Lastly, I took a look at our supposed test file for the package. It was painfully sparse. As such, this patch removes the test file and the package file, and removes C4::Input references from these six files: - acqui/addorderiso2709.pl - acqui/basketgroup.pl - acqui/neworderempty.pl - acqui/uncertainprice.pl - admin/aqplan.pl - members/memberentry.pl NOTE: neworderempty had 3 lines of it?! Didn't anyone see that?! Here is the output of what I did to confirm this correction: mtompset@debian:~/kohaclone$ git reset --hard origin/master HEAD is now at `6e9086f` Bug 3206: (QA followup) missing comma on sysprefs.sql mtompset@debian:~/kohaclone$ git grep C4::Input C4/Input.pm:package C4::Input; #assumes C4/Input C4/Input.pm:C4::Input - Miscellaneous sanity checks C4/Input.pm: use C4::Input; acqui/addorderiso2709.pl:use C4::Input; acqui/basketgroup.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/uncertainprice.pl:use C4::Input; admin/aqplan.pl:use C4::Input; members/memberentry.pl:use C4::Input; t/Input.t: use_ok('C4::Input'); mtompset@debian:~/kohaclone$ grep sub C4/Input.pm sub checkdigit ($;$) { my $temp2 = substr($infl,$i,1); if ($rem eq substr($infl,8,1)) { } # sub checkdigit mtompset@debian:~/kohaclone$ grep checkdigit `find acqui -type f` mtompset@debian:~/kohaclone$ grep checkdigit `find admin -type f` mtompset@debian:~/kohaclone$ grep checkdigit `find members -type f` mtompset@debian:~/kohaclone$ cat t/Input.t use strict; use warnings; use Test::More tests => 1; BEGIN { use_ok('C4::Input'); } Apply this patch, and the output of git grep C4::Input will be empty. Run koha qa test tools (kind of overkill) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	469f36d38f	Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller The C4::Acquisition module should be exploded in order to add readability and maintainability to this part of the code. This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in it the code from GetBookSeller and GetBookSellerFromId. Test plan: 1/ Create a bookseller, modify it. 2/ Add contacts for this bookseller 3/ Create an order, receive it, transfer it 4/ Launch the prove command on all unit tests modified by this patch and verify that all pass. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jared Camins-Esakov	1d089b86f7	Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	4820462185	Bug 10723: Merge GetPendingOrders and SearchOrders routines In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl, acqui/parcel.pl scripts. Note: on acqui/parcel the basket filter is a search on basket name (was on basket id, which was not relevant). Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pm, no adverse bahaviors noted. All sub calls updated. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Owen Leonard	81c90ba3bf	Bug 8913 [Revised] Improve acquisitions navigation This patch adds a new menu for vendor-related pages in which vendor related "views" can be linked to: baskets, basket groups, contracts, invoices, uncertain prices. The acquisitions toolbar is pared down to vendor-related actions: New basket, contract, or vendor; edit vendor, delete vendor, receive shipment. Other small improvements have been made to other pages: corrections to breadcrumbs and title tags, adding useful links betweeen pages. Vendor menu and toolbar are added to booksellers.pl when there is only one "search result" (i.e. a vendor id is passed). - Menu appears when booksellerid variable is present - Redundant heading removed - Additional variables added to enable proper display of the toolbar - Revision corrects broken links pointed out by QA. - Revision adds check of existing baskets and subscriptions as a condition on display of the vendor delete button. TODO: Add coverage of Basket groups page. To test, navigate Acquisitions pages and test as many links and buttons as you can, confirming that nothing is broken on vendor pages, invoice pages, contract pages, uncertain price pages, etc. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass - I like this very much! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: 1) New toolbar - vendor search - no results = button to create new vendor shows - 1 result = additional new options show - more than one result = button to create new vendor shows 2) Vendor views - acq toolbar consistent with 1 result in vendor search - new tabs on the left - checked all links have the needed parameters and work correctly 3) New toolbar - different pages - Toolbar is formatted consistently - Delete vendor shows only up when it should - no baskets or subscriptions - Links work correctly Works nicely, great groundwork for further improvements. TODO Add new toolbar to (new) invoices page. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Lars Wirzenius	5f69c342de	Fix FSF address in directory acqui/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Paul Poulain	aa708232fe	partial fix for mantis #1498	15 years ago
Paul Poulain	862822283d	uncertainprices uncertainprice is set on z3950 or staged file import	15 years ago

23 Commits (4d011bd9983926488f783730ca43e98e6e07dabe)