Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	564e9ce1ee	Bug 20829: Handle non-existent barcode when linking to host item Since commit `2c9aeb9b0f` Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem $item is not defined if the barcode is invalid, we should not call method on it in that case. Test plan: - Turn on EasyAnalyticalRecords - Go to a detail page - Edit > Link to host item - Enter an invalid barcode => With the patch you get a friendly error message => Without this patch it explodes with Can't call method "itemnumber" on an undefined value at /home/vagrant/kohaclone/cataloguing/linkitem.pl line 86. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Grace Smyth	70b4176b19	Bug 19996: use Modern::Perl in cataloguing perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; addbiblio.pl addbooks.pl additem.pl linkitem.pl moveitem.pl value_builder/normarc_field_007.pl value_builder/normarc_field_008.pl value_builder/normarc_leader.pl value_builder/unimarc_field_010.pl value_builder/unimarc_field_100.pl value_builder/unimarc_field_105.pl value_builder/unimarc_field_106.pl value_builder/unimarc_field_110.pl value_builder/unimarc_field_115a.pl value_builder/unimarc_field_115b.pl value_builder/unimarc_field_116.pl value_builder/unimarc_field_117.pl value_builder/unimarc_field_120.pl value_builder/unimarc_field_121a.pl value_builder/unimarc_field_121b.pl value_builder/unimarc_field_122.pl value_builder/unimarc_field_123a.pl value_builder/unimarc_field_123d.pl value_builder/unimarc_field_123e.pl value_builder/unimarc_field_123f.pl value_builder/unimarc_field_123g.pl value_builder/unimarc_field_123i.pl value_builder/unimarc_field_123j.pl value_builder/unimarc_field_124.pl value_builder/unimarc_field_124a.pl value_builder/unimarc_field_124b.pl value_builder/unimarc_field_124c.pl value_builder/unimarc_field_124d.pl value_builder/unimarc_field_124e.pl value_builder/unimarc_field_124f.pl value_builder/unimarc_field_124g.pl value_builder/unimarc_field_125.pl value_builder/unimarc_field_125a.pl value_builder/unimarc_field_125b.pl value_builder/unimarc_field_126.pl value_builder/unimarc_field_126a.pl value_builder/unimarc_field_126b.pl value_builder/unimarc_field_127.pl value_builder/unimarc_field_128a.pl value_builder/unimarc_field_128b.pl value_builder/unimarc_field_128c.pl value_builder/unimarc_field_130.pl value_builder/unimarc_field_135a.pl value_builder/unimarc_field_140.pl value_builder/unimarc_field_141.pl value_builder/unimarc_field_210c.pl value_builder/unimarc_field_210c_bis.pl value_builder/unimarc_field_225a.pl value_builder/unimarc_field_4XX.pl value_builder/unimarc_field_686a.pl value_builder/unimarc_field_700-4.pl value_builder/unimarc_leader.pl z3950_auth_search.pl z3950_search.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Mark Tompsett	d5986c9b97	Bug 19040: Refactor GetMarcBiblio parameters Change parameters to a hashref. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks good to me. Two calls in migration_tools/22_to_30 still in old style. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Jonathan Druart	2c9aeb9b0f	Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	c840c93835	Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jared Camins-Esakov	f09e2ca27e	Bug 5528: Analytic records support Display links to parent biblios, show linked items in holdings, allow holds on linked items. This uses MARC to maintain relationships. Sponsored by the Mississippi Department of Archives and History and RapidRadio Solution. Originally developed by Savitra Sirohi and Amit Gupta at OSSLabs, with UNIMARC support added by Zeno Tajoli. Commits squashed and merge conflicts resolved by Chris Cormack from Catalyst. Respect for NORMARC and some small framework portability fixes made by Jared Camins-Esakov of C & P Bibliography Services. IMPORTANT NOTE: A bug in the 773 coding for MARC21 was corrected from the original OSS Labs code. The 773s generated by the pre-release code did not have the first indicator set to '0', which means that they were not supposed to display. Going forward, the first indicator will be set correctly, but existing records created with this code will no longer appear (they appeared before only due to another bug). To correct this, you could globally (or, to make sure you only modify records created with the Analytics tool, for records with 773$0) change the first indicator of the 773 from blank to '0'. == Background == An analytic record for an item is a more detailed, monographic biblio for an item attached to a serial record . This is often used for special issues of a journal that are released as books on their own (assigned an ISBN, as well as an ISSN/volume/issue). It is important for researchers to be able to search for these items both as issues of the serial, and as monographs. It is equally important for the library to not have duplicate item records for the item in question to have to keep synchronized. == Establishing relationships == Analytical records are connected to items belonging to parent or host bibliographic records. This can be accomplished by: * From an analytical bibliographic record linking to an host item by providing the item barcode as input * From a host item by using option "analyze", this creates a new empty bibliographic record with field 773 (MARC21) populated * Running a new CLI script that establishes a relationship between the analytical record and the host item identified by the barcode in the analytical record's 773$o (MARC21) == Connecting Records == The relationships are maintained in the MARC records, we have not used database tables at all. == MARC Representation == In MARC21/NORMARC we have used: * 773$9 to store the Koha item number of the host item * 773$0 to store the Koha biblio number of the host bibliographic record The above fields are used to display the relationships in various screens in the OPAC and the staff interface. Additionally, when populating field 773 with host item's details, we have used following MARC 21 mapping: * 'a' <= 100/110/111 $a (author main) * 'b' <= 250$a (edition) * 'd' <= 260$a, 260$b, 260$c (place, publisher, year) * 'o' <= barcode * 't' <= 245$a (title) * 'w' <= (003)001 --> if no 001 is available, we can populate biblionumber * 'x' <= 022$a (issn) * 'z' <= 020$a (isbn) In UNIMARC, this code uses: * 461$9 to store the Koha item number of the host item * 461$0 to store the Koha biblio number of the host bibliographic record When populating field 461 in UNIMARC, the following mapping is used: * 't' <= 200$a (title) == Treatment of Holds == A key requirement was to allow holds to be placed on host items from the analytical record. We have accomplished this by allowing holds on specific copies only. Biblio level holds are not allowed. This ensures that holds are placed on specific items that are relevant to the analytical record. == Deleting host items with linked analytical records == As we have not used database tables to maintain relationships, we had to use search to find out if any linked analytical records are present. If 1 or more analytical are present, we do not allow deletion of items. This is similar to what we see when we try to delete authority records. == Importing analytical records == Analytical records can be imported using bulkmarcimport or the GUI tools. The new CLI script can be executed after the import to establish relationships with host items. The script will establish relationships using the host item's barcode, the barcode must be present in 773$o of the analytical record. == What if there are two or more copies of the host item? == The current design will require that there be two host (773) fields, one for each copy. == What if there is no barcode available for the host item? == It is still possible to establish a relationship, by populating 773$9 with the host's item number. However the CLI script uses barcode in 773$o to establish relationships so it won't work where barcodes are unavailable. Also from an analytical record, it is possible to establish a relationship to a host item by providing the barcode as input, this option will not be available as well. Commits that added the following features were squashed by Chris Cormack (this is not a list of every commit): * Display links to host records from biblio detail screens * Support for UNIMARC, respecting the system preference 'marcflavor' * Support holds from the OPAC * Ability to link to items belong to host records from a analytical record * Display items belonging to host records in the moredetail page * Ability to edit items belonging to host records, also ability to delink from them * Move get host items code into a C4 routine, also calling the new routine in related perl scripts * Move host field population to a C4 routine, all changes in pl files to call new routine * Allow only specific copy holds for analytical records plus changes to use new C4 routines * Support for holds on items linked via host records * Storing bibnumber and itemnumber in subfields 0 and 9, plus other mapping changes * New command line script that establishes relationships between analytical records and host items and bibs. The script looks for host field (MARC21 773) in records, and based on barcode in subfield 'o' populates host bibnumber in subfield '0' and host itemnumber in subfield '9'. The script can be run after an import of analytical records, it can also be run in the crontab to maintain the relationships * Ability to create analytical records from items, to view linked analytics, and prevent deletion of items that have linked analytics * New template for catalogue/detail.pl (NOTE: not a new template file, just a new way of displaying analytics), template displays linked analytics and allows creation of analytical records * New zebra index for item number in host fields. This index will be used to display links to analytical records from host records * Display title of host record instead of the phrase host record * Using detail.tmpl for analytics tab instead of a new template file * Improved qualification info prepration in Prephostmarcfield * Check for linked analytics before deleting item * Display link to host record and more meaningful anchor text for edit item link * Analytical record: Unimarc index in record.abs and help in create_analytical_rel.pl * Adding a sys pref that controls display of options to create analytical relationships * Add host entry in XSLT stylesheet in staff item detail * Added host record support to OPAC detail XSLT * Adding 773$0 and 773$9 to all frameworks * Adding 773 subfields 0 and 9 to default marc framework via updatedatabase.pl * Display create analytics and used in links in catalog detail * Fixed problem where analytical records not showing in OPAC search results because GetMarcBiblio now needs a flag to add item records * Fixed problem where analytics count was set to 1 for all records, not just those with analytics * Fixed catalogue detail page not to show analytics counts if count is 0 Conflicts: installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt kohaversion.pl Co-author: Savitra Sirohi <savitra.sirohi@osslabs.biz> Co-author: Zeno Tajoli <tajoli@cilea.it> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	12 years ago
Paul Poulain	d251585f71	Bug 5718 : fix permission of moveitem = edit_items needed Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Donovan Jones	f394170ebc	Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory	14 years ago
Lars Wirzenius	5c42b6512e	Fix FSF address in directory cataloguing/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Matthias Meusburger	9f41fe64be	MT 2050, Follow-up, Fast Cataloging Adds granular permissions for cataloging Also adds a link from the circulation home to fast cataloging when fast cataloging is active	14 years ago
Matthias Meusburger	d4f06e5023	MT 1094, Following : added a test to check if we really found the item	14 years ago
Henri-Damien LAURENT	9eba7dc594	Moving item : no need for ModOrder, as the itemnumber now stays the same Conflicts solved cataloguing/moveitem.pl Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>	14 years ago
Henri-Damien LAURENT	d948e8ba42	Merge fixes and removing warnings	14 years ago
Henri-Damien LAURENT	d7d3f4f774	Moving item rather than Delete/recreate	14 years ago
Henri-Damien LAURENT	9995ff8fd1	MT 0001094, Follow-up : Enhancement : Item is moved rather than deleted and re-created	14 years ago
John Soros	2d90fb22d4	fix for 1431 point 2: orders and orders_items also moved to new biblionumber now	15 years ago
Henri-Damien LAURENT	5f8cab28d1	Move Item from one biblio to another Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago

10 Commits (4d011bd9983926488f783730ca43e98e6e07dabe)