Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Mazen Khallaf	71c1aa44a9	Bug 27486: Rename system preference delimiter to CSVDelimiter Test Plan: 1. Go to Administration 2. Go to System Preferences 3. Find 'delimiter' (note the name) 4. Apply patch 5. Repeat step 1 and 2 6. Find 'CSVDelimiter' (note the name) Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Martin Renvoize	d2e189ca1c	Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Jonathan Druart	2b90ea2cb0	Bug 17829: Move GetMember to Koha::Patron GetMember returned a patron given a borrowernumber, cardnumber or userid. All of these 3 attributes are defined as a unique key at the DB level and so we can use Koha::Patrons->find to replace this subroutine. Additionaly GetMember set category_type and description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Chris Cormack	da172a560f	Bug 18432 : Follow up - Updating to use they/them Updating to use they/them and skipping the ones changed to it Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
phette23	553ce38225	Bug 18432: code comments assume male gender Comments throughout the Koha codebase assume that all librarians or borrowers are male by using the pronoun 'he' universally. This patch changes to 'he or she' / 'him or hers'. Testing plan: - ensuring modifying tests still pass: + C4/SIP/t/06patron_enable.t + t/db_dependent/Circulation.t + t/db_dependent/Koha/Patrons.t + t/db_dependent/Reserves.t Sponsored-By: California College of the Arts No code changes detected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Jonathan Druart	b59df2bce7	Bug 17578: GetMemberDetails - Remove GetMemberDetails All the values different from the ones GetMember returned has been managed outside of GetMemberDetails. It looks safe to replace all the occurrences of GetMemberDetails with GetMember. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Marcel de Rooy	c2d63e5e4e	Bug 9892: [QA Follow-up] Typo and updated usage Corrected specifield. Updated usage statement on use of delimiter pref. Clarified the CONDITION explanation somewhat.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	6517e9c16d	Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	dbd8602280	Bug 13975: Remove compilation warning about encoding pragma deprecation Test plan: 0/ Does not apply the patch 1/ Launch the export_borrowers.pl script to export data with unicode characters % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname Use of the encoding pragma is deprecated at misc/export_borrowers.pl 7874,JOUBU,صةصةصة 2/ Apply this patch 3/ Repeat 1 % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname 7874,JOUBU,صةصةصة Note that the deprecated message is gone and the encoding is correct. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the warning (on Perl version above 5.14). And that the patch fix the warning. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Sophie Meynieux	e8b470ede4	Bug 9045 - Adding some parameters to export_borrowers.pl Followup : Adding test if results has some records and usage example for --where clause Signed-off-by: Owen Leonard <oleonard@myacpl.org> I infer from the bug comments that a proper test for this patch is to check how the script reacts if it returns no results with a --where clause, and to verify that there is a good usage example for the --where option. These are both true, so I think this passes. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: - tested -s option with \; - tested -f surname -f borrowernumber to have multiple fields specified - tested -w with "borrowernumber > 100" and similar with and without results - if no results a message is shown - tested -h shows documentation for new options Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Sophie Meynieux	74090b8d39	Bug 9045 : Adding --where parameter to filter what kind of borrowers to export and --separator to choose a specific caracter for patron export Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Tested, works as advertised. Note, to use tab character as a separater, do this: -s $'\t' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on second patch. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Julian Maurice	30ee49ddb4	Bug 8376: New script to export borrowers misc/export_borrowers.pl This script prints to standard output what is returned by GetMemberDetails in CSV format. Exported fields can be specified with option -f. If no -f option is specified, all fields are exported. Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Amended with some code to better handle bad data. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago

13 Commits (4d011bd9983926488f783730ca43e98e6e07dabe)