Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Kyle Hall	d3005a2a4c	Bug 27586: Import patrons script has a confirm switch that doesn't nothing! If the script misc/import_patrons.pl is run without "--confirm" it reports that it is "running in dry-run mode" but it is not! Test Plan: 1) Import a CSV of patrons using import_patrons.pm without the --confirm parameter 2) Note that it does actually import the patrons 3) Apply this patch 4) Note that this time the patrons are not actually imported 5) Import again with --confirm 6) Note that the patrons were actually imported this time! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Nick Clemens	6464ada6c6	Bug 23473: Allow overwrite of passwords during import To test: 1 - Have some patrons in your system 2 - Export some of their info via reports SELECT cardnumber, userid, surname, firstname, password, branchcode, categorycode 3 - Edit the file from above, changing all the password lines 4 - Import the file with overwrite 5 - Confirm passwords have not changed (run the report again and confirm the hashes are the same) 6 - Apply patch 7 - Restart all the things 8 - Check the new box on import screen to overwrite passwrods 9 - Import file again 10 - Confirm passwords have changed 11 - Signin using new password to verify the hash is the password as supplied 12 - Repeat via commandline import supplying --overwrite_passwords option 13 - Verify works as expected 14 - Prove -v t/db_dependent/Koha/Patrons/Import.t Sponsored-by: ByWater Solutions Signed-off-by: Ron Marion <ron.marion@goddard.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Colin Campbell	d9248c8802	Bug 22875: Document verbose option in import_patrons Docs did not state that verbose can be repeated or that you need more than 1 repetition to see lines that have failed To test: - Run ./import_patrons.pl -h - Verify the additional documentation for -v is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Martin Renvoize	d2e189ca1c	Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Katrin Fischer	2cf573ab34	Bug 22299: Fix typo in option of import_patrons.pl Fix typo in 'p\|preserve-extended-atributes' option of the import_patrons.pl script. To test: - Use the script to import patron data. - Verify behaviour is the same with and without the patch concerning the preserve-extended_at(t)tributes option Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Kyle M Hall	427b9a70ba	Bug 12598: Fix POD Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Jonathan Druart	2b07298991	Bug 12598: Use Pod::Usage and make the help more explicit Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Kyle Hall	c2066bcadc	Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Fix merge to master. Backport 3 updates from latest import_borrowers.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes package Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Creating objects in misc/import_patrons.pl and tools/import_borrowers.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical date types and header column parsing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598 - Rebase + backport of 16426 plus fixing 16426 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12598: catch warnings raised by import_patrons in tests Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	10 years ago