Commit graph

471 commits

Author SHA1 Message Date
636bb72702 quick spoine label followup: sysprefs
* Added missed SpineLabelAutoPrint to updatedatabase;
  this preference controls whether labels generated
  by the new quick spine label tool are printed automatically
* put SpineLabelAutoPrint and SpineLabelFormat in the
  Cataloging section of the syspref editor
* set height and width for the SpineLabelFormat textarea
  in the syspref editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
Sébastien Hinderer
1ac250ea27 bug 3440: Modifies branches script and template so that the newly added rows are taken into account.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:44:22 -04:00
38a0e22d2e Spelling correction per convention: cataloguing -> cataloging (Bug 3277)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:11:24 -05:00
Joe Atzberger
c8cbf6b5f2 Cleanup stopwords.pl and .tmpl
Remove "toggle" code and useless javascript.
Rework "SimpleSearch" to use just one argument.
Remove unnecessary dependencies.
Remove incorrectly pasted comments.
Remove queries that didn't do anything.
Enable warnings.  Use one $dbh.  Remove $sth->finish calls.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 18:00:57 -05:00
Garry Collum
f18df06e5d Bug 2889: Removed toggle variable from auth_tag_structure.pl and auth_subfields_structure.pl
Removed toggle variable from auth_tag_structure.pl and .tmpl.  Used template __odd__ in auth_tag_structure.tmpl.

Removed toggle variable from auth_subfields_structure.pl and .tmpl. Use __odd__. Removed a type in the highlight class definition. Fixed a minor xhtml error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 10:47:52 -05:00
Galen Charlton
11916ad734 followup - restore correct conditional
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 10:46:11 -05:00
Joe Atzberger
f226b02dd4 Cleanup: biblio_framework and marctagstructure
Removed unused javascript.  Enabled warnings.  Use common $dbh.
Removed sth->finish calls.  Removed toggle code.  Added row highlight where
none had been implemented.  Repaired validation error w/ mislocated input tag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:53 -05:00
Joe Atzberger
8db0cc330b Cleanup classsources.pl and .tmpl
Relatively minor cleaning.
Remove unused javascript.  Add row highlighting to both tables.  Remove conditionals where the
behavior is the same for both possibilities.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:52 -05:00
Garry Collum
7d4a962a18 Bug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl
Removed toggle variable from marc_subfields_structure.pl and marc_subfields_structure.tmpl.  Used template __odd__ variable instead.

Corrected a typo in the highlight class definition in .tmpl.

Corrected a readability issue with the description when deleting a subfield in .tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:38 -05:00
Garry Collum
7f4a8f90b0 Bug 2889: Removed toggle variable from stopwords.pl and .tmpl.
Removed toggle variable from stopwords.pl and stopwords.tmpl. Used template __odd_ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:10 -05:00
Joe Atzberger
f4ec623939 Cleanup - admin scripts
Fixed useless redirect statements that weren't even printed.
Removed unused javascript and script variables;
Removed sth->finish.  Use get instead of post on "cancel" button (no data to post).
Reduce duplicative variables (e.g. scriptname and script_name).

Many other problems are still in the scripts, including use of META-REFRESH instead of
redirect, and the whole idea of redirecting back to the same page for no valid reason.
We should be able to formulate the right response on THIS pass, not ask the browser to start over.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:07 -05:00
Garry Collum
7f28053a65 Bug 2889: Removed toggle variable from aqbudget.tmpl. Used template variable __odd__ instead.
Removed toggle variable from aqbudget.pl and aqbudget.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:58 -05:00
Garry Collum
368681f9dd Bug 2889: Removed toggle variable from categorie.pl and categorie.tmpl.
Removed toggle variable from categorie.pl and categorie.tmpl.  Used template __odd__variable in categorie.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:50 -05:00
Garry Collum
d5904a0835 Bug 2889: Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl.
Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl. Used template __odd__ variable in aqbookfund.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:47 -05:00
Joe Atzberger
dcf25a5b44 Cleanup authtypes and currency .pl and .tmpl
Removed unused javascript.  Enabled warnings.  Use common $dbh.
Removed sth->finish calls.  Removed toggle code.  Added row highlight where
none had been implemented.  Added some HTML escaping in TMPL.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:45 -05:00
Garry Collum
ccb39e40de Bug 2889: Removed toggle variables from z3950servers.pl and .tmpl
Removed toggle variables from z3950servers.pl and z3950servers.tmpl.  Used template __odd__variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:42 -05:00
Garry Collum
b776266faa Bug 2889: Added highlighting to smart-rules.tmpl
Removed unused toggle variable form smart-rules.pl and added highlighting to smart-rules.tmpl through template __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:41 -05:00
Garry Collum
0b3f75183b Bug 2889: Removed toggle variable from roadtype.pl and .tmpl.
Removed toggle variable from roadtype.pl and roadtype.tmpl.  Corrected typo in class definition in roadtype.tmpl and add highlighting through the templated __odd__ variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:39 -05:00
Garry Collum
7f555830aa Bug 2889: Removed toggle variable from itemtypes.tmpl. (resubmittal)
Removed toggle variable from itemtypes.tmpl and itemtypes.pl.  Used the __odd__ template variable instead.

Resubmittal - first patch contained a typo.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-09 09:00:29 -05:00
Galen Charlton
e92b346f89 fixed bug resulting in invalid XHTML
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:57:47 -05:00
Garry Collum
fc8b7c27bb Bug 2889: Removed toggle variable from koha2marclinks.tmpl. Used template __odd__ variable.
Removed toggle variable from koha2marclinks.tmpl and koh2marclinks.pl.  Used template __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:47:55 -05:00
Garry Collum
c09bdabaf4 Bug 2889: Removed toggle variable from currency.tmpl. Used template __odd__ instead.
Removed toggle variable from currency.tmpl and currency.pl.  Used template __odd_ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:47:53 -05:00
Galen Charlton
bea8db3072 bug 3278: move three sysprefs to Staff client tab
* viewMARC
* viewISBN
* viewLabeledMARC

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:17:04 -05:00
Joe Atzberger
c90dd8b512 Cleanup branches.pl and .tmpl
Remove entire subs that were unused.  Remove "toggle" code.
Comment out unconditional warn.
Remove inaccurate comments regarding long-fixed bugs and obsolete processes.
Remove unused variables.
Added "dialog message" div around MESSAGE8.

NOTE: all printer functions currently useless, unfixed by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-06 15:19:15 -05:00
Joe Atzberger
7bebd743d0 Cleanup cities.pl and .tmpl - major
80% of the javascript was junk.
Bad check failed on non-existant field borrowers.select_city.
Enabled warnings.  Reduced "StringSearch" to 3 lines, removed unused args and vars.
Fixed row highlighting and removed "toggle" code.  Etc.

TODO: Stop redirecting to the same page.  Instead get the correct data and show it
on THIS pass.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 17:15:05 -05:00
Galen Charlton
aaf3f9fea7 bug 2884: followup patch
[1] Restore behavior of the input field for the library
    code; when adding a new library, it should be a
    a text box; when editing an existing library,
    should be a hidden input.
[2] When user attempts to add a new library with the same
    code as that of an existing library, populate the form
    with what the user entered for the new library, not the
    values from the existing library.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:17:44 -05:00
Paul Poulain
950f753f11 fix for #2884: Add error management to branches
While trying to add a new Branch with an existing Branch code, the UI says "Library saved" instead of something such as "Please select a unique branch code".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:55:09 -05:00
Galen Charlton
ab44e2986a bug 2866: Overdues Reports - Upgrading to filter by patron extended attributes
Patch by Rick Welykochy <rick@praxis.com.au> with some squashing
by me.

Bug Report: 2866 Filtering and sorting the overdue report using patron attributes

1. Create a new system preference ?FilterBeforeOverdueReport?
2. Option to filter *before* the overdue report runs, avoiding report slowness
3. Add searchable patron attributes to the list of overdue report filters
4. Add searchable patron attributes to the sort fields on the overdue report
5. add item call number and replacement price
6. the CSV download link now returns the same
   data as the web report, rather than (inconsistently)
   trying to run the overdue_notices.pl batch job
7. always run report if requesting CSV
8. barcodes are now links
9. use item-level item type for overdue itemtype filter

Included is a new callback for searching patron attributes, similar
to circ/ysearch.pl.

The following additional bugs are fixed:

2748: Nothing is output to the .csv file for the "Overdues" circulation report

This is fixed by having circ/overdues.pl produce the CSV output directly instead
of trying to call the overdues cronjob.  The CSV output includes all of the fields
that are displayed on the web table plus the item replacement price and any extended
patron attributes.

2836: overdues.csv may contain HTML
2837: Descending sort doesn't descend on the overdues report plus other probs with report

This enhancement was sponsored by the Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:20:36 -05:00
Paul Poulain
0fdb397ec6 removing useless line (use Data::Dumper)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:02 -05:00
Galen Charlton
42b58a7e52 bug 1933: started work fixing IntranetBiblioDefaultView syspref
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:22 -05:00
Galen Charlton
a1200e6498 bug 3222: messaging preferences for patron categories
Add the ability to set the default circulation messages preferences
for a patron category.  When the EnhancedMessagingPreferences
syspref is ON, the administrator will be able to define
default patron messaging preferences for a patron category.  When
a new patron record is created (either manually or via a patron
import), the new patron's preferences will be copied from the default
for that patron's category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:52 -05:00
Garry Collum
7fe2fb0956 Bug 3245: advancedMARCeditor syspref not returning to cataloguing tab
The advancedMARCeditor system preference was not returning to the cataloguing tab after you changed its value in system preferences.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-21 15:56:10 -05:00
Galen Charlton
741af686ce bug 2770: add RenewalPeriodBase syspref for 3.2 (DB rev 032)
Reconciliation patch to add the RenewalPeriodBase system
preference, which per code by Nahuel Angelinetti changes
the process of calculating the due date after a renewal:

If RenewalPeriodBase is set to 'now', the due date is
set to the current date + the loan period.  This is the
current behavior.

If RenewalPeriodBase is set to 'date_due', the due date
is set to the due date before the renewal + the loan period.

Unless like the corresonding database update in the 3.0.x branch
(3.00.01.007), the default value of RenewalPeriodBase is set to
'now' so as not to unexpectedly change the calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 15:36:37 -05:00
Colin Campbell
e60fbf4c30 (bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:10:19 -05:00
Joe Atzberger
970fcce040 Remove duplicate assignments for $template->param(script_name)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:55 -05:00
Garry Collum
8c850ff3fe minPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorrect reference MinPasswordLength fixed. Could not find bug report.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:47:37 -05:00
Galen Charlton
46037ac61a bug 2893: tweaks to AllowNotForLoanOverride (DB rev 030)
* moved to DB rev 030
* assigned AllowNotForLoanOverride to circulation syspref category
* added a hint to the circulation operator: when the
  AllowNotForLoanOverride is ON, if the operator attempts
  to check out an item that is normally not for loan due to
  its item type or because the item is explicitly marked as
  not-for-loan, the operator is given the chance to check
  out the item anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 14:44:09 -05:00
f6aeeeb3c0 Bug 2920 Display AmazonReviews syspref in the enhanced content category
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 09:46:33 -05:00
Michael Hafen
454dd9376b New feature Number of Returned Items to Show
This adds a system preference controlled feature.  This controls how
many returned items are shown on the check-in page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 13:23:44 -05:00
Michael Hafen
7d61fd62f5 New feature ceiling Due Date.
This adds a feature and system preference: ceilingDueDate.  If this is
set to a valid ( according to dateformat syspref ) date, then calculated
due dates will be less than this date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 12:49:54 -05:00
Galen Charlton
11fef5234c fixed typos in LTFL sysprefs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:40:37 -05:00
Galen Charlton
0a8b0f44ba bug 3155 followup: tweak OPACAmazonReviews syspref
* add to enhanced content tab of syspref editor
* during upgrade, if database has OPACAmazonEnabled
  turned on, ensure that OPACAmazonReviews is on
  as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 06:08:22 -05:00
Christopher Hyde
1d4892cf1c Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified:   admin/systempreferences.pl
	modified:   installer/data/mysql/en/mandatory/sysprefs.sql
	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
	modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:34:56 -05:00
John Beppu
286c3c3a9e bug 1546 - replacing REPLACE statements
replaced REPLACE statements with a pair of INSERT and UPDATE statements.
Hopefully, these are the last ones.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:00:02 -05:00
Jane Wagner
a966c51f1a Creates a syspref & modifies template to show checked out username in OPAC
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC.  Most libraries will want
to leave this turned off!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 14:39:25 -05:00
Paul Poulain
505b6a52f3 fix for 2336
When you put a library in a group it doesn't show on the details list.  The
details list has a properties column that maybe is supposed to be used for this
since there doesn't appear to be any other use for it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:38:52 -05:00
Paul Poulain
ff931f977c fix for #908
In an list of autorised values (Parameters >autotised values), if you delete an
autorised value after confirm, you go back to the first page of the list, and
you must return manually to the page you left before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 14:58:59 -05:00
Paul Poulain
6cc99a3f1c fix for #918
In authorities, you can create frameworks like for biblio.
But in these it's impossible to delete useless fields, because when you click on
delete button, you go back to the default framework.
SO if you confirm your deletion, it delete your field in the default framework
and so in all the framwork (I think...).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 14:58:58 -05:00
Galen Charlton
1c1a0815a7 remove last reference to deprecated syspref noOPACUserLogin
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 10:42:35 -05:00
Galen Charlton
e86ae195af remove last reference to deprecated syspref NoReturnSetLost
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 08:20:55 -05:00