Commit graph

138 commits

Author SHA1 Message Date
slef
8b66c677e5 DBI call fix for bug 662 2003-12-08 14:45:30 +00:00
slef
7f1072e28f DBI call fix for bug 662 2003-12-08 14:24:55 +00:00
slef
732e834edf DBI call fix for bug 662 2003-12-08 14:14:56 +00:00
slef
c3491a735e DBI call fixes for bug 662 2003-12-08 14:08:49 +00:00
slef
a1d31b88e7 DBI fixes for bug 662 2003-12-03 12:09:44 +00:00
slef
8f6f8b99a9 DBI changes fixing bug 662 2003-12-03 12:05:40 +00:00
slef
7784d816a1 DBI fixes re bug 662. Removed worrying suggestion to use dbh->do in comments. 2003-12-03 11:51:52 +00:00
rangi
9c998cda51 Fix for bug 535, and adding the classification column to the variables
available to the template
2003-11-04 19:48:50 +00:00
rangi
d7bf28d524 Fix for bug 562 2003-09-03 19:41:22 +00:00
rangi
e6a4f80040 Another attempted fix for issuing bug, can NPL test this please.
It seems to be working ok for me
2003-08-04 01:53:55 +00:00
rangi
e0e3784e8b Fix for bug 293 2003-07-24 09:17:42 +00:00
wolfpac444
2ee3977b0e *** empty log message *** 2003-07-01 17:22:17 +00:00
plugz
878b64dadd FIX: Incorrect parameters given to function Stats::UpdateStats in
issuebook and returnbook functions
2003-06-20 12:48:09 +00:00
tipaul
a72d9621ae removing searchborrower from circ2.pm.
Already exists in Search.pm
this fixes bug #439 and improve consistency.
2003-06-05 17:03:31 +00:00
wolfpac444
00fef22485 Added "noissuescharge" parameter 2003-05-08 12:48:23 +00:00
tipaul
1a218daf74 fix : when a book is taken and marked "not returned yet", it's now marked returned and issue done. 2003-05-05 14:14:28 +00:00
tipaul
fa5d7968a2 missing " 2003-05-05 10:11:34 +00:00
tipaul
3c4012d4de fix for 191, code reindenting & some query improvment 2003-05-05 09:41:03 +00:00
rangi
76b467c900 renewbook is used by renewscript.pl
Making sure characters are escaped in the database insert
2003-04-30 22:55:54 +00:00
tipaul
22567447ce *** empty log message *** 2003-04-29 16:51:15 +00:00
tipaul
7d34ac8ec4 *** empty log message *** 2003-04-11 08:41:06 +00:00
tipaul
b9fbe0083f *** empty log message *** 2003-03-10 15:19:33 +00:00
acli
88dcb0a314 Changed the 3 "this does nothing" lines to set the flag. Is this right? 2003-02-05 07:55:42 +00:00
acli
f475af255f Implemented fixes for bug 170
1. Circ2::returnbook will throw an exception if $branch is undef
2. branch/printer-getting code is modularized into getbranch and getprinter
   with correct logic from circulation.pl (temporarily put into Circ2.pm)
3. circulation.pl and returns.pl modified to use above functions

Noted correct tab sizes for the files; returns.pl partially reformatted to
conform to the dominant correct tab size

Handle non-latin1 charsets for returns.pl
2003-02-05 06:28:56 +00:00
tonnesen
08d26bcc75 Removing ReserveWaiting call pending further discussion... 2002-10-24 20:09:29 +00:00
tonnesen
7aeb26593b Merging changes from rel-1-2 into trunk (circulation module only) 2002-10-24 18:30:17 +00:00
arensb
eff606ba56 Replaced expressions of the form "$x = $x <op> $y" with "$x <op>= $y".
Thus, $x = $x+2 becomes $x += 2, and so forth.
2002-10-13 11:32:14 +00:00
arensb
fddab26c2e Deleted unused variables.
Removed trailing whitespace.
2002-10-13 08:27:49 +00:00
arensb
d5c8d40e23 Deleted unused variables.
Removed trailing whitespace.
2002-10-13 06:37:54 +00:00
arensb
73bcde4fa1 Added magic RCS comment.
Added some FIXME comments explaining why I didn't write a POD.
Removed unused finalizer.
2002-10-13 06:29:37 +00:00
arensb
a3118241ed Added magic RCS comment.
Added some FIXME comments.
Added some explanatory comments.
Removed trailing whitespace.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:28:49 +00:00
arensb
c572ee3b11 Added magic RCS comment.
Added some FIXME comments.
Added some explanatory comments.
Removed trailing whitespace.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:22:48 +00:00
arensb
f96a21551d Added magic RCS comment.
Added some FIXME comments.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:20:22 +00:00
arensb
048e1fdfe1 Added magic RCS comment.
Removed a lying comment.
Removed unused global variables.
Added POD.
Added some FIXME comments.
Added some explanatory comments.
Removed unused finalizer.
2002-10-13 06:18:42 +00:00
arensb
198d27dd88 Added magic RCS string.
Added some FIXME comments.
Removed unused finalizer.
2002-10-13 06:15:08 +00:00
arensb
4779119226 Added magic RCS string.
Added a FIXME comment.
Removed unused finalizer.
2002-10-13 06:14:10 +00:00
arensb
70d8c21450 Removed bogus unused variables at the top.
Prettified @EXPORT list.
(bug fix): Added missing semicolon.
2002-10-11 12:42:08 +00:00
arensb
cd8203d8d8 Added FIXME comment. This file is obsolete, right? 2002-10-11 12:36:44 +00:00
arensb
99fdc7afa0 Cleaned things up a bit. 2002-10-11 03:24:29 +00:00
arensb
657643c67d Added whitespace to make the POD work.
Added author.
2002-10-10 04:47:54 +00:00
arensb
3344f22bb7 Added POD.
Added a bunch of FIXMEs.
Trimmed trailing whitespace.
2002-10-09 14:17:49 +00:00
arensb
fe98e2768b Removed unnecessary "use" line. 2002-10-07 00:51:55 +00:00
arensb
c3a1bd7117 Replaced several prepare()/execute()/finish() sequences with do(). 2002-10-05 23:57:39 +00:00
arensb
dbca39823f Merged with arensb-context branch: use C4::Context->dbh instead of
&C4Connect, and generally prefer C4::Context over C4::Database.
2002-10-05 09:44:27 +00:00
arensb
048d545d11 Added some FIXME comments, mostly marking duplicate functions. 2002-10-01 11:48:51 +00:00
rangi
a68e85669b fixes for the ordering of the issues table in issues, and also on the
printed slip
2002-09-14 00:57:27 +00:00
finlayt
4867288671 changed the way Waiting items are transfered from returns.pl to Circ2.pm 2002-09-05 00:16:39 +00:00
finlayt
eb78ea1a41 minor changes to comments etc.... 2002-08-21 02:45:30 +00:00
finlayt
49e2aee04c Added some red color here into the message that appears when a waiting book is attempted to be issued. 2002-08-15 03:27:28 +00:00
tonnesen
1e67687742 Added copyright statement to all .pl and .pm files 2002-08-14 18:12:50 +00:00
finlayt
7cb45abb40 added a check in the returnbook subroutine that checks to see if a book has been cancelled: i.e. that the wthdrawn field has been set to 1. 2002-08-14 05:37:07 +00:00
rangi
d6f9a61c7d Fixed so datelastseen is updated on the item record for every issue or return 2002-07-02 23:31:33 +00:00
tonnesen
1ac576e81b removed "use warnings" 2002-06-24 21:54:44 +00:00
tonnesen
264b8f0093 Merged changes from rel-1-2 branch version 1.21.2.1, all fixes to warnings 2002-06-20 20:10:08 +00:00
tonnesen
cb7441a537 More merges in from rel-1-2
All of the changes so far have been minor.  I did uncomment delbiblio($biblio)
in delbiblio.pl in the main branch to match delbiblio.pl in rel-1-2
2002-06-20 17:33:07 +00:00
rangi
49e2b90a8b Fix to get list of overdue items showing correctly 2002-06-13 03:16:55 +00:00
finlayt
89026ec754 Changed the issuebook routine to use the new methods from C4::Reserves2.pm 2002-06-06 02:48:53 +00:00
finlayt
a6dd1bcf44 Changed the returnbook method to use CheckReserves instead of FindReserves. 2002-05-29 05:52:12 +00:00
finlayt
970081fb49 Some small changes in transferbook: uses the new Reserves2.pm methods. 2002-05-29 04:40:15 +00:00
finlayt
fe88c2a022 Removed the "Item has been transfered" message from the returnbook2
subroutine.
2002-05-06 04:36:42 +00:00
finlayt
ca7a9d7264 Changed the error message from: There is no book with barcode: XXXXXX
to: No item with barcode: XXXXXXX
2002-05-06 04:30:37 +00:00
finlayt
9255f92b21 moredetail.pl presents circulation information taken from the
branchtransfers table

Circ2.pm has been changed a little

admin/branches.pl alows branches to be added, edited and deleted.

updatedatabase needs more fixing
2002-05-02 00:08:53 +00:00
rangi
3eecf2956e Deals with lost book charges now 2002-03-17 02:58:00 +00:00
finlayt
314e80a9e9 Added a transferbook subroutine that is called from /circ/branchtransfers.pl
It writes a new line in the branchtransfers table and changes the
currentbranch field in items.
2002-03-13 21:13:42 +00:00
rangi
79ebd030d6 Fixing reserve handling.
Mulitple copy reserves now handled correctly, and correct charges are being
applied
2001-11-25 20:17:53 +00:00
tonnesen
aa97d73b39 Typo in printf format string was causing all issues to appear in the
Previous issues box and not in today's issues.
2001-10-10 19:28:05 +00:00
rangi
9eee24c9a2 Changed the way a lost book being returned is handled.
If the book has already been paid for a credit is added to their account.
And offset against any current charges
2001-05-09 23:29:00 +00:00
rangi
f72283e23f Renewing a rental or pay item from the borrowers record screen
Now adds a charge to the borrowers account
2001-05-09 00:05:57 +00:00
tonnesen
3fd3b300c4 Added an overdue variable to the itemdata returned by the currentissues
subroutine.  This makes it easier to pick out overdue items in other
modules (ie circulation, reports, etc.)
2001-05-02 22:38:26 +00:00
rangi
4680c9e98a Fixed the code that adds a credit or wipes a lost book charge from a
borrowers account if said book is returned
2001-05-02 21:15:22 +00:00
rangi
b2c9dabcf1 Making a change to the way charges are handled, the system originally worked such that if a borrower owed more than $5 issues werent allowed. This worked fine except that often borrowers wish to borrows say 3 pay videos at $2 each, then 2 books say. The three pay videos rack up charges of $6 and then they cant issue the books until that is paid.
Reworked so that it cares about previous charges, not the ones accrued during current issue process.
2001-04-03 21:32:37 +00:00
rangi
fe1fab2ab5 Reworked layout of issues section. 2001-03-28 02:23:03 +00:00
rangi
6bd59eeef7 Little fix to the returnbook routine so the correct branchcode is passed to the updatestats routine 2001-02-18 22:13:26 +00:00
rangi
de38567887 Made some changes to checkreserve and find_reserves, so that items are always displayed as reserved when returned, not just once 2001-02-14 00:27:36 +00:00
tonnesen
ee184dc80b Added a couple of missing $dbh->disconnect lines that were logging errors
in apache log files.
2001-02-05 17:47:58 +00:00
rangi
cf3086c7da Attempting to get issues slip to print when borrower is finished with 2001-02-01 02:08:34 +00:00
rangi
74aa1d1edd Fixed a little bug in getiteminformation, it wasnt returning item loanlength 2001-01-31 22:09:31 +00:00
tonnesen
f7953fecf3 Return itemlist array, and itemlisttext (text version of overdues) with
overdue flag in getpatroninformation()
2001-01-31 18:13:38 +00:00
tonnesen
ee5ba729f3 Returns module lists recently returned items, cookies used to store branch
and printer preferences.
2001-01-26 00:17:00 +00:00
tonnesen
d389b68e6d Refined Returns module.
Added ability to select branch and printer.
Fixed charges for rental items.
2001-01-25 00:01:34 +00:00
tonnesen
eaa9677292 Changes to web circulation module: rudimentary returns module, arbitrary
due date for issues, flag info displayed, overdue books are displayed in
red.
2001-01-23 23:48:54 +00:00
tonnesen
3186e690ce Fixed a bug in issuing reserved books. Was calling non-existent
printreserve subroutine
2001-01-23 00:12:49 +00:00
tonnesen
7c52cda9d6 Started work on a web-based circulation interface. 2001-01-22 23:48:41 +00:00
tonnesen
e6d86cdd17 Added support for showing patron flags in the issues module.
Moved popup message windows to a Toplevel widget instead of a message
widget.  Toplevel widgets come up much faster than message widgets.
2001-01-17 23:45:50 +00:00
rangi
e6fb400c7d Fixing a glitch in the fines routine, was failing if adding a new fine to
the same user for the same item
2001-01-16 23:34:29 +00:00
tonnesen
e16ba0cb0a API for circulation modules 2001-01-15 19:31:41 +00:00
tonnesen
21b18bf675 Modified getbranch() and getprinter() subroutines to not pop up a menu if
there is only one branch or one printer, but just select the single option
automatically.
2001-01-05 17:39:25 +00:00
rangi
d0374d0037 Initial revision 2000-12-19 23:45:51 +00:00