Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	b1ba7fac2c	Bug 18292: Remove return 1 statements in tests The test files do not need to return 1 Patch generated with: perl -p -i -e "s/^1;\n//xsm" t/*/.t Test plan: git grep '^1;$' t/*/.t should not return any results NOTE: does not fix C4/SIP/t, nor xt tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Marcel de Rooy	eb8666357c	Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout logic to one routine (with unit test). This further implements two suggestions from Kyle and Larry: [1] You could use a client_timeout of 0 to specify no timeout at all. [2] Have the client_timeout default to the timeout if not defined. Test plan: [1] Run t/db_dependent/SIP/SIPServer.t. [2] Test login timeout for raw and telnet. [3] Check ACS status message for timeout value. Should match policy timeout from institution. [4] Test client timeout (zero and non-zero). [5] Remove client timeout. Test fallback to service. [6] Remove service timeout too. Test fallback to 30 at login. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended to incorporate Srdjan's suggestion to move get_timeout to SIPServer.pm; this requires some additional mocking in the unit test. And even makes the test db dependent, as documented. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Colin Campbell	d85f757ce7	Bug 7904 Change SIP modules to use standard LIB path For historical reasons the SIPServer and SIP modules have used an extra module path in addition to the standard Koha one. This has caused numerous irritants in attempting to set up scripts and basic tests. It does not help in attempting to modify or debug this code This patch changes the package value in the modules under the C4/SIP directory and makes calls to them use the full package name. Where the export mechanism was being short circuited routines have been explicitly exported and imported declarations of 'use ILS' when that module was not being used and which only generated warnings have been removed. As a lot of the changes affect lines where an object is instantiated with new. The opportunity has been taken to replace the ambiguous indirect syntax with the preferred direct call In intializing ILS the full path is added as this will not require any changes to existing configs. I suspect this feature is unused, and adds obfuscation rather than flexibility but have kept the feature as we need this change in order to rationalize and extend the testing of the server. The visible difference is that with the normal Koha PERL5LIB setting. Compilation of Modules under C4/SIP should be successful and not fail with unlocated modules, allowing developers to see any perl warnings All the SIP modules can now be run through the tests in t/00-load.t now except for SIPServer itself Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	fa678fa241	Bug 12753: Warnings in t/SIP_Sip.t could be tested A C4::SIP warning is expected and should be tested. To test: - Run $ prove -v t/SIP_Sip.t => FAIL: A warning is printed to STDOUT - Apply the patch - Run $ prove -v t/SIP_Sip.t => SUCCESS: No warnings on STDOUT, a new test verifying the warning is added. - It was an easy one, smile and sign off :-D Sponsored-by: The Will to Procrastinate Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Sponsored-by: Sunday TV is boring Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sponsored-by: Avoiding distance study homework Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Duncan Tyler	7876d4fa8d	Added unit tests for Sip Checksum.pm http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test passes. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	13 years ago
Colin Campbell	0d5029ec5b	Bug 5601 :: Add tests for bugfix Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Galen Charlton	7fd5071e67	bug 5327: follow-up to fix SIP tests * removed t/SIP_SIPServer.t - despite the file name, C4/SIP/SIPserver.pm is not actually a module and cannot be 'used' or 'required' * set module search path so that t/SIP_ILS.t and t/SIP_Sip.t will pass Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Katrin Fischer	e0892a5139	Bug 5327: More basic unit tests for C4 modules Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Katrin Fischer	cc9a34c274	Bug 5327: Add basic unit tests to some C4 modules Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Chris Cormack	e85b4557f9	C4::Bookfund no longer exists, removing the test	15 years ago
Joe Atzberger	a1fe32d2f8	Total Test Overhaul! Most of these were stubs, and still are. Input.t was replaced because it tested a now obsolete function. Input.pm has that function commented out. Several files were renamed to match their counterparts or correct misspellingz. Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
rangi	77618f43cf	Finishing up the last of the tests	17 years ago
rangi	ccc8db346d	More test files	17 years ago
rangi	07b3e3c952	Continuing to add tests	17 years ago
rangi	07902f96e8	Working on unit tests	17 years ago

2 Commits (55f2279314edf390e6257942a84f9f9b058c84cf)