Koha-community/Koha - Koha: The world's first free and open source library system

52921 commits 35 branches 616 tags 1.8 GiB

Author	SHA1	Message	Date
Marcel de Rooy	0397251ece	Bug 33671: (follow-up) Disable FK check for column change See also BZ report. As suggested by Tomas. NOTE: The dbrev is extended too for removing records with a failing guarantor_id foreign key (theoretically not present obviously). Test plan: 1) cp installer/data/mysql/db_revs/220600048.pl installer/data/mysql/atomicupdate/ 2) Run updatedatabase.pl 3) Remove copied file Bonus: Manually remove FK constraint before running updatedatabase. Insert a record with bad guarantor_id into relationships manually. Run the update again. You should not see the message that the constraint is removed. Is the bad record count reported and record removed? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Simplified. No longer removes the FK. Just disables during ALTER. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	2023-07-18 14:07:43 -03:00
Marcel de Rooy	1dee35d412	Bug 33671: Fix for 30472 - Remove null-guarantors These guarantors cannot be added. They are of no use. NOTE FOR QA/RM: I do not think that it is needed to add a new db rev for this change since it happens seldom. But if you think that it is, just copy it to atomicupdate/change bugno. Test plan: [1] Check your table definition and modify it: alter table borrower_relationships modify column `guarantor_id` int(11) NULL; [2] Add an empty guarantor: insert into borrower_relationships (guarantee_id,relationship) values (SOME_PATRON_ID,'father'); [3] Run the dbrev and verify that the inserted record has been removed. [4] Check table definition with 'show create table borrower_relationships'. You should see NOT NULL with guarantor_id. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	2023-05-10 14:19:24 -03:00
Tomas Cohen Arazi	9be197d567	Bug 30472: DBRev 22.06.00.048 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	2022-09-16 16:56:44 -03:00

Author

SHA1

Message

Date

Marcel de Rooy

0397251ece

Bug 33671: (follow-up) Disable FK check for column change

See also BZ report. As suggested by Tomas.

NOTE: The dbrev is extended too for removing records with a failing guarantor_id
foreign key (theoretically not present obviously).

Test plan:
1) cp installer/data/mysql/db_revs/220600048.pl installer/data/mysql/atomicupdate/
2) Run updatedatabase.pl
3) Remove copied file

Bonus:
Manually remove FK constraint before running updatedatabase.
Insert a record with bad guarantor_id into relationships manually.
Run the update again.
You should not see the message that the constraint is removed.
Is the bad record count reported and record removed?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Simplified. No longer removes the FK. Just disables during ALTER.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

2023-07-18 14:07:43 -03:00

Marcel de Rooy

1dee35d412

Bug 33671: Fix for 30472 - Remove null-guarantors

These guarantors cannot be added. They are of no use.

NOTE FOR QA/RM: I do not think that it is needed to add a new
db rev for this change since it happens seldom. But if you think
that it is, just copy it to atomicupdate/change bugno.

Test plan:
[1] Check your table definition and modify it:
    alter table borrower_relationships modify column `guarantor_id` int(11) NULL;
[2] Add an empty guarantor:
    insert into borrower_relationships (guarantee_id,relationship) values (SOME_PATRON_ID,'father');
[3] Run the dbrev and verify that the inserted record has been removed.
[4] Check table definition with 'show create table borrower_relationships'.
    You should see NOT NULL with guarantor_id.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

2023-05-10 14:19:24 -03:00

Tomas Cohen Arazi

9be197d567

Bug 30472: DBRev 22.06.00.048

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

2022-09-16 16:56:44 -03:00

Renamed from installer/data/mysql/atomicupdate/bug_30472.pl (Browse further)

3 commits