Commit graph

161 commits

Author SHA1 Message Date
Galen Charlton
9ea0c6ba77 fix problem with prior patch that inadvertantly
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:57:44 -05:00
Galen Charlton
51e639ed7e added dropdown for classification source for addbiblio and additem
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:57:29 -05:00
Galen Charlton
7a24aac808 bib and item editing bugfixes
- bugfix: update items.cn_sort upon edit of item
- bugfix: make failure of a value_builder plugin non-fatal
- bugfix: remove references to non-existent plugins
          from optional MARC21 frameworks
             bookseller.pl
             marc21_callnumber.pl
             marc21_classcodes.pl
             marc21_locationqualifier.pl
- bugfix: corrected trying to enter 'u*' fields twice in the 'CF'
          format in the optional MARC21 frameworks; resulted in
          most of the framework not being loaded

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:57:10 -05:00
Galen Charlton
af9dfd9cda bib and item editing bugfixes
- bugfix: update items.cn_sort upon edit of item
- bugfix: make failure of a value_builder plugin non-fatal
- bugfix: remove references to non-existent plugins
          from optional MARC21 frameworks
             bookseller.pl
             marc21_callnumber.pl
             marc21_classcodes.pl
             marc21_locationqualifier.pl
- bugfix: corrected trying to enter 'u*' fields twice in the 'CF'
          format in the optional MARC21 frameworks; resulted in
          most of the framework not being loaded

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:56:53 -05:00
Henri-Damien LAURENT
458111f263 Managing IndependantBranches when creating a new Biblio
librarians can only add/edit/delete items on their own branches.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:44:29 -05:00
4cb09388fa Misplaced closing parethesis was causing javascript error with plugins
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 15:41:19 -05:00
Paul POULAIN
10eb85455b bugfix (security flaw) : the additem template was open AFTER doing actions
when Logguing was ON, this resulted in an internal server error, thus the discovery of this bug.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:24:49 -05:00
Paul POULAIN
124ed1188b #1432 : duplicated barcodes when item edited
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:18:13 -05:00
Henri-Damien LAURENT
38685bdf90 Bug Fixing : Adding item had a javascript Error.
So.
There are no more errors on saving an item.
There are still little problems when you duplicate a subfield :
Display table is not adapted
When you reedit, all the duplicate field values are concatenated.
But apart from that, it works.
Donot have time enough to work on it these days.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-20 14:12:01 -05:00
Chris Cormack
b9c20fa9cf Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:22:01 -05:00
Galen Charlton
af466ca41a start of reworking call number handling and other Biblio changes
Most of this commit by Joshua Ferraro.
updatedatabase changes by Galen Charlton.

Major changes:

This commit includes a lot of fairly major changes
to Koha's Biblio handling, largest is the addition
and deletion of several columns in the biblioitems,
items tables, as well as cleanup of deletedbiblioitems,
deleteditems tables. Some of the changes are simple
cleanup, but most have to do with improvements to
storage of call numbers in Koha.

Also, I had to clean up the _koha_* routines quite a
lot to make them work -- there was lots of data just
being lost because columns weren't being updated.

I'm still not completely convinced that the items
table is being treated as authoritative for items
data, investigating further.

DB Changes (updated in kohastructure.sql and in
updatedatabases):

ADDED:
biblioitems.cn_source   ( auth value, CN_SOURCE, stores the source of the
                          call number: DDC, LCC, NLM, etc.)
biblioitems.cn_class    ( plugin, marc21_callnumber.pl, helps fill in
                          the rest of the biblio-level fields)
biblioitems.cn_item
biblioitems.cn_suffix
biblioitems.cn_sort     ( for zebra sorting, stored as a decimal number)
biblioitems.totalissues ( for counting the total times issued )

items.cn_source         ( auth value, CN_SOURCE, stores DDC, LCC, NLM, etc.)
items.itemcallnumber    ( plugin, marc21_itemcallnumber.pl, helps fill in
                          the itemcallnumber based on the record data )
items.cn_sort           ( for zebra sorting, stored as a decimal number)
items.ccode             ( auth value, CCODE, stores the Collection Code
                          of the item, can be used as call number prefix
                          by some libraries )
items.uri
items.materials
items.damaged

DELETED:
items.itype
items.cutterextra
biblioitems.classification
biblioitems.subclass
biblioitems.dewey
biblioitems.lcsort
biblioitems.lccn
biblioitems.ccode

DB version now 3.00.00.009.

Minor changes:

* Drop revision history from C4/Biblio.pm
* GetMarcAuthors now returns additional authors (7XX), not
  main authors (1XX)
* Debug warnings in C4/Search.pm commented out

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:19:56 -05:00
Henri-Damien LAURENT
8bdc7f83ac bug Fixing bugs.koha.org 1479
Porting userinterface improvements from biblios to items.

I have to port that also into serialsadditems.
Maybe there could be a way to have only one place for MARCinput management.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:28:15 -05:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
Paul POULAIN
4682f9ae39 reintroducing size for fields in addbiblio
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:10:31 -05:00
Paul POULAIN
9f58a48ef2 bugfix: parenthesis at wrong place
authorities could not be open in MARC editor

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:20:21 -05:00
16d0f61af9 Corrections to addbiblio.pl and addbiblio.tmpl for XHTML compliance; Formatting addbilbio.tmpl tabs.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-10 17:08:39 -05:00
Henri-Damien LAURENT
7f15241095 BugFixing unimarc_field_210c.pl was badly broken. It allows searches.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 18:46:09 -05:00
Paul POULAIN
e36f63bfc4 #1473: MARCfindbreeding breaks MARC21 records in reservoir
doesn't change anything for UNIMARC (as expected), UNTESTED for MARC21, pls test it

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-08 15:51:35 -05:00
Paul POULAIN
2c596cec54 1340 (querying 2 z3950 servers merged results)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-08 15:49:30 -05:00
Joshua Ferraro
3840e76192 partial 1481: adding back missing updateitem.pl script
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:59:44 -05:00
Joshua Ferraro
e494fadf0a partial 1481: adding to templates, fixing non-display of data
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:34:56 -05:00
Joshua Ferraro
a6ad58f82a partial 1481: adding back missing updateitem.pl script
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:34:46 -05:00
Joshua Ferraro
ba36be1cbc refining barcode plugin, two new options
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 01:39:11 -05:00
Joshua Ferraro
2131e1e9aa adding dateaccessioned plugin
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 01:38:49 -05:00
Paul POULAIN
40b8937717 MARC21 plugins fixed
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:54:59 -05:00
Paul POULAIN
0396492c4e 1363 (mandatory field break MARC editor)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:53:08 -05:00
Paul POULAIN
fa5acd49ea fixing upbutton that has disappeared & fixedfield condition check
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:52:30 -05:00
Paul POULAIN
421e85ad16 #1452 (Labels for item editor are truncated)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:50:24 -05:00
Henri-Damien LAURENT
1b5ae3aea5 BUG FIXING : 210$c is now searching EDITORS
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:38:15 -05:00
Joshua Ferraro
dace73a81f fix for bug 1451
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-02 20:22:34 -05:00
Henri-Damien LAURENT
eb8e666234 Bug Fixing : page changes were broken for unimarcfield_4XX.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-02 15:45:11 -05:00
Paul POULAIN
4025e6fd38 BUGFIX: we show the 1st page, that is numbered 0
Without this, the search in catalogue showed the # of results, but not the results !

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 16:03:45 -05:00
Paul POULAIN
9a1b556879 BUGFIX : create a unique div for each subfield
otherwise, when you have a repeated field, when editing biblio,
the cloneSubfield (+) button will clone the subfield in the 1st field
wherever you click !

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-27 16:32:40 -05:00
Paul POULAIN
ff9aca298d BUGFIX (unimarc specific) escaping ' in template variables in 4XX plugin
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-26 05:28:52 -05:00
Paul POULAIN
5f15ea68e8 2 BUGFIX (1 being unimarc specific) : change in plugin handling
before this commit, the main (usually $a) entry could not be entered by the librarian.
With the new BiblioAddAuthority feature, it's a bad idea : the librarian will
be able to enter a value manually, and the authority will be automatically created on the fly
Thus the small change in addbiblio.pl

This commit also fixes a bug in plugin 4XX (which is unimarc specific) :
"Empty" option did not work properly + API convention fix (biblionumber instead of bibnum)

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-26 05:28:45 -05:00
Paul POULAIN
b67d77e211 BUGFIX : repeated fields where merged on biblio update
When updating a biblio, all repeated fields had the same input name.
Thus, when retrieving them through cgi->param resulted in a single line
Thus all subfields where merged in a single MARC field.
Adding a random() part to the name solves the problem

+ removing some warn lines

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-12 20:54:31 -05:00
0f3b435b15 Removing script-specified CSS and js pointers. More markup cleanup and restructuring.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-11 16:41:39 -05:00
55bc6939ad Corrections for XHTML compliance
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-11 16:41:36 -05:00
Paul POULAIN
a201aac3c8 BUGFIX (major) : when editing an existing biblio, biblionumber was lost
In Koha 2.2 the biblionumber was an hidden field in the form,
exactly as any other subfield.
As we also stored biblionumber as specific field, it was useless to have it
twice.

with this commit, we restore the biblionumber in the MARC:Record in TransformHtml2Marc

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-04 16:35:22 -05:00
Paul POULAIN
6af15e5e9d BUGFIX : deal with repeatable values when retrieving a z3950 biblio
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-04 05:43:55 -05:00
c44f56fcac Moving </head><body> into body of templates so that js and css can be embedded per-page.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-30 15:50:54 -05:00
dc68c00c8d Testing new changes to Auth.pm to allow passing of page-specific js and css to templates
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-30 15:50:01 -05:00
3262d91a16 Modifications to enable YUI-Grids layout structure. Unfinished.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-28 16:50:42 -05:00
Henri-Damien LAURENT
61efebb7e7 Adding new feature : creating authorities on-the-fly.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-23 15:14:22 -05:00
7e7a070ee3 Adding missing barcode.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-16 13:42:39 -05:00
Paul POULAIN
9a32fe85c2 This commit fixes a bug in biblio encoding. things were mixed up when reporting item(s) into the biblio, to UPDATE biblioitems.marcxml, after a biblio modif (in MARC editor).
So, deal carefully with this commit pls, and check it for your setups, because the patch works for me, but I'm not sure to understand well why :\

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-14 21:28:28 -05:00
Joshua Ferraro
2e7a14fe4d patch to fix marc21 leader
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-09 10:11:33 -05:00
Paul POULAIN
3f9017b349 adding a ExpandField feature to MARC editor : all subfields that are empty and not mandatory are hidden by default. a click on the tag title expand all of them. This is better imho than the previous minimizer, because :
Note that the minimize/expand by default behaviour could be changed to use the hidden property. Il let LibLime guys say what they think of this proposal, and discuss another behaviour.
Anyway, it proves that the new editor is better than the previous one as it can evolve easily ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-09 09:51:57 -05:00
Joshua Ferraro
e9ae8c0686 patches from paul 2007-08-08 07:41:19 -05:00
Chris Cormack
2e4a11773c Merge branch 'master' of /home/jmf/repos/koha-rm-root.git/ 2007-08-08 07:36:43 -05:00
Paul POULAIN
0187bcaf84 tidying SQL query
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-08 07:25:06 -05:00
toins
ae706f0d7a fix indentation. 2007-07-31 16:14:15 +00:00
toins
3731406592 plugin rewrited to works with addbiblio.
NOTE :
Unimarc plugins has been fully tested but not MARC21 one.
Unimarc plugins respect the norme now.
2007-07-31 16:06:21 +00:00
toins
e14fdf1f5e addbiblio cleaned.
TODO: There is still a encoding pb when modifying a biblio.
2007-07-31 16:03:09 +00:00
hdl
1fcab18c44 Creating Biblio if BiblioAddAuthorities is set in system Preferences.
Need further testing and debugging.
Biblio is created but it seems the creation of authority fails.
2007-07-20 16:38:21 +00:00
hdl
6ab51c1782 Adding a biblio can be executed in a popup now. 2007-07-16 15:49:53 +00:00
toins
e1b6492b50 syntax error 2007-07-13 16:00:50 +00:00
toins
76c3275d12 bug fix there was an internal servor error when there is no result 2007-07-13 13:13:41 +00:00
toins
267ca1b99a displaying the query to search
re indenting
minor style enhancement
2007-07-12 15:30:13 +00:00
toins
a8bca5403e remove duplicated line. 2007-07-12 15:28:31 +00:00
toins
3c1ae55fcf adding a pagination bar & displaying only 20 results per page.
style enhancement
re indenting
2007-07-12 15:28:00 +00:00
hdl
7494188760 Adding macle_plugin for FRANTIQ 2007-07-10 08:48:54 +00:00
hdl
5f5da86c27 Bug Fixing:
authorised values for a subfield was not taken into account beacause value names were conflicting.
2007-07-06 12:59:06 +00:00
tipaul
967542e325 leader length checking bugfix : 25 and not 24 2007-07-02 09:51:28 +00:00
tipaul
d132e60e33 unimarc bugfix : the encoding is in field 100 in UNIMARC. when TransformHTMLtoXML on an item, you must not automatically add a 100 field in items, otherwise there will be 2 100 fields in the biblio, which is wrong 2007-07-02 09:50:03 +00:00
tipaul
4cbf85f1b2 decoding correctly z3950 biblios 2007-06-25 15:06:28 +00:00
tipaul
014350b476 bugfixes on unimarc 100 handling (the field used for encoding) 2007-06-25 15:01:45 +00:00
tipaul
23427c51b9 some fixes (and only fixes) 2007-06-15 13:44:44 +00:00
toins
d693f7946b writing absolute path. 2007-06-08 15:20:16 +00:00
tipaul
5dd3f0229a bugfixes (various), handling utf-8 without guessencoding (as suggested by joshua, fixing some zebra config files -for french but should be interesting for other languages- 2007-06-06 13:08:35 +00:00
tipaul
e43c164395 fixing template & javascript bug on almost all plugins 2007-06-05 08:38:39 +00:00
tipaul
67d1dcf1f7 various bugfixes (minor) and french translation updated 2007-05-23 16:19:40 +00:00
btoumi
a29ba65fba bug fixing : add new check for isbn because u can find number in begenning of title 2007-05-22 13:39:26 +00:00
hdl
286930bdc7 Changing GetMarcStructure signature.
Deleting first parameter $dbh
2007-05-22 08:50:47 +00:00
tipaul
e1d907c688 various bugfixes on parameters modules + adding default NoZebraIndexes systempreference if it's empty 2007-05-04 16:24:08 +00:00
hdl
097fef712a Removing $dbh from GetMarcFromKohaField (dbh is not used in this function.) 2007-04-27 14:00:48 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
a481fad4b7 Code cleaning :
== Biblio.pm cleaning (useless) ==
* some sub declaration dropped
* removed modbiblio sub
* removed moditem sub
* removed newitems. It was used only in finishrecieve. Replaced by a Koha2Marc+AddItem, that is better.
* removed MARCkoha2marcItem
* removed MARCdelsubfield declaration
* removed MARCkoha2marcBiblio

== Biblio.pm cleaning (naming conventions) ==
* MARCgettagslib renamed to GetMarcStructure
* MARCgetitems renamed to GetMarcItem
* MARCfind_frameworkcode renamed to GetFrameworkCode
* MARCmarc2koha renamed to TransformMarcToKoha
* MARChtml2marc renamed to TransformHtmlToMarc
* MARChtml2xml renamed to TranformeHtmlToXml
* zebraop renamed to ModZebra

== MARC=OFF ==
* removing MARC=OFF related scripts (in cataloguing directory)
* removed checkitems (function related to MARC=off feature, that is completly broken in head. If someone want to reintroduce it, hard work coming...)
* removed getitemsbybiblioitem (used only by MARC=OFF scripts, that is removed as well)
2007-03-29 13:30:31 +00:00
tipaul
8830e5af8f removing marc=off scripts 2007-03-29 13:29:48 +00:00
tipaul
56c4a32119 adding default value new feature into cataloguing. The system (definition) part has already been added by toins 2007-03-29 09:42:13 +00:00
tipaul
f8e9fb6445 rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00
tipaul
70501283b3 rel_3_0 moved to HEAD 2007-03-09 14:41:32 +00:00
tipaul
2ffd5b7228 rel_3_0 moved to HEAD 2007-03-09 14:28:54 +00:00
tgarip1957
04b2e6112f Finalized XML version for intranet 2006-09-27 21:19:21 +00:00
tgarip1957
a21d954442 Fixes a bug with Marchtml2xml and sync with dev_week 2006-09-11 17:12:04 +00:00
tgarip1957
7e52a5665c Clean up before final commits 2006-09-06 16:21:03 +00:00
tgarip1957
30e64942f4 Z3950 search when adding a bibblio using ZOOM.
Servers chosen on the fly
If during a modification allows imported file to replace existing biblio
2006-09-01 22:28:34 +00:00
tgarip1957
e928ba3e05 MARCXML only. No more MARC record. No more non-marc handling
Install LibXML or Expat for fast parsing. either will work
Bug in addbiblio when adding authorities fixed
2006-09-01 15:45:01 +00:00
toins
8bd1fdc6ac C4::SearchMarc is deprecated now. it is totaly replaced by C4::Search. 2006-08-10 13:08:28 +00:00
toins
756827b164 1 sub renamed and cleaned. 2006-07-27 13:52:49 +00:00
toins
3c6410111b subs renamed according to coding guidelines. 2006-07-21 10:10:29 +00:00
toins
c05482a407 getitemtypes renamed to GetItemTypes 2006-07-12 17:17:12 +00:00
rangi
4f210d4556 Modify item now works
BUT only if there is only one item, if there is more than one item, it gets messed up.
They get combined into the form, ill work on this next
2006-04-03 04:00:02 +00:00
kados
52283b6c66 re-adding oldbiblionumber for the sake of the plugin 2006-04-03 00:17:13 +00:00
kados
6c633aca55 syncing with rel_2_2, adding visibility handling 2006-04-02 19:12:01 +00:00
kados
ea32a21f7f adding eval to fix 500 error with blank marc record 2006-04-01 23:06:22 +00:00
kados
d8ed60a8a2 syncing with rel_2_2 2006-03-10 02:43:13 +00:00
rangi
69604ba93f catching oldbiblionumber also 2006-03-07 23:37:48 +00:00
kados
c6d8b997d0 fix syntax error. 2006-03-06 03:50:29 +00:00