Commit graph

439 commits

Author SHA1 Message Date
Michael Hafen
3e0163adb8 bugfix stickyduedate more sticky - also patron search in quick search block
Forgot about the patron search for check out form in the quick search
block

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 11:07:32 -05:00
Nahuel ANGELINETTI
348d471fe0 (bug #3187) authority search pagination doesn't work
this patch just set a marclist argument value on search authority, else the pagination won't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:23:58 -05:00
Galen Charlton
786a1aa36a bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:42 -05:00
Joe Atzberger
ac6cfb28a3 Make js prompts translatable using _("...") and comment out unused vars.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 14:01:19 -05:00
Nahuel ANGELINETTI
5cf66ad6dd (bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:36 -05:00
Joe Atzberger
14be4400d8 Bug 3066 - Overhaul guided reports
execute_query now refactored, returns reliable results, does
zero presentation-layer crap.  Arguments reduced, client scripts
adapted to new API and performance improved.  Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.

Replaced tools/runreport.pl with misc/cronjobs/runreport.pl:
    ~ security fixed
    ~ documentation improved
    ~ TODO: finish sendmail option.

Bug 3077 also fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 20:17:55 -05:00
Joshua Ferraro
76f03c53b0 Adds a 'New Subscription' option for selection from the detail page of a record.
NOTE TO DOCUMENTATION WRITERS: Due to the limitations in the serials module search
interface, some users may find it easier to use the standard catalog search to locate
an item on which to create a subscription record, and then use this new button to
create a subscription from the detail page.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:48 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Mason James
dacb4e0e60 quietens a noisy debug pop-up, when debugging
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:36:49 -05:00
c0b0a2741e Correcting delete patron button to use TMPL_VAR instead of DOM query. Fixes Bug 3014, Can't delete restricted patron from circulation screen.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:25 -05:00
Nahuel ANGELINETTI
72563b0449 (bug #2933) change popup names containing space chars
This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:37:30 -06:00
d79ac60b90 Fix for Bug 2984, Error when generating CSV output from "Generate labels for Batch" button
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-25 16:32:24 -06:00
b246e1bf60 Correcting title of link to admin/itemtypes.pl from "Item types and circulationcodes" to just "Item types." Ccodes are authorized values.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:46:13 -06:00
John Beppu
233010f451 Branch Level Notification Config
- This will allow admins to disable notifications for any combination of
  branch, patron category, and item_type.
- Still working on this...

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:55:38 -06:00
Nahuel ANGELINETTI
ba34bea474 (bug #2938)[follow previous] Add new report in menus
Just adding the new report in miscellaneous menus

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:42:00 -06:00
Galen Charlton
0f47a7db16 bug 2799: followup
Various fixes to meet coding standards, template
design, and basic functionality:

* (bug 2505) turned on warnings
* use correct loop names when populating
  $template
* put all TMPL_FOO in HTML comments
* assign UseBranchTransferLimits to circulation tab
* change template to use "library" instead of "branch"
* use standard YUI scripting for toolbar buttons
* add new script to admin menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:16 -06:00
Nahuel Angelinetti
7238585c60 bug 2841: add an hidden field with booksellerid
The bug throw because the booksellerid is not in the request, and the newordersuggestion.pl need this one to import
it in a new order.
So I just added an hidden input in the search form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 10:15:31 -06:00
41db97255c Corrections and tweaks to recent lists fixes.
Corrected an instance where <!-- TMPL_IF --> was embedded inside an HTML tag (conflicts with translation script). Modified styling of confirm button to match existing interface convention.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:24:25 -06:00
Allen Reinmeyer
25eb36f21f Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 08:33:59 -06:00
Jesse Weaver
b883e6cd7f fix for bug 2447: yuipath variable not getting passed to help pages
This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:51 -06:00
ccad2f8cf0 Language corrections: branch -> library. Changing "Libraries, branches, and groups" to "Libraries and groups." Fixes Bug 2802.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:28 -06:00
Nahuel Angelinetti
ff27962633 A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:27 -06:00
f0fc788a28 Spelling correction: catalogue -> catalog. Fixes Bug 2730.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:28 -05:00
Allen Reinmeyer
ae83425a79 Bug #2030 z3950 search function does not filter
Entering a term in the z3950 search box does not filter the results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:35:06 -05:00
0a33d4554b Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 13:34:36 -05:00
96c29c707f Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:18:17 -05:00
13fca44836 Adding progress bar and some other visual enhancements to file upload interactions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 11:58:21 -05:00
db7daf7586 Corrections to fix javascript error in Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:31:59 -05:00
7b2e4ebce2 A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:02 -05:00
Jesse Weaver
5d8a285b81 fix for bug 2577: Cannot delete patron in IE
Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:45 -05:00
Danny Bouman
83b8cfb1ad bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:48:22 -05:00
8a6125532c Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:00:30 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
79819e0b24 Style correction in member entry form; Enabling intranetuserjs in doc-head-close.inc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:35:35 -05:00
61e8d4f1c8 Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:30:48 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
092e474389 Fixing a couple of minor markup issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-19 13:40:11 -05:00
Jesse Weaver
c6e2bcf67d Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:43 -05:00
Ryan Higgins
29d0c646f7 Final cleanup of labels for 3.0
This patch adds the callnum_split and text_justify options to the templates,
fixes bad javascript to switch between 'formatstring' and fixed-field means of specifying labels content,
fixes csv output when fixed-fields specifiers are used, and adds some help text for the formatstring case.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-10 06:19:00 -05:00
72622336a3 Link correction (affected only non-js users).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:11:53 -05:00
d4ca58e80a Adding "New Item" menu option. Jumps to anchor for Add Item form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 11:56:51 -05:00
Joe Atzberger
adbb25b52b auth_finder - HTML validation fixes
Missing </tr> and extra </select>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:28 -05:00
Galen Charlton
b8fe6d7a1b bug 1433: use same bib when adding new subscription from details page
When viewing the subscription details page of a bib that already
has at least one subscription, clicking on the 'New Subscription'
button in the toolbar will fill in the biblionumber and title
in the new subscription form.

Clicking on the 'New Subscription' button in other context (e.g.,
when viewing the results of a search) will leave the biblionumber
and title fields unpopulated, as there is no specific bib to
use.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:15:16 -05:00
16f20864b0 Complete sweep of help files in order to correct invalid markup and fix Bug 2444(break up long lines in templates).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-01 14:33:28 -05:00
82d0920ec0 Spelling corrections (Fixes Bug 2381).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 05:57:25 -05:00
Chris Nighswonger
9971756a24 kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves
Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:48:13 -05:00
fd2ee6411e Fix for Bug 2373 ("Tags missing from the left menu"). Also doing some cleanup and reformatting on review.tmpl. Fixing some capitalization--I hope that's not a translation problem.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:53 -05:00
16c8171564 Adding new patron form for non-javascript users (Fixes Bug 2344, No "New Member" button w/o js).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:51 -05:00
Ryan Higgins
b16463a81e Change language on serials toolbar from 'edit record' to 'edit subscription'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:23 -05:00
Joshua Ferraro
6f0526abaf Fix for bug: 2323: Conference name search fails in staff interface.
wrdl missing from definition on adv search page in staff client
2008-07-14 13:05:04 -05:00