Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
simith	a61c3a7688	Bug 8837: Dewey cn_sort inaccurate This patch fix the cn_sort sorting accurace described by Joy Nelson. Testing: I) Appy the bug 12424 patch Before applying this patch: 0) Select 3 items. 1) Edit the items selected 2) Change "Full call number" option to 971/P23w/v.1-2/pt.8, 971.01/P23w/v.1-2/pt.6-7 and 971.01/P23w/v.1-2/pt.7 3) Save changes 4) Valide 971P23WV_12PT_8_000000000000000, 971_000000000000000_01P23WV_12PT_67 and 971_01P23WV_12PT_700000000000000 (table items - cn_sort column). After applying this patch: 5) Edit again the item selected in 0 3) Save changes 4) Valide 971_000000000000000_P23W_V_12_PT_8, 971_010000000000000_P23W_V_12_PT_67, 971_010000000000000_P23W_V_12_PT_7 (table items - cn_sort column). Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jason Etheridge	dba36a7a12	Bug 9770: fix sorting of Dewey call numbers that contain prefixes C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally. The subroutine get_class_sort_key tokenizes a call number string (splitting on periods and whitespace) and counts the number of tokens that solely contain digits. If there is only one such digit group, a comment in the code states that it will pad said digit group. However, the bug is that the code assumes said digit group is the first token, when this may not be the case. In practice, this can cause poor sorting when used a call number is in the form of PREFIX _space_ 3DIGITS. To test: [1] Create two item records whose class scheme is set to 'ddc' (Dewey) and whose call numbers contain prefixes, e.g., J DVD 700.1 ABC and J DVD 850 DEF. [2] Use the inventory tool to produce a list of item items that include the two created in step 1. Obsere that that items are sorted in the incorrect order, with "J DVD 850 DEF" coming before "J DVD 700.1 ABC". Alternatively, run the following SQL to see the incorrect sort order: SELECT cn_sort, itemcallnumber FROM items WHERE itemcallnumber LIKE 'J DVD%' ORDER BY cn_sort; [4] Apply this patch. [5] Run misc/maintenance/touch_all_items.pl to force cn_sort to be recalculated. [6] Repeat step 2 and verify that the call numbers are now sorted corrected. Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	bc87274c66	bug 6281: introduce LC::CallNumber::LC for sorting LC call numbers This replaces the previous hand-coded normalizer. Because LC::CallNumber::LC appears to reject strings that aren't valid LC call numbers, significant changes to the test cases were made as well -- however, the one that really counts is the last one which verifies the sorting. To recalculate the call number sort key for each item, it is necessary to run misc/maintenance/touch_all_items.pl To test, create item records with the following call numbers, setting the classification sort to 'lcc': QC100 .U57 NO. 555 1986 QC145 .A57 V.12 1980 QC145.45 .H4 D65 1998 QC995 .E29 1997 Next, make a report of them in the inventory tool. The items should be sorted in the above order. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Chris Cormack	509d673f10	Bug 7941 : Fix version numbers in modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Magnus Enger	aef8358cf2	Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting 1. The current C4::ClassSortRoutine::Dewey turns "306 Les" into "306_Les" for items.cn_sort and MARC-field 952$6, which results in "306.46 Les" being sorted before "306 Les" in the OPAC. With this patch, "306 Les" is turned into "306_000000000000000_Les". 2. Currently, call_number_asc and call_number_desc are set up to sort by 1=20, but this is mapped to Local-classification in ccl.properties, which is mapped to 952$o in record.abs. This patch changes these sorts to use 1=8007, which is mapped to cn-sort and 952$6. Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Galen Charlton	7c0e441d50	replace references to defunct info email address Now links to Koha project website. Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Galen Charlton	29eadaa1f7	fix a common "developement" typo Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Galen Charlton	64daee5495	fix a common "developement" typo Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Lars Wirzenius	7279f55b60	Fix FSF address in directory C4/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Galen Charlton	1455d663d6	bug 2505: enable warnings in call number normalization modules Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	15 years ago
Galen Charlton	7e044751ef	ignore "/" when sorting Dewey call numbers Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
Galen Charlton	a2c245c77d	call number work part 2 -- added framework for call number filing routines Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago

11 Commits (5db89aa1e93b3156989e55179f8d7295833e3c12)