Commit graph

4174 commits

Author SHA1 Message Date
852bb18b1f Bug 3213 - Add UNIMARC XSLT stylesheet
With those stylesheets result and detail pages
render better UNIMARC biblio record than normal
views. But works still have to be done in order
to reach UNIMARC-ISBD compliant display.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:35:50 -05:00
df03217b49 More fixes for Bug 2704, 440 Display Issues
Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 12:20:07 -05:00
Jane Wagner
3fa269da6c Bug 3173 Place Hold link visible in OPAC even if syspref turned off
If the syspref RequestOnOpac is turned off, the link to place a hold does not
show in the detail page.  However, the link is still present in the results
list as well as in the basket and in lists.  Modified templates to check
for the syspref and to obey it.

NOTE:  This does not turn off the display of the Holds tab in the OPAC
user account.  I think there are situations where library staff may be
allowed to place holds but users are not allowed to do so through the
OPAC.  Leaving the Holds tab visible shows users what they have on hold,
but does not allow them to place holds.  It does allow users to cancel
holds.  If there is a need to hide this tab, that would probably be
best accomplished by a separate syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:39:23 -05:00
Nahuel ANGELINETTI
348d471fe0 (bug #3187) authority search pagination doesn't work
this patch just set a marclist argument value on search authority, else the pagination won't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:23:58 -05:00
Nahuel ANGELINETTI
78756abc37 (bug #3174) show the member name in reports
this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:17:30 -05:00
98650328dd Add system preference search to administration home page (Bug 3181)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:49:41 -05:00
Galen Charlton
70b7017eca fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:32:02 -05:00
Colin Campbell
e60fbf4c30 (bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:10:19 -05:00
Garry Collum
2eaf194268 Bug 3081 - The category code in the patron personal details page in opac showed the category code and not the description. This patch makes the description appear instead. Looking at both opac-userupdate.pl and opac-userupdate.tmpl, the actual value of this text box is not retrieved for any purpose.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:54:10 -05:00
Joe Atzberger
544b03357a Convert shelves from using "toggle" code
And one ELSIF.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:54 -05:00
Joe Atzberger
51a0e335d5 Bug 3157: IE compatibility for label display
Also fixed validation errors where label elements were "for" non-existant ids.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:53 -05:00
Galen Charlton
822ecbdc42 removed extra /TMPL_IF introduce in previous Syndetics patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:27:46 -05:00
David Birmingham
d5d21fe101 Bug fix to OPAC shelf browsing query statement
If the items.location field was NULL, then the current
SQL query would produce no results.  I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.

In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open.  This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:18:27 -05:00
Chris Cormack
d32d5bfb9b Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:06:53 -05:00
Garry Collum
1eb9154b73 Bug #2974 Adding category code to BorrowerMandatoryField produced a "The following fields are mandatory: categorycode"
If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element.  The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank.  Added code to check for an empty string in the first
element.

You can test this by making salutation (title) mandatory.

Also fixed some typos in some of the comments.  Why?  Because I'm a Librarian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:47:09 -05:00
Nahuel ANGELINETTI
4dbe34f231 (bug #3174) fill borrower number, and show author and creation date in saved reports
This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:25:36 -05:00
Galen Charlton
1ecd369926 fix XHTML validation error introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:18:04 -05:00
Jane Wagner
f5be7dc8e4 Enhancements/fixes for OPAC advanced search screen
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.

Added Publication Date Range search to advanced search screen

Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).

Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:11:17 -05:00
Galen Charlton
53ace84401 Syndetics: add support for AVSUMMARY and AVPROFILE
Added support for the Syndetics AV summary and AV profile
data elements.  The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:19:19 -05:00
Galen Charlton
2e9d9d9d95 Syndetics: add fiction notes/title profile link
If a Syndetics title profile (AKA fiction notes page) exists
and is avaailable to the user, add a link to to in the OPAC
detail page.

TODO: add a system preference

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:17:22 -05:00
root
99dd5db699 Verbiage clarification in intranet advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:30 -05:00
1f0c678d5c Fix for Bug 2767, cart and lists buttons missing on opac-search.pl
This fix adds alternate markup to be included on the advanced search page in order to mimic the placement of the cart and lists buttons on other opac pages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:26 -05:00
Liz Rea
2c5d971a96 Libraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:24 -05:00
root
dd8ee0bbc6 Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:33 -05:00
Liz Rea
69620d9479 Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:26 -05:00
Michael Hafen
d8fad2313f Checkout page - Check Out's table sortable on barcode
Add the barcode column of the Check Out's table to the tablesorter
setup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:59:51 -05:00
Joe Atzberger
a57b438df0 Bug 3126: remove comma for IE7
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:12 -05:00
Joe Atzberger
de38cf6df1 Bug 3130 and general cleanup
Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional.  jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.

There were several other errors addressed by this patch:
 ~ 13 unused variables deleted.
 ~ regexps run on user-supplied $var before checking $var defined
 ~ decimal ratio prohibited and silently replaced with "3"

I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click.  Hidden .sql div now contains the actual query run,
like the other wizard reports.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:10 -05:00
Jane Wagner
f9c3780def Bugs 2822, 2551, 3163 fixes to XSLT
Resent with additional comments.

Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music.  Modified record display to use Sound.

Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource.  Changed the record display page
to also use Continuing Resource.

Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display.  Modified the utils file
to force a space.

The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png).  Also, corrected spelling of icon name
from pencile.png to pencil.png.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 09:00:28 -05:00
Galen Charlton
978f0d5618 fix DOS newlines in MARC21slimUtils.xsl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 08:59:47 -05:00
Chris Catalfo
96f82b3403 bug 3156 followup Fix display of LTFL content when not displaying it in tabs.
LTFL content needs to appear in div rather than span elements.  This patch simply replaces the LTFL span elements with divs to fix Bug 3156: LTFL content not displaying if LibraryThingForLibrariesTabbedView sys pref is Off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 07:57:59 -05:00
Galen Charlton
46037ac61a bug 2893: tweaks to AllowNotForLoanOverride (DB rev 030)
* moved to DB rev 030
* assigned AllowNotForLoanOverride to circulation syspref category
* added a hint to the circulation operator: when the
  AllowNotForLoanOverride is ON, if the operator attempts
  to check out an item that is normally not for loan due to
  its item type or because the item is explicitly marked as
  not-for-loan, the operator is given the chance to check
  out the item anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 14:44:09 -05:00
Joe Atzberger
aebdecfb35 Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:44 -05:00
Galen Charlton
786a1aa36a bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:42 -05:00
33fffbcfd6 Bug 2920 Fixes Amazon content use in pro interface
This patch fixes Amazon content use in pro interface :

* Control Amazon Editorial Review by a new syspref:
  AmazonReviews.
* /catalogue/detail.tmpl doesn't display Amazon reader reviews.
  It displays only Editorial review in Description tab.
  This patch disable request for AWS reader reviews.
* Use Amazon TLD for linking book cover to local
  Amazon Search Inside.
* Minor clean up on C4::External::Amazon.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:53:34 -05:00
Galen Charlton
feead03b08 fix XHTML error - duplicate tabindex
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:36:30 -05:00
Joe Atzberger
843c5b5b2d Bug 3127 - Stub function prevents undefined reference
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 19:49:08 -05:00
Joe Atzberger
ac6cfb28a3 Make js prompts translatable using _("...") and comment out unused vars.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 14:01:19 -05:00
David Goldfein
17923b97f6 Modified log reporting to allow multiple modules to be selected.
Reworked ViewLog.pl and the template.  Eliminated html errors, cleaned up
the template, change mime type to text/csv and other minor changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 13:36:16 -05:00
b398f9981f Modify GoogleJacket display
On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.

This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 09:20:32 -05:00
Andrew Moore
b15be22620 refactor: removing a few unnecessary loops and moving HTML out of script into template
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:48:38 -05:00
Jane Wagner
b81479fdb2 Bug 3152 OPAC reading history column headers don't line up with text
Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:08:56 -05:00
Joe Atzberger
f3b5014449 Bug 3128 - followup and correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:34 -05:00
Joe Atzberger
173556364d Bug 3128: IE7 tweak
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:28 -05:00
Stephen Edwards
47690dbcc4 bug 3093: Enhance placing of holds in the staff interface.
This patch allows staff users to request reserves on multiple
items at one time.

Added checkboxes, select-all, clear-all, and place-hold button to
staff search results page.  Place-hold button will only appear if
the user has permission to place holds for others.  Item-level
Place-Hold button will not appear for multiple holds, nor will
the vertical detail menu.

Patron input page now shows multiple items, if applicable.

Hold confirmation page shows results for multiple items, if
applicable.  Those which cannot be reserved are highlighted and
are excluded from the reservation.  The reservation is placed at
the biblio number (i.e. next available) level.

Fixed display of item type.

Removed side menu for multiple items; removed item-oriented button for multiple items.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 06:12:06 -05:00
29ab92d261 Bugfix #3155 Disabling Amazon Reviews
Disable Amazon reviews without disabling Amazon book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 05:56:54 -05:00
Galen Charlton
f5e93e0099 fix XHTML validation errors in LTFL output
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 16:13:29 -05:00
Christopher Hyde
a5d6494c62 Fixed minor error in comment code
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:37:15 -05:00
Christopher Hyde
4b56532d0a Changes made: Fixed typo/bug which had wrong order for if statement checking to see whether
Committer: Christopher Hyde <chyde@ebpl.org>

	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:35:02 -05:00
Christopher Hyde
1d4892cf1c Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified:   admin/systempreferences.pl
	modified:   installer/data/mysql/en/mandatory/sysprefs.sql
	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
	modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:34:56 -05:00