Commit graph

35 commits

Author SHA1 Message Date
Galen Charlton
abe349ed6c Revert "Bug 10074 - Encoding problems for installer"
This reverts commit d0c6e09429.

Rolling back bug 6554 work until we have more comprehensive tests.
2013-04-29 15:09:48 -07:00
Galen Charlton
ad5e44bcde Revert "Bug 10074: QA Followup for InstallAuth.pm"
This reverts commit e848d89e45.

Rolling back bug 6554 work until we have more comprehensive tests.
2013-04-29 15:06:12 -07:00
e848d89e45 Bug 10074: QA Followup for InstallAuth.pm
Moving use Output.pm to optional require.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-04-19 23:07:01 -04:00
d0c6e09429 Bug 10074 - Encoding problems for installer
Bug 6554 patched output_html_with_http_headers to encode utf8 data, and Templates.pm to expect utf8 data to be encoded.
The Installer page login screen outputs directly to STDOUT (InstallAuthAuth.pm does, WHICH IS WRONG!) and wasn't fixed to do the encoding first.

This patch makes it use output_html_with_http_headers and solves the problem.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-04-19 23:07:01 -04:00
Jonathan Druart
bc5f5f4f01 Bug 9102 : Followup Set HttpOnly on the CGISESSID cookie
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-02-01 10:50:12 -05:00
Paul Poulain
a60101bea0 Bug 6627 follow-up
in installer, some lines where forgotten, and can also be commented
2012-01-06 14:22:59 +01:00
Duncan Tyler
00290e8619 Bug 6627 [Signed Off] - Update to improve security in specified log files - bug 6627
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Verified sessionlog file is not written to /tmp when patch is applied. Also verified original bug - logging in did in fact log to /tmp.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-01-06 14:20:34 +01:00
Chris Cormack
948f65344e Bug 6629 : Follow up to trap vuln in webinstaller and fixing the error
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch fixes problem occuring in web installer.
2011-11-28 09:44:34 +01:00
1bf7550a82 Bug 7026 Web installer does not switch language
Language installer should switch to template files of language selected in
first step. It used to do that, but the feature seems to be broken now. Web
installer remains English after selecting a different language.

To reproduce:

- make sure your database is empty
- run 'perl translate install <some language>
- access web installer
- select language other then en on the first page

=> templates should change to translated templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Test plan provided works, correct language and sample files are selected.

In a second test I deleted the staff templates for de-DE and repeated
the steps. de-DE is not offered in the language selection of the web installer
now, but does appear in the opaclanguages list after running the web installer.
(Bug 5660)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-10-19 15:46:21 +13:00
6b8be20497 Bug 6755 Problems with switching languages
This patch solves the situation that news is in another language than
the Koha interface AND makes that themelanguage routine is always called
the same way in order to prevent mixed display.

It fixes also a bug related to language preselection based on web
browser prefered language.

September 9: Adjusted with input of Frederic Demians.

Septembre 10: Avoid circular dependency, as pointed by Chris Cormack.
Templates related functions are moved from C4::Output to C4::Templates

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-09-23 09:47:09 +12:00
240edb6c0d 5660 Webinstaller should check if KohaOpacLanguage exists in staff
Rebased on April 27 for master (3.05.00.001).

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Signing off on the whitespace changes made by Paul

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-08-05 10:35:06 +12:00
Chris Cormack
2b1d818736 Bug 6205 : Further fix for installer 2011-04-19 21:55:26 +12:00
Chris Cormack
fc264bb1e2 Bug 6205 : Fix for not found doc-head file when installing in another language 2011-04-19 21:27:05 +12:00
Chris Cormack
d6b080ddd4 Bug 5917 - Switching the installer to use Template Toolkit
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-03-22 17:16:11 +13:00
Donovan Jones
593a7d8e6a Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Lars Wirzenius
b761503f8f Fix FSF address in directory installer/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:50 -04:00
Joe Atzberger
1b12339c19 InstallAuth doesn't have setlanguagecookie to export.
Only installer/install uses InstallAuth, and it gets setlanguagecookie
from C4::Export.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:36:54 -05:00
Galen Charlton
a7ba1bb941 kohabug 2105: prevent crash on IE7
Three scripts were incorrect setting the HTTP type
header to 'utf-8' instead of something appropriate
like 'text/html' - Firefox evidentally can ignore that
mistake, but IE7 does not.

Fixed by replacing an invalid print of the HTTP header
and template output with a call to
C4::Output::output_html_with_http_headers.

Also corrected POD in C4::Auth and InstallAuth to
reflect correct use of output_html_with_http_headers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:36 -05:00
Galen Charlton
66966334b8 completed use of YAML by InstallAuth
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-21 10:28:39 -06:00
Paul POULAIN
8d7d372e1d use YAML for installer auth like we do for Koha itself
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-21 10:28:37 -06:00
Joshua Ferraro
a433d314da Revert "use YAML for installer auth like we do for Koha itself"
Sorry, this patch breaks the installer.

This reverts commit 22a044afce.
2008-02-17 14:38:41 -06:00
Paul POULAIN
22a044afce use YAML for installer auth like we do for Koha itself
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-16 11:18:35 -06:00
Joe Atzberger
fbc151c16d Auth.pm should have "CAN_user_updatecharges" (plural), and this change to InstallAuth.pm should catch it.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:59:41 -06:00
Chris Cormack
b9c20fa9cf Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:22:01 -05:00
Joshua Ferraro
d1f6407baa moved images to img fixed installer path for templates
perl -pi~ -e 's/\/prog\/images\//\/prog\/img\//' *
perl -pi~ -e 's/\/prog\/en\/images\//\/prog\/img\//' *

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-23 21:21:58 -05:00
Joshua Ferraro
836b9857ed content-type was incorrectly set in InstallAuth.pm
Adding 'wizard' and 'login' detection

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-08-15 21:22:21 -05:00
Chris Cormack
f14a897b90 Fixing a bug that was causing the installer to not check the password
correctly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-08-10 15:43:56 -05:00
Chris Cormack
24d5e31dae Changing InstallAuth to use CGI::Session and fixing install.pl which broke
with the kohastruture.sql clean up

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-08-10 10:55:53 -05:00
Chris Cormack
8494eff8bc Removing warn in Auth.pm
Changing InstallAuth.pm to use CGI::Session

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-08-10 10:51:59 -05:00
kados
40af15d8e6 changing permissions on templates and scripts 2007-08-07 13:20:51 -05:00
jmf@arwen.metavore.com
c0d85e87b4 From 0751ba130288bc69e9e563473e7fc25551edc40e Mon Sep 17 00:00:00 2001
From: kados <jmf@arwen.metavore.com>
Date: Sat, 4 Aug 2007 20:10:51 -0500
Subject: [PATCH] fixing permissions on all scripts

Signed-off-by: Chris Cormack <crc@arwen.metavore.com>
2007-08-04 22:41:41 -05:00
kados
f6126d9962 replacing SUPER with NO_LIBRARY_SET for login information 2007-07-03 18:29:37 +00:00
tipaul
6f276facc8 removing guessencoding, hard-coding utf-8 2007-06-05 08:53:19 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
f8e9fb6445 rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00