Should fix any remaining warnings with 'podchecker'
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
If these are acceptable I'll continue - target is to get rid of all warnings
and errors with podcheck and make sure that any man and html formatted pod
docs look 'OK'
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
RM note: we've had our fun; next patch will be to trim
the comment to something that makes sense in context.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
perl-base is a required package, so it is always installed on a Debian
system, and Debian packages should not depend on it, unless they need
it a specific version, and I don't think we do.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
My investigation finds that the problem in Internet
Explorer was not with the spaces in the URL but
with the spaces in the "name" attribute of the pop-up
window. Converting spaces to underscores allows
the plugin links to work correctly.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The template-side fix for Bug 3926 was overwritten by
another template change I submitted later. My bad.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
There wasn't a conditional in place to stop the planning
pull down from showing a blank 'plan by' option.
This patch also makes the other 'plan by' options look
cleaner by removing the all caps.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Remove 'use Installer' which had external dependencies we're trying to
report on. Instead call Installer::PerlModules directly
added use warnings and strict
updated FSF address in License statement
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Strings within JavaScript onclick attributes are not getting picked
up by the translator:
onclick="return confirmDelete(_('Are you sure you want to cancel this
hold?'));"
This patch converts those to use variables defined in the main
script block:
onclick="return confirmDelete(MSG_CONFIRM_DELETE_HOLD);"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
these prefs : FilterBeforeOverdueReport & DisplayClearScreenButton shouldn't be
lumped together - they do two very different things and have nothing to do with
each other.
this patch splits them into two individual preferences.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This way, the various cron jobs will not try to do things to it.
They can't, since it is not yet really created.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
If the new version of Koha requires a newer version of the database
schema, the Koha instances will work immediately after the package
is upgraded, rather than after the sysadmin has run koha-upgrade-schema
manually.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The canonical list of Perl module dependencies are in
C4::Installer::PerlDependencies::PERL_DEPS now. Add a script
(debian/list-deps) to turn that into a list of Debian package names.
Because that is a slow process, and the output rarely changes, do
not do that at build time. Also, doing it at build time would require
modifying debian/control in evil ways.
Instead, add another tool, debian/update-control, which reads the
new file debian/control.in, and adds the output of debian/list-deps to
Build-Depends and creates a new debian/control.
debian/control.in is the master file. If changes are needed, that should
be edited. For performance and convenience reasons, the output is also kept
in git, but don't edit debian/control directly, please. Such changes
might get lost by the next commit by someone else.
Whenever PERL_DEPS changes, debian/update-control should be run as well
and the result committed to git.
This is not quite as automatic as it might be, but should be good enough.
It avoids keeping the list of Perl modules in two places.
Note that since it seems impossible to automatically figure out the Debian
package version that corresponds to a Perl module version, I have not
tried to do that at all.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
search so the alert stands out. Previously no css was applied to it so
it was just plain text. Librarians weren't noticing it.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This fix the csv export that doesn't export correctly the budget name, it's empty column.
And it turn off some SQL debug that slow down the result of the page and the csv export.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
When editing patron attributes or messaging preferences on the
patron editor, Koha would crash with the following error:
Software error:
Can't use an undefined value as an ARRAY reference at
/home/koha/kohaclone/C4/SQLHelper.pm line 186.
This would occur only when editing the specific attribute
or message preferences section, not when editing the entire
patron record.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Since we're uploading a git snapshot, this is not meant for
production, and thus it should not be uploaded to squeeze,
but for squeeze-dev.
Documentation for the pockets will appear in the apt
repository or the wiki once it is ready.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
One bug fix (three steps, not two, are automated in koha-post-install-setup).
Also add a note about the need to possibly edit ports.conf.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The way things are set up, each Koha instance runs under its own
user account. At least for now, this requires apache2-mpm-itk.
Later we can investigate other possibilities.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
