Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	166720982e	Bug 11616: remove jQuery tablesorter plugin DataTables has replaced the tablesorter plugin for client-side sorting of tables in Koha. There is no table using this plugin, so this patch removes it and remaining references to it. REVISED TEST PLAN ----------------- 1) Apply the patch 2) Home -> Koha administration -> Authorized values 3) Change the 'Show category:' drop down value, and play with the sorting of columns. -- should sort as expected. 4) Search the catalogue -> look for a biblio with high circulation 5) Click one of the name links. 6) Click the Items tab on the left. 7) Scroll down and click the (View item's checkout history) link in the History area. -- There was no sorting prior to the patch, so afterwards it should display the same. 8) git grep -i tablesorter -- Only a reference in staff-global.css and release texts. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	9 years ago
Owen Leonard	bef919d60d	Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Kyle Hall	490688ea53	Bug 9307 - Allow libraries to add/edit status for suggestion management. This patch allows for the addition of new suggestion status by adding authorised values of the category SUGGEST_STATUS I sign it off. Details of my test plan : 1. Applying the patch 2. Checking existing suggestions, in staff view and opac : ok 3. Creating a new suggestion in staff and in opac : ok 4. Moving a suggestion into one of the old categories : ok 5. Adding a new authorized value category named SUGGEST_STATUS and fill it with 3 values : value Description Description (OPAC) =)> tata tatapro tataopac titi titipro titiopac toto totopro totoopac For "tata", I defined a branch restriction on branche B. 6. Connecting in staff interface as a librarian of branch A : I could only use codes titipro and totopro. On OPAC, these codes were displayed as totoopac and titiopac 7. Connecting as librarian of branch B : I could use the 3 codes 8. Checking tabs visible : new tabs for tata, titi, toto, but also a new "Unknown" tab with 0 record. Maybe point 8 could be fixed in a followup. I sign off the patch. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>	10 years ago
Owen Leonard	20180b4c39	Bug 10420 - Standardize spelling of "authorized" This patch corrects instances of the non-[American]-standard spelling "authorised" when used in text. The following instances are corrected: - In Administration -> Funds, the error message displayed if you do not have permission to edit a fund. - In Administration -> Authorized values, the instructions linked to the "Libraries limitation" field. - In Administration -> MARC bibliographic framework test, instructions related to linking to authorized values. - In the course reserves add form, error messages referring to missing authorized values. - In guided reports, error messages shown when an authorized value chosen as a report parameter doesn't exit. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Owen Leonard	1b3b942409	Bug 2835 - Inconsistent use of colon at the end of sentences Labels which precede a text input or select typically have a colon before them: Name: [____] This patch cleans up templates where labels in this context lack a colon. Exceptions to this rule include radio buttons, checkboxes, and labels inside tables. To test, view the affected pages and confirm that labels look consistent. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch adds more consistency. Work for translators could be made easier using CSS instead of whitespace after colon. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	10 years ago
Jonathan Druart	db0070f330	Bug 9945: Changed display: inline to inline-block on the inline CSS styling on the li elements. When adding/modifying an authorised values. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves icon set display in authorised value configuration. CSS only. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	10 years ago
Owen Leonard	9f08b5e3a5	Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	10 years ago
Owen Leonard	eedd8a8d4b	Bug 9648 - Replace YUI buttons on authorized values administration page with Bootstrap This patch converts the toolbar on the authorised values administration page to to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the authorised values administration page and confirm that the "New authorized value..." and "New cateogry" buttons look correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Both buttons works and look correctly. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	10 years ago
Jonathan Druart	014f818303	Bug 7919: Followup: Fix plural and GetAuthvalueDropbox Remove plural if there is just one branch limitation (authorised_values.tt, categorie.tt and patron-attr-types.tt) FIX a bug in GetAuthvalueDropbox (called by acqui/fetch_sort_dropbox.pl) Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	10 years ago
Jonathan Druart	acbfe26c9e	Bug 7919 : Display of values depending on the connexion library In a librairies network, we would like to declare specific values just for one (or more) library. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a library not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/modborrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	10 years ago
Owen Leonard	d772d3af4d	Bug 9137 - Focus when editing/adding new itemtypes/authorised values This patch adds the "focus" class to the relevant inputs so that the global staff client JS will move the focus to those fields. Logic in the authorised_values template puts the focus on the correct field whether you're adding a new category, a new value, or performing an edit. To test, try the following operations: - add an itemtype - edit an itemtype - add an authorised value category - add an authorised value value - edit an authorised value value In all cases the focus should automatically be in the first form field. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass and works nicely. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	10 years ago
Adrien Saurat	adfbbfa0d1	Bug 8757: longer descriptions for authorised values In the "suggestions" table, the "lib" and "lib_opac" sizes has been raised from 80 chars to 200. The GUI allowing the authorised values creation/update has been changed accordingly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	11 years ago
Owen Leonard	68b30468c3	Bug 8143 [REVISED] Upgrade jQuery tabs to current jQueryUI version Current jQuery-driven tabs are done using a very old version of the tabs plugin. This patch upgrades jQueryUI to the latest version and adds the tabs widget dependency to the jqueryui js file and updates the syntax for existing tabs: - $("#foo > ul").tabs(); changes to $("#foo").tabs(); - Remove full URL from tab links (use #anchor only). Pages with "static" tabs (tabs which are built in the markup rather than generated by the plugin) have been modified to use their own style. Examples: pay.tt in the staff client and opac-readingrecord.tt in the OPAC. Edit: Minor revision to some uncorrected markup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	11 years ago
Owen Leonard	f3a3d7a42d	Bug 2780 - Capitalize strings consistently (Admin pages) Correcting capitalization in Administration templates. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>	11 years ago
Katrin Fischer	27dd804725	Bug 7760: Add unique ids and a module class to all administration pages This is the first patch for bug 7760 and touches all pages in administration. This adds a unique id "admin_<filename>" and a class "admin" to the body tag of each page in administration. Note: aqcontract can only be accessed from the acquisition module, so I made it acq instead of admin. Signed-off-by: Owen Leonard <oleonard@myacpl.org>	11 years ago
Owen Leonard	78e0754bfc	Fix for Bug 6616 - Move common table pager markup to include Created new include for the tablesorter pager markup: [% INCLUDE 'table-pager.inc' perpage='20' %] 'perpage' variable defines the default items per page for the paged table. Unique changes in branch_transfer_limits.tt: - Moved tablesorter configuration out of a loop and changed it to work by class instead of id (less repeated markup). - Corrected an errant TMPL tag. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	12 years ago
Owen Leonard	7f095be74a	Revised fix for Bug 6133 - Authorised values administration, warn for modifs - Reformatted for T:T - Changed wording slighly - Styled message with new "note" style for non-dialog messages - Added correct alert style to existing error message Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	12 years ago
Chris Cormack	5884fb1000	Bug 5917 : Swapping templates over	12 years ago
Chris Cormack	77b6409802	Bug 5917 : Converted templates	12 years ago

1 2

68 Commits (62848497033c601ea928890f903acf32c72d08d2)